5746227588
Support for configurations in import/export directives.
...
R=brianwilkerson@google.com
Change-Id: I5dce86c0f8b20a3f06323783737b12469bf43067
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-12 14:14:28 +00:00
e9ca6a5335
Enable constant-update-2018 by default.
...
Fixes https://github.com/dart-lang/sdk/issues/32517
Fixes https://github.com/dart-lang/sdk/issues/34189
Fixes https://github.com/dart-lang/sdk/issues/34192
Fixes https://github.com/dart-lang/sdk/issues/34205
Unskipping the skipped tests is tracked by
https://github.com/dart-lang/sdk/issues/36433 and
https://github.com/dart-lang/sdk/issues/36595 .
Expectation files for front-end tests will need to be updated to make
front-end builders green. They are part of unapprovable suites.
Change-Id: I311f449af6feff5bf40740227a95aa06e0a9d84f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99169
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-04-12 13:30:15 +00:00
c2eb9a9860
Add support to the element model for both lazy variables and required parameters
...
Change-Id: I2733f26cc4ee1be28fc96bbf23402e34449ff030
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99241
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-12 12:41:48 +00:00
4ed24862ee
[CFE] Extra dummy SDK classes that the constant evaluator needs.
...
Change-Id: Ib82db42686f5b075e7c3a282e7c370849c4c28e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99167
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Auto-Submit: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-04-12 11:03:11 +00:00
a3d13fbf54
[CFE] Option to report error on unevaluated constants.
...
Fixes https://github.com/dart-lang/sdk/issues/36565
Change-Id: I011e4b5242a02e06392af01ad77615c694fb62ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99121
Auto-Submit: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2019-04-12 08:15:57 +00:00
394f88d5cf
Create source information from ConstantExpression
...
(now that it has a fileOffset)
Change-Id: I057ca3cf04a941ccdb03a6d8ca58947650b1cbec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99161
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-04-12 07:37:17 +00:00
b7b7a63407
Fix relative import from pkg/kernel/test to pkg/kernel/lib.
...
This doesn't work due to the file organization used in google3.
Change-Id: I814a087bd9c6e10fc7738c782af6f54fde3cf000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99181
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2019-04-12 07:17:47 +00:00
0136d96a96
[dartdevc] fix #36532 , adds DDC support for CFE constant flag
...
This fixes DDC to work when CFE's constants flag is enabled.
The fixes are primarily due to how CFE inlines constants, and how it
handles "unevaluated constants" (these arise from modular compilation
and outline kernel files).
Specifically this CL addresses the following issues:
- private names now work across modules (landed in this CL:
https://dart-review.googlesource.com/c/sdk/+/98926 )
- correctly emit tearoffs regardless of how they're represeted
(constant or StaticGet)
- correctly recognize the internal SDK and JS interop annotations,
regardless of how they're represented (constants or expressions)
- change how DDC represents `undefined` in its internal SDK, so
its detected regardless of constant inlining
- emit numeric constants as integers in JS when possible
Change-Id: I0fbda9d24578075f655ea945ed1b2ceed124af48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99240
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Jenny Messerly <jmesserly@google.com >
2019-04-12 01:47:57 +00:00
022400eecb
Fix several small issues with AST based summaries.
...
R=brianwilkerson@google.com
Change-Id: I716b55f2a656b56d4999547da03308dc11ec3b52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99190
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-12 00:50:06 +00:00
fe6897ab7f
[dartdevc] fix #36252 , export private name symbols
...
This adds support to DDC's Kernel backend for instance constants
inlined across module boundaries, by saving private name symbols
so they can be referred to from outside of the current module.
Change-Id: I28d45d1844f5351f506cc7606dd1c4803037304e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98926
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Jenny Messerly <jmesserly@google.com >
2019-04-11 23:45:17 +00:00
e129b201e5
Fix for absent names of parameters in GenericFunctionType.
...
R=brianwilkerson@google.com
Change-Id: I9a6444cc076b5d6a79c4ebf33fae9deef85e2049
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99189
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-11 21:29:12 +00:00
ed280a98a2
Instantiate to bounds when resolving type names.
...
R=brianwilkerson@google.com
Change-Id: I55ea6339b5b949f986f7e6becc60c0328496489e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99188
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-11 21:24:29 +00:00
f657371972
Change dev_dependencies to any
...
Using path dependencies here is misleading - they are not sufficient for a
`pub get` and we do not expect to do a pub solve in this package. In order to
suppress the warnings on `pub publish` we need only the `any` dependencies and
can rely on the repo's `.packages` file to resolve their path.
Change-Id: I5e7b2d50ece2c133b2583fd75eab3509db400a95
Bug: 36581
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99204
Commit-Queue: Nate Bosch <nbosch@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2019-04-11 20:55:22 +00:00
04ee9b9336
Add support for the manifest checks in analyzer_cli
...
Change-Id: I8d2670cca509cf2229f5475e355e3b85b1ca2f30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99220
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-11 20:41:51 +00:00
a91381ab07
Build local elements in initializer expressions, so support closures.
...
R=brianwilkerson@google.com
Change-Id: Ic84841835ed4a24c3a58ed0ef3c3d1332e12e8f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99186
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-11 20:20:02 +00:00
850d56c681
Fix an error in the manifest file test framework
...
Change-Id: Id0aff93f9312a510a7ef375dc6087e971aa0189c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99203
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-11 19:53:31 +00:00
d4fee0a85e
Issue 36576. Add returnType to constructor in available declarations.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/36576
Change-Id: I6acbf82bbaafc1ab5a1599cd415cdb11600064a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-11 18:59:43 +00:00
32f120c1e9
Resolve default values in AST summaries.
...
R=brianwilkerson@google.com
Change-Id: I60bfb04a2616371c6079c7a5819f78ab13fd601b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99202
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-11 18:55:28 +00:00
5dd89ef9a0
fix invalid var init parser recovery
...
Fix https://github.com/Dart-Code/Dart-Code/issues/1548
Change-Id: Ib593c17fa8dfcee3c8ad139b72ceff56497d43a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99093
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-11 18:42:02 +00:00
b9cbb679f3
[dart2js] Add --experiment-new-rti flag.
...
This flag doesn't affect any behavior yet, but we can start implementing
the new RTI system behind it.
Change-Id: I8c6ae6c60a97394c628f68876e086d455a815ca1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98925
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2019-04-11 18:38:48 +00:00
7943e50cfd
Compute simply bounded types.
...
R=brianwilkerson@google.com
Change-Id: Ie992ccba43d2a5fca293c7791ee11875ca73c01f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99184
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-11 18:17:23 +00:00
e104054059
Rework storing type parameters and function types.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ia2c71237cf0f7d9c31c7036522bb24a1aaead92f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99094
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-11 17:22:42 +00:00
2723835b18
dont fall back on the wrapped file system when the uri is the multi-uri scheme
...
Bug: b/130291059
Change-Id: I10f276c36239cd60ae0adf795dc32c462e078ef4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99087
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-04-11 17:09:52 +00:00
b857d53e7e
Re-work collection literal strict-raw-type to strict-inference
...
Bug: https://github.com/dart-lang/sdk/issues/36445 https://github.com/dart-lang/sdk/issues/33749
Change-Id: I127d671840bfcfe3857225932164fa4098963715
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99085
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-11 16:20:06 +00:00
229e00d97b
[vm/frontend_server] Ensure incremental compiler gets vm environment defines set.
...
Change-Id: I86a2ccdd6c7ea6555384ff37966affccb7048055
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99180
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2019-04-11 16:15:16 +00:00
54caf5c950
Dart deps_pruning: track summary dependencies during analysis phase.
...
(Originally written by Emmanuel Pellereau (emmanuelp@google.com ))
Change-Id: I61983558cbb88b76be2a292080e96c0bf3f780de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98680
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-11 14:48:44 +00:00
f7ad0c4de8
[CFE] Avoid spurious circularity error when an error is evaluated again.
...
Fixes https://github.com/dart-lang/sdk/issues/36563
Change-Id: Ic078ad1f380ee92513948c5f85560db3c6a2941f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99163
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Auto-Submit: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-04-11 13:45:14 +00:00
a9f8248bfb
Add support for computing fixes in pubspec and manifest files
...
Change-Id: Ib13f7a529a441cf02d91452ac7507fffdee06161
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99091
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-11 13:23:54 +00:00
1555594ddb
Include a per-library index of owned sources in kernel
...
This for instance allows the VM to include all patches
(e.g. the previously missing `runtime/lib/date_patch.dart`)
in what's returned from `LoadedScripts()`.
Over time this also allows for `LoadedScripts()` to be simplified and
become faster (it's currently something like O(m + m*n) where m is the
number of results in DictionaryIterator(*this) and n is the number of
returned scripts).
Change-Id: I4b5a6a0fe666b774fc0987d099ed02e81ac97b43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98660
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2019-04-11 12:40:49 +00:00
88068ebfe3
Add missing _getLocationInEnclosingFile on Typedef
...
Change-Id: I81fbef620fd1742fe9a6e6428596718b038b0925
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98462
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-11 12:34:04 +00:00
f919c3985b
Proper offstes on mixin classes
...
Change-Id: I1e7fcdae5713e8017aaf81e87afba20e59b9f789
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98338
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-11 12:32:44 +00:00
7f3ced4333
Set proper startCharOffset on enum classes
...
Change-Id: I2edf7b5484e4c0fc9728644c5e1166fb3adcd909
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98353
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-04-11 12:20:44 +00:00
6609ea21e2
Proper endoffset on enum classes
...
Change-Id: Ia6e04b8f84dbe9600d7d9a7fab17cb25e8c5a170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98345
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-04-11 12:19:44 +00:00
460d00616c
Better printing of imports
...
Before a import of, say "hello.dart" was printed as
"import './hello.dart'".
Now instead it is printed as "import 'hello.dart'".
At the same time we get rid of a dependency.
Change-Id: I352f0f507168fde75358704ec9bf0e248bb8179d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98480
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-04-11 11:43:23 +00:00
fe535ac27c
Add missing offset to yield produced by await for
...
Fixes #36069 .
Fixes #28916 .
Change-Id: I1acc6b9f0aaba100827749a1f3653f5cc9e4fd2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98665
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-04-11 11:16:13 +00:00
51433e65cc
Compile flutter tests via the sdk
...
This CL includes:
* A dart script that - given a flutter checkout - finds and compiles
tests to ensure we actually can.
* A shell script that checks out flutter, compiles the platform
(to cope with any changes to the kernel format) and runs the above
script.
Change-Id: I02806a375943361c3c111d9aa12a76d745391ca3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98140
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-04-11 08:38:53 +00:00
318967456c
Resolve constructor initializers.
...
R=brianwilkerson@google.com
Change-Id: I55101108af0e63f23d3af89a3cb23dc5e46e6392
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98877
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-11 06:07:43 +00:00
b6f8c717f0
update lint error code associations
...
Change-Id: I2918958494c3ffebced64de7a398544f72f78b08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99103
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-04-11 00:26:33 +00:00
5cc9455b65
scanner-tool: add explicit command-line arguments to enable printing tokens
...
This will be used instead of -DprintTokens=true.
Context: we use this tool in bazel where we use a modular pipeline. That
pipeline will no longer support dart environment variables due to
https://github.com/dart-lang/sdk/issues/36513 .
In this specific file the intent was anyways to pass an option when
launching the program, so a command-line option is appropriate IMO.
Change-Id: I5187190a01afe59aef57ec6a7311b1e380313a81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99102
Reviewed-by: Ari Aye <ariaye@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2019-04-10 22:57:04 +00:00
ebd13e891f
[vm/bytecode] Add UncheckedInterfaceCall instruction
...
dart --use-bytecode-compiler NavierStokes.dart
Before: NavierStokes(RunTime): 8909.053017777778 us.
After: NavierStokes(RunTime): 7221.510314079423 us.
Issue: https://github.com/dart-lang/sdk/issues/36429
Issue: https://github.com/dart-lang/sdk/issues/36428
Change-Id: Ib1be4dd20cdc25e3b979a91a098f67a7bc00df8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98945
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2019-04-10 21:49:23 +00:00
ab66a3808b
Add more JS subtyping semantics to CFE constant evaluator.
...
If we're targeting a JS backend, `isSubtype` considers every int to be a
double. We need to additionally allow any integer-valued double to be an
int. This mainly allows us to handle signed zeroes correctly.
Fixes https://github.com/dart-lang/sdk/issues/36562 .
Change-Id: I00d1e693bb3f1268ac100a76c9bec8fcc612b182
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99101
Commit-Queue: Mayank Patke <fishythefish@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-04-10 21:09:03 +00:00
17f5d2d757
Add assists to inline add and addAll
...
Change-Id: Ie085fd10ffe533fae8a0c5f6325d081a118adc39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99040
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-10 20:40:33 +00:00
5735bde143
Fix a test to fix the windows bot
...
Change-Id: Ifcf60eda337a8dea149fb9c9eeec9efca477e885
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99041
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-10 17:16:16 +00:00
75a529f115
[vm/tests] Improve usability of pkg/vm tests
...
Fixes https://github.com/dart-lang/sdk/issues/36468
Change-Id: I7deecb1a4ef5cb337056049cdcf4781020a07a5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98946
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-04-10 15:24:36 +00:00
ac02811081
[cfe] Allow expression compilation with constant-update-2018
...
Allow expressions to be compiled by the VM but without evaluating
constants. This will use the VM's C++ constant evaluator.
Fixes https://github.com/dart-lang/sdk/issues/36479
Change-Id: Icd6e769e53db5d211a083d1f5cff7ddf88cc4da2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98675
Commit-Queue: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-04-10 14:13:56 +00:00
5ed4cdac5d
Remove unused import
...
Change-Id: I295192ea5885a283210e3530be77cf68bc202945
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98950
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-10 13:23:56 +00:00
4ab4545ff7
[cfe] Add type and file offset to constant expressions
...
Closes #36471 .
Bug: http://dartbug.com/36471
Change-Id: I5ac294057f2f69f1a8edfdf1106f65908fc257ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98677
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-04-10 09:55:36 +00:00
523e3789e0
Add support for providing fixes in analysis options files
...
Change-Id: I6c9a0a0624201538a90608c2eff9cff7b6cdb4b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98870
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-10 03:39:40 +00:00
919461badd
Ensure boolified SSA nodes are non-null first.
...
Fixes https://github.com/dart-lang/sdk/issues/34147 .
The Dart language specification says we should ensure booleans are
non-null in the following (non-exhaustive) situations:
* (ternary) conditional expressions - this includes the `!` operator
since `!x` is equivalent to `x ? false : true`
* arguments to logical boolean expressions (`||` and `&&`), modulo
short-circuiting
* `if` conditions
* `for` loop conditions
* `while` conditions
* `do`/`while` conditions
With control-flow-collections enabled, this CL will also cover
conditions in `if` elements and `for` elements. Tests for these already
exist in
language_2/control_flow_collections/{if,for}_null_condition_test.dart.
Change-Id: I2ce9a30adeb16a0a68411f358f69aeca08656dab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98780
Commit-Queue: Mayank Patke <fishythefish@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-04-10 00:28:10 +00:00
15b11b0183
[ VM / Service / Observatory ] The VM service now requires an authentication code by default.
...
Previously, a valid web socket connection would use the following URI:
`ws://127.0.0.1/ws`
Now, by default, the VM service requires a connection to be made with a
URI similar to the following:
`ws://127.0.0.1:8181/Ug_U0QVsqFs=/ws`
where `Ug_U0QVsqFs` is an authentication code generated and shared by the
service.
This behavior can be disabled with the `--disable-service-auth-codes`
flag.
Change-Id: I288aac58e3ba9d35dca8071f3f7e7a073896c271
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98433
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2019-04-09 22:57:29 +00:00
Konstantin Shcheglov