dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

25510 Commits

Author SHA1 Message Date
Brian Wilkerson 73d99df7e0 Report when a potentially nullable type is used in an on clause 
Change-Id: I6e9e779d5bb0f37cfd71d4d2dc38c1511c03d59f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99484
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-16 19:34:25 +00:00
Dan Rubel 80dd5ca3d4 new "modifier out of order" error code 
This replaces the const-after-factory error code
with a more general modifier-out-of-order error code.

Change-Id: I71baf2c96656241475c344cb33b887d8e0d456fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-16 19:28:55 +00:00
Konstantin Shcheglov 41e9878348 Unbreak two tests that were failing on Windows. 
R=brianwilkerson@google.com

Change-Id: Ib871dcddb5c547ad3b89ef529fb0d739f1cdd30b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-16 17:55:55 +00:00
Konstantin Shcheglov cef1e31284 Rewrite AST for implicit instance creation. 
R=brianwilkerson@google.com

Change-Id: I2fc7b75e2d64359c3bd79fdb613f03d01e8211a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-16 17:24:24 +00:00
Johnni Winther 5af34ea93d [CFE] Handle invalid constant string interpolation in unevaluated constant expressions 
Non-primitive constants were incorrectly stringified in an unevaluated
context. These are now, as with unevaluated constants, checked when the
string concatenation is fully evaluated.

Closes #36609

Change-Id: Ia3266ebcb9d497b277690244569812f7cd3e30c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99461
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Auto-Submit: Johnni Winther <johnniwinther@google.com>
 2019-04-16 16:05:05 +00:00
Paul Berry 457a781bd7 Reland "Do not append ! to type names in tests that exercise NullabilitySuffix.none." 
This is a reland of 890d12fa47

Original change's description:
> Do not append `!` to type names in tests that exercise NullabilitySuffix.none.
> 
> Appending `!` is confusing because it suggests a non-nullable version
> of the type.  But the absence of a `?` or `*` suffix doesn't mean the
> type is non-nullable.  For type parameters, the type might or might
> permit null depending on how it is instantiated.
> 
> Change-Id: I3c98ddeb80816cc82e00e2692977e66c9fb51170
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99373
> Reviewed-by: Dan Rubel <danrubel@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

Change-Id: Ifbb3caea8881839e16ac959f962adc831b792ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99448
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-16 16:02:25 +00:00
Konstantin Shcheglov 2b4d27bf6f Fix test_unresolved_annotation_instanceCreation_argument_super. 
R=brianwilkerson@google.com

Change-Id: I6a70d9766fe90fc9eb4b7783a3c897c849a1652e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-16 15:54:24 +00:00
Paul Berry c3428c9342 Disallow UI-as-code in constants if constant-update-2018 is disabled. 
Analyzer unit tests exercising the behavior of UI-as-code had to be
replicated so that we could test the behavior both with and without
constant-update-2018.

Note that as of the writing of this CL, constant-update-2018 has been
enabled by default, so there is no immediate functional change.  The
change will take effect if we decide to back out constant-update-2018.

Change-Id: Iff50f4cb834805bec14638220671384c97dea39d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99443
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-16 15:45:44 +00:00
Paul Berry 2768cce4bf Revert "Do not append ! to type names in tests that exercise NullabilitySuffix.none." 
This reverts commit 890d12fa47.

Reason for revert: Bot failures

Original change's description:
> Do not append `!` to type names in tests that exercise NullabilitySuffix.none.
> 
> Appending `!` is confusing because it suggests a non-nullable version
> of the type.  But the absence of a `?` or `*` suffix doesn't mean the
> type is non-nullable.  For type parameters, the type might or might
> permit null depending on how it is instantiated.
> 
> Change-Id: I3c98ddeb80816cc82e00e2692977e66c9fb51170
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99373
> Reviewed-by: Dan Rubel <danrubel@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com,danrubel@google.com,mfairhurst@google.com

Change-Id: I5fe26d9d668dde4072ec0e4e25b9865a047bb817
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99447
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-16 14:53:59 +00:00
Konstantin Shcheglov 8188e02661 Create ConstFieldElementImpl for final instance fields in classes with const constructors. 
R=brianwilkerson@google.com

Change-Id: Ie8590959e11b642951fae8fd39b93b75181034e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-16 14:16:46 +00:00
Konstantin Shcheglov 6761015e30 Fixes for unresolved and invalid URIs. 
R=brianwilkerson@google.com

Change-Id: Ief66dea3203187da90367984dc33f535748938d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-16 14:10:56 +00:00
Paul Berry 890d12fa47 Do not append ! to type names in tests that exercise NullabilitySuffix.none. 
Appending `!` is confusing because it suggests a non-nullable version
of the type.  But the absence of a `?` or `*` suffix doesn't mean the
type is non-nullable.  For type parameters, the type might or might
permit null depending on how it is instantiated.

Change-Id: I3c98ddeb80816cc82e00e2692977e66c9fb51170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99373
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-16 13:29:32 +00:00
Paul Berry 2f77be6dc7 Fix overzealous rename. 
In 79974bb026 I accidentally renamed one
of the withNullability methods, causing it to become disconnected from
the method it was overriding.  This CL undoes the bogus rename.

Change-Id: I24655d76ef5c602e967a055e86d072a87435f3a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99480
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-16 13:22:42 +00:00
Johnni Winther 58ff41ad33 Add test for static tear-off 
- to document the change (for the better) with CFE constant

Change-Id: I9b6673497fe07ccd4f92fc4c22df0ae3205f72a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99152
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-04-16 07:06:12 +00:00
Brian Wilkerson 32f5223119 Search all directories when attempting to analyze manifest files 
Change-Id: I3a900362d8d36d27e5c22f600db7bc54059c7717
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-16 00:45:32 +00:00
Vijay Menon 5319d76b5a Run ddc worker tests 
Change-Id: I3555fe64bacd03a728d63a035457ca1e3398edb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98699
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-04-16 00:38:24 +00:00
Jaime Wren f8c1cc7c24 Update the output for the generated Outline.java to compile. Outline.java has a special fromJson() method special cased in codegen_java_types.dart that was not updated when fields were added to the protocol. 
Change-Id: Ib78f8a81ea3b48d6ae821d89617d3c1b66e69fcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99375
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2019-04-15 23:05:56 +00:00
Paul Berry bd4576174e Remove the nullability variants of dynamic, bottom, and void. 
Dynamic and void are always nullable.  Bottom is never nullable.

Change-Id: I198dd6ccc84684ed05c578a5f80b1770d3f14b39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99276
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-15 22:04:21 +00:00
Paul Berry a82a35af71 Rework _checkForDeadNullCoalesce using isNonNullable. 
Change-Id: If55565d272af1be44e3326c3ec34889b3258323b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99367
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 22:04:21 +00:00
Brian Wilkerson fa5440a568 Fix a typo in the comments 
Change-Id: Ie67ca958622aef487322ad32d32d807f39cfe6f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99381
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-15 21:58:36 +00:00
Brian Wilkerson 77d096ca94 Add AST representation of the required keyword 
Change-Id: I7eededadfa7bf5648cbaadbbccb0ef65af9a839f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99371
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 21:56:16 +00:00
Paul Berry f315727b79 Add basic resolution semantics for null-assertion operator 
Change-Id: I69d0c577938a8991b98c44577556722bf54a1df8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99285
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 21:46:07 +00:00
Jaime Wren 067293b7fc Update the copyright year to 2019 before pushing DAS 1.26.0 version to the Dart plugin 
Change-Id: I8a2e5de067d5ee5a1bd564e5738e990bf289e325
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99372
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2019-04-15 21:41:29 +00:00
Konstantin Shcheglov 3937751b94 Switch AST summaries tests from the hardcoded SDK to MockSdk. 
We have implemented enough to link MockSdk.

R=brianwilkerson@google.com

Change-Id: I6593a6a65773c5727a2bcd1d0b937b35bf8598ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99368
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-15 20:44:22 +00:00
Konstantin Shcheglov 369c9653c6 Store 'definingType' for next to raw Element references. 
R=brianwilkerson@google.com

Change-Id: Ieb21f9af030b65afb59491f50a5659c564dfc419
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99366
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-15 20:37:06 +00:00
Brian Wilkerson b9eb7c312c Add nullability testing methods to TypeSystem 
Change-Id: I6451468eafedddb75a7012f328d730836694bdd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99380
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 20:32:05 +00:00
Konstantin Shcheglov 55ff0abde5 Rework building types for type annotations and declarations. 
It is possible that a TypeName is a typedef, for which we have not
built types for its return type and parameter types. So, we cannot
rely on the order of nodes in NodesToBuildType. We have to build types
recursively.

R=brianwilkerson@google.com

Change-Id: Idb865ed1723456ccaea49802ea5e869e544461d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 20:06:13 +00:00
danrubel 0b6c61dbd3 tests for issue 36055 
Change-Id: I1ccd5deb6cff6e046895220ffdd03842ec5c20d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-15 19:28:45 +00:00
Brian Wilkerson ae05bc6ec5 Add support for the type Never 
Change-Id: I174ab85c0010a900b4d84068a90ac27e76b0e80c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99363
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 19:24:25 +00:00
Paul Berry 79974bb026 Rename Nullability enum to avoid confusion with spec. 
The spec uses the terminology "nullable", "non-nullable", etc. to
refer to properties of types that differ subtly from their structure.
For example "Null" is considered nullable, even though it lacks a
trailing "?".  Since we were using the Nullability enum to denote a
purely structural property of types (whether they end in "?", "*", or
neither), this led to confusion.

So to avoid confusion, we rename the Nullability enum, and its
enumerated values, to clarify that it refers specifically to the
nullability suffixes and not to the property of being
nullable/non-nullable.

Change-Id: Ia34a500a3d2d724d30c66a410140ae11d6512f50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99275
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-15 16:50:14 +00:00
Kevin Millikin e42a8032fb [cfe] Remove uninferred initializers from outlines 
When performing top-level type inference based on overrides for fields
that have initializers, we never perform type inference for the
initializers.  Since type inference is the thing that rewrites shadow
AST nodes with their Kernel translation, we are left with
untransformed shadow nodes that cannot be serialized.

Instead, remove these initializers.  Fixes
https://github.com/dart-lang/sdk/issues/36498

Change-Id: I044fadd897e9f2d0e37f5ce0e5adaadb0e42a992
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99120
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-04-15 16:17:35 +00:00
Dmitry Stefantsov 4b42f87971 Remove unused import 
Change-Id: I48175f0eecbd53fbe0c02b70c0a5f4d27ba88764
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99155
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-04-15 15:45:24 +00:00
Brian Wilkerson 193458abaa Return the keyword from childEntities for import and export directives 
Change-Id: I92d04bb856d7798d141f871766ec417745dd5f13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 15:36:45 +00:00
Dmitry Stefantsov d3e00fd35e Update .expect files in pkg/front_end after e9ca6a53 
TBR=askesc@google.com

Change-Id: I65e263c7ee627f94bc314346a322953f9e954899
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99174
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-04-15 14:40:24 +00:00
Keerti Parthasarathy b997b59c09 Include manifest in the list of files to analyze 
Change-Id: I9b1c52ce085303e84b8882b0ccdc51c9555ce55c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2019-04-15 14:15:15 +00:00
Brian Wilkerson ec0447db5d Add support for using ExpectedError and convert a couple of tests over to use it 
Change-Id: I04a89cc922e0046dee4d7e9f964f272cfc60a055
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 02:17:44 +00:00
Brian Wilkerson ea8d6e6fa9 Rename some error checking methods 
Change-Id: I5a750c16a8c49d724f964efa5184a3d82abce8ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-14 15:10:33 +00:00
Konstantin Shcheglov 3e6fd64a8a Dependencies based type inference with AST summaries. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I1513d54f6d6dbab70fa58af8d9c68a186c2a1ee3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99273
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-14 04:54:33 +00:00
Brian Wilkerson 0aa5547de1 Add missed tests and fix bug 
Change-Id: I7696207525a009860f813ddcb94528edbf12ac4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99244
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-13 20:39:13 +00:00
Paul Berry 22a843a23d Fix precedence of postfix "!" operator 
Change-Id: I00446e15cd7e19285b35742a1936c36b1faf4774
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99282
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-13 16:20:22 +00:00
Paul Berry f3dbfee467 Fix the error message template for EXPERIMENT_NOT_ENABLED. 
Given an experiment named foo, it doesn't make sense to ask the user
to enable experiment --foo, since that's not the syntax for enabling
an experiment (the syntax is --enable-experiment=foo).  Changed to
'foo'.

Change-Id: I055461fb389a4338578fc7f260e252b8e3fe9a13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99286
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-13 16:19:23 +00:00
danrubel 2e7bd1359d parse dart language version comment 
This updates the parser to recognize a language version comment
of the form

// @dart = <major>.<minor>

as specified in
https://github.com/dart-lang/language/blob/master/accepted/future-releases/language-versioning/language-versioning.md#individual-library-language-version-override

Change-Id: I884620ac7da86025f5b408bcba8dd1f77e4c523c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99261
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-13 13:09:22 +00:00
Sam Rawlins e89850f95d Move STRICT_RAW_TYPE on constructors to INFERENCE_FAILURE_ON_INSTANCE_CREATION 
Bug: https://github.com/dart-lang/sdk/issues/33749 https://github.com/dart-lang/sdk/issues/36445
Change-Id: Ic34f0e07b1cc5cbbc265ab2c32cabc61d7901c0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-04-12 23:51:21 +00:00
Brian Wilkerson 0314d86af4 Add errors when a nullable type is used as a supertype 
Change-Id: I82471ba67dd74db6425bb2081bd761eb2b490333
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99284
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-12 21:13:21 +00:00
Alexander Markov 9cc008e49c [vm/bytecode] Add bytecode instructions for double operations 
Change-Id: Ib1e8ca3b9bbf62f8282524fc5599eee5cae38389
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99089
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-04-12 20:17:01 +00:00
Alexander Markov 734c50cbf2 [vm/bytecode] Update expectations for bytecode generator unit test 
This update is needed after constant-update-2018 is enabled in
e9ca6a5335

Closes https://github.com/dart-lang/sdk/issues/36601

Change-Id: I25f33e504f4df09a0d936fd11c7fa9c6236e4c78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99265
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-04-12 20:15:40 +00:00
Liam Appelbe 47520b1856 test.py plumbing for ABI versions 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I68ca1ad01dfb3126c1d8c7f60a87f47d392d2d75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98745
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-04-12 19:33:40 +00:00
Alexander Markov 25cb45c02f [vm/aot/tfa] Update TFA tests after front-end starts evaluating constants 
Usually TFA takes kernel AST with all constants evaluated.
However, in order to avoid calling constant evaluator pass in TFA unit tests
there is a special implementation of pragma annotation parser (for testing)
which accepts annotations which are not ConstantExpressions.

After CFE starts evaluating all constants (constant-update-2018 was enabled in
e9ca6a5335), TFA unit tests need be
switched to use ConstantPragmaAnnotationParser.

Also, empty environment defines are passed to CFE to avoid unevaluated constants
and unit test expectations are updated.

Closes https://github.com/dart-lang/sdk/issues/36602

Change-Id: I2e7b0647e065cca129449b4531c6278c1d98061d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99269
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-04-12 19:33:35 +00:00
Brian Wilkerson 6c5709c44a Remove the URI of types until we can produce better URIs 
Change-Id: I50e4361b2736245d8d1af32da15822e416c5b2be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99267
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-12 19:18:01 +00:00
Konstantin Shcheglov 85f623374a Triage and fix some more tests. 
R=brianwilkerson@google.com

Change-Id: Ia5fcd1591532c3030eb2030ea483192b8c35fd05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-12 14:19:17 +00:00