bc8b6fb94d
[vm/bytecode] Fix last source position in a function
...
Change-Id: Id3b9c6476cc3745a39a7010b7ae09d2422467e31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107182
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-06-24 19:25:07 +00:00
efc85cac7c
Drop TODO to remove isHostChecked option
...
See #37318
This enables asserts in the dart2js compiler and is worth keeping.
Update the comment to better express the behavior and remove the TODO to
drop it.
Change-Id: I2e1eef74eac7949812670dd1c6294641ce80a4a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106940
Auto-Submit: Nate Bosch <nbosch@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2019-06-24 18:59:27 +00:00
6941d04a6e
Add support for testing the context messages for diagnostics
...
Change-Id: I33d4abc0dcc969f3beecfdc7cbc814e8a486ad1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107142
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-24 18:15:38 +00:00
33df2ed85a
Switch flow analysis tests to performFlowAnalysis().
...
So, we can make visitors private.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I8ff98e95b30f4b2d807a7b3d2a63e125d9420669
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-24 18:09:08 +00:00
7c63999e74
[vm/bytecode] Correct scripts for members not from the script of enclosing class/library
...
This change ensures that fields and functions have correct script if their
script doesn't match script of enclosing class/library.
Change-Id: Icd598707fd8a3d8227b425ecbe3a9f6806c73d7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107060
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-06-24 18:06:38 +00:00
c13752442c
Fix isNullable / isNonNullable, expand tests.
...
This addresses the issue in a previous CL.
https://dart-review.googlesource.com/c/sdk/+/106620/3/tests/language_2/nnbd/static_errors/equals_parameter_made_nullable_at_invoke_test.dart#30
Change-Id: Ib510ddbfe42c8e6d7cb0c4793a30e050b7e56bd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106962
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2019-06-24 16:53:36 +00:00
f860ea4b24
Make AnalysisError._contextMessages non-nullable
...
Change-Id: Icf85525d0003a2e6892f385c22128dd477a532ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-24 16:15:26 +00:00
cf03e96b90
Remove appJit and precompiled compiler options
...
Towards #37318
- appJit has been replaced by appJitk and is no longer.
- precompiled has been replaced by dartkp and is no longer used.
- For the precompiled runtime, default to dartkp.
- Remove status file references to these compiler options and normalize
status files.
Change-Id: I48728db13dc84737092a92314e2f474a9309f4d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106942
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-06-24 16:07:27 +00:00
37a25d9100
[vm/bytecode] Add a compile-time error if there are too many arguments.
...
Issue: https://github.com/dart-lang/sdk/issues/37305
Change-Id: I9dac7c1b7b49fca8531ca2bf83b1c309d8217969
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106984
Reviewed-by: Aart Bik <ajcbik@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-06-24 16:02:05 +00:00
31599c1e64
No --mode=legacy in incremental_perf_test
...
Fixes #37302 .
Change-Id: I69f07848ab20922628df0d01ea7b9c75fe8a5bb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106905
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-06-24 13:45:52 +00:00
d307402d49
Summarize the context messages in diagnostics
...
Change-Id: Id03e778cf9bebe9be61d9ded601408121b891097
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107102
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-24 13:31:52 +00:00
dac4929e19
Migration: propagate nullability inference through override relationships: parameter types.
...
Change-Id: Ib41ffa388af9688efc59aea2c196d8fdcf713ad8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107101
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-06-24 12:51:14 +00:00
559e49aa5e
Migration: propagate nullability inference through override relationships: return types.
...
Parameter types will be handled in a follow-up CL.
Change-Id: I71862fa6cf27aeede24bef60c096f631f6d8f60d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107100
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-06-24 12:51:14 +00:00
937bb61476
Migration: clean up parameters for _handleAssignment and _checkAssignment.
...
_checkAssignment now uses named parameters for source and destination
so that there's no danger of mixing them up. _handleAssignment lists
the source first, consistent with connect and assertEdge.
Change-Id: I811e070500b075bbc1733640bc81182ecd837dce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107040
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-06-24 02:09:53 +00:00
a5d6b81da8
Use flow analysis to report potentially non-nullable local variables that are used before definitely assigned.
...
Not done yet:
1. Switching all unit tests to `performFlowAnalysis()`.
2. Updating the error code and renaming tests.
3. Writing more language_2/ tests.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I0936f2daa4ab1cd91edeaca3eef9544eced5b443
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106982
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-23 22:08:43 +00:00
8b523e8efb
Migration: rename GraphBuilder to EdgeBuilder.
...
Nomenclature is more consistent now; the graph is built by a
combination of NodeBuilder (which builds the nodes) and EdgeBuilder
(which builds the edges).
Change-Id: Id162467eab2b3b3cc17ea9f72a0f291665b1a7d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107022
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-22 16:03:02 +00:00
fa8f1f60de
Stop visiting comments and convert NPEs to more meaningful errors
...
Change-Id: Idcebed220dbcd8fcb1613fce891387f88ee4d442
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107063
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-22 15:09:02 +00:00
990f84173c
[dart2js] Implement encoder for recipes
...
Change-Id: Ia8fd313b014730859796abaf0083fdf738034365
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106941
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2019-06-22 00:00:21 +00:00
477ac2d58e
Migration: start adding support for assignment of function types.
...
So far we only handle zero-parameter non-generic functions. Support
for positional parameters, named parameters, and type parameters will
be added in future CLs.
Change-Id: I5a5907ba595da40352193e0193f908bca4d1bf1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106040
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-21 22:59:41 +00:00
718ab662c0
Support postfix ++ and -- operators
...
Change-Id: Ib16f30a8b5d6e94b1a6ec0cddf5c88f58188ea83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107021
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-21 22:43:42 +00:00
e2bc5513f0
Migration: add a data structure for tracking class hierarchy information.
...
The new data structure, called `DecoratedClassHierarchy`, computes and
caches the variable substitutions necessary to relate a class to one
of its superclasses. In future CLs, we'll use this information to
create the appropriate contraints for override relationships, and to
compute the correct types when a method dispatch resolves to a method
declared in a superclass.
Note that the analyzer uses `InhertanceManager2` both to determine
what a method call resolves to and to record the appropriate
substitutions. We can take advantage of its determination of what a
method call resolves to (that information is stored in the resolved
AST), but we need to cmopute the substitutions separately because the
substitutions need to be decorated with nullability nodes.
Change-Id: Ifb334972e509b77151d41f7e0700cd590d7b5417
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106800
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-06-21 22:42:01 +00:00
ffb044e4f0
[dartdevc] Apply all lints from pkg:pedantic
...
Ignore slash_for_doc_comments in lib/src/js_ast to avoid additional diffs when
potentially un-forking in the future.
Fixes : #37218
Change-Id: If5c5bacf2d77fbae432217ba6031a6a8fa5dfcd8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106580
Commit-Queue: Nate Bosch <nbosch@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2019-06-21 22:13:59 +00:00
9b5718ca7e
[vm/bytecode] Cleanup support for bytecode formats older than v7
...
Bytecode format v7 was introduced 2019 May 08,
in 68de477535https://dart-review.googlesource.com/c/sdk/+/106969
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-06-21 21:38:09 +00:00
7a57e241a3
Support prefix ++ and -- operators
...
Change-Id: I2437469ad67721736a6b4800f0134e0f358a7dbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106970
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-21 20:48:58 +00:00
f6af8ccba8
[vm/bytecode] Consolidate bytecode generation options
...
As number of bytecode generation options grows, it becomes cumbersome
to add them and propagate from the place where they are parsed to
the place where they are used. In order to make it easier to
change and add new bytecode generation options, this CL introduces
BytecodeOptions class which consolidates all options for bytecode
generation. Also, command line options --emit-bytecode-*** are gathered
into a single multi-option --bytecode-options=opt1,opt2,...
Also, unused --use-future-bytecode-format option is cleaned up. If needed,
it could be easily re-introduced in the new BytecodeOptions.
Change-Id: I637bf28ceb4233ead2562afe7ad51c69a99f2d60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106965
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-06-21 20:31:38 +00:00
a1a51072da
Add a failing "move file" refactoring test for dartbug.com/37121
...
Change-Id: I88aa52e96c09ea6eec03013bfd3c3a3e205b08e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106981
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-21 20:09:48 +00:00
9b5ddec382
Better FutureOr support, failing test.
...
Change-Id: Ib662286a58fb9389ce1065d87835613f3b899be4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106968
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-06-21 20:09:38 +00:00
348e030ce2
Incremental refactoring in index.dart to setup the addition of the missing visitPartOfDirective()
...
Change-Id: I247db3ad49f928aaec0884aa8d99e603d5a26318
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106966
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
2019-06-21 19:15:18 +00:00
86622feae0
[dart2js] Handle ConstantExpression in InlineWeeder.
...
With constant-update-2018 enabled, ConstantExpression nodes are added to the AST. The defaultNode() implementation increments each node count by 1 whenever we see a ConstantExpression and then does it again when we visit the child DartType, resulting in each ConstantExpression being counted twice. Instead, we should just increment the node counts when we see a ConstantExpression and not visit the children.
Change-Id: Ifdbda2913420eea1463790cab2e477e7552d1394
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106727
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2019-06-21 19:12:58 +00:00
c01258a87d
Fix handling of &&, || and ?? operators
...
Change-Id: Ibfe574f381af701932cf30f5fdd77fe50a7c8158
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106961
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-21 18:45:27 +00:00
44c136423c
Report DEFAULT_LIST_CONSTRUCTOR_MISMATCH only in opt-in libraries.
...
R=brianwilkerson@google.com
Change-Id: I8c2a0e6742af85c00db04a5a7a94f3b91b9cee13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106964
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-21 17:36:10 +00:00
639cff0ec0
[dart2js] Detect non-trivial substitution between type and this-type in optimization
...
Closes #37267
Change-Id: I317c2b8e5fb3f1df10691bdaf9c10f20b8042b8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106347
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-06-21 17:07:57 +00:00
d0a22c747e
add migration engine support for top level setters
...
Change-Id: I436e673370ed0094b0615d99796f117145c8fbaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106923
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-21 16:50:17 +00:00
6089a943be
add migration engine support for imported top level var references
...
In addition to adding imported top level var references support,
this revert GraphBuilder._checkAssignment changes so that the method
conforms to team expectations and addresses comments in
https://dart-review.googlesource.com/c/sdk/+/106562
Change-Id: I3e2b021ec51a1363706a7f6811807d0e6a680df5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106920
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-21 16:50:17 +00:00
9c62632f49
add migration engine sanity check
...
This adds a sanity check to ensure that DecorateType.forElement
is not called on elements in libraries that are being migrated.
Change-Id: I394004a70e9ca3c9ac22f30e63e8e48a0cd03204
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106922
Reviewed-by: Paul Berry <paulberry@google.com >
2019-06-21 16:50:17 +00:00
6847789eb8
Fix an NPE in Variables when there are no decorated types in a given file
...
Change-Id: I4258becb60509b3dd0facfb2731be532464f665c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106947
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-21 16:24:27 +00:00
53a905cde1
Introduce function parseFile2.
...
This is similar to the existing `parseFile` function, but it is more
efficient, and it supports the same parameters `featureSet` and
`throwIfDiagnostics` as `parseString`.
Change-Id: I4b9ecc36a137cc1c99e671e379f00afa3942c9ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105542
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-21 16:08:07 +00:00
48fa94cfdd
Report MISSING_DEFAULT_VALUE_FOR_PARAMETER only when NNBD is enabled.
...
It works now, because we consider types in opt-out libraries as S*,
and so far TypsSystem.isPotentiallyNonNullable(S*) returns false,
because TypeSystem.isNullable(S*) returns true. But I think this
is wrong. The spec says:
We say that a type T is nullable if Null <: T. This is equivalent to
the syntactic criterion that T is any of:
<cut>
- S* for some S where S is nullable
<cut>
So, we currently say that `int*` is nullable.
But this is wrong - `int` is not nullable.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I87340fbed23cebd3d68c92579b7d1785b2fc097a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106952
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-21 15:53:17 +00:00
bd1ffcb2bd
Support for type formals in function LUB.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I5576db2279810bf1e4fc4a73870f60ca50166ee7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-21 14:35:27 +00:00
735eb21529
Add support for &&, || and ?? operators
...
Change-Id: Ibb6269b349b3d0ffcf1068442c70ef46a6f521eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106948
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-21 14:16:57 +00:00
77668f4e58
[CFE] Preserve errors in unevaluated and unused arguments and locals
...
Change-Id: If8c23ac2f374ee863fd8df4c241195c0a115e69d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104980
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-06-21 13:53:17 +00:00
0a4d47de3c
[fasta][nnbd] Add nullability modifiers to DartType
...
Change-Id: Ica2e5e250831573453c1d469571d9d001e7702a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106642
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-06-21 11:43:26 +00:00
153683b1be
[cfe] Get rid of 'strong' in incremental compiler tests
...
Fixes #37302 .
Change-Id: Id8e83dfa86dcd188e5541e0465fab08a51e39882
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106900
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-06-21 09:53:36 +00:00
a6eb2cd309
[vm] Support for simarm_x64
...
Third sub-CL of https://dart-review.googlesource.com/c/sdk/+/100644
The first was here https://dart-review.googlesource.com/c/sdk/+/103487
The second was here https://dart-review.googlesource.com/c/sdk/+/104286
This is the last major CL to support simarm_x64. Now that the other two
CLs have put the required infrastructure in place, this CL actually
adds the new mode..
Bug: https://github.com/dart-lang/sdk/issues/36839
Change-Id: Ie2f850bf33544f2462f37854e762191c78b1bde6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105500
Commit-Queue: Liam Appelbe <liama@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2019-06-21 04:00:35 +00:00
4f71abcd71
[dart_internal] Bump SDK constraint upper-bound to <2.5.0
...
Issue: #37324
Change-Id: Ibea63bb775c83484523fb8d6caeda918df25e849
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106949
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-06-21 00:39:25 +00:00
d046448d00
Convert an NPE into an unimplemented notification
...
Change-Id: Ic032f26d54d1e85a54ca21068988d4dd226f3879
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106946
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-20 21:18:07 +00:00
a4b67bd6ce
add regression test for issue 37285
...
Change-Id: Ieb2636ba8404c95a6b3027bd5fccf02876940933
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106501
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-06-20 21:04:37 +00:00
683ea6dc67
add fasta extension method test
...
Change-Id: I8de4f01463aa141ac4104d98b8ba42f970e32021
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103881
Commit-Queue: Dan Rubel <danrubel@google.com >
Auto-Submit: Dan Rubel <danrubel@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-06-20 20:55:07 +00:00
0ae10fa68d
[vm/bytecode] Support --causal_async_stacks in bytecode generator
...
Also, standalone_2/causal_async_stack_test is updated to actually
test --causal_async_stacks after Dart 2 sync-async.
Change-Id: I28a7a281963828707461652f19494ff54bdd21c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106760
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2019-06-20 20:23:37 +00:00
5042ff97c7
[vm/bytecode] Add async/async*/sync* attributes to closures
...
Change-Id: Ibb0f202ada840ee112f46d5db3d8f9459817c358
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106730
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2019-06-20 20:23:37 +00:00
Alexander Markov