792a3d561a
With summary2 the 'nameOffset' for directives in the offset of their keywords.
...
R=brianwilkerson@google.com
Change-Id: I2cade95e4fb876096ec299d45665fd51a8193bd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-17 17:49:21 +00:00
2164bcefdb
Add support for await expressions
...
Change-Id: I36c1bad75a0f6981715e621c09df1befef38061a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106166
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-06-17 16:58:51 +00:00
f9dfa7cbfd
[dartfix] Bump pkg:pedantic to version 1.7.0
...
New versions of pedantic now offer imports to versioned includes. This will
allow us to update packages in the SDK independently when new lints are added in
future versions.
Issue: #37218
Change-Id: I43a4a9ba6730ed107a87f4060d47bb50d837de49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106184
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-06-17 16:47:52 +00:00
f897a940c1
Fix minor nit in documentation
...
Change-Id: I0a75ecce970754b036f2af0a065aa392547dae7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-17 16:19:09 +00:00
071a99bfbe
Add support for super expressions
...
Change-Id: I7d78810ca7fe8f669370803f2dd8146379ca2f7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106164
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-06-17 16:15:54 +00:00
9a2eecf67f
Fix parseString: ensure that CompilationUnit.lineInfo is set properly.
...
Change-Id: Id81338c1021f9548f2c3f24931baf1e45ac1b18b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106320
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-06-17 16:10:29 +00:00
43264f5f97
Add missing CHANGELOG entry for parseString
...
Change-Id: Ieb293ac02d97cf454231a27a82bf9dade567ada5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106321
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-06-17 16:07:49 +00:00
2a240ddab9
Don't create accessors/fields typed as Impl.
...
DDC code generator copies these lists using toList(), so inherits
their reified types, and then fails to add a PropertyAccessorMember,
which is not an Impl.
R=brianwilkerson@google.com
Change-Id: Id26ef7bcea07b9956ebf7487883fbbf9f92cf7ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106301
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-17 15:59:50 +00:00
df8e0aff6c
Use AnalysisDriver.useSummary2 in FileSystemState.
...
R=brianwilkerson@google.com
Change-Id: Ie64f05a522d08c1fe779ccc78fbfe25ad52ec422
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-17 15:59:46 +00:00
60fa066cd7
Filter LSP completion to exclude symbols already imported via another URI
...
Change-Id: I39d807ef88b939feffcba2b333dd76595257c768
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105760
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-17 14:16:21 +00:00
8d39e3456f
[vm/aot] Minor improvements to make snapshot profiles more useful.
...
Change-Id: I614d0af3fb3b2bcb642f13d767c385d255b43d5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105580
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2019-06-17 13:09:50 +00:00
b92c287fd7
Use StateError in LegacyTypeAsserter.
...
AssertionError does not print on the console its message, at least in
IntelliJ. Also tweak tests to use throwsStateError.
R=brianwilkerson@google.com
Change-Id: Ifbe2ed0b1d3deba1feaecc7c462f470e8608b70c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106204
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-15 19:45:51 +00:00
7f0519721e
Use unit featureSet during linking.
...
This fixes NonNullOptOutTest.test_nnbd_optOut_late with summary2.
R=brianwilkerson@google.com
Change-Id: I9939ca92daaed349491df3463394164ead5d626b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106205
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-15 19:39:31 +00:00
c5cd37e727
Address more documentation feedback
...
Change-Id: I2e55e146495ab8bd59e87cff9915ee84c99da8b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-15 15:30:40 +00:00
58664602a5
Change NullabilityGraph.propagate to return a list of unsatisfied edges.
...
In follow-up CLs this should allow us to simplify the generation of
fixes (since each fix is associated with one or more unsatisfied
edges) and to streamline tests.
Change-Id: I997f704aac41f270756adcdf8d382fb2263273eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106180
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-06-15 12:55:00 +00:00
c1b56a9ea0
Catch the test_runner codebase up to somewhat modern practices.
...
- Run dartfmt --fix. This converts JavaDoc comments to "///", removes
"new" and extraneous "const", and a couple of other things.
- Fix SCREAMING_CAPS constants to lowerCamelCase.
- Use collection literals where possible.
- Use UI-as-code in a couple of places where it seemed obvious.
- Use "var" for more local variables.
- Use "const" instead of "final" when possible.
- Make members private when possible. Deleted a few that then became
obviously unused.
- ".length > 0" -> ".isNotEmpty".
There are no meaningful changes.
Change-Id: Ic6c5a74b2af9b3ebcbe881dbed69f65488bdef09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105880
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2019-06-15 01:02:50 +00:00
99e8a9fba5
Move the test runner (i.e. "test.dart"/"test.py") to pkg/.
...
This makes it an actual Pub package like most other code inside the SDK
repo. The main goal is to make it easier to write tests for the test
runner itself.
This change:
- Moves all of the code from tools/testing/dart/ over to
pkg/test_runner. Most of it ends up under test_runner/lib/src.
- Move tools/testing/dart/main.dart to
pkg/test_runner/bin/test_runner.dart.
- Move standalone_2/io/test_runner_test.dart to
pkg/test_runner/test/test_runner_test.dart. I don't think it currently
works, but it wasn't being run in its old location either.
- Add test_runner to the analysis-server bot. This ensures the
test_runner package is static error clean.
- Remove standalone_2/io/test_runner_analyze_test.dart which used to
attempt to do the above and is no longer needed.
- Update test.py to look for the test runner at its new location.
- Add test_runner to the repo .packages file and remove the weird
test_dart pseudo-package. (I think this fixes #35279.)
- Remove status file entries for the removed standalone_2 tests.
There are no code changes to the test runner itself aside from fixing
up import paths.
Change-Id: I3d05d50d222b291848fa5a30de2846e803bc81e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105821
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2019-06-14 23:35:10 +00:00
177f425012
[dartdevc] Fix violations of library_prefix lint
...
Rename the library prefix used in imports from `JS` to `js_ast`. Create more of
a distinction between:
* `JS` the library. Now named `js_ast`.
* `js` the const instance of a JSBuilder.
* `JS` the helper to inline javascript in the SDK patches
and runtime libraries.
Ignore the lint in the js_ast directory to avoid additional diffs for the
eventual un-forking of the package.
Cleanup a few unused imports.
Issue #37218
Change-Id: I039c1048876d9d9ad424fbec3ad555d300845a3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106160
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-06-14 22:48:40 +00:00
047bacc94c
Add support for symbol literals
...
Change-Id: I273b2290b8d4d2e0948fac1962d02efc70e7813e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106163
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-14 22:13:40 +00:00
11cc292383
[dart2j] Add TypeEnvironmentStructure and TypeRecipe
...
These will be tracked through SSA to generate correct recipe strings.
Change-Id: Ifebeead0f39d87be3208c673e34793145c64cf23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106181
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2019-06-14 22:10:19 +00:00
d342402c80
Always ensure TypeProvider, even with external summaries include the target library.
...
There is at least one case (but not many) when this happens internally.
R=brianwilkerson@google.com
Change-Id: Ic940cb836f58467d40ed7b31cb8bb43cf12eee50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106165
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-14 21:57:34 +00:00
d4cad0fff1
Restore element and typeArguments for typedef-based _FunctionTypeImplStrict.
...
R=brianwilkerson@google.com
Change-Id: Ibc7fc53aba10661236f0d3f3361bf7f05882cc5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-14 21:55:20 +00:00
2eebc1024c
Refactor non-bool expression checks
...
Change-Id: I4da7abe3293c4dbf7218f3a276cf9418b3d14f19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106000
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-14 21:50:30 +00:00
9bb678f88b
Add support for is expressions
...
Change-Id: I3be70d83b03a4d00a68070fb03ba2ab989880a9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106161
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-06-14 21:43:50 +00:00
c246fa1f2b
Fix #36956 , report undefined getter for uses on Null.
...
Bug: 36956
Change-Id: I5b8f40f5c1f7fd9304b02054e3d8d7d607c12af1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106021
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-06-14 21:29:29 +00:00
f56df4a251
Add support for double literals
...
Change-Id: I08ea12bb0213272b192d063fd3699b2495912077
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-14 19:57:26 +00:00
fa885b3eae
report undefined operator instead of method for bad +=.
...
Change-Id: Ia28fdb47c80768b011b05edc1e3e7b832f9335e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105971
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-06-14 18:56:07 +00:00
fc5eb09cb9
Migration: remove getUpstreamNodes
...
This method was unnecessary--the same functionality can be provided
more efficiently by getUpstreamEdges.
Also fixed a doc comment error in getUpstreamEdges.
Change-Id: I44560eced353b57e00b06e57c8c628de79d689e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-06-14 18:31:57 +00:00
1e454a1c1b
Add some missing visit methods from the visitors
...
I'll start implementing them and adding tests in future CLs.
Change-Id: Ic8cb5ed9bd00f05232869d7f4c585daa5d5ab4c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106122
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-14 18:03:37 +00:00
dcc85a6594
Fix exception thrown in ConditionalModification
...
Change-Id: I6e60bd74bc55cafca86a64a721455e0ed465a357
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106101
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-06-14 17:13:37 +00:00
a02d6de474
Update documentation based on addition feedback from the documentation team
...
Change-Id: If028f6f3a81a827537642da9f261001588f67bf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-14 17:09:37 +00:00
fb85d41c08
Catch another exception earlier in the code
...
Change-Id: Ia9fdca760c4c0838cdb6bb31c00f296fbf21cbac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106102
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-06-14 16:02:37 +00:00
e3004dae0d
Fix hint override_on_non_overriding_setter
...
Change-Id: Id0b9cf7fcfb972b77181356f0d70275ce1e3be1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106100
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-06-14 14:58:27 +00:00
a2f32ebe87
finish cleanup ErrorToken parsing
...
Change-Id: I876c4805561d29b289184ce696fe4db2038bc362
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-06-14 13:40:17 +00:00
6bd64ff8b2
cleanup StringScanner references
...
Change-Id: Ic75305c7a76860c5b96032d4f8c8fff695006f22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-06-14 13:39:47 +00:00
8cc00f8f18
[dart2js] Move embedded globals earlier
...
In anticipation of adding type metadata for --experiment-new-rti, move the embedded
globals earlier so they are available for generating constants.
The metadata for custom elements is split out since it depends on constants.
Change-Id: Ic99895bd1a1f7bf42a1f41948733ea001df8a8e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106007
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2019-06-14 04:13:41 +00:00
25292abc1d
Add support for boolean negation
...
Change-Id: Idae8d8dbedacdd0004dff3afad2d736b3a652466
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105972
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-13 23:02:57 +00:00
a19611b079
Improve test coverage for constructor parameters
...
Change-Id: Ia1a803bd52e94e15696c60c77938fd2f5c08bdaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105981
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-13 22:20:26 +00:00
611ed823f0
[dartdevc] Add packages arg for creating the DDC SDK from kernel
...
Copied from a change by keertip@ from internal repo.
Original change ID: 253076358
Change-Id: I997ffe7c4fa0588689a2562b7b1dcd5c01837919
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106002
Reviewed-by: Vijay Menon <vsm@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-06-13 21:58:16 +00:00
1a9801e9fa
mark ExperimentalFeature bogus_enabled and bogus_disabled as deprecated
...
... and update comment and test output to indicate how files should be
regenerated from tools/experimental_features.yaml
Change-Id: I369b93c35b91f7a93c915f0abf9cebdd00c13f8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106003
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Dan Rubel <danrubel@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-06-13 21:30:05 +00:00
fa0fe94b57
[dart2js] Generate new-rti SSA instructions for checks
...
There is no codegen yet so almost all code compiled with
--experiment-new-rti will crash the compiler.
Change-Id: Idf542646ac3629cb02a50d44c2a98abd156047ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106001
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2019-06-13 21:21:20 +00:00
60c04b8f44
[dartdevc] DDK now outputs relative paths in source maps
...
Bug: https://buganizer.corp.google.com/issues/133784498
Change-Id: Ifbaae661ac401d0a935a100fbbb7fa2e42325abc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105703
Commit-Queue: Mark Zhou <markzipan@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2019-06-13 21:16:45 +00:00
e9f17ae8e8
Convert some NPEs into explicit throws and add the missing visit methods discovered by doing so
...
Change-Id: I0613614168a7373a460d05cf8470f9b59264de0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105970
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-13 18:51:44 +00:00
9676ca0ff9
Support constructor invocations with arguments
...
Change-Id: I2d537121efd29f051d8f533c6f58e0ad10835301
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105964
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-13 18:29:10 +00:00
41a23711d9
Support for LinkedElementFactory in getLibraryElement().
...
R=brianwilkerson@google.com
Change-Id: I82d613d33beaaa8c46a718996993fd4c8e584d3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105966
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-13 17:50:30 +00:00
f9c2e3856b
Store exactly GenericTypeAliasElement with FunctionType(s).
...
R=brianwilkerson@google.com
Change-Id: I128eaf7852eb23031d843e1d970cf62b6c975fc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105967
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-13 17:50:17 +00:00
1e92103181
[dartdevc] Fix violations of avoid_relative_lib_imports lint
...
Issue: #37218
Change-Id: Id248e378d6fbe832952b8e61102da7f68536f81b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105861
Commit-Queue: Nate Bosch <nbosch@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2019-06-13 17:30:17 +00:00
9d3afa537e
Compute parameters before calling DecoratedType constructors.
...
This will allow me to put stronger assertions in the DecoratedType
constructor in a follow-up CL.
Change-Id: I375ae2b33c2f14948d9fedbdfbc000b8a1057b00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105963
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-06-13 17:06:16 +00:00
8a5495700a
Clean up null aware access test
...
Change-Id: I893b4cea44278d114160331b69d06d92d0e56cf1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105735
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-06-13 17:04:06 +00:00
c530c333bb
Update null-aware nnbd "?.[" operator recovery
...
This sets the "?.[" endGroup to "]" for proper token stream structure
and parser recovery.
Change-Id: Ie4147ac5dedcc273ea6cfda6dafc5d91e892b1a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-06-13 16:53:26 +00:00
Konstantin Shcheglov