680744d169
Fix version number strings to always include a patch number.
...
The version parser we use (Version.parse from package:pub_sumver)
doesn't support `major.minor` formatter version strings.
Change-Id: Ie6bf59d0f59d24d036c037d079494eb980e73212
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99886
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-19 22:44:31 +00:00
af0fa108da
Add support for required named parameters
...
Change-Id: Iebfd8da18c6f2158ed39043ab116e2670a7329c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99717
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-19 19:25:01 +00:00
a2e06eafff
allow built-in keywords as identifier in for-in loop
...
Fix https://github.com/dart-lang/sdk/issues/36678
Change-Id: I2af3a21e96c5654b12c199fc71d87f088e9d739d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99904
Auto-Submit: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-19 19:07:11 +00:00
63658b113c
Proposed new API for tracking feature opt in/out
...
Change-Id: I777094da1301b525cd92cab1f9bf49d2f70a911b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99784
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-19 18:20:41 +00:00
8924c18003
[vm/tests] Revert changes in pkg/vm unit tests after constant-update-2018 was disabled
...
Pkg/vm tests were adjusted after constant evaluation was enabled in the front-end.
As constant evaluation was reverted (4b7d256a06734c50cbf225cb45c02fhttps://dart-review.googlesource.com/c/sdk/+/99782
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-04-19 18:12:21 +00:00
9e87c16677
Record TopLevelInferenceErrorKind.dependencyCycle in summary2.
...
R=brianwilkerson@google.com
Change-Id: I1869f31dd6163827026e8e9d54e8682cb9ab2405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-19 15:45:34 +00:00
3ae2ef7763
parse "late" modifier
...
This updates the parser to recognize the "late" modifier and produce
errors when it is used improperly, but not yet notify the listeners.
Listeners will be updated in a subsequent CL.
Change-Id: Id15dfb1e3763872256e2ec93c83cf58adda096d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99786
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-19 01:25:26 +00:00
f8491950fe
Create List<TypeParameterElement>, not Impl.
...
Otherwise this Impl type gets propagated via toList(), and we get
a cast failure when attempt to assign TypeParameterMember element to
it. I'd like that we did not use TypeParameterMember at all, but
for now we do.
R=brianwilkerson@google.com
Change-Id: I03e1392fbd52d5a0fc7c257265d17d1cbd391edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99718
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-18 20:15:26 +00:00
fa7485f28e
Build types for not simply bounded elements using dynamic type arguments.
...
R=brianwilkerson@google.com
Change-Id: Ia3c2d5193212a8cf58caad2323185e1ac9e31c9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99716
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 20:14:49 +00:00
9d376de55a
[vm] Remove code collection.
...
Code collection interacts badly with
- warming up compiled code
- retaining pre-compiled code
- code coverage
- hot reload (deopting to an old version of a function)
Change-Id: Id269a6c3281e577d4f600f0c158af9e62f6b49ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99722
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-04-18 20:12:09 +00:00
0c0e49cd11
update keyword list to include "late" modifier
...
Change-Id: I10d815d78d8198749680af1b56eff8eb31a6f895
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-18 19:59:29 +00:00
2b9f968d2f
Convert engine.dart to triple-slash comment style
...
Change-Id: I5808862e2d9a8e0944f713d925cf9b526bc5cccc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99780
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 18:45:08 +00:00
20fde9a6a8
Don't overwrite inherited types of fields with types of initializers.
...
R=brianwilkerson@google.com
Change-Id: I0a92cc38e6f4bb8fe8f2102bf62f27c61ade1823
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99715
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-18 18:03:59 +00:00
e6e2a196a3
Issue 36667. Check for unresolved URI in getLibraryByUri().
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/36667
Change-Id: If35719b350c2f26edbb7cbe42f51af896aa41fe7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99713
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 18:02:38 +00:00
6ac38a926c
The synthetic default constructor should have reference.
...
We use ElementImpl.reference to store references to elements.
So, all elements must have one, even synthetic.
R=brianwilkerson@google.com
Change-Id: I29932449d97816108a6c1fca6db3fe7162baa1ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99781
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 17:44:10 +00:00
92729e0cd3
Remove UndefinedTypeImpl.
...
And corresponding DartType.isUndefined as well.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I85debe627e989b5a5671becf5d9dd16413562236
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99729
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-18 17:42:28 +00:00
cf77b82f52
[analyzer] handle youtube and animation dartdoc directives
...
Change-Id: I5bcad74803da2466c8a50160823c586f57e00ec1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99711
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-04-18 17:18:28 +00:00
6384f629c0
new conflicting-modifiers error code
...
This adds a new "conflicting modifiers" error code for new NNBD
modifier errors and replaces the existing "const and var" error
code with the new error code.
Change-Id: I1997bbb7f66e62d2de3c5042b6ea85861f2e00d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-18 16:44:08 +00:00
f3703c1bce
change "late" from built-in to keyword
...
Change-Id: I851bc1a6db305c6fa7f5be001af1632d6d69aa2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99739
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-18 16:42:28 +00:00
af9c01432c
Remove unused import
...
Change-Id: I41a322c6eb208127256d752be23a92e59a01387f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99710
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2019-04-18 14:10:48 +00:00
7b6b8f8c43
Restore 'parameters' and 'typeParameters' for ParameterElementImpl.
...
This partially reverts https://dart-review.googlesource.com/c/sdk/+/5000
which was done during moving toward integration with Kernel, which
we don't do anymore.
With summary2 the FunctionType of a function type parameter is purely
synthetic, without its original element. However parameters in
function typed parameters still exist as nodes, so they must have
elements.
R=brianwilkerson@google.com
Change-Id: I6689b05459f3989a20839346013c80a86ac8dc7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99709
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 14:10:18 +00:00
bc58bf598e
Add summary serialization support for nullability suffixes.
...
Resynthesis support will be added in a future CL.
Change-Id: I652da0c1ba60d8e41179e952294b4a4b45961347
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99702
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-18 12:11:08 +00:00
336fc9001c
Fix for getting type of a DefaultFormalParameter during building types.
...
R=brianwilkerson@google.com
Change-Id: Idce49baa00c9b100efd5622ecfc64ef8f85bcb78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99708
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 05:08:08 +00:00
e93c6b7ce1
Add AST representation of the late keyword
...
Change-Id: I0475065506488a0313c0aa6bc7f30d16f95d1405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99730
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-18 01:56:18 +00:00
284a299543
Fix mustCallSuper for mixins; fixes #36492
...
This re-lands most of https://dart-review.googlesource.com/c/sdk/+/98443 .
This change does not include the "inherited interfaces" bit of that CL,
which some developers have objected to; we'll discuss.
Bug: https://github.com/dart-lang/sdk/issues/36492
Change-Id: Ibaa8ab87c749eae6359b739204c6f286b6818aa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-04-17 22:59:11 +00:00
5a824581b7
Read directive annotations before returning offset.
...
AST is read lazily.
R=brianwilkerson@google.com
Change-Id: Ibba09fd28d0cf6c0b5d59b0bf437b09adf16c78f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99706
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-17 21:47:28 +00:00
703ccc974b
Support for TypeParameter metadata.
...
R=brianwilkerson@google.com
Change-Id: Id0d0b9018538986787832c8001c6aa43c6bec380
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99733
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 21:47:13 +00:00
242ed77040
Fix for FormalParameter without name.
...
R=brianwilkerson@google.com
Change-Id: I9dd957a9a55aef444f1e82a094dbf600a57074b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99732
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 21:46:46 +00:00
92dd37081d
Write / read Annotation element.
...
R=brianwilkerson@google.com
Change-Id: Ia1cf2fd7d397186094827245a3cf33a5892690aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99731
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-17 21:46:11 +00:00
b8a9711489
Update AstBuilder to handle "required" modifier
...
Change-Id: I68a3f0abd405119ccc52dc9263860129fff7453a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-17 21:19:51 +00:00
ca28e2c8ce
forward "required" modifier to parser listeners
...
... and have each report an error by default
Change-Id: If818a7bb207becbed95a97890632a1803917d285
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 21:19:51 +00:00
250d931ecc
When URI cannot be resolved, the library is null.
...
R=brianwilkerson@google.com
Change-Id: Icdba4cd1c23b88bdfc11bd9082a79738f3371a9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99726
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 20:27:56 +00:00
2491767a33
Use correct CompilationUnitElement for annotations.
...
R=brianwilkerson@google.com
Change-Id: Iad43c3f8cb02bcc165235e3832a569f4dd44c7a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99725
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 20:27:35 +00:00
4ef18fdb96
Fix nameOffset for Export/ImportElement.
...
R=brianwilkerson@google.com
Change-Id: If757d8ccbb0bdaed74c2d4268a507bd87854ab05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 20:27:18 +00:00
7873dbdc1d
Fix for duplicate declarations.
...
R=brianwilkerson@google.com
Change-Id: Ie08b441edc30027ec4c4509f6c77b97d4cf8242d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99723
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 20:27:01 +00:00
714a082a5d
Minimal integration of summary2 into AnalysisDriver.
...
There are also a couple of fixes for linking, to reduce the number
of failures.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I411ac34dd65bafd35adcbf22c1b78869ec0b5e24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99703
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 19:15:52 +00:00
dd3530450d
make "late" and "required" builtin keywords
...
Change-Id: Ia352ec979bc04edcb1e9ee9733a3f86d8e5ce1a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99644
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-17 18:51:01 +00:00
836efd6520
Add a language_2 test for having an invalid type in an on clause
...
Change-Id: Ia073e6a85f6f5cc54ecb45ab5d4e11e7976c3134
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99701
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 18:35:20 +00:00
81e554ea43
parse "required" modifier for NNBD
...
This updates the parser to recognize the "required" modifier
but always reports an error when it is detected.
A subsequent CL will update the listeners to handle the new modifier.
This also cleans up ModifierContext initialization
and adds a new pseudo-keyword-used-as-type test
Change-Id: I83f9a6b410c2bfb3476e691d3e8482bf7c97b0dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99643
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-17 17:54:00 +00:00
7b9ab9f353
Add error ranges to more diagnostic tests
...
Change-Id: I7c3efc8b4973f84f6b1ccfaf85d1c5655b461ffb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99446
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-17 16:08:16 +00:00
3782197e95
Sort summary_common.dart
...
Change-Id: Id3ce4ab8437de025ce9e7cd754f69a18f18c72b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99642
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-17 15:41:36 +00:00
b0c98d57fa
Add the new manifest error codes to error codes list
...
Change-Id: Iaea0edc3d0680c03dec32c5da74399e1b26a399c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2019-04-17 15:08:16 +00:00
ebdefa3f5f
add new "late" and "required" modifiers
...
Change-Id: Iec0acac1bb4280f31bd32297543eceb54f87f1ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-17 15:01:36 +00:00
9a5a720413
Remove dead/outdated lints from pkg/dev_compiler/README.md
...
Change-Id: I6f09fcc5e8627b22e2a1e14568218108501ffa8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99640
Auto-Submit: Kevin Moore <kevmoo@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
Commit-Queue: Jenny Messerly <jmesserly@google.com >
2019-04-17 00:40:56 +00:00
523666a97a
Fix messages_test.
...
Now that the feature is enabled by default, this status file needed to be updated.
TBR=dmitryas@google.com
Change-Id: Ib9ca7350e40da31fab7804fbcd89ca54180d5bd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99620
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-04-16 21:38:09 +00:00
8e73b3c006
Enable ui-as-code features.
...
Change-Id: I97781ffe5144c4b959cb3cb720e9cd06c22928ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99283
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-04-16 21:29:55 +00:00
e7f75e11ae
Add more checks for manifest
...
Change-Id: I1bdfa35fe6ae6d026a913abc95b209f0fe41e2fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99500
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-16 20:33:15 +00:00
4b7d256a06
Revert "Enable constant-update-2018 by default." and "Update .expect files in pkg/front_end after e9ca6a53"
...
This reverts commit e9ca6a5335d3e00fd35ehttps://dart-review.googlesource.com/c/sdk/+/99560
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2019-04-16 20:20:12 +00:00
ecdbdf00b8
[dartdevc] Retry ddc incremental compile on crash
...
Change-Id: I00c2eb1b3bc6d9153fd2e88a8074e5670a0e082e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99442
Reviewed-by: Jake Macdonald <jakemac@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
2019-04-16 20:06:05 +00:00
f175b0baf8
Report errors for using control-flow and spread features in a const context
...
CFE detects the const context while parsing, so we can report the error message
early on before we do any transformations.
Change-Id: Ib1cadb28366eb6a9a18612206aa155b04a4a5b32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99540
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-16 19:50:55 +00:00
Paul Berry