43e26c2de9
Add highlight support for late and required
...
Change-Id: Ic57ab28c3cbe600f9733733d96d367e774504b97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100323
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-24 13:22:26 +00:00
e42c5d12fe
Cleanup tests by removing references to enabled experiments and by reducing duplication
...
Change-Id: Ic7eb96e1724d2a51469e41760856d4194e3379e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-24 13:20:36 +00:00
5ebb640a67
[vm] Finish adding support for ECMAScript 2018 features.
...
This work pulls in v8 support for these features with
appropriate changes for Dart and closes
https://github.com/dart-lang/sdk/issues/34935 .
This adds support for the following features:
* Interpreting patterns as Unicode patterns instead of
BMP patterns
* the dotAll flag (`/s`) for changing the behavior
of '.' to also match line terminators
* Escapes for character classes described by Unicode
property groups (e.g., \p{Greek} to match all Greek
characters, or \P{Greek} for all non-Greek characters).
The following TC39 proposals describe some of the added features:
* https://github.com/tc39/proposal-regexp-dotall-flag
* https://github.com/tc39/proposal-regexp-unicode-property-escapes
These additional changes are included:
* Extends named capture group names to include the full
range of identifier characters supported by ECMAScript,
not just ASCII.
* Changing the RegExp interface to return RegExpMatch
objects, not Match objects, so that downcasting is
not necessary to use named capture groups from Dart
**Note**: The changes to the RegExp interface are a
breaking change for implementers of the RegExp interface.
Current users of the RegExp interface (i.e., code using Dart
RegExp objects) will not be affected.
Change-Id: I0709ed0a8d5db36680e32bbad585594857b9ace4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95651
Commit-Queue: Stevie Strickland <sstrickl@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-04-24 09:24:16 +00:00
c4ab0d2014
Inline create methods in JsKernelToElementMap
...
Change-Id: I911c7c81056f07dd15c23162489bbcd8bda5d05b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100221
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-04-24 06:57:16 +00:00
db8f0090a5
Separate mixins into @mixin, build GenericTypeAlias.
...
R=brianwilkerson@google.com
Change-Id: I5ac649978607d1369b4c06ccd330361b973a9c05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-24 05:24:56 +00:00
d6a09ff02f
Prepare to publish analyzer version 0.36.2
...
Change-Id: I4ae73e8a55cf8c0d013152eb15bea74f2c1f69e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100321
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-24 02:32:36 +00:00
07017d33a6
pkg/analyzer_plugin: support the latest pkg:analyzer
...
Change-Id: I0948b78c481594e31a54aa356b320fbc5744eb90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100302
Commit-Queue: Kevin Moore <kevmoo@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Kevin Moore <kevmoo@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-24 02:26:26 +00:00
9af0574287
Remove unused import
...
Change-Id: I6fc0c75afc22b31e101631dac366b58a2f2ba8a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100285
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-24 01:17:15 +00:00
b5769936a9
Perform mixin inference during types building.
...
R=brianwilkerson@google.com
Change-Id: Id6f685be40ea7cf8100d635208fd6327df5e390e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100276
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-24 00:14:57 +00:00
4624419736
Support UI-as-code in deprecated parse functions.
...
Fixes #36724 .
Change-Id: Iff8277c0e08b11ec815426b1940767076f4141ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100278
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-23 23:19:25 +00:00
ca9bbd39d5
[dartdevc] Remove ddc and ddk pre-compiled "legacy" sdk modules
...
We do not expect any client uses of the precompiled SDK in this module format. The only know use
case builds the SDK manually first.
Add simple tests that files can be compiled with `--modules legacy` option.
Issue: #35988
Change-Id: Ie2c4244e5876bb04f968b0198f5763ff3d29c01c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99921
Reviewed-by: Jenny Messerly <jmesserly@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-04-23 21:29:15 +00:00
e695bc3c6d
Record type inference errors for fields and parameters.
...
R=brianwilkerson@google.com
Change-Id: I1d6856eac8ecab4bdb7c5290f1cdb296b2d6db6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100271
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-23 21:04:46 +00:00
c66a67c4a3
Rename isLazy to isLate to reflect change in keyword
...
Change-Id: Ic4891aa7a9d4d16719cb23a3f5e4afc928087960
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100267
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-23 19:36:25 +00:00
b9be35b3fc
Perform override and initializer inference at the same time when required.
...
R=brianwilkerson@google.com
Change-Id: I54cf4d1e343439494e10cbfe2d5016cb36120df2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100269
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-23 19:25:59 +00:00
688f029c4f
Rename workspace to refactoringWorkspace in move_file.dart to clarify the type of the object.
...
Change-Id: Idfe7c53cfbdab59d7343c449f01c1ab4c57160db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100266
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
2019-04-23 17:40:42 +00:00
594a0ef7a7
Perform instantiateToBounds() even for not simply bounded types.
...
Apparently my previous understanding was wrong.
R=brianwilkerson@google.com
Change-Id: I17ccce93d8e6b8744eaf05c80782ae4f1fe4a414
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100090
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-23 17:39:08 +00:00
b4d17f2eee
Add diagnostics related to default values
...
Change-Id: I4b30580e34fbf302a53778010fada54a2e100409
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99887
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-23 17:16:50 +00:00
cee1e41fe8
Plumb new FeatureSet class into Scanner.
...
And change clients of the scanner (within the SDK) to use it.
Long term, it would be better to store the FeatureSet object directly
in the Scanner and remove the existing flags `enableGtGt` and
`enableNonNullable`. However there are analyzer clients that
currently use these flags. So for now, we simply plumb in the
FeatureSet as a new way of setting AstBuilder flags. Once we've
updated clients to use FeatureSet, we'll publish a breaking version of
the analyzer that removes the old flag API.
Change-Id: I9e662f4ed45668d9acd4f56e42d7d8dae6180d48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99975
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-23 16:13:43 +00:00
bb2a3ca6f6
Plumb FeatureSet into ConstantVerifier
...
Change-Id: I40509fffcbb9d772100b1b5e4bc5461dccf5bc27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99978
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-23 14:57:32 +00:00
81b028de78
cleanup some error codes
...
* replace CovariantAfterFinal with ModifierOutOfOrder
* replace ConstAndCovariant with ConflictingModifiers
Change-Id: If09551a28d4bffecaf009b4e836a67dfc939c0bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-23 14:22:12 +00:00
80d4b9a5db
[vm/frontend_server] Expose protobuf aware tree shaker in frontend server
...
Change-Id: If195ab074278d4768d261b6f6ffd1529de1f7e2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100241
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2019-04-23 13:40:52 +00:00
1f1592edce
Add manifest checks for touchscreen feature
...
Change-Id: Ib849eccdbad6f41e22dbffeca755099cb3926f8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100160
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-23 00:32:54 +00:00
5ee20c99ac
[vm/aot/tfa] Workaround for crash in getStaticType
...
Issues: b/131091988, https://github.com/dart-lang/sdk/issues/34496
Change-Id: I9ef8edfff39848e6f240402682d119fe35f7f776
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99972
Reviewed-by: Aart Bik <ajcbik@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-04-22 22:49:24 +00:00
2c304d997f
[dartdevc] fix #36372 , make JS Array constructor property usable from JS
...
The `new array.constructor()` pattern is occasionally used in JS
(presumably, to get the array subtype if one is available). GopherJS in
particular does this. This fixes DDC's generic `JSArray<T>` to support
this pattern, for all values of T. This also makes JSArray work like
all other "native" types in DDC, where the "constructor" property
is the JS constructor for that native type.
Change-Id: I5270bd648d3d60cf07b8548fcd8c9b9d1a3018d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99940
Auto-Submit: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Jenny Messerly <jmesserly@google.com >
2019-04-22 22:43:14 +00:00
ef9c25c08b
Support codeOffset/Length for CompilationUnit and other nodes.
...
R=brianwilkerson@google.com
Change-Id: I155662712bf72f2823bb0a3b35b1de341f27670d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99977
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 22:03:39 +00:00
80bed430c8
Extract AnalysisDriver tests that work with summary1 into a separate test class.
...
R=brianwilkerson@google.com
Change-Id: I4c078d189b3c1bd7c0da3cfbe87490c2cedbc40f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99976
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 21:39:09 +00:00
39662f8108
Set ElementAnnotation for directives.
...
R=brianwilkerson@google.com
Change-Id: Idfd06b4bd987796e32982083d2a4453777a77cda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99974
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 21:22:09 +00:00
c7279d347b
Always lazy create TypeParameterTypeImpl.
...
Also, not every FunctionType has element, so change FunctionTypeImpl.fresh().
R=brianwilkerson@google.com
Change-Id: Id760d2f94d6fc0c4dad56a1d139068177cce8a0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99973
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 21:08:38 +00:00
27b64953d5
Fixes for applying resolution for fields metadata.
...
R=brianwilkerson@google.com
Change-Id: I6154b5dc78b802cc9ebe184132f697fc8a7c4b02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100088
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 20:56:21 +00:00
385406ac92
Give LinkedElementFactory its AnalysisSession, fixes for nameOffset.
...
R=brianwilkerson@google.com
Change-Id: I0cf24dd2b1662fbe50478aea6e21da874d83598f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99971
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 20:56:10 +00:00
8b6d04b2ee
sort tests
...
Change-Id: I598ea625cc7dce757906f2f7fbef0c5d186ee462
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99969
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Dan Rubel <danrubel@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-04-22 20:54:23 +00:00
c89e71cd40
The default return type for []= is void.
...
R=brianwilkerson@google.com
Change-Id: I748ada4ee9a6f7f9c2693d959982305c5b9d1650
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100086
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 20:27:24 +00:00
3aef424c9c
Always add imported / exported files, even if they are parts.
...
R=brianwilkerson@google.com
Change-Id: I884e61711c61f8d664428f13d3c699a56ed76295
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100084
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 19:59:22 +00:00
e7a54a9759
Support for TokenType.GT_GT_GT
...
R=brianwilkerson@google.com
Change-Id: Ie02eb93757a4fe6e89eafab70027523e828d5208
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99968
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 19:45:13 +00:00
ec79fc2ff4
update AstBuilder to process "late" modifier
...
Change-Id: I97530583b059a39d502469079940ffc5b8d4db71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-22 19:34:33 +00:00
390ba6925d
Allow nnbd to be enabled in tests
...
Change-Id: Iafe7abc132c664b0b16109b3c5d6fd8a6ac3b0c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100083
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 19:11:08 +00:00
d1b675055c
Read all GenericFunctionType(s) and TypeParameter(s) is lazy AST before reading eager AST.
...
So, that all corresponding elements are available.
R=brianwilkerson@google.com
Change-Id: I844cc276fda574883a658cc9b150a0a74b13e63a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100120
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 18:55:16 +00:00
2d6313c9e4
Prepare to publish analyzer version 0.36.1
...
Change-Id: I84e132ff2b2635cc5703a58c88f5ab1767e4970e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99965
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-22 18:05:19 +00:00
4a33d33297
Store FeatureSet in CompilationUnit.
...
Change-Id: I8c132b0ae93ee76adb5cf89f8a725db048b9e935
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100060
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 17:38:39 +00:00
08832508ec
Forward "late" modifier to parser listeners
...
... and update parser tests to use preNonNullable feature set
to address comments in https://dart-review.googlesource.com/c/sdk/+/99963
Change-Id: I3a3293d65805807b7b95e887f829f3f0080ae3b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99964
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-22 17:20:10 +00:00
6d9d95d938
Add GenericFunctionTypeImpl.declaredElement
...
R=brianwilkerson@google.com
Change-Id: I46db30d67722d4cecbff65d95fcecc0f683a13e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 16:59:21 +00:00
fd48001ace
Put NNBD modifiers behind a flag
...
Fix https://github.com/dart-lang/sdk/issues/36691
Change-Id: I48aa72eb6a4aa63d072089baaf99d249763095fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99963
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-22 15:31:09 +00:00
a9b1d9e33b
Splice resolved API nodes and unresolved function bodies.
...
After attempting to use DeclarationResolver to implement building
elements, I decided that this does not work well enough, and we need
a more specialized implementation. This also opens ways for interesting
optimizations in the future, e.g. we don't need to resolve any names in
APIs of nodes - they are already resolved summaries.
R=brianwilkerson@google.com
Change-Id: Ib448eb7334b469296ffb866ba27ae7edd0d4543a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-22 15:02:29 +00:00
38eed58f61
Fix hints in nullability migration code
...
Change-Id: I22ef26cd928832a9d9ab2e8f4552519b914eef98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100080
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-22 14:00:59 +00:00
d50232a3f5
Plumb new FeatureSet class into AstBuilder.
...
And change clients of parser and AstBuilder (within the SDK) to use
it.
Long term, it would be better to store the FeatureSet object directly
in the AstBuilder and remove the existing flags `enableNonNullable`,
`enableSpreadCollections`, `enableControlFlowCollections`, and
`enableControlFlowCollections`. However there are analyzer clients
that currently use these flags. So for now, we simply plumb in the
FeatureSet as a new way of setting AstBuilder flags. Once we've
updated clients to use FeatureSet, we'll publish a breaking version of
the analyzer that removes the old flag API.
Change-Id: I6d37177c40b1a1216956e95f473252aa218d10b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100000
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-22 13:38:59 +00:00
780f1b6c3e
Remove unused imports
...
Change-Id: Ia34e9d49e1baffe96a7da72a663f6751de31fc36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100041
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-22 13:29:19 +00:00
c3f822eae6
Attempt to fix failures on the windows bot
...
Change-Id: I668e62e5b866b83bba24a8406ffcaca4450eeb46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-21 19:42:17 +00:00
47a8ff60e1
Convert more analyzer unit tests
...
Change-Id: Ie457491e24bc8820d24c533342b0d74edb922370
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-21 15:29:17 +00:00
76f177a492
Use a non-null index for all features, even expired ones.
...
This ensures that the FeatureSet object can track the presence or
absence of expired features.
Change-Id: Ie6e213993792b8c3d6cf84ef01c464c16c274b85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-20 13:53:45 +00:00
f5224b53e4
[dart_internal] Bump SDK constraint upper-bound to <2.4.0
...
Change-Id: Iaad5890187b02562ae97ccc5195b0576cb58e564
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99860
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-04-20 00:58:51 +00:00
Brian Wilkerson