dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

25510 Commits

Author SHA1 Message Date
Mark Zhou e5d78513a1 [dartdevc] Hoisting covariance checks for generators outside of the body. 
Issue: https://github.com/dart-lang/sdk/issues/33066
Change-Id: I77fed5a2b82e3d65436d71a4bd1461d731f8358e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97945
Commit-Queue: Mark Zhou <markzipan@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2019-04-05 23:35:44 +00:00
Konstantin Shcheglov 73b931b6e6 Start reworking to use actual AST nodes created lazily. 
Change-Id: I94746fd27eb02b928f4983fe88bcf2a72f600aaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-05 23:08:54 +00:00
pq cf04a16527 dartfix to migrate to spread collections 
Change-Id: I7764f29e159356cc589f4e66b80eefff6cc998f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98742
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-04-05 22:27:58 +00:00
Jenny Messerly f93b93dd91 [dartdevc] fix string escaping for string_literal_test 
This brings some updates from dart2js' string escape function over to
DDC. Includes some small changes to work better for DDC:

- take the quote style as an input; DDC uses it for ES6 template strings.
- use ES6 escape syntax (DDC requires ES6 support).
- always use UTF-8 mode because DDC writes files as UTF-8.

Change-Id: I56e2cbb9afcebf06500185170bd9877b16f5dd92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98693
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2019-04-05 21:11:05 +00:00
Konstantin Shcheglov 4b9b8562c6 Update expectation for conditional expression and constant_update_2018. 
R=brianwilkerson@google.com

Change-Id: Ie02053740ff3f643d93a754491e3727c246774b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-05 20:42:24 +00:00
Jenny Messerly da4ccd0855 [analyzer] fix #32918, eliminate type variables during const inference 
This brings Analyzer's type inference in line with the language spec.
Similar to CFE, the inference function now takes an isConst parameter,
which if set, tells it to eliminate type variables from the context
type.

Change-Id: Ied67bac39d73c9ecd7e0a482a0c8db77272637cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98707
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2019-04-05 19:30:54 +00:00
Keerti Parthasarathy 0e7bec7d2f Add validation for AndroidManifest.xml files 
Change-Id: Ieab8027eb81257d76cdda34b423bb554f968f021
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98040
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-05 19:30:34 +00:00
Konstantin Shcheglov ca4e707e80 Fix AvailableSuggestionSetsTest on Windows. 
R=brianwilkerson@google.com

Change-Id: I99fb2c60e539b0acc37bcb2073c1624a620ddff5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-05 19:21:11 +00:00
Mike Fairhurst d4c61411f3 Update bug number to reflect deprioritized bug 
Change-Id: I0664dd951ab4374856b3db83b7311a63176fa356
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98721
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-04-05 19:01:54 +00:00
Jaime Wren ee248fef23 Add a fix for using relative imports when the missing import is in the same library. 
https://www.dartlang.org/guides/language/effective-dart/usage#prefer-relative-paths-when-importing-libraries-within-your-own-packages-lib-directory

Change-Id: I6a4d7f2906fa56dc91d05a86d53dd9da023d2bcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98623
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-05 18:50:44 +00:00
Sam Rawlins 1ad11facec Fix mustCallSuper for mixins and inherited interfaces: 
* If a method overrides a mixed in @mustCallSuper method, it should call super.
* If a method overrides a method from a supertype, which itself overrides a
  method from an interface, the first method should call super.

Fixes internal b/70374204.

Change-Id: I645de4a288a8c5ffff173e97692f8eb6fe38bdb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98443
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-05 16:14:24 +00:00
Aske Simon Christensen 6dc9c8d127 [CFE] JS: Treat integer valued double constants as integers. 
This fixes the problem with two-pass constant evaluation (with
intervening serialization) where an integer created by the first
pass would look like a double to the second pass.

Fixes https://github.com/dart-lang/sdk/issues/36477

Change-Id: I5040c3a2dac780c17a28b29df3dd65b6b9b3379b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98676
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-04-05 15:56:04 +00:00
Jacob MacDonald 44799241fa Revert "set empty environment defines to CompilerOptions" 
This reverts commit 3d6e29d251.

Change-Id: Id4760ef320e26552629d6795b6faa630bf5e15dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98697
Auto-Submit: Jake Macdonald <jakemac@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
 2019-04-05 14:57:14 +00:00
Paul Berry d14990b3ad Remove no-longer-needed override 
Change-Id: I7cda32a2b9f087e3fb2922dc938d3e17be4121de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98694
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-05 13:32:14 +00:00
Clement Skau 4958a4e782 [vm] Adds a --help flag to vm/lib/kernel_front_end.dart (and by extension gen_kernel). 
Bug:None
Change-Id: I6f2a1748189a586e42d84db2989bade751acb467
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98568
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2019-04-05 09:40:24 +00:00
Kevin Millikin b700223542 [cfe] Do not reset the VM async name generator 
In the VM-specific async transformation, an index is used to generate
fresh temporary names for values that are live across an await.
Before it was always 0 when translating a statement because there are
no live values on entry or exit to a statement.

When translating statements nested inside block expressions there can
be live values, so the index should not be reset.

Closes https://github.com/dart-lang/sdk/issues/36466

Change-Id: I6103d75c25f312ab1538a7c0f8fee0fea9f01b27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98664
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-04-05 09:00:24 +00:00
Alexander Markov 38dbddc90d [vm/bytecode] Add AllocateClosure bytecode 
AllocateClosure bytecode is used to convey information about closure
function into an instance allocation site. This allows VM inliner to see
closure function very early at the optimization pipeline and enables
inlining of closure calls.

DeltaBlueClosures in JIT/bytecode mode (--use-bytecode-compiler):
Before: DeltaBlueClosures(RunTime): 1746.5404424083767 us.
After: DeltaBlueClosures(RunTime): 1291.4649496449324 us.

Issue: https://github.com/dart-lang/sdk/issues/36342
Issue: https://github.com/dart-lang/sdk/issues/36429
Issue: https://github.com/dart-lang/sdk/issues/36428
Change-Id: I6e94cdc2eb30110b0651a86bd2bdc40dcdd63207
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98439
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2019-04-05 00:00:13 +00:00
danrubel a38dbf8575 update ChangeBuilder to lazily build the source change 
Change-Id: Id645c0538eb8a3391d78e24a3785fe26c7861777
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98626
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-04 23:20:53 +00:00
Brian Wilkerson 2415c08373 Add Dartdoc template info to the status pages 
Change-Id: I27df7cabe864b99feb64d95365232dda72d5fb63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98691
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-04 22:15:53 +00:00
pq 4ff8846d79 associate CONVERT_TO_SPREAD assist w/ spread_collections lint 
Change-Id: I6cd1882c7a88328895bb8172ea5c5808d9e75bb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98689
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-04-04 21:23:03 +00:00
Konstantin Shcheglov 7e28fc2cd6 Increment Analysis Server version to 1.26.0 
R=brianwilkerson@google.com

Change-Id: I3121d8262bab8748fdd64a58178b7020607a2252
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-04 21:02:33 +00:00
Brian Wilkerson 4fa79e9ded Remove comments from the token stream 
Change-Id: Idc5171ad87590d40d26e26000c8fb795f28678dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98704
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-04 20:43:33 +00:00
Jacob MacDonald 3d6e29d251 set empty environment defines to CompilerOptions 
Bug: https://github.com/dart-lang/sdk/issues/36476
Change-Id: I5fac7372026acbb9ef1d9514e6518088ee18dcfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98702
Auto-Submit: Jake Macdonald <jakemac@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2019-04-04 20:38:18 +00:00
danrubel afe609d2c2 Update NNBD migration to add import as necessary 
... and simplify apply code edits

Change-Id: I6f205df29ffd42341e2244ff3a5609ba005adcfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98612
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-04 20:31:23 +00:00
Brian Wilkerson e4fa8904f8 Fix the windows bot 
Change-Id: I76c4670464869a9f7efcc2c758677b1c2bffe18b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98682
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-04 20:30:13 +00:00
Konstantin Shcheglov ddbeda075f Rework storing constructors and enum constants. 
I was adding default constructor to classes and found another problem
with shadowing exported declarations with local ones - we shadow
the class, but not its constructor. So, I'm changing it to keep
constructors and enum constants in corresponding parent declaratiosn.

R=brianwilkerson@google.com

Change-Id: I4e49b57f9fe1ac8bf611f241d2c279c746ad55ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-04 19:40:54 +00:00
Brian Wilkerson 7e5810ab30 Add an offset to the protocol used for import-on-paste 
Change-Id: I87c50b2fee7643733b38a368b2c231e5fb7cddda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98681
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-04 16:18:43 +00:00
danrubel 896f1c4bb9 CFE tests for issue 36400 
Change-Id: I05139ce86177fe32cae857e410f759d365dc7bde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98503
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-04-04 15:48:30 +00:00
Aske Simon Christensen 313e0f5410 [CFE] Check if set element or map key overrides operator '=='. 
Fixes https://github.com/dart-lang/sdk/issues/36444

Change-Id: I38b485ca538c65072e2ec3386e30c5ce49671fe4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98666
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-04-04 14:39:50 +00:00
Brian Wilkerson e58a8fade5 Fix typos in the diagnostic messages 
Change-Id: I65a11e52933c37a63cb9d0a14b1961a20e16271f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-04 13:47:40 +00:00
Brian Wilkerson 688475b1cd Fix bug in evaluation of == under constantUpdate2018 
Change-Id: Ie915a116365dc93e8e329c28e6c79ac0a79da2ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98611
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-04 12:28:50 +00:00
Aske Simon Christensen a069ddda21 [CFE] Produce InstanceCreation from unevaluated constructor invocation. 
Thread assert enable flag through in dart2js to make the dart2js cfe
constant evaluation unit test properly pass the flag.

Fixes https://github.com/dart-lang/sdk/issues/36454

Change-Id: Ie4ac86ce96feda1548120fed54ece9ca03387496
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98570
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-04-04 12:22:50 +00:00
Aske Simon Christensen f63eaab3af [kernel] Add instance creation kernel node. 
This is used in constant evaluation to represent const constructor
invocations with unevaluated field values or asserts.

Change-Id: I1d2d60a18f967a4dd195b3b5895db9a126c47803
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98561
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-04-04 12:22:50 +00:00
Daco Harkes 395e5f6037 [cfe/vm] make dart:ffi compatible with constant-update-2018 
I added TODOs for removing the old code after the constants update has landed.

Change-Id: Icde8d68e4e7c4b51e9536f09ce4e514e3b00336d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98661
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-04-04 11:09:51 +00:00
Mark Zhou 600b2831ef [dartdevc] Updating nullability inference to account for unevaluated constants 
Change-Id: I9982a38c8e15655d660c2e9d68fea5dc993bc962
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98455
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2019-04-04 02:14:19 +00:00
Alexander Markov 7c9d02b313 [vm/bytecode] Generate empty list literals more efficiently 
Issue: https://github.com/dart-lang/sdk/issues/36429
Change-Id: I47e189bff4e9998123c06afa2e5b0d1c79d74566
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98608
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
 2019-04-03 23:43:21 +00:00
Alexander Markov bf293ea34c [vm/bytecode] Remove support for old version of bytecode format (v1) 
Bytecode format version 2 was introduced Feb 05 2019 in
https://dart-review.googlesource.com/c/sdk/+/91108

This change cleans up code related to old constant pool entries which
were removed in v2.

Change-Id: Ic9cccd2fdec26758f377691bf4edc26d1309a524
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98610
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-04-03 22:44:21 +00:00
Brian Wilkerson da15746f4c Update the production of training data 
Change-Id: Ib9634c5e5bdd8c0097f55a9cf71054e2a2b6a5fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98287
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 22:36:01 +00:00
Mayank Patke 2f77af1c6f Fold identical(double.nan, double.nan) => false in dart2js. 
Change-Id: Idc6b064e330af71bbc8525a48874d332d84f404a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98607
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-04-03 21:14:31 +00:00
Sigmund Cherem 35f45cf3f1 Remove _mainLibraryUri, replace with user-code-locations 
This prepares the compiler to accept a modular mode that contains several
libraries as user-code locations

Change-Id: I04f6c1fe36eea23de79b3573855896c560996fe1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98457
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-04-03 19:34:41 +00:00
Sigmund Cherem 5fffa99993 Add helper method to clear batch-mode state 
This is minor clean up step before adding modular support.

Change-Id: If06333d89c0484e76bfe51e60e344791c3a61be3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98456
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-04-03 19:34:41 +00:00
danrubel 0669c2cee5 fix dartfix modification of analysis options 
... and improve NNBD YamlException error message
Address comments in https://dart-review.googlesource.com/c/sdk/+/98524

Change-Id: I0e44ca8b887b47f1fac247650402032d1e5f5b23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-03 19:34:01 +00:00
Brian Wilkerson 830ec419b6 Cleanup warnings and sort a few files 
Change-Id: Ie781e1dff7eb079311b833d4a13f7a1d38ef0515
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98603
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 17:51:36 +00:00
Alexander Markov dfdd974390 [vm/kernel] Pass environment defines through CompilerOptions for front-end const evaluator 
Front-end constant evaluator doesn't fully evaluate constants if
CompilerOptions.environmentDefines is not set. Unevaluated constants
are not handled in bytecode generator or AOT tranformations.

As we're moving towards constant evaluation in the front-end, all
VM-specific kernel compilers such as gen_kernel and front-end server
should set CompilerOptions.environmentDefines.

Change-Id: I0c3021f87e4afdcb289822c57c2a19195b0dc467
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98435
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-04-03 17:43:56 +00:00
Konstantin Shcheglov 1dd6eaac56 Resolve default values. 
R=brianwilkerson@google.com

Change-Id: I9166b298624d469499b05992393e5674348dfef1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98602
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-03 17:15:46 +00:00
danrubel fe2d66006d improve type-before-factory error message 
Address comment in https://dart-review.googlesource.com/c/sdk/+/98449

Change-Id: I38e7cf04e2061dbd6c9b37cca713e8420a1e021d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98520
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 16:30:18 +00:00
Konstantin Shcheglov f32db1a453 Start adding type algebra. 
R=brianwilkerson@google.com

Change-Id: I8184a65733c679e4c025215354bd9f7ad081daef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/76588
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 16:07:23 +00:00
danrubel 1d6a7bee36 rework dartfix NNBD to use FixCodeTask.processPackage 
This generalizes the dartfix NNBD processing of packages so that
other fixes can process packages in a similar manner.
In addition, if at least one package to be migrated to NNBD
cannot be marked as NNBD or is not already NNBD,
then no additional NNBD processing is done.

This also addresses comments in
https://dart-review.googlesource.com/c/sdk/+/98429

Change-Id: I406d9d395a0ee8a85cc5b3d7be311a76e1e48bdb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-03 15:52:36 +00:00
Johnni Winther 93d0e8279a Include liveness of type arguments in supertypes in RTI needed checks computation 
Including supertypes (and not just superclasses) this time.

Change-Id: Ib398f6f2fab0ae502dd754727b482641793dd225
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98569
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-04-03 15:03:46 +00:00
Brian Wilkerson 80b40bdbeb Add completion subscriptions to the status page 
Change-Id: Id7bdb64d3041dfd5441dcef754f83b675e3b8922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98580
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 14:35:58 +00:00