Commit Graph

4090 Commits

Author SHA1 Message Date
scheglov@google.com 51fb6c5a9e Issue 21377. Specify that navigation regions are sorted and implement it.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21377

Review URL: https://codereview.chromium.org//649853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41261 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 17:18:13 +00:00
scheglov@google.com 227c5524d8 Issue 21375. Fix for FunctionTypeAliasElement-based FunctionType source.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21375

Review URL: https://codereview.chromium.org//672013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41254 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 04:24:59 +00:00
paulberry@google.com 751e087262 Add package root setting to analysis server API.
The command does not have any effect yet.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//672003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41253 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 00:11:36 +00:00
paulberry@google.com 7611c5415a Add an integration test to verify that server I/O is asynchronous.
Currently disabled, since server I/O is currently synchronous.

BUG=dartbug.com/21252
R=danrubel@google.com

Review URL: https://codereview.chromium.org//668953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41246 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-22 15:48:06 +00:00
scheglov@google.com 8f337c37d1 Issue 21373. Fix for removing line info in case of exception (causes NPE in outline computer).
I will update analysis_server/pubspec.yaml before commit.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21373

Review URL: https://codereview.chromium.org//652903006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41235 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-21 20:34:31 +00:00
scheglov@google.com 3074fefa82 Issue 21372. "Convert into block body" and "Convert into expression body" for factory constructors.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21372

Review URL: https://codereview.chromium.org//664403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41230 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-21 15:32:55 +00:00
scheglov@google.com 89978808cd Issue 21238. Fix for NPE in occurrences computer when FieldFormalParameterElement references unresolved field.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21238

Review URL: https://codereview.chromium.org//668763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41215 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 21:26:09 +00:00
scheglov@google.com cf3d70227a Fix for file to URI mapping.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//665153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41213 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 21:00:49 +00:00
scheglov@google.com 1635b56077 Fix for getAnalysisContext()
There was a bug when there are two contexts in folders prefix/test and prefix/test2.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//668513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41198 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 15:03:50 +00:00
danrubel@google.com 4f2faa385c fix failing test
BUG=

Review URL: https://codereview.chromium.org//669483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41183 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-18 16:48:28 +00:00
danrubel@google.com 946d40e8ac improve element parameter string returned by local suggestion computer
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//664523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41178 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:37:37 +00:00
danrubel@google.com 8da06376d3 update keyword suggestion priorities
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//666473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41177 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:35:41 +00:00
danrubel@google.com efd813f9b3 update protocol server getter test
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//662013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41176 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:34:27 +00:00
danrubel@google.com 522e3433e4 remove duplicate packages in fuzz test
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//656533004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41175 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:32:42 +00:00
brianwilkerson@google.com 2fa3b2cab4 Add command-line options for instrumentation
R=paulberry@google.com

Review URL: https://codereview.chromium.org//664743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41171 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 16:47:11 +00:00
danrubel@google.com 582b276b6f filter invalid method invocation suggestions
and filter _ from local suggestions

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//651443006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41159 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 21:25:46 +00:00
danrubel@google.com 8d47e699d9 filter void methods when suggesting expression
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//658053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41153 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 16:46:45 +00:00
danrubel@google.com 7c9dc9695b add imported inherited member suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//643153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41137 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 01:55:30 +00:00
danrubel@google.com 8465275f69 include locally inherited members in suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//657593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41114 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-15 03:25:20 +00:00
danrubel@google.com be3cc6897b exclude operators from "." suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//655733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41100 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-14 15:35:46 +00:00
danrubel@google.com 1766795d5f improve method invocation and string interpolation suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//651953006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41091 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-14 06:07:58 +00:00
scheglov@google.com 11f7d4027e Fix for missing LineInfo to SDK entries.
I will update analyzer reference in pubspec before commit.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//647553006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41064 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-12 21:27:08 +00:00
paulberry@google.com 71552797de Update analyzer version to 0.23.0-dev.10
TBR=scheglov@google.com

Review URL: https://codereview.chromium.org//645793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41044 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 16:13:40 +00:00
danrubel@google.com db9357f408 (TBR) fix the build
BUG=

Review URL: https://codereview.chromium.org//643923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41040 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 13:12:52 +00:00
danrubel@google.com eb0e7f5c0c suppress suggestions in string literals
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//643803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41039 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 12:52:20 +00:00
danrubel@google.com dd6b2426df add if statement condition suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//642973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41034 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 02:52:30 +00:00
scheglov@google.com 8f4ce65d53 Ignore case when sort members.
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//646753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41033 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 23:48:19 +00:00
danrubel@google.com b45a2aa7ff include imported elements in interpolation suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//646773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41032 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 22:49:23 +00:00
danrubel@google.com e0b32d20f2 improve suggestions in for statement
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//645733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41031 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 22:17:53 +00:00
paulberry@google.com 31310ceea4 Test that analysis server and analysis engine enums properly match.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//647563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41029 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 21:53:05 +00:00
danrubel@google.com 56027f1dcb fix suggestions in class body and more common tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//645573004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41027 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 21:00:15 +00:00
scheglov@google.com 07cf72a3ec Improve import prefix search results UI.
1. Bug fix for search on an import directive without a prefix.

2. Pretend that import prefixes are children on libraries' compilation units.

3. Icon for import prefix elements in Editor.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//640333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41024 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 20:30:49 +00:00
scheglov@google.com 68831585dd Fix for renaming import without an import prefix.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//640253004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41021 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 16:25:07 +00:00
danrubel@google.com 029ed4968e binary expression suggestion fix
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//639183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41019 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 16:07:32 +00:00
paulberry@google.com 6742866101 Add "checked mode compile time error" type to analysis server API.
This avoids a crash if the analyzer detects a checked mode compile
time error.

R=brianwilkerson@google.com, danrubel@google.com

Review URL: https://codereview.chromium.org//636313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41000 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 20:52:29 +00:00
danrubel@google.com 64db597677 import directive suggestion fix
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//639133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40999 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 20:46:22 +00:00
danrubel@google.com 5bdaa8ddcf combinator suggestion fix and more common tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//644473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40998 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 20:38:42 +00:00
scheglov@google.com 9bcd836cf8 Search for function to import even when reported as UNDEFINED_METHOD.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//636293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40996 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 19:35:45 +00:00
danrubel@google.com b95d052249 more common code completion tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//636153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40995 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 17:56:31 +00:00
danrubel@google.com e4200b55d8 add suggestions for variable declaration assignment RHS
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//637703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40991 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 13:15:35 +00:00
scheglov@google.com b67b33f60c Move Engine to Server element / error converters into protocol_server.dart
Also move the corrsponding tests.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//628023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40983 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 22:25:08 +00:00
scheglov@google.com 6d440417dd Remove the last external import in protocol.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//637683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40982 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 22:11:14 +00:00
danrubel@google.com e08c24ea56 show only type names in is expression RHS
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//635043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40977 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 20:24:40 +00:00
danrubel@google.com 6319b75048 cascade target fix and common test
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//633153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40970 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 18:54:34 +00:00
scheglov@google.com 53fe3d983f Issue 21233. Improve inlining strings into string interpolations.
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21233

Review URL: https://codereview.chromium.org//633823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40963 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 17:21:40 +00:00
danrubel@google.com 932218aea1 local cascade suggestion fix and move towards common tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//632323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40959 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 16:21:01 +00:00
danrubel@google.com 19e54e4f2b add named constructor, cascade selector suggestions and more tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//634653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40954 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 12:43:45 +00:00
scheglov@google.com e9e0694e2f Remove references to Engine classes from protocol.dart
R=brianwilkerson@google.com, paulberry@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//628293004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40948 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 00:24:48 +00:00
scheglov@google.com 482ecda504 Simplify conversion of empty lists to null.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//629283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40945 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 21:37:15 +00:00
brianwilkerson@google.com 623f8dd33f Stop sending launchData for non-analyzed files
R=scheglov@google.com

Review URL: https://codereview.chromium.org//630863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40942 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 18:56:30 +00:00