Commit Graph

4090 Commits

Author SHA1 Message Date
jwren@google.com 9eca55332e Remove watchdog from RemoteAnalysisServerImpl
R=danrubel@google.com

Review URL: https://codereview.chromium.org//575163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40400 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:53:21 +00:00
scheglov@google.com 3e884db043 Index and search of import prefixes.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//582453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40397 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:19:39 +00:00
scheglov@google.com c7a131a7d5 Churn only: move analysis notification tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//563373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40396 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:16:29 +00:00
scheglov@google.com 40be584340 Remove unused code.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//569243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40395 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:09:43 +00:00
scheglov@google.com bbbcddfac6 New analyzer snaphot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//581733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40394 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:07:57 +00:00
danrubel@google.com 70d983e570 add element to completion suggestions
suggest getter rather than field element
add test for function suggestions

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//580623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40366 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 03:50:46 +00:00
danrubel@google.com 6a91be4ddf convert engine element setter to completion element setter
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//578673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40362 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 23:21:57 +00:00
danrubel@google.com 6cc9d7d887 add element to completion suggestion API
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//572373004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40360 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 23:17:24 +00:00
scheglov@google.com 7fde5deecc Send final problems even if 'validateOnly'.
Also fix for reporting duplicate 'Rename Local' shadowing warnings.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//576703004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40332 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 17:48:19 +00:00
scheglov@google.com 457050dd88 Add SourceFileEdit.time field.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//574573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40329 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 17:19:37 +00:00
scheglov@google.com 620f7cf957 Rollback https://codereview.chromium.org/575613002
I'm sorry, but I'm going to rollback this change.
We discussed this offline with Brian and decided that while it looks
technically correct, it does not work well for our use cases, as well as
probably for our users.

R=paulberry@google.com, brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19697

Review URL: https://codereview.chromium.org//560133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40324 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 16:31:52 +00:00
scheglov@google.com 2208ce5587 Split refactoring problems into init, options and final.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//576473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40318 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 15:14:51 +00:00
scheglov@google.com 8ed8098a48 Issue 17389. Analyzer snapshot and server tweaks to use new ParameterElement.defaultValueCode.
This also makes Analysis Server to return hovers with parameter default values.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=17389

Review URL: https://codereview.chromium.org//564413005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40298 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 01:46:27 +00:00
scheglov@google.com e823d01b65 Issue 19697. Partial fix - don't search for subclasss members.
I think it still worth to commit this CL, if nothing else,
it makes search a little faster by not searching for subclasses.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19697

Review URL: https://codereview.chromium.org//575613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40290 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 23:34:15 +00:00
scheglov@google.com 3d6fff5735 Issue 18926. Rename refactoring for labels.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=18926

Review URL: https://codereview.chromium.org//573803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40259 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 17:48:09 +00:00
scheglov@google.com e5a2441aa4 Search for LabelElement and icon for LABEL in Editor.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//576443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40254 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 17:03:35 +00:00
scheglov@google.com 80757f2511 Semantic highlighting for LABEL elements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//559353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40252 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 16:41:09 +00:00
scheglov@google.com caf4b0476e Issue 18895. Convert an expression function body into the block function body when Extract Local.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=18895

Review URL: https://codereview.chromium.org//568333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40250 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 15:28:31 +00:00
scheglov@google.com bab2843d3a Issue 19696. Test for potential reference to the element defined in a subclass.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19696

Review URL: https://codereview.chromium.org//567243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40248 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 15:07:08 +00:00
scheglov@google.com 9773f61186 Add LABEL ElementKind, completion and highlighting kinds.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//567273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40247 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 15:04:52 +00:00
scheglov@google.com 3e3178ee6c Support for searching LabelElements in SearchEngine.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//567653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40245 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 15:03:01 +00:00
scheglov@google.com 7eae998b90 Issue 13029. Quick fix to create a function for a Function typed named parameter.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=13029

Review URL: https://codereview.chromium.org//565023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40242 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 14:53:06 +00:00
scheglov@google.com 3f1f6f9e41 Issue 20892. Quick Fix 'Import Library' for type arguments.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20892

Review URL: https://codereview.chromium.org//556793007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40241 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 14:50:38 +00:00
scheglov@google.com 210a4459b2 Issue 20358. Don't report referenced names of named parameters in named expressions as possible shadowing.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20358

Review URL: https://codereview.chromium.org//567083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40240 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 14:48:36 +00:00
danrubel@google.com a5ecdaffcc fix code completion import dart exception
BUG=dartbug.com/20893
R=paulberry@google.com

Review URL: https://codereview.chromium.org//565793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40238 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 12:41:41 +00:00
danrubel@google.com e7bdefffba update error handling to send response with stack trace
BUG=dartbug.com/20893
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//569743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40237 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 12:30:07 +00:00
scheglov@google.com 59eac1e533 Issue 19800. Support for inlining getters/setters.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19800

Review URL: https://codereview.chromium.org//565973006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40230 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-14 03:17:55 +00:00
scheglov@google.com 4a59e13a84 Issue 19799. Merge getter/setter pairs into fields when create missing overrides.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19799

Review URL: https://codereview.chromium.org//563333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40220 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 21:29:09 +00:00
scheglov@google.com 8269bc67c3 Issue 19801. Fix for inlining referenced function with an expression body.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19801

Review URL: https://codereview.chromium.org//569723004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40214 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 19:41:59 +00:00
scheglov@google.com d2d8fb708e Issue 20894. Rename 'Class' when rename refactoring is activated on 'Class' in 'new Class.name()'.
To do this we need to tweak the Java version of ElementLocator and regenarate the Dart version.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20894

Review URL: https://codereview.chromium.org//571523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40208 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 17:16:15 +00:00
scheglov@google.com b67e00a59e Issue 20894. Improve navigation regions for 'new Class.named()' expression.
As we discussed offline.
Rename changes will follow.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20894

Review URL: https://codereview.chromium.org//551143003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40207 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 15:52:08 +00:00
danrubel@google.com 36dca53a87 fix path in generated comment
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//565773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40199 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 05:03:41 +00:00
danrubel@google.com a9a2c98d53 gracefully handle internal exceptions during request
- new SERVER_ERROR response code
- return SERVER_ERROR response if exception when processing request before request can be sent
- send server.error notification if exception occurs anytime while processing request or future work triggered by request

BUG=dartbug.com/20893
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//570453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40198 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 05:01:46 +00:00
scheglov@google.com 778536d97c Issue 19682. New analyzer snapshot that fixes an inline refactoring problem.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19682

Review URL: https://codereview.chromium.org//561373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40193 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 22:47:29 +00:00
scheglov@google.com 3120d3632f Issue 17024. Quick Fix to find imported library.
It works with both project and package libraries.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=17024

Review URL: https://codereview.chromium.org//562333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40173 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 18:36:04 +00:00
scheglov@google.com 14e375418b Issue 10355. Quick Fix to replace 'var' with 'dynamic'.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=10355

Review URL: https://codereview.chromium.org//562183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40172 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 18:26:58 +00:00
scheglov@google.com 88c1df9734 Issue 20891. Produce Quick Fixes for annotations.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20891

Review URL: https://codereview.chromium.org//562293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40167 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 17:36:42 +00:00
scheglov@google.com 94bab70117 Remove contexts from the index.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//561863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40153 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 15:45:12 +00:00
scheglov@google.com 2900afc0ed Use Relationship as a first key in the index store.
This significantly speeds up computing type hierarchies.
For example for List we don't have to read all the nodes (files) where it is
used as a type annotation. We read node where it IS_EXTENDED_BY and IS_IMPLEMENTED_BY.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//566433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40152 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 15:40:50 +00:00
brianwilkerson@google.com 1e5e985370 Disable tests to fix the build
Review URL: https://codereview.chromium.org//559993003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40116 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 20:49:58 +00:00
scheglov@google.com 7ac6ed2b6f Issue 20890. Fix for NPE in the 'Add show' QA.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20890

Review URL: https://codereview.chromium.org//560913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40115 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 20:49:42 +00:00
brianwilkerson@google.com f289a1abac Fix exception in error processing; implement mapUri
R=jwren@google.com

Review URL: https://codereview.chromium.org//560103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40109 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 19:54:49 +00:00
paulberry@google.com bad1890ab3 Implement "analysis.reanalyze" in analysis server.
This is accomplished by instructing the context manager to remove all
contexts and recreate them from scratch.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//553193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40106 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 19:20:09 +00:00
danrubel@google.com 016dc1132b add code completion declared and return types
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//558893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40087 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 13:04:11 +00:00
paulberry@google.com 2c15ecefbf Avoid false positives when searching for uses of a constructor.
Since constructor invocations are statically bound, there's never a
reason to search for potential matches.  Since potential matching is
performed by name, this avoids an enormous number of false positives
in the case where the constructor is unnamed.

BUG=dartbug.com/20869
R=scheglov@google.com

Review URL: https://codereview.chromium.org//560553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40058 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 21:25:15 +00:00
jwren@google.com 83de5a8f7b New dev version of analyzer package
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//557043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40056 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 21:13:10 +00:00
jwren@google.com 944174f36a Move package_map_provider.dart from the server to the analyzer package to be used by the command line analyzer.
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//560553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40051 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 20:36:35 +00:00
scheglov@google.com 65f95d89f4 Fix for List<Future> is not assignable to List.
Instead of pushing core.dart file, we should pre-index SDK.

R=danrubel@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//551103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40038 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 16:24:22 +00:00
scheglov@google.com 209ebe2a7f Integrate the EXTRACT_METHOD refactoring into Editor.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//554143003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40034 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 14:57:41 +00:00
scheglov@google.com 16f88fe5f2 Make the generated Java class RefactoringMethodParameter mutable.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//551083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40002 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 21:37:40 +00:00