ea7f519f03
Make SdkLibrary.shortName consistently include 'dart:'
...
The documentation of SdkLibrary.shortName claimed that it didn't
include the 'dart:' prefix; however the implementation did include it.
The implementation of shortName in _MockSdkLibrary class (used only
for unit testing) did not include the 'dart:' prefix, causing some
unit tests to pass even though the functionality was wrong.
This change updates the docs and _MockSdkLibrary to correspond to the
implementation (the 'dart:' prefix is included). Additionally it
fixes one usage of shortName which was expecting the 'dart:' prefix to
be absent; this was preventing quick fixes from working correctly.
In addition, the Mock SDK is modified to add a reference from
dart:core to dart:async and from dart:async to dart:math (these
dependencies exist in the real SDK). This avoids the need for some
workarounds in unit tests.
BUG=dartbug.com/20850
R=scheglov@google.com
Review URL: https://codereview.chromium.org//556573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40000 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 21:02:30 +00:00
19f017660a
Return a feedback for the INLINE_METHOD refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//554053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39993 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 19:56:26 +00:00
d7f0532f29
Add feedback for INLINE_METHOD refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//551963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39992 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 19:26:52 +00:00
611e8ca216
rename completion class
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//551933003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39987 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 18:38:36 +00:00
c0c0b51188
Send feedback for the INLINE_LOCAL_VARIABLE refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//547343004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39981 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 17:33:09 +00:00
8aeace76ec
improve keyword suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//543393002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39978 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 16:32:50 +00:00
4187ed6349
Add feedback for 'Inline Local' refactoring.
...
Also fix for the Java client tests.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//542333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39977 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 16:29:23 +00:00
44c2892f6f
Initial support for execution domain
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//544273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39974 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 16:21:16 +00:00
2eec75f67e
Search domain implementation in the Remote java server, using generated types.
...
TypeHierarchyContentProvider_NEW.java functionality has been stubbed out as it is currently written to support the old implementation of the TypeHierarchyItem type.
Search functionality in Editor has been converted.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//542323003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39949 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 04:40:46 +00:00
b66227cb7a
Update RemoteAnalysisServerImpl and tests to fix the build.
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//546073006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39943 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-06 03:23:23 +00:00
29341b4e5e
Rename debug domain to execution
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//547753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39942 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-06 02:43:12 +00:00
a99a140173
Change analyzer package to a "-dev" version.
...
This will enable the analysis server to depend on the latest and
greatest analyzer without forcing that version on other analyzer
clients.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//545373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39935 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 21:34:53 +00:00
897ba068ee
Fix for no-op assist proposals.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//548523004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39931 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 21:09:01 +00:00
77a6daa667
Add error condition INVALID_OVERLAY_CHANGE to analysis server.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//545323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39925 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 19:23:55 +00:00
c5251c6bd9
Integrate 'Rename' refactoring into Editor.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//548593002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39923 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 19:13:18 +00:00
3661df5b0e
Include additional information into RenameFeedback.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//545943003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39918 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 16:39:15 +00:00
a828b39332
Generate setters for RefactoringOptions.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//545023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39915 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 14:49:02 +00:00
ce242e4d44
Use primitive int/boolean where possible in the Java client.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//538253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39891 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 00:16:57 +00:00
7ac61164ff
Use RefactoringFeedback objects in Java.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//539353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39889 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 23:29:35 +00:00
bd54398b61
Update analysis server to depend on analyzer 0.22.4.
...
Analysis server relies on some files that don't exist in analyzer 0.22.0-dev.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//533073006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39888 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 21:32:34 +00:00
67cd1ab0e2
Decode RefactoringFeedback automatically.
...
The implementation is pretty ugly though.
1. I have to add Response into ResponseDecoder.
2. I have to hack EditGetRefactoringParams.fromRequest generation to feel the "id to kind" map.
It would be easier if we decided to return 'kind' in responses.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//541823004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39887 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 21:13:24 +00:00
5033317a13
Split channels library.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//544693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39881 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 17:53:16 +00:00
3ddecb8c64
Use typed RefactoringOptions in the Dart version of the protocol.
...
R=jwren@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//537733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39875 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 16:21:08 +00:00
9279b9fe81
Fix error handling in analysis.getError.
...
Analysis.getError now has the following behaviors:
- If the file in question does not exist, or is not subject to
analysis, a new error called GET_ERRORS_INVALID_FILE is generated.
- If the server's internal state (the set of active analysis contexts)
changes while the query is in process, the query is transparently
restarted; the client no longer receives a GET_ERRORS_ERROR error.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//532403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39871 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 14:34:43 +00:00
e3a2f54db8
Clarify some of the analysis server errors.
...
The errors GET_ERRORS_ERROR, UNANLYZED_PRIORITY_FILES, and
UNSUPPORTED_FEATURE exist for legacy reasons and should be removed
soon. The error SERVER_ALREADY_STARTED exists for future expansion
and is not yet used.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//535333003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39832 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 20:36:29 +00:00
245168938e
Merge analysis server's mocks.dart and mocks2.dart into one file.
...
There were competing implementations of MockAnalysisContext and
MockSource, but one of the implementations was only used in one place
(analysis_server_test.dart), so it's been switched over to use the
other implementation.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//532333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39826 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 19:45:42 +00:00
44473cf553
Integrate INLINE_LOCAL_VARIABLE into the server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//540503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39824 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 19:23:37 +00:00
43b0e2d584
Use unit + offset as 'Inline Local' arguments.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//533273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39821 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 18:45:18 +00:00
dfeccd520d
Integrate INLINE_METHOD into the server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//538583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39816 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 18:32:36 +00:00
8d8ee25cff
Merge analysis_testing package into analysis_server.
...
Note that analysis_server already contains a file test/mocks.dart, so
the mocks.dart file from analysis_testing has been imported as
test/mocks2.dart. I will merge these two into a single file in a
future CL.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//533243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39814 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 18:11:42 +00:00
063e6cc00f
Fix for NPE in the server.
...
I think that is the same NPE we saw in both Dart and Java last week.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//529313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39809 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 14:55:32 +00:00
47fe46e1a6
Integrate EXTRACT_METHOD refactoring into the server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//534123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39808 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 14:54:16 +00:00
3df72ead31
Document all the cases where HoverInformation fields can be absent.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//528303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39807 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 14:52:11 +00:00
216602d57a
return correct replacementOffset and replacementLength
...
BUG=
R=jwren@google.com
Review URL: https://codereview.chromium.org//536593002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39789 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 00:55:40 +00:00
efb4c758f8
improve keyword suggestions when completing partial keyword
...
BUG=
R=jwren@google.com
Review URL: https://codereview.chromium.org//531243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39780 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 21:54:56 +00:00
df574c6e2c
Test for 'search.findElementReferences' for the case when there is no element.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//536563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39779 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 21:54:19 +00:00
4213f465fe
Fix for 'returnType' when extract a method with a single expression.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//533913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39778 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 21:51:21 +00:00
703df31e12
Rename ExecutableFile.offset to ExecutableFile.kind and fix documentation.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//528053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39774 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 20:13:03 +00:00
33b4cc89c0
Make findElementReferences' "id" result optional.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//529123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39773 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 20:10:59 +00:00
b7189ea678
New analyzer snapshot.
...
We compute the parameter element for 'object.field = 42' now, so:
1. We can stop doing it in InlineMethodRefactoring.
2. We need to update the corresponding hover integration test.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//535543003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39772 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 20:10:47 +00:00
d092a96981
Clarify type names in analysis server API.
...
The following types are renamed:
- ErrorFixes -> AnalysisErrorFixes
- ErrorSeverity -> AnalysisErrorSeverity
- ErrorType -> AnalysisErrorType
This clarifies that the types have to do with the
errors/warnings/hints generated by the analysis of user code, as
opposed to analysis server protocol errors.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//531153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39770 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 19:54:03 +00:00
43e1872038
Impements 'names', 'offsets' and 'lengths' for ExtractMethodRefactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//530123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39768 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 19:35:48 +00:00
766c549ec7
Fix references to non-existent requests in analysis server API doc.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//527773004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39761 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 18:23:34 +00:00
a239950909
Rename Error to RequestError in analysis server API.
...
Also, use the code-generated RequestError class in place of the old
handwritten RequestError class.
R=jwren@google.com
Review URL: https://codereview.chromium.org//530583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39760 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 18:20:47 +00:00
ba9c0c689b
Use a more precise type for "object" in analysis server API.
...
Previously, we translated "object" in the API to the dart type
"Object". But this is not correct, since in the API when we say
"object" we mean "JSON object", which corresponds to a Dart Map.
Using a more precise type exposed some bugs in our refactoring
implementation, where we were forgetting to convert objects to and
from JSON.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//530033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39757 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 17:46:02 +00:00
d8b6298631
Drop the 'occurrences' field from the EXTRACT_METHOD refactoring feedback.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//533743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39756 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 16:59:23 +00:00
209abb70f4
Integrate EXTRACT_LOCAL_VARIABLE into the server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//526183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39747 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 15:00:45 +00:00
04f5b81652
Remove excessive check.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//525993003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39722 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-31 21:17:09 +00:00
3d5ea37050
'Inline Method' refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//526583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39719 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-31 16:43:43 +00:00
3123e48d29
In the analysis server API, change RequestError.code to an enum.
...
Some of the error codes that were previously defined are no longer
used, so those have been removed. The enum reflects the set of errors
that are currently in use.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//513853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39689 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-29 07:30:43 +00:00
paulberry@google.com