6f88255462
Remove already ported generated code.
...
Mostly to avoid duplicate import proposals from Quick Fixes.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//482143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39357 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 21:50:49 +00:00
b623c4d49f
When user renames 'prefix' in 'prefix.Class' she actually wants to rename ImportElement.
...
Unfortunately we resolve "prefix" to a "PrefixElement".
So, we have to fix this mismatch in the server.
We do the same in indexer, so this CL extract shared namespace-related code into a new unit.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//481173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39356 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 21:49:11 +00:00
e1e1febe72
Merge two constants.dart into one.
...
R=paulberry@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//478933003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39355 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 21:34:54 +00:00
d988d1c1cb
Test for 'edit.getAssists'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//480223002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39354 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 21:21:26 +00:00
9c900edd7e
Ignore hidden files in implementation of GeneratedDirectory.check()
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//469253006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39353 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 21:06:44 +00:00
7226309842
Import analysis_services.dart into analysis_server.dart.
...
Having two separate packages doesn't really have any benefit, and has
the downside of forcing us to carefully avoid circular dependencies
between the two. It makes more sense to just combine them.
This is largely a mechanical change consisting of the following renames:
1. pkg/analysis_services/lib/src/* -> pkg/analysis_server/lib/src/services/*
2. pkg/analysis_services/lib/* -> pkg/analysis_server/lib/src/services/*
3. pkg/analysis_services/test/* -> pkg/analysis_server/test/services/*
There were 4 instances where 1 and 2 created a collision:
.../services/correction/assist.dart, .../services/correction/fix.dart,
.../services/refactoring/refactoring.dart, and
.../services/search/search_engine_internal.dart. To fix the
collision, the files coming from pkg/analysis_services/lib/src were
renamed to "..._internal.dart".
In addition, pkg/analysis_services/test/test_all.dart was modified to
call pkg/analysis_services/test/services/test_all.dart.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//484733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39349 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 20:17:49 +00:00
ebf9caabfc
Add additional flag methods and fields onto the generated Element type.
...
R=brianwilkerson@google.com , paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//482833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39342 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 18:12:48 +00:00
87f6954692
Support for the 'edit.getAvailableRefactorings' request.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//484713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39340 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 18:09:05 +00:00
1a6b8db026
refactor and cleanup code completion
...
- combine all elements of request into request object
- pass request object through to all computers / visitors
- add override annotations on visitor subclasses
- rename completion_computer -> completion_manager
- move DartCompletionComputer into library with other related classes
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//467233003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39333 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 15:43:09 +00:00
2bf03e89c6
Fix the build
...
Review URL: https://codereview.chromium.org//481533002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39310 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 19:45:41 +00:00
54edbcc686
Support potential edits
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//472373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39309 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 18:51:16 +00:00
4ab9bde919
Add an integration test for analysis.overrides.
...
Also remove the note from the API documentation saying that
analysis.overrides only works for overrides of a superclass.
Interface overrides work too.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//476163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39302 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 16:56:45 +00:00
fa2f2ec46d
add keyword suggestions
...
BUG=
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//461063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39284 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 03:37:01 +00:00
fce2ad90a8
Add an integration test for analysis.outline.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//472933003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39282 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 03:03:24 +00:00
f3dbe9fbe3
first incomplete cut at invocation/accessor suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//471143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39281 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 02:29:16 +00:00
d2f6dddc57
Fix code generated matchers to handle recursive objects.
...
This requires using a wrapper that creating the matchers lazily (when
they're first used), so that a matcher can refer to itself without
causing a circularity during initialization.
R=jwren@google.com
Review URL: https://codereview.chromium.org//475143003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39274 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 22:45:01 +00:00
7e83cc7363
Add an integration test for analysis.occurrences.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//475903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39269 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 21:38:47 +00:00
c38a23704c
Write an integration test for analysis.navigation notification.
...
Also, add the missing ElementKind "PARAMETER", and sort the
ElementKinds.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//468233003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39267 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 21:06:50 +00:00
7540279401
Nit fixes in codegen_java_types.dart to clean up nits in generated code.
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//473793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39262 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 18:43:28 +00:00
6eb410fe93
Fixed TODOs/bugs in codegen_tools.dart for code generation of a directory.
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//476623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39258 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 18:15:06 +00:00
2e9c206530
Output javadoc for enumerated values; suppress empty javadoc.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//473733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39254 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 16:56:58 +00:00
8bbd86fd11
Proposal for RefactoringMethodParameter.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//470723003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39253 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 16:46:55 +00:00
53889222d5
Generate public static EMPTY_ARRAY fields for each object.
...
Order the fields by the ordering in the spec instead of alphabetically.
R=paulberry@google.com
Review URL: https://codereview.chromium.org//475673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39243 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 06:21:44 +00:00
a75c2b7458
Pub buildbot fix, TBR- Paul
...
Review URL: https://codereview.chromium.org//474883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39241 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 05:32:18 +00:00
20ed9dd253
Initial cut at having the enum objects from the spec generated as classes with public static strings.
...
Type/enum aren't being generated yet.
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//462253005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39240 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 05:22:55 +00:00
7c370bf74c
Initial code to generate the Java types from the spec. A constructor, the fields, getters, toString, and equals are all implemented. hashCode is not yet generated for each class.
...
This doesn't do anything with enum types.
The main source is in codegen_java_types.dart
The types are not yet used in the Java server.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//473533003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39228 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 22:37:17 +00:00
17a5250955
Document the fact that client must filter results from completion.results.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//474583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39220 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 20:36:55 +00:00
f822f41189
Update analysis server and integration tests to match new ChangeContentOverlay.
...
The spec was changed in r39199 so that ChangeContentOverlay contains a
list of edits rather than a single edit. This updates the analysis
server and integration tests accordingly.
BUG=dartbug.com/20495
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//472613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39218 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 20:04:55 +00:00
96d5bd1bf0
Add union types to the analysis server API spec.
...
R=brianwilkerson@google.com , jwren@google.com
Review URL: https://codereview.chromium.org//469673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39208 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 17:38:11 +00:00
d03c364236
Add a test to verify that analysis server code generation is up to date.
...
This test will run on the Windows, Linux, and MacOS buildbots, so it
should help ensure that code generation works properly on all of those
platforms.
R=jwren@google.com
Review URL: https://codereview.chromium.org//469543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39201 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 15:29:04 +00:00
7ab0a914ba
Improve spec style and minor changes
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//461283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39199 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 14:46:56 +00:00
a6dd18a2d7
Cleanup in CodegenJavaVisitor.javaType(...), no functional change.
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//452313004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39166 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 21:35:46 +00:00
b685fa31ee
Get the RemoteAnalysisServer to compile against the new generated AnalysisServer interface.
...
This disables any and all functionality that is not up to date with the current server spec.
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//460423003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39164 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 21:14:24 +00:00
5731ca607a
Use hanging indentation when code generating Javadoc @params.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//468563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39160 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 19:52:54 +00:00
6e66a26763
Initial cut at generating the AnalysisServer.java interface. Currently this generates a commented out interface as the java server is not up to date with the spec.
...
This work iterates on the work that Paul started.
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//463163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39155 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 18:33:59 +00:00
153e73e155
Add an integration test for analysis.highlights.
...
Also fix sort order in the API definition of HighlightRegionType.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//463643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39152 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 18:16:37 +00:00
c25a70a1d9
Fixes for the missing highlights.
...
These problems were found in https://codereview.chromium.org/463643002/
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//454843004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39140 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 14:24:01 +00:00
37697c0e81
Rename InttestMixin -> IntegrationTestMixin
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//459203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39128 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 12:07:43 +00:00
19a44a67a6
Split up server_domain_int_test.dart; regularize integration test directories.
...
With this change, there is a separate subfolder in "test/integration"
for each domain, and each subfolder has its own "test_all.dart".
This change is almost entirely code motion. The only material change
is that two tests have been dropped:
- test_connected(): this test is now unnecessary since every time the
"server.connected" message is received, the generated code in
integration_test_methods.dart verifies that it is well-formed.
- test_error(): this was a placeholder to remind us to test the
"server.error" notification. On further reflection, it's unlikely
that we'll be able to integration test this notification, since it
only occurs in the event of a server bug.
R=jwren@google.com
Review URL: https://codereview.chromium.org//458453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39112 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 22:25:26 +00:00
61451c87ad
Tweak for AnalysisDomainHandler.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//463563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39104 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 20:22:43 +00:00
7ff8e1a17b
rename CompletionSuggestionKind.VARIABLE to LOCAL_VARIABLE to match spec
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//463493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39103 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 20:13:53 +00:00
3bd149aa45
remove duplicate suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//459853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39100 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 19:18:53 +00:00
931b0afaa6
Split analysis_domain_int_test.dart into several test files.
...
This test was timing out on the debug build bots because it had 6
sub-tests, each of which started a separate instance of the analysis
server. Split it out to one test per file.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//465513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39095 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 17:39:10 +00:00
ff1f9c2643
Code generate integration test streams for notifications.
...
When a notification is received from the server, it is checked to
verify that its type matches the analysis server API, and then it is
dispatched to the proper stream.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//453603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39094 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 17:34:27 +00:00
d80f9d9053
Improve matchers for enums defined by the analysis server API.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//459643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39090 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 15:21:18 +00:00
8e1d92bcfa
rename and improve imported completion computer
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//458073002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39081 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 12:42:49 +00:00
d5f437d702
local code completion suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//454403003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39069 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 02:18:48 +00:00
80352fd61c
Fix analysis server to only send SERVER_STATUS when subscribed to.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//453263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39065 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-09 16:36:39 +00:00
abfa8dd268
Rework search_domain_int_test to avoid timeouts.
...
Now all sub-tests are run using a single analysis server so that the
SDK only needs to be analyzed once.
Reduces test time by about 9x.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//455983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39064 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-09 14:19:17 +00:00
dd94c27671
Always ignore 'packages' folders.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//452303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39052 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 21:09:52 +00:00
scheglov@google.com