33c7e78bb0
Split analysis server's HttpAnalysisServer into two classes.
...
Behaviours of the HttpAnalysisServer which are independent of the
WebSocket transport mechanism have been moved to a new class,
SocketServer, which will also be used when the transport mechanism is
stdio.
GetHander now holds a reference to the SocketServer rather than the
AnalysisServer, so that we don't need to go to extra effort to update
it when the AnalysisServer is created.
R=brianwilkerson@google.com , jwren@google.com
Review URL: https://codereview.chromium.org//237643003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35061 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-15 15:41:09 +00:00
ab56da71ce
Fix race condition with "server already started" error.
...
We can't report the "server already started" error prior to the call
to WebSocketTransformer.upgrade(), because it's possible that a
different client will successfully establish a connection during the
upgrade process. Instead, check after the call to upgrade(). This
means that if there is an error, we have to report it via a
RequestError object rather than using an HTTP error.
When we add stdio as a transport mechanism, this will have the further
advantage of allowing the "server already started" error to be
detected by code that is independent of the transport mechanism.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//237793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35046 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-14 22:13:10 +00:00
b8ac1a83a0
Improve analysis_server/protocol.dart test coverage.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//227713004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34794 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-07 19:01:10 +00:00
7e7426ae99
Clean-up and progress on analysis server
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//214933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34529 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 21:26:03 +00:00
b25bbbb5eb
utility for manually running all analysis_server tests
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//209003005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34522 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 20:29:30 +00:00
1119399bf3
pkg/analysis_server: fixes for unittest deprecations
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//217153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34503 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 16:10:00 +00:00
6f76a96fcf
Introduce class Sink<T>.
...
The sink only has "add" and "close" methods. It is the supertype of both EventSink and ChunkedConversionSink.
Made startChunkedConversion take Sink as argument, but still return ChunkedConversionSink. The more specialized chunked conversion sinks are test for, just as they always were.
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//203603008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34157 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 10:13:01 +00:00
faf2c8ddf4
(TBR) simplify check for valid SDK directory
...
BUG=
Review URL: https://codereview.chromium.org//198083004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33618 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 21:47:13 +00:00
55e113a629
(TBR) fix path to sdk on Windows
...
BUG=
Review URL: https://codereview.chromium.org//196743004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33610 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 20:58:03 +00:00
4a626200be
(TBR) improve error message when fails on bots
...
BUG=
Review URL: https://codereview.chromium.org//196353006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33606 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 20:25:12 +00:00
8db05728f2
(TBR) upgrade analyzer version in pubspec to fix build
...
BUG=
Review URL: https://codereview.chromium.org//196283009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33604 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 19:57:03 +00:00
18618a20b3
add sdkPath and enable tests
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//196993003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33600 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 19:18:14 +00:00
12fdc641b4
revert r33595
...
BUG=
Review URL: https://codereview.chromium.org//196283007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33598 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 18:29:58 +00:00
2b5113a52f
update analysis server pubspec
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//196353005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33595 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 17:28:51 +00:00
ce8dce2195
add dart-sdk option to dartdeps
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//196423005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33590 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:44:30 +00:00
84de116968
Nit change in the Dart command line analyzer and analysis server.
...
Logger.logError takes a String, not Error types. This will enable the exception to be printed, instead of the message '<SomeError> is not a String'.
Also, in the command line version of the dart analyzer, I put in a commented out stdout/stderr logger for developers.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//196373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33587 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:30:23 +00:00
20158f95a7
update channel test per comments
...
in https://codereview.chromium.org/185313002
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//195463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33573 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 13:33:38 +00:00
3a86b9fd59
Fix the build
...
Review URL: https://codereview.chromium.org//191003003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33454 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 21:00:39 +00:00
e0b6dbb3b6
Add back previously removed tests
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//191103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33451 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 20:40:52 +00:00
9e21e89d95
gracefully degrade with response to client if fail to access client specified dart sdk
...
+ return response if client specifies inaccessible sdk
+ cleanup JSON encode/decode references
+ cleanup channel close processing
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//187603010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33355 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 23:30:45 +00:00
dc1d6bcacf
guard against invalid request id / method
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//180743020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33337 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 18:40:29 +00:00
2231a169fd
restructure client api to use streams
...
+ restructure client api to use streams for notifications and responses
+ client waits for server shutdown response
+ cleanup channel tests
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//185313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33330 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 15:41:08 +00:00
dbb20f6746
split client and server channels
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//182903005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33131 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-27 20:23:37 +00:00
c1c75d48ae
update client to use channel rather than socket
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//176873015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33080 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-26 20:11:00 +00:00
ee9f48440f
Error handling and code cleanup
...
+ cleanup futures code and error handling
+ send message to request server shutdown
+ normalize strings to match codebase
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//180253005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33063 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-26 14:39:40 +00:00
ecdbe3b6ab
Analysis server connect fixes
...
+ new option for connecting to already running analysis server
+ gracefully handle unknown arguments
+ fix bugs in analysis server websocket connect
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//175183008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32974 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 17:41:22 +00:00
a633f22d76
first cut cmdline analysis server launcher
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//175173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32903 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 15:54:21 +00:00
2743d06073
set analysis server exitCode on invalid cmdline arguments
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//171363007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32902 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 15:42:22 +00:00
66590d7363
Use Future for error handling. This appears to be the recommended way of doing things because it is safer.
...
R=devoncarew@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//166703004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32748 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 17:20:14 +00:00
238ca64ce9
Server code clean-up
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//139983004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32466 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-08 15:25:37 +00:00
a9a2021517
Fix test failures
...
Review URL: https://codereview.chromium.org//152893004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32372 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 18:01:32 +00:00
e28a252941
Add structured error support
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//138833010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32366 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 17:11:39 +00:00
d5c3a07611
Add top-level server
...
R=danrubel@google.com , devoncarew@google.com
Review URL: https://codereview.chromium.org//138163006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32008 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-25 18:46:04 +00:00
8179cbae09
Fix the build
...
Review URL: https://codereview.chromium.org//145033011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31984 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-23 20:22:00 +00:00
93ce7745ca
Fix the build
...
Review URL: https://codereview.chromium.org//145973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31983 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-23 19:51:08 +00:00
8a0bf15dcf
Add server and request handlers
...
Review URL: https://codereview.chromium.org//137703010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31982 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-23 18:50:26 +00:00
fe37bca654
Basic communication protocol for server
...
R=devoncarew@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//137853026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31951 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-21 03:20:52 +00:00
5388d0ce8b
Logging support for server
...
R=devoncarew@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//136333008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31926 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 16:52:25 +00:00
b1f2b87a76
Move the unittest dependency to a dev_dependency.
...
(redux of https://codereview.chromium.org/132273005/ )
Review URL: https://codereview.chromium.org//137783013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31841 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 17:46:22 +00:00
8e03a18e15
Initial server package layout
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//129813003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31674 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 19:33:15 +00:00
paulberry@google.com