Commit Graph

4090 Commits

Author SHA1 Message Date
scheglov@google.com 15743f701e Support for inlining methods when some arguments are missing.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//694373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41464 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 18:35:58 +00:00
paulberry@google.com 9b35b056a7 Fix deprecation warnings in analyzer and analysis server.
R=brianwilkerson@google.com, danrubel@google.com

Review URL: https://codereview.chromium.org//685133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41461 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 17:10:08 +00:00
scheglov@google.com 47532a7ba5 Tweak test for the new resolved/parsed AST management and restore it.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//695923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41454 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-01 05:28:46 +00:00
scheglov@google.com da1b1e947a Remove unnecessary cast in Quick Assist.
Sorry, missed it in the previous CL.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//696003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41451 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 20:44:44 +00:00
scheglov@google.com 90b785c88c Fix for an error in the error handler.
We pass exception as String message.

We would have caught it if we had run the server in the checked mode.
Instead it failed at the JSON serialization stage.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//698563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41450 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 20:43:28 +00:00
scheglov@google.com 8bd5c75f0c Fix for 'Replace if-else with conditional expression' in case of mixed expression/return branches.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//690353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41446 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 19:22:22 +00:00
scheglov@google.com b7c685bbe2 Support for 'Add Type Annotation' when selection if right after ';'.
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//693193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41445 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 19:09:03 +00:00
brianwilkerson@google.com e9696e5f67 Clean up logging uses
R=scheglov@google.com

Review URL: https://codereview.chromium.org//685993004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41443 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 19:05:19 +00:00
danrubel@google.com 58b915ffea move import combinator suggestions into a separate computer
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//695773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41442 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 18:31:18 +00:00
brianwilkerson@google.com 20c13d4715 Fix logging API. This should fix the exception I'm seeing. I'll clean up uses of the deprecated API in a separate CL.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//694833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41439 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 16:22:50 +00:00
brianwilkerson@google.com 9dad99f92c Disable a test until I can fix it
Review URL: https://codereview.chromium.org//655353005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41428 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 21:47:58 +00:00
brianwilkerson@google.com 3d13808d7d Status page improvements: sort context names, right align numbers, add missing data descriptors.
R=paulberry@google.com

Review URL: https://codereview.chromium.org//685123006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41427 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 21:11:40 +00:00
danrubel@google.com d22c027e0a add suggestions in format parameter list
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//693573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41420 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 15:13:57 +00:00
danrubel@google.com 010f33956f cleanup warnings/hints
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//685363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41419 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 15:12:30 +00:00
danrubel@google.com b7aeaab3f7 make deprecated elements have low suggestion relevance
BUG=dartbug.com/19615
R=scheglov@google.com

Review URL: https://codereview.chromium.org//690793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41414 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 01:08:32 +00:00
scheglov@google.com 97bc20ffc5 Suggest names for PropertyAccess.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//646103006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41409 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 22:07:27 +00:00
scheglov@google.com e96b29143c Rename ForEachStatement.iterator -> iterable.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//689793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41405 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 21:33:04 +00:00
scheglov@google.com bdd50e1230 Issue 21458. Support for 'Add type' Quick Assist in for-each loops.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21458

Review URL: https://codereview.chromium.org//680133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41403 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 20:59:29 +00:00
paulberry@google.com 03b3d16691 Make table entries on analysis server's '/status' page clickable.
Clicking on a table entry now takes you to a list of files in the
given state.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//685863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41400 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 20:05:16 +00:00
danrubel@google.com 67071bd861 Refactor CompletionSuggestionKind
- Remove many CompletionSuggestionKinds that duplicate ElementKind
- Add two new CompletionSuggestionKinds: INVOCATION and IDENTIFIER
- regenerate Analysis Server Dart and Java API and docs
- rework Dart and Java tests
- remove/rename unused Dart and Java classes and methods
- remove unnecessary reference to SDK

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//684183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41396 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 16:09:56 +00:00
danrubel@google.com e4b90d4cee add class type alias suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//689433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41388 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 02:48:31 +00:00
paulberry@google.com 3e361ba46b Allow print() to be used for debugging analysis server.
We now run analysis server inside a zone so that all print() calls it
executes can be captured to a buffer (rather than being sent to
standard output, where they will confuse the client).  When the server
is run in HTTP server mode, the print buffer is displayed on the
status page.

R=brianwilkerson@google.com, danrubel@google.com

Review URL: https://codereview.chromium.org//686763004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41380 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 23:29:27 +00:00
danrubel@google.com 98d9096892 add functional type alias suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//682953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41376 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 22:03:16 +00:00
scheglov@google.com e446dd5227 Issue 21333. Constant names are not special anymore in the style guide (Dart version).
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21333

Review URL: https://codereview.chromium.org//684863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41373 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:42:46 +00:00
paulberry@google.com 02dada3dec Avoid analysis server crash when reanalyze invoked during analysis.
BUG=dartbug.com/21448
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//678413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41372 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:15:59 +00:00
paulberry@google.com 7014ca0b76 Rename package_root.dart test to package_root_test.dart
So that the test will be run on the buildbots.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//685843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41370 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:10:17 +00:00
danrubel@google.com 2e5f738ad9 add type static constants suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//686843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41369 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:03:36 +00:00
danrubel@google.com 1a68218c36 suggest imported functions in argument list
BUG=dartbug.com/21446
R=scheglov@google.com

Review URL: https://codereview.chromium.org//683133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41368 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 19:03:37 +00:00
paulberry@google.com 4745b7f24a Add a debug option to analysis server to specify HTTP port.
When a port is specified, user may navigate to localhost:$port/status
to see the status of analysis.

Intended for internal debugging of analysis server only.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//679113006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41349 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 00:34:24 +00:00
brianwilkerson@google.com 2f937685fc Code clean-up
R=scheglov@google.com

Review URL: https://codereview.chromium.org//667463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41348 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 00:25:22 +00:00
paulberry@google.com ba8b83eac8 Fix analysis server asynchrony test.
The test had two bugs: it neglected to account for the
"server.connected" notification, and it failed to allow the test to
run to completion before reporting success.  The second bug sometimes
covered up the first, making it look like the test succeeded.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//683573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41345 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 23:19:17 +00:00
danrubel@google.com b41bc7b57e add property accessor suggestions
BUG=dartbug.com/21380
R=paulberry@google.com

Review URL: https://codereview.chromium.org//666863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41344 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 22:56:26 +00:00
scheglov@google.com a625b09fa8 Index EnumDeclaration definitions as top-level elements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//685493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41341 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 21:56:55 +00:00
scheglov@google.com 0463d78cfb Semantic highlight async/await/sync/yield.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//668943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41335 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 20:18:11 +00:00
scheglov@google.com 2ca4bbbd60 Support for enums semantic highlighting.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//679103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41330 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 18:39:40 +00:00
brianwilkerson@google.com 2c08b51c9b Remove unnecessary List creation
R=scheglov@google.com

Review URL: https://codereview.chromium.org//677303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41327 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 17:41:45 +00:00
brianwilkerson@google.com ab87e9fa81 Fix broken tests
Review URL: https://codereview.chromium.org//680953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41322 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 15:59:12 +00:00
brianwilkerson@google.com a22aa71cab Remove JavaIterator and MapEntry
R=scheglov@google.com

Review URL: https://codereview.chromium.org//680913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41321 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 15:37:24 +00:00
brianwilkerson@google.com 9d0ad88805 Remove Math and most uses of PrintStringWriter
R=scheglov@google.com

Review URL: https://codereview.chromium.org//649873007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41318 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 14:49:20 +00:00
scheglov@google.com a151361e2d Add ENUM and ENUM_CONSTANT to the specification.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//677333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41307 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-26 22:01:29 +00:00
brianwilkerson@google.com 877291fb07 Remove ArrayUtils
R=scheglov@google.com

Review URL: https://codereview.chromium.org//660563005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41303 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-26 18:38:26 +00:00
scheglov@google.com 8ae0268b39 Issue 21419. Don't create navigation region for elements without location.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21419

Review URL: https://codereview.chromium.org//661193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41302 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-25 21:12:12 +00:00
paulberry@google.com 0251bcdcf6 Add package root support to analysis server.
Not yet hooked up in Dart editor.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//679763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41292 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 20:29:24 +00:00
brianwilkerson@google.com c362d21351 Fix deprecation hints
R=scheglov@google.com

Review URL: https://codereview.chromium.org//677723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41283 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 16:03:56 +00:00
scheglov@google.com d4f0d9f912 Force Dart unit resolution when elements at offset are requested.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//642693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41282 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 15:54:59 +00:00
scheglov@google.com 2d38012c14 'Create Local Varaible' quick fix.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//677583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41280 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 14:55:38 +00:00
paulberry@google.com dc7d2249eb Fix merge resolution in r41267.
Due to an incorrectly resolved merge, r41267 inadvertently
re-introduced the notificationProcessor parameter to Server.start(),
which was removed in r41246.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//637283008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41272 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 20:43:16 +00:00
brianwilkerson@google.com f04d5d01ea Add timing of serialization
R=scheglov@google.com

Review URL: https://codereview.chromium.org//666913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41270 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 19:38:17 +00:00
paulberry@google.com 61c3ef6bd6 By default, don't use observatory during integration tests.
TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//676623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41268 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 19:31:48 +00:00
brianwilkerson@google.com 5d9ff4c570 Add support for attaching observatory to the server.
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//651243005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41267 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 19:18:08 +00:00