fa62416480
An option to enable 'print' to send output to the console.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//751353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41973 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 22:01:20 +00:00
283b78e260
Add --enable-incremental-resolution option.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//756193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41971 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 20:53:10 +00:00
002769a47c
Coalesce analysis server output messages into a single write call.
...
This ensures that only one call to stdout.write() is made per run of
the event loop, so the output of the analysis server should not fall
behind the rate of analysis.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//758833004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41969 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 20:39:49 +00:00
8a12fbbb59
Use write instead of writeln for client/server communication.
...
We have observed that each string sent from the server to the client
using stdout.write() takes at least one cycle of the event loop to
complete. Since writeln() is implemented using two calls to write(),
this means that streaming of messages to the client was almost always
falling behind the actual rate of analysis, resulting in very annoying
delays for the user.
As a stopgap, send each message from server to client using a single
call to write(). This doesn't completely solve the problem, but it
should reduce its impact while we work on a better solution.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//757013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41959 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 16:06:30 +00:00
369b7f3918
fix broadcast streams
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//752193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41940 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 20:26:59 +00:00
8745f2073a
new onPriorityChanged event stream
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//757613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41935 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 17:56:17 +00:00
0cd030eeb8
Issue 21613. Fix for renaming FieldFormalParameterElement.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21613
Review URL: https://codereview.chromium.org//749173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41929 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 16:00:28 +00:00
2996ef1754
Issue 21650. Fix linked positions added after insert code buffers.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21650
Review URL: https://codereview.chromium.org//750423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41928 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 15:52:58 +00:00
a255faf85c
Exchanging operands of a comparision operator should invert the operator.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//756483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41927 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 15:51:47 +00:00
52d55e933d
Issue 21662. Fix 'Sort Members' when both directives and declarations are updated.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21662
Review URL: https://codereview.chromium.org//753883003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41926 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 15:50:19 +00:00
be636515be
refactor import caching to exclude suggestions for inherited members
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//752833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41925 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 12:28:07 +00:00
651d589c2f
Remove flaky check from reanalyze_concurrent_test.
...
This should avoid sporadic false failures with this test. If in the
future we genuinely regress bug 21448, there is a danger that this
test won't catch it reliably, but that is mitigated by the fact that
(a) even flaky failures do get noticed, and (b) the bug was severe
enough that it probably would be noticed in manual testing. The extra
risk seems worth it to avoid the sporadic false failures we've been
seeing.
BUG=dartbug.com/21638
R=scheglov@google.com
Review URL: https://codereview.chromium.org//724403003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41870 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 22:52:30 +00:00
703b744966
Issue 21655. Don't import self when add type declaration.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21655
Review URL: https://codereview.chromium.org//747613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41869 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 22:10:57 +00:00
76f1d90e3e
Matching fields, some parameters, ignore locals.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//733203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41868 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 22:08:47 +00:00
947ec59930
Fix driver.dart
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//742023004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41867 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 21:49:59 +00:00
a714eb2faf
cache import suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//742163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41865 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 19:31:31 +00:00
5977fec49b
discard code completion cache if context or other sources change
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//744043002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41860 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 18:40:23 +00:00
4a50ed6cf8
cleanup hints
...
BUG=
R=brianwilkerson@google.com , paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//734403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41852 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 14:03:18 +00:00
91c02b4a8e
Issue 21618. Fix for empty code for 'dynamic' type.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21618
Review URL: https://codereview.chromium.org//731313004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41838 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-19 17:42:29 +00:00
438fbd7f6b
Cache ElementLocation instance and index key/location ids.
...
This saves us about 9% of time, as the previous CL.
From 22294 ms to 20040 ms.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//739643003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41814 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 23:02:14 +00:00
58587a470e
Rollback r41807.
...
As discussed, it is not compatible with the incremental analysis.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//736603005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41809 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 18:50:28 +00:00
4032b4d86b
Use shorter DartElementLocation.
...
This improves analyzer + analysis_server analysis time from 21841 ms to 19839 ms.
I.e. about 9% faster.
However it is still 25% slower than without index at all - 15593 ms.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//738673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41807 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 16:21:01 +00:00
b7146b4ac1
Add the --no-error-notification flag to the analysis server flag set, not yet implemented.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//737623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41803 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 14:22:27 +00:00
b8da9bc651
Format and sort analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//725143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 22:23:53 +00:00
fabddbd918
add ContextsChangedEvent
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//732093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41786 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 17:14:48 +00:00
f60be24eb8
add code completion cache
...
- generic mechanism for use in a subsequent CL
- minor get_handler import cleanup
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//729193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41778 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 15:13:38 +00:00
dc7f0c20dc
cleanup warnings
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//729283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41776 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 15:06:07 +00:00
30e11469c3
Use a better way to compute InterfaceTypes least upper bound.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//730803003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41761 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-15 16:52:58 +00:00
84c6c0d7ba
only wait for analysis if necessary when computing invocation suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//728143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41760 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-15 15:16:53 +00:00
0f0a275fc7
Issue 21612. Support for multiple returns in the 'Extract Method' refactoring.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21612
Review URL: https://codereview.chromium.org//725393002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41758 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-15 01:40:46 +00:00
6a03e08cca
Issue 21617. Replace explicit 'this' references and clean ups.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21617
Review URL: https://codereview.chromium.org//733663002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41753 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-14 23:16:13 +00:00
19bd923634
Remove unused fields from analysis_server.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//725153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41743 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-14 15:47:53 +00:00
9e4a3ec845
Report HintCode.UNUSED_FIELD
...
There are two positives in dart2js, valid as I can see.
There are several positives in analyzer and analysis_server.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//728503003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41727 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-13 23:12:40 +00:00
2bcc7feba2
Remove unused methods in analysis_server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//721223002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41718 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-13 16:27:07 +00:00
9bc06fbf41
Workaround for ConstantVisitor dependency issues.
...
This restores proper test functionality on the buildbots. I plan to
follow up with a more permanent fix.
BUG=dartbug.com/21572
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//701583003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41676 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 22:55:58 +00:00
affc91a881
Issue 21552. Fixes for navigation, hover and rename in instance creation expressions.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21552
Review URL: https://codereview.chromium.org//717513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41651 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 03:01:21 +00:00
d23df4f448
Clean up references in comments
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//708263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41623 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-08 15:45:19 +00:00
7e71785a58
Issue 20827. Add imports as needed the 'Add type annotation' Quick Assist.
...
I left some TODOs, the CL is big enough already.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20827
Review URL: https://codereview.chromium.org//706263003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41620 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-07 23:21:35 +00:00
7e7f3ce68c
display completion performance in new server status page
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//691853006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41612 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-07 18:10:51 +00:00
d3646956e8
first cut argument list completion suggestions
...
- first cut simplistic insertion of params
- required params only for now
- move cursor after ) if no params
- don't insert () if identifier suggestion
- does not cover all method/function invocations yet
- updated comments in Server API
- extracted new declaration visitor
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//711533003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41586 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 21:42:31 +00:00
e36820617a
Fix integration test to avoid new 'Unused local variable' hint.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//700323004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41580 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 19:49:40 +00:00
7225ac4794
Enable asynchrony test.
...
This test passes now that dartbug.com/21252 has been fixed.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//700723006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41579 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 19:39:20 +00:00
772a0c6b22
Fix 'Unused local variable' hints in analyzer and analysis_server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//709493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41576 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 18:32:54 +00:00
ca91f9f770
Report HintCode.UNUSED_LOCAL_VARIABLE for local variables whose value is never used.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//686113007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41568 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 17:00:28 +00:00
df6233ae4a
Use Element's source paths instead of URIs as a key in the index.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//703963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41530 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 21:02:37 +00:00
f92b942be2
move combinator suggestion ast traversal into computeFast
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//694203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41521 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 14:13:46 +00:00
7f4d5bb1fb
Issue 21506. Fix for adding back previously excluded resources in sub-folders.
...
The server's part of the issue.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21506
Review URL: https://codereview.chromium.org//692073004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41500 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 18:47:14 +00:00
24fac6c7e5
Flush analysis server output stream when closed.
...
This ensures that if the analysis server terminated with an exception,
the stacktrace will actually be written to stdout before the server
exits.
BUG=dartbug.com/21494
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//694413004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41495 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 16:11:55 +00:00
1c6ddd0751
Issue 21498. Fix for navigation from instance creation with type arguments.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21498
Review URL: https://codereview.chromium.org//694383003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41468 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 20:45:34 +00:00
1d69da9c39
Issue 21496. Fix for inlining negate/decrement into negate.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21496
Review URL: https://codereview.chromium.org//695383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41466 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 20:29:57 +00:00
scheglov@google.com