05ac43c3ea
Issue 22027. When parameters has function type alias type, use its name.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22027
Review URL: https://codereview.chromium.org//836413006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42720 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 22:10:36 +00:00
3f6fc86c14
Remove remaining references to Angular and Polymer from the analysis server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//842753004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42713 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 19:37:19 +00:00
46df250c5a
suggest fields rather than synthetic getters
...
BUG=dartbug.com/21679
R=paulberry@google.com
Review URL: https://codereview.chromium.org//838053003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42712 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 19:35:52 +00:00
e259b02b92
Adds LINTs to the server's generated protocol.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//838283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42711 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 19:05:48 +00:00
11b1c09a10
Remove the Polymer support from the analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//830893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42709 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 18:43:13 +00:00
dd306dc9eb
Enable enum and deferred import support
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//829133007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42704 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 17:51:49 +00:00
faba1283b6
Lint error type for server.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//846493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42703 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 17:42:45 +00:00
4fe7a9dd3e
Remove Angular support from the analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//844593003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42697 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 16:04:17 +00:00
8393c92e89
exclude suggestions from other contexts
...
BUG=dartbug.com/21853
R=paulberry@google.com
Review URL: https://codereview.chromium.org//839713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42668 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 17:16:37 +00:00
94993d5cc1
Include required parameter names when completing a method call.
...
When a method such as "void m(int i, int j)" is completed, instead of
simply inserting "m()", we insert "m(i, j)", we highlight "i", and we
set up linked position groups for "i" and "j" so that the user can
press tab to move from one parameter to the next.
Optional parameters (both named and positional) are not handled by
this logic--the user must still enter them manually.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//837793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42667 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 16:57:39 +00:00
54df418597
Enable async support
...
R=danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//842503003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42666 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 16:51:14 +00:00
ee26309ffb
Add format API
...
R=pquitslund@google.com , rnystrom@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//809213003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42648 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 22:45:41 +00:00
6d83e207b2
Fix comment on ArgListComputer.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//809883003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42641 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 18:49:13 +00:00
603ca51eec
Add a flag/options for enabling incremental resolution validation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//839553005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42640 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 18:17:17 +00:00
138572182c
Getter elements should not have parameters.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//831263007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42617 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 23:22:20 +00:00
9f64a926e6
Issue 21959. Check that type of parameters in 'Extract Method' occurrences are exactly the same.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21959
Review URL: https://codereview.chromium.org//832343004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42615 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 23:12:27 +00:00
409fcc9d44
Fix for 'await' highlighting in for-each.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//835953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42610 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 20:01:05 +00:00
712cd7cc87
Check if assists are requested on a invalid offset.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//823103003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42609 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 19:58:20 +00:00
dca42cafab
Check if the method / accessor being inlined is synthetic.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//835093005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42606 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 19:36:39 +00:00
bc9c340ec5
fix local setter suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//831273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42599 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 17:26:51 +00:00
d645d2dce2
fix top level getter suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//832343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42597 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 15:55:15 +00:00
f6d7bd629f
Improve tests for refactoring exceptions. Catch initial exceptions.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//816133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42574 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-30 18:50:57 +00:00
78a3bfe9c2
refactor/cleanup dart completion cache
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//816233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42556 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-22 22:09:46 +00:00
6d7155de63
Introduce CompletionTarget to take the place of the Node being completed.
...
Instead of locating the node containing the cursor offset using a
NodeLocator, identify the edge in the parse tree which will be
displaced or modified by the completion proposal. This reduces the
number of cases that need to be handled in the _OpTypeAstVisitor, and
avoids the need for the _OpTypeAstVisitor to consider character
offsets in nearly all cases.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//820773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42543 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-20 15:47:25 +00:00
d06e291c52
update completion cache key to include part directives
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//812233003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42542 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-20 05:17:58 +00:00
e95dcac840
support part file completions
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//815683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42541 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-20 05:15:50 +00:00
d139fbfaa2
Add InstrumentationService.logPriorityException() and use logException() in refactorings.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//816103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42530 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 23:00:19 +00:00
97f90d4acc
Fix for extracting from interpolated string.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21907
Review URL: https://codereview.chromium.org//820763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42528 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 22:11:13 +00:00
11bdb14559
Catch exceptions in refactorings and return them as a SERVER_ERROR.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21907
Review URL: https://codereview.chromium.org//815233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42526 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 21:51:02 +00:00
a49d0f02c9
Instrument top-level exceptions
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//797503004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42513 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 17:11:02 +00:00
dfb35c0ea6
Add methods to mock SDK that are referenced by completion tests.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//810063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42512 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 17:02:18 +00:00
e98df5b991
Update existing Outline objects with new location information.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//813353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42511 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 16:39:01 +00:00
86dfd8470f
Capture and report all exceptions in server
...
Review URL: https://codereview.chromium.org//811223002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42509 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 15:55:34 +00:00
8c99b69287
Log more information to debug 'null' location for constructor.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21842
Review URL: https://codereview.chromium.org//809203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42463 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-18 18:52:34 +00:00
7c877ab009
Ensure shutdown is always called
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//814453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42442 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 18:16:11 +00:00
523dac8d75
Print a count of total tests and expected failures in completion tests.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//806413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42441 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 16:52:25 +00:00
879984875b
Add filtering to completion tests.
...
This allows the negative completion tests to be run.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//798173004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42432 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 14:42:29 +00:00
d0c5b78efa
Add tests for AnalysisServer.getAnalysisContextForSource.
...
BUG=dartbug.com/21898
R=danrubel@google.com
Review URL: https://codereview.chromium.org//807323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42422 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 02:38:10 +00:00
2546490ed5
Ensure that AnalysisContext futures are completed when context disposed.
...
It's possible for the analysis server to create or destroy contexts in
the background while the user is working (as a result of changes on
the filesystem). This ensures that if any code completions are
waiting for analysis when that happens, they are aborted.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//807993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42416 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 23:41:56 +00:00
27b38e807c
Convert analysis_server_test.dart to use reflective tests.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//813563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42413 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 22:30:07 +00:00
049adb2777
refactor optype to be computed once per refactoring request
...
and hide optype computation internals
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//807743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42412 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 22:15:38 +00:00
3448724d3a
Improve nomenclature of new AnalysisContext async method.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//809793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42404 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 18:05:02 +00:00
997ac90b24
Fix getAnalysisContextForSource.
...
Previously this function was always returning the first context; as a
result completions were only being precomputed for the first context.
There were probably subtle breakages in other features as well, though
I'm not aware of any specific problems.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//805783004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42401 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 17:11:25 +00:00
ddc3cae8bd
refactor duplicate code into single visitor
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//804323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42398 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 16:53:24 +00:00
8affb6c015
Upgrade unittest to be able to use isNotEmpty.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//790363006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42380 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 04:07:37 +00:00
fef0e84293
Issue 21883. Add checks if type parameters can be used.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21883
Review URL: https://codereview.chromium.org//806933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42377 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 00:29:22 +00:00
a662ca1ea1
Disable 'Split && condition' if there is an 'else' statement.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//805053003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42374 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-15 20:36:13 +00:00
438aa447d4
refine when suggestions are limited to types
...
BUG=dartbug.com/18860
R=paulberry@google.com
Review URL: https://codereview.chromium.org//802233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42366 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-15 17:48:00 +00:00
cd4ec28541
fix named constructor completion
...
BUG=dartbug.com/21799
R=paulberry@google.com
Review URL: https://codereview.chromium.org//803913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42365 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-15 17:16:40 +00:00
5599bc3a5b
fix invocation completion test
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//805683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42364 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-15 17:14:36 +00:00
scheglov@google.com