ba6742f9fe
Formatter service API tweaks.
...
Some way to indicate no selection is required in the case where there is none. I opted for the -1 convention not becuase I particularly like it but because, well, it's convention! :)
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//894863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43369 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:14:22 +00:00
81c90c6492
Specify mapUri for directories
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//896513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43364 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 22:45:50 +00:00
b40a5702b3
Fix async/await type checking in analyzer.
...
This required making the "async" library into TypeProvider so that we
can create Future<...> types when doing resolution and error/hint
checking.
BUG=21888,22053,22091,22092,22160,22164
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//898513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43361 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 20:58:37 +00:00
03874e1c60
record and display request latency
...
and update unknown page handler
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//894823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43359 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 19:44:51 +00:00
46e5078360
Bump analyzer rev pre pub publish.
...
Addresses bug in setting linter options.
R=danrubel@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//873883005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43341 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 17:46:37 +00:00
dd09212ee5
fix internal option typo
...
BUG=
Review URL: https://codereview.chromium.org//887053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43339 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 15:53:36 +00:00
01ea08c589
Fix incremental resolution of files referenced by multiple contexts.
...
There were two problems:
1. When a file was set as a priority, we weren't propagating that
information to all contexts; as a result, the resolved AST wasn't
cached in all contexts, so incremental resolution wasn't able to take
place in all contexts.
2. In setPriorityFiles we weren't scheduling analysis operations, so
even after the file was made a priority, its resolved AST wouldn't be
available until some other event triggered analysis in that context.
BUG=dartbug.com/22209
R=scheglov@google.com
Review URL: https://codereview.chromium.org//892493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43323 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 00:27:58 +00:00
952c2c260f
Bump server analyzer dep to point to latest dev build.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//880103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43316 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 21:56:55 +00:00
f9f324ca9b
Avoid redundant notifications when a file is analyzed in multiple contexts.
...
BUG=dartbug.com/22210
R=danrubel@google.com
Review URL: https://codereview.chromium.org//887793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43315 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 21:42:48 +00:00
675b99110c
fix race condition when recording computeCache performance
...
and improve completion performance status page
BUG=dartbug.com/22205
R=paulberry@google.com
Review URL: https://codereview.chromium.org//889583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43299 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 17:00:57 +00:00
ef89b4c21a
tests for earlier CL
...
BUG=dartbug.com/21768
R=paulberry@google.com
Review URL: https://codereview.chromium.org//882273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43295 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:50:24 +00:00
cb6c16922f
Fix for issue 22052
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//881403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43292 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:01:58 +00:00
b9f3559e03
(TBR) fix failing test
...
BUG=
Review URL: https://codereview.chromium.org//881413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43258 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 20:39:36 +00:00
4229cb1c6f
use CompletionTarget for replacement offset/length
...
add code completion replacementLength and replacementOffset assertions
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//886463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43255 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 20:11:10 +00:00
36ce6423a6
Fix for two semantic highlighting problems.
...
1. We need to dispose the existing semantic highlighting manager before setting a new input.
So, we would not apply old highlighting to the new file.
2. We need to clear "input" fields to correctly determine full file path.
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//882203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43254 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 19:55:25 +00:00
c5af5132fc
Issue 22191. Grab the document lock before positionsLock to prevent deadlock.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22191
Review URL: https://codereview.chromium.org//885653005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43251 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 18:33:16 +00:00
b35d83dbad
Revert 43227
...
BUG=
Review URL: https://codereview.chromium.org//878353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43228 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 04:48:18 +00:00
5a7c80ab80
(TBR) fix the build
...
BUG=dartbug.com/22180
Review URL: https://codereview.chromium.org//882913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43227 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 04:30:36 +00:00
ea333d8459
Fix mixin resolution order when multiple mixins present.
...
BUG=dartbug.com/22069
R=scheglov@google.com
Review URL: https://codereview.chromium.org//879093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43224 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:41:21 +00:00
a016a7b56e
Fix for 'Convert Method to Getter' when multiple files are changed.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//881943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43221 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:12:23 +00:00
3c66f9be64
Change server API version to 1.0.0 for clients
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//881873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43212 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 22:06:16 +00:00
b280b861f9
Issue 22143. Navigation from super initializers.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22143
Review URL: https://codereview.chromium.org//882823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43209 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 21:50:00 +00:00
c93b24904d
Issue 22157. Cancel a pending refactoring request on receiving a new one.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22157
Review URL: https://codereview.chromium.org//884453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43201 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 19:24:19 +00:00
af8a953cb8
Tweaks for refactoring manager.
...
My forgotten changes for your review comments.
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//880613004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43194 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:39:15 +00:00
b9f355d2a4
Library dependencies server API updates (to pass package maps).
...
R=brianwilkerson@google.com , jwren@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//874373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:23:09 +00:00
4f5494c2ac
Clean up and add analyzing contexts
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//875663002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43170 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 03:40:39 +00:00
aac571f7a0
Add tests for additional bugs fixed by r43163.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//862133006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43168 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 01:09:54 +00:00
7bf029506d
Fix "reanalyze sources" when there are unsaved files.
...
The analysis server now maintains a single content cache which is
shared by all contexts; this allows it to persist the content cache
across reanalysis (which destroys all contexts and recreates them from
scratch).
Two other bugs are fixed in the process:
- If a file is analyzed in multiple contexts, then editing it will
cause all affected contexts to be notified of the change. (Note
that this could potentially account for some other strange behaviors
we've seen recently, such as incorrect semantic highlighting and
lingering errors/warnings.)
- If the client supplies a ChangeContentOverlay for a file which
currently has no overlay, the proper error is generated.
I plan to submit tests for these two bugs in a follow-up CL.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//880643005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43163 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 23:26:45 +00:00
23b8a90d91
Use async/await in edit_domain.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//876633005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43162 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 23:13:47 +00:00
7db81a77c0
Make AnalysisServer.onAnalysisComplete a Future and wait for it before refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//875163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43158 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 22:31:51 +00:00
a9bc5e512d
Issue 22150. Quick fix to add a getter, in addition to create a field.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22150
Review URL: https://codereview.chromium.org//875193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43155 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 22:29:37 +00:00
2b8c66ea79
Rename ChangeNotice resolved Dart/Html unit fields.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//881463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43147 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:58:19 +00:00
dc144bb870
Issue 22155. Send outline for both parsed and resolved Dart units.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22155
Review URL: https://codereview.chromium.org//876703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43145 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:39:36 +00:00
09b93c2416
Support code generation for other languages
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//863883004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43144 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:35:48 +00:00
f32f6699bf
Fix for file:// package: references to the same element.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//877693004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43143 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:30:45 +00:00
26d43c80fc
Library dependency service tests.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//868873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43142 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 18:28:12 +00:00
ef257710e1
add periodic delay in analysis to reduce request processing latency
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//874083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43127 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 02:10:38 +00:00
a23f1b3488
Fix the build by disabling asynchrony_test.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//869343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43124 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 22:11:27 +00:00
768aeeac4b
Use 'print' to send responses/notifications to the client.
...
Ensure that Java client reads lines in a separate thread,
so that server's stdout never overflows.
R=brianwilkerson@google.com , danrubel@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//872633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43123 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 21:33:40 +00:00
36f5f8e768
Move AnalysisServer to package ...generated to indicated that the file shouldnt be changed manually.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//868183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43119 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 20:10:03 +00:00
3226596c3c
Prioritize analysis operations for contexts with priority files.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//869153003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43118 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 19:29:05 +00:00
f94326c241
add optional request field to record time at which client made request
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//865383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43113 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 17:41:29 +00:00
beff0fa32d
Move indexing into operations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//869793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43090 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 00:32:30 +00:00
4f59e94ce1
update analysis server spec and regen files
...
this is needed to support new UpdateContentConsumer
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//868893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43088 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 23:14:09 +00:00
d284fef9db
cleanup unused imports
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//868803006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43086 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 22:41:51 +00:00
55d1df2cf2
cache completion performance by default
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//867023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43084 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 22:25:38 +00:00
010541927b
Fix 'MockContext does not implement getContents' test failures.
...
R=danrubel@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//866973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43080 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 21:35:39 +00:00
e2bf6de0f9
(TBR) fix the build
...
BUG=
Review URL: https://codereview.chromium.org//872443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43079 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 21:33:00 +00:00
03aa9c33e5
Library Dependencies Analysis service API.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//861893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43077 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 21:26:28 +00:00
a26c95865a
Use a raw string to correctly print \n in option description in the analysis server.
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//867433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43054 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 22:28:57 +00:00
pquitslund@google.com