f99f4f3212
improve measurement of completion performance
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//861153003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43051 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 19:33:43 +00:00
54727b8eca
Add addStatusListener to the AnalysisServer generator.
...
R=keertip@google.com
Review URL: https://codereview.chromium.org//864063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43049 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 18:25:18 +00:00
14d008359d
Use UTF-8 when serving web pages for analysis server debug.
...
This avoids the need to encode unicode characters using hexadecimal
escape sequences.
(Note that setting the charset using response.headers.contentType
affects the encoding used by both client and server.)
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//855643004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43045 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 17:57:57 +00:00
30f1b97888
Handle generic parameters correctly in invocation completions.
...
When doing invocation completions, we need to walk the interface
types, not the classes, because the interface types record the actual
types of the generic parameters. This required some rework because
the old technique used an element visitor, and interface types can't
be visited using an element visitor.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//829173003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43040 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 15:16:50 +00:00
252c19c920
Addition of the new flag "file-read-mode" into the analysis server to fix the offset bug with IntelliJs integration.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//857283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43028 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 21:48:00 +00:00
f7915c7a84
Return outline after parse
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//842533004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43027 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 21:36:14 +00:00
0b975704b5
Alternate status page
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//840953008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43020 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 18:46:44 +00:00
f5f408e412
send priority instrumentation message on startup with version info
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//859513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43017 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 17:30:47 +00:00
96462aab53
Send notifications using separate server operations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//847663005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42970 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 20:11:47 +00:00
bcad595a17
Revert "Addition of the optional FileReadMode into the server spec."
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//838243004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42965 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 17:39:32 +00:00
288694de4e
Console was removed from dart:io.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//854183003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42964 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 17:37:13 +00:00
30ae29f4f2
Reapply revert of "Make stdout/stderr async"
...
This re-applies r42909 which was reverted in r42910 with a few fixes.
TBR=ajohnsen@google.com
BUG=
Review URL: https://codereview.chromium.org//851253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42953 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 13:35:37 +00:00
3eb4d4f9a2
Include overlays contents.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//854703004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42943 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 04:50:36 +00:00
a737481621
improve completion performance status page
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//813563007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42941 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 00:33:20 +00:00
ad01eca4e2
Fix NPE in tests.
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//846383004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42937 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 22:09:00 +00:00
ef7456f199
Update cache size on analysis start/stop.
...
This reduces time of dart2js analysis after rename form 16000 ms
to about 1200 ms, i.e. about 13 times ;-)
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//844493005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42933 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 20:55:57 +00:00
4d1507935d
Addition of the optional FileReadMode into the server spec.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//825393005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42921 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 18:01:46 +00:00
c831cdf97f
Revert "Revert "Make stdout/stderr async""
...
This reverts commit r42909
TBR=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//850333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42910 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 14:33:35 +00:00
bc1be9c45f
Revert "Make stdout/stderr async"
...
This makes writes to the stdout and stderr IOSinks in dart:io blocking again.
To get the non-blocking behaviour the getter "nonBlocking" will return an
IOSink with real non-blocking behaviour.
Updated the class exposed for stderr to also support checking for whether it
is connected to a terminal and checking the terminal size.
R=ajohnsen@google.com , iposva@google.com
BUG=
Review URL: https://codereview.chromium.org//807833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42909 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 14:18:16 +00:00
cbd16a7336
add local parameter info to completion suggestions
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//850003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42894 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 02:26:45 +00:00
dc96eabde3
Display overlays at /overlays URI.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//823123004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42891 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 00:22:44 +00:00
81b8596681
Add indication of instrumentation active/inactive to analysis server status.
...
The instrumentation status shows up when querying the "/status" page, when analysis server is started with the "--port" option.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//847963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42879 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 18:23:22 +00:00
806e0fc181
Have the analysis server not send error notifications when NO_ERROR_NOTIFICATION has been set to true.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//854493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42851 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 04:00:41 +00:00
01a1ea75b8
fix function type alias conversion to protocol element
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//848943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42850 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 01:58:15 +00:00
e8d04b5d1e
Remove dart_style pub dep in quest for build greenness [TBR].
...
Review URL: https://codereview.chromium.org//848003007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42843 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 21:49:25 +00:00
93eea56a86
Catch and report exceptions in computers.
...
So, they will not cause the server crash anymore.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//854443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42841 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 21:14:08 +00:00
e034c062cf
Server dart_style package version dep fix.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//806133004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42840 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 21:05:47 +00:00
8e91d1abec
Fix server pubspec.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//849943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42839 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 20:57:51 +00:00
6fb12789e7
Analysis server format service wiring (and protocol doc update).
...
R=brianwilkerson@google.com , danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//833903005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42835 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 20:34:10 +00:00
79cfcc3ac8
cleanup NO_RETURN_TYPE
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//845363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42830 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 19:23:33 +00:00
a38a503d86
Replace @ReflectiveTestCase() with @reflectiveTest.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//849863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:11:24 +00:00
0974f8b1ea
insert parameters when completing imported functions and inherited methods
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//811933007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42808 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 14:10:47 +00:00
cebcc398f6
Add support for completion of case labels.
...
This change addresses completions like the following:
switch (...) {
foo: case 1:
...
bar: case 2:
continue ^;
baz: case 3:
...
}
Completion at the point marked "^" will show "foo", "bar", and "baz"
as possible completions.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//806473007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42799 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 03:11:46 +00:00
1c24293cb1
Reset compilation unit in notification, as it might be damaged.
...
This should fix the navigation computer crash.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//846973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42792 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 23:07:32 +00:00
adcffd8bf5
Fix checking of generated directory contents.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//811973010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42789 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 22:19:58 +00:00
473438f940
Addition of AnalysisServer.isSocketOpen for clients to know if the server is still running.
...
Execution of generate_all for recent changes to the analyzer spec input, and resulting changes to have editor and the java server layer compile.
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//845973006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42787 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 21:46:59 +00:00
14a97cafed
suggest fields rather than synthetic getters
...
and return dynamic returnType rather than null
BUG=dartbug.com/21679
R=paulberry@google.com
Review URL: https://codereview.chromium.org//791553007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42786 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 19:02:47 +00:00
531c591460
Completion support for loop labels.
...
Break and continue statements inside loops now have their targets
properly completed. Continue statements inside switch statements will
be addressed in a future CL.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//812593008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42781 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 17:37:46 +00:00
4a8c341ecf
Server clean-up
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//795833005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42780 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 17:34:14 +00:00
214a2380ca
Fix for NPE in the index store.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//823223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42777 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:38:52 +00:00
b161853940
Minor clean-ups and rename
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//840473007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42776 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:36:14 +00:00
82d7224537
Style changes in assist and fix.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//825363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42760 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 23:18:03 +00:00
e84aa1aa54
Fixes for linked and exit positions offsets.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//843163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42757 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 22:31:42 +00:00
11c0e607a0
Make domains plugable
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//846723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42756 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 22:15:20 +00:00
db4c9543ac
Remove computation with no effect from local completion computer.
...
The computation performed by _computeExcludeVoidReturn was always
being overwritten by the caller right after construction, so it had no
effect.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//830153004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42752 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 19:28:52 +00:00
f781ec6675
Add generateLints analysis option to the Server protocol API.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//806943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42745 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:38:43 +00:00
9fb54ea3db
Capture log messages via instrumentation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//840553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42741 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:06:44 +00:00
c35a4acd9c
Fix order of operations dependencies in element_references_test
...
It's not safe for a single test to have two overlapping calls to
findElementReferences() because fields in the test class are used to
hold the search results and to keep track of whether more results are
pending.
Fixes a bogus test failure that arose after the relative ordering of
futures and microtasks was changed.
BUG=dartbug.com/22014
R=scheglov@google.com
Review URL: https://codereview.chromium.org//842803003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42738 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 16:36:42 +00:00
b7de258068
Initial plugin API
...
R=danrubel@google.com , pquitslund@google.com
Review URL: https://codereview.chromium.org//839833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42736 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 15:57:51 +00:00
2005b07aea
Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int
...
This allows the sever to return a more graduated relevance
and facilitates moving client side prioritization over to the server.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//845553005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42735 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 15:30:59 +00:00
danrubel@google.com