Commit Graph

4090 Commits

Author SHA1 Message Date
Brian Wilkerson e8a5e404c3 Move LocalDeclarationVisitor for use by contributors that will be moved to analyzer_plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2918343002 .
2017-06-05 10:24:54 -07:00
Brian Wilkerson db7d3d0fe7 Move relevance constants for use in plugins
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2923573002 .
2017-06-05 10:10:56 -07:00
Devon Carew 0b79e4d20d update the analyzer and analysis server perf tags
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2917183003 .
2017-06-03 19:51:27 -07:00
Devon Carew 4f2867d86c Add clientID and clientVersion to the diagnostics page.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2925463002 .
2017-06-03 17:53:52 -07:00
Devon Carew 511963d715 Add an analytics domain to the analysis server.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2922603002 .
2017-06-02 14:38:53 -07:00
Devon Carew 428c0ff59d Expose the exceptions info in the diagnostics page.
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2914383002 .
2017-06-02 09:57:09 -07:00
Brian Wilkerson b5c630426c Update a few more methods in FixProcessor, and fix some bugs in ChangeBuilder
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2916923002 .
2017-06-02 07:36:51 -07:00
Devon Carew 7e32f3bd7c Remove dead code related to the diagnostics server.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2918553002 .
2017-06-01 10:31:27 -07:00
Devon Carew 6c1625743c Relax a null check in context_manager.dart.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2915673002 .
2017-06-01 09:50:00 -07:00
Brian Wilkerson d7d3ee40dd Report plugin errors to the instrumentation service
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2913913002 .
2017-05-31 08:01:07 -07:00
Devon Carew 02f7f5fee7 Updates to the diagnostics page.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2918533002 .
2017-05-31 07:15:20 -07:00
Devon Carew c817241ad6 Update the analysis server diagnostic page - re-enable code completion and overlay pages,
and refactor the css and navigation.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2911313002 .
2017-05-30 18:46:33 -07:00
Max Kim 311dd0bb0c Modify autocompletion test case to work with new feature added
Request offset and Length of plugin response must line-up if main Dart autocompletion has suggestions already.

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2913903002 .
2017-05-30 17:14:48 -07:00
Devon Carew 24b0d1489f Fix an npe in context_manager.dart.
BUG=

Review-Url: https://codereview.chromium.org/2917453002 .
2017-05-30 14:29:53 -07:00
Max Kim 82490f0d2f Allow replacementOffset and replacementLength overriding from plugin autocompletion. In cases where a plugin overrides the original Dart autocompletion offset/length or another plugin's offset/length - the suggestion for the plugin is dropped and an error notification is logged.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2913833002 .
2017-05-30 13:54:11 -07:00
Devon Carew 1e7ff6bccf Add the analysis options path to the diagnostics page.
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2913493002 .
2017-05-30 13:29:25 -07:00
Brian Wilkerson 265ef252ae Write type parameters when writing members (issue 29714)
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2909943004 .
2017-05-30 12:19:15 -07:00
Konstantin Shcheglov 9737664106 [Extract Method] When no selection, check for implicitly selected closure.
R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review-Url: https://codereview.chromium.org/2907213002 .
2017-05-30 11:11:46 -07:00
Brian Wilkerson 1b4679cacd Clean-up several warnings
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2912883003 .
2017-05-30 09:04:41 -07:00
Brian Wilkerson f6c6c01211 Update some of the fixes to use ChangeBuilder
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2910683002 .
2017-05-30 08:01:52 -07:00
Devon Carew 3d2d913969 Add analysis server integration tests.
BUG=
R=brianwilkerson@google.com, messick@google.com

Review-Url: https://codereview.chromium.org/2909823002 .
2017-05-27 15:55:53 -07:00
Devon Carew 8df017b670 Re-gen analysis server specs.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2911783002 .
2017-05-27 12:42:17 -07:00
Devon Carew 03e0a93092 show the enableAssertInitializer setting in the diagnostics page
BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2911563002 .
2017-05-26 08:36:26 -07:00
Brian Wilkerson a7cc00e01a Make server forward getNavigation requests to plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2908633002 .
2017-05-25 14:49:35 -07:00
Brian Wilkerson f65c7ecbdf Fix a recent regression with nested contexts
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2903303002 .
2017-05-25 13:17:08 -07:00
Brian Wilkerson 1c8b59dc31 Update status pages to show package map and plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2904983003 .
2017-05-25 12:51:19 -07:00
Brian Wilkerson 013411c10b Allow plugins to provide completions for non-dart files
R=maxkim@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2910463002 .
2017-05-25 10:53:07 -07:00
Brian Wilkerson 61e3486ed1 Find drivers even when the file is not a dart file
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2898213004 .
2017-05-23 17:23:30 -07:00
Konstantin Shcheglov ab9ee72a34 Switch server tests to strong mode.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2903523003 .
2017-05-23 14:58:53 -07:00
Brian Wilkerson 0929b7736e Convert quick assist support to use AnalysisDriver
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2899843002 .
2017-05-22 13:45:55 -07:00
Ian McKellar 5b6a9392e5 Fix inifinite loop in analysis server. (#29685)
It was walking up a directory heirarchy looking for a directory named
"lib" but didn't terminate when it reached the root.
2017-05-22 11:46:44 -07:00
Brian Wilkerson 7e47a24c8a Convert quick fix support to use AnalysisDriver
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2894403003 .
2017-05-22 10:41:57 -07:00
Steve Messick 5455f21565 Fix reparent on windows
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2892963002 .
2017-05-19 10:28:44 -07:00
Brian Wilkerson a8dc041543 Capture the request time for performance data and support forced shutdown
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2893803004 .
2017-05-19 08:49:47 -07:00
Brian Wilkerson c1a7070770 Add the ability to whitelist plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2897653002 .
2017-05-19 08:48:32 -07:00
Brian Wilkerson a6214b3129 Remove more libraries directives from server
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2894883002 .
2017-05-19 08:42:30 -07:00
Brian Wilkerson 7e11a13cf5 Add requestTime to responses
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2890163004 .
2017-05-18 10:32:47 -07:00
Brian Wilkerson 5659afc812 Make instrumentation data structure more regular
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2890193002 .
2017-05-18 09:09:17 -07:00
Brian Wilkerson daffcecc11 Pass the sdk path to plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2885993004 .
2017-05-17 08:19:49 -07:00
Brian Wilkerson 7d26ff6d4f Remove some more library directives
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884233004 .
2017-05-17 08:02:08 -07:00
Brian Wilkerson d9f1c2620b Update the log viewer to understand the plugin entries
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2891743002 .
2017-05-17 07:51:42 -07:00
Brian Wilkerson cb258a952c Remove unused contentHash from results
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2885203002 .
2017-05-16 14:08:11 -07:00
pq aa491e7133 Support tear-off completions for named params (in constructors) (flutter-intellij#836)
R=danrubel@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/836
Review-Url: https://codereview.chromium.org/2883363002 .
2017-05-16 13:40:33 -07:00
Dan Rubel d566906167 cleanup unused incremental resolution
* remove unused analyzer incremental resolution
* remove unused Token.applyDelta method

Patch Set 1 is the original CL that was landed and reverted
https://codereview.chromium.org/2876993005

Patsh Set 2 contains additional fixes and test changes

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884853002 .
2017-05-16 07:53:17 -04:00
Brian Wilkerson a03958bfc9 More clean-up after getting common protocol classes
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2880393002 .
2017-05-15 13:01:57 -07:00
Brian Wilkerson 6643349a8f Minor clean-up
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2885473002 .
2017-05-15 10:09:47 -07:00
Brian Wilkerson 0b5bee6c66 Fix a failing test (TBR)
Review-Url: https://codereview.chromium.org/2877353003 .
2017-05-15 09:49:22 -07:00
Brian Wilkerson fb982f5476 Make server use the common protocol classes
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
Brian Wilkerson 38143be701 Fix an error to fix the bots (TBR)
Review-Url: https://codereview.chromium.org/2883883003 .
2017-05-15 09:11:12 -07:00
Brian Wilkerson 27f9e5e4ce Reverse the sense of the flag to make it easier to find test that need to be converted
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884593003 .
2017-05-15 08:40:40 -07:00