90121b528a
Remove the 'Move File' refactoring.
...
It has been broken since we switched to Analysis Driver.
Given that IDEA does not use it, there is little incentive to fix it.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2983783003 .
2017-07-18 17:59:20 -07:00
8b7e3ef7e4
add env var info to the diagnostics page
...
BUG=
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2981123002 .
2017-07-17 09:22:23 -07:00
00d5012906
Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt.
...
...instead of mixing formatting with actual changes in many CLs.
R=ahe@google.com , paulberry@google.com , sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2975253002 .
2017-07-13 16:28:18 -07:00
2eb0017013
Add angular to analyzer plugin whitelist
...
BUG=
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2982773002 .
2017-07-13 14:36:14 -07:00
78f78feaf8
Don't include *.yaml files in 'analysis.analyzedFiles' notification.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review-Url: https://codereview.chromium.org/2980653002 .
2017-07-11 14:19:15 -07:00
5cd77dda37
AnalysisOptionsProvider.getOptionsFile() should return only existing files.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review-Url: https://codereview.chromium.org/2981553002 .
2017-07-11 13:38:08 -07:00
b47bfa88be
remove unused analysis server flag
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2974013002 .
2017-07-11 08:10:42 -04:00
def1ee6604
add analysis server --flutter-repo startup flag
...
This adds a new flag used by `flutter analyze --watch` when analyzing
the flutter repository. When specified, this flag causes analysis server
to enable the public_member_api_docs lint even though it is not enabled
in the analysis_options file. `flutter analyze --watch` needs the results
of this lint to summarize the number of public members missing dartdoc,
but enabling it in the analysis_options causes too much noise in the IDE.
See https://github.com/flutter/flutter/issues/10721 for more background
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2976473003 .
2017-07-10 16:50:04 -04:00
a673395664
Don't depend on visiting local functions.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2970403002 .
2017-07-07 13:01:23 -07:00
a2e9519279
Make exception reporting best effort.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2965263002 .
2017-07-06 13:36:28 -07:00
ee4a09faea
Fix for element_search.dart import in analysis_server.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2975473002 .
2017-07-06 12:38:56 -07:00
e454986288
Add code to run more tests from test_all
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2968233002 .
2017-07-06 12:24:01 -07:00
19265a82b4
Move findElementsByName() into shared analyzer/element_search.dart file.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2965133003 .
2017-07-06 11:51:17 -07:00
ba625804b7
Tweaks to the profiling diagnostics page.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2966383002 .
2017-07-06 11:47:26 -07:00
6323bedc58
Stop depending on LabelElement(s) to be reported in visitChildren().
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2973093002 .
2017-07-06 11:28:06 -07:00
fe445e079e
Add a generated file that was missed
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2966223004 .
2017-07-06 09:55:29 -07:00
cc5ccf5dcf
Add unit tests for copy/paste support
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2965243002 .
2017-07-06 09:54:42 -07:00
d4abd49df7
Add analytics to analyzer-cli and analysis server.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com , zra@google.com
Review-Url: https://codereview.chromium.org/2963323002 .
2017-07-05 23:29:46 -07:00
d9754a58e9
Initial implementation of copy/paste support
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2972833002 .
2017-07-05 14:02:07 -07:00
ce43a15e51
Stop depending of visiting LocalVariableElement(s) in Executableelement.visitChildren().
...
We still visit them, but analyzer and analysis_server don't need it.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2969343002 .
2017-07-05 12:28:20 -07:00
d2569cc3ee
Add lint timing information to the status pages
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2970153002 .
2017-07-05 12:00:42 -07:00
3c1c22a3a1
Add a quick fix for missing new (issue 30077)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2965063002 .
2017-07-05 10:59:34 -07:00
62f43f663b
Fix a bug in inline method refactoring
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2973673002 .
2017-07-05 09:35:48 -07:00
a3406c38e2
Update server version after adding experimental API
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2972673002 .
2017-07-04 16:14:57 -07:00
6a7b9f441b
Convert DartChangeBuilder to use AnalysisSession
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2969833002 .
2017-07-03 08:41:40 -07:00
2f28f5713c
Fix a test so that it passes
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2968883002 .
2017-07-03 08:39:31 -07:00
0ee29eadf1
Run the generator after updates to spec
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2972473002 .
2017-07-02 07:49:05 -07:00
8c8a177f3c
Fix failing test (TBR)
...
Review-Url: https://codereview.chromium.org/2964343002 .
2017-07-01 12:55:17 -07:00
aadafd1bd5
Use DartEditBuilder to write types and remove dead code
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2972463003 .
2017-07-01 12:03:44 -07:00
d31ed8690e
Capture imports on copy; update imports on paste
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2939593002 .
2017-07-01 12:02:30 -07:00
238894eb76
Stop using ExecutableElement.localVariables in RenameClassMemberRefactoringImpl.
...
This is the only / last usage in Analysis Server.
And this change fixes 3 failing tests.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2961363003 .
2017-06-30 11:58:15 -07:00
6248df44a6
Add the tests of the spec generator to the unit tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2966623003 .
2017-06-30 10:08:51 -07:00
10fa170d66
Add null check before returning postfix expansion
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2966813002 .
2017-06-30 09:43:51 -07:00
99cc563718
Update the spec to deprecate fileStamp
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2964653002 .
2017-06-30 08:21:47 -07:00
d1bb233f52
Remove timeStamp from the ChangeBuilder API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2962223002 .
2017-06-29 13:48:46 -07:00
f6b7fd307a
Pass target elements being renamed into validator.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2963173002 .
2017-06-29 13:42:01 -07:00
077b6b687d
Remove incremental: logger, validator, options.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2968473002 .
2017-06-29 11:51:12 -07:00
8f5c21ea68
Use SearchEngine.membersOfSubtypes() instead of actual elements in ImplementedComputer.
...
This makes 'implemented' notification 10x faster for files with
many types and implemented methods, like visitor.dart - from 400 ms
down to 36 ms. Still not as fast as I would like, but much better.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2955313003 .
2017-06-29 10:11:26 -07:00
b3fe985371
Use AnalysisDriver.getCachedResult() for 'implemented' notification.
...
In general case we cannot use getResult() in this notification.
We generate these notifications after analysis is complete in scheduler.
But if there is no cached result, getResult() will schedule analysis.
So, we might get into a loop.
In practice this worked, because IDEA always makes files priority,
so their results cached, and then subscribes for notifications.
But in general case we need this protection.
This also means that the 'implemented' notification works (and will
work) only for priority files.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2965533002 .
2017-06-29 09:57:20 -07:00
256d6fa704
Remove the stale test for discarding notifications.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2961173002 .
2017-06-28 14:27:38 -07:00
e0f4c7b467
Report only private members in the same library as overrides.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2959273002 .
2017-06-28 13:47:33 -07:00
911263f240
Remove the old index.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2963773003 .
2017-06-28 13:44:05 -07:00
2b64bbed6a
Add SearchEngine.membersOfSubtypes().
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2962023002 .
2017-06-28 11:44:48 -07:00
7bd9e6c443
Add a mixin for assists similar to that for fixes
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2956353002 .
2017-06-28 11:44:22 -07:00
6248e7cab2
Add support code to make fixes easier in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2962903002 .
2017-06-28 10:52:06 -07:00
9ddb832e10
Generate constants in server as we do in plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2960073002 .
2017-06-28 08:21:33 -07:00
a2f18fdb73
Fixes and tests for adding library imports.
...
R=brianwilkerson@google.com , pquitslund@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/1119
Review-Url: https://codereview.chromium.org/2955913002 .
2017-06-26 13:16:19 -07:00
8c50e08e64
Add integration tests for postfix serer api
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2961683002 .
2017-06-26 13:13:21 -07:00
4c8e1b9132
Update coverage.md
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2960683002 .
2017-06-26 11:21:50 -07:00
c26c2774ca
This defines some postfix completion templates for use in the IntelliJ editor.
...
R=brianwilkerson@google.com
To use it, you'll need a version of the Dart plugin with this PR patched in:
https://github.com/JetBrains/intellij-plugins/pull/534
Review-Url: https://codereview.chromium.org/2917943002 .
2017-06-26 09:53:02 -07:00
Konstantin Shcheglov