Commit Graph

4090 Commits

Author SHA1 Message Date
Florian Loitsch ff1d7488d9 Fix patch errors.
Review-Url: https://codereview.chromium.org/2853813002 .
2017-05-01 15:57:40 +02:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d.
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
2017-05-01 08:28:10 +02:00
danrubel c8784af933 rename .analysis_options --> analysis_options.yaml
See https://github.com/dart-lang/sdk/issues/28385

R=brianwilkerson@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2839383003 .
2017-04-30 18:33:10 -04:00
Brian Wilkerson 725261ecdd Add support for recording a log file during tests
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2851833003 .
2017-04-28 16:47:00 -07:00
jpaulsen 6ff38127d6 New Lint quick-fix: await_only_futures (#29490) 2017-04-28 14:00:52 -07:00
jpaulsen ddd9bb1be2 New Lint quick-fix: avoid_annotating_with_dynamic (#29489)
New Lint quick-fix: avoid_types_on_closure_parameters
2017-04-28 13:40:51 -07:00
pq 37dbc98df8 Fix null default value access (#29512).
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Fixes: #29512
Review-Url: https://codereview.chromium.org/2844323004 .
2017-04-28 11:33:34 -07:00
pq fa318bf1c7 Fix VERBOSE_FLUTTER_COMPLETIONS flag.
(Mis-defined as an option when it should be an arg flag.)

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2854453002 .
2017-04-28 11:20:05 -07:00
Brian Wilkerson e55812a3f2 Unify the server and plugin versions of the generators
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2844273003 .
2017-04-28 07:46:29 -07:00
pq daa399499d Fix following comma detection in code completion (#29503).
BUG=
R=brianwilkerson@google.com

Fixes: https://github.com/dart-lang/sdk/issues/29503
Review-Url: https://codereview.chromium.org/2849703002 .
2017-04-27 16:52:33 -07:00
pq efb5c5ddc5 Trailing commas for named args in Flutter cons invocations (flutter-intellij#551).
* adds trailing commas to named params in Flutter instance creations
* adds trailing commas to default value boilerplate

See https://github.com/flutter/flutter-intellij/issues/551 for action shots. :)

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2850693002 .
2017-04-27 14:58:02 -07:00
jpaulsen f929ab15e7 New Lint quick-fix: empty_statements (#29491) 2017-04-27 14:10:17 -07:00
Brian Wilkerson 51dd0538ea Guard against files that are not being analyzed (issue 29493)
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2844413002 .
2017-04-27 14:10:06 -07:00
pq e02902578b Fix selectionOffset testing.
Follow-up from: https://codereview.chromium.org/2839273002/.

BUG=
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2848643003 .
2017-04-27 10:54:24 -07:00
Brian Wilkerson d98d672c16 Add completion support for plugins.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842243003 .
2017-04-27 10:26:46 -07:00
pq ef60d4b46e IML updates for 2017.
BUG=
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2852483003 .
2017-04-27 10:17:39 -07:00
pq bfc071e515 Named arg completion fixes.
Related to: https://github.com/flutter/flutter-intellij/issues/551

* fixes named arg selection offset to precede comma
* fixes inconsistent trailing commas between completions w/ and w/o prefixes

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2839273002 .
2017-04-27 10:12:47 -07:00
Max Kim a211c5e4e7 Add stopgap for angular autocompletion.
Autocompletion for angular

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2835053005 .
2017-04-26 15:48:17 -07:00
jpaulsen 404f9a806c New Lint quick-fix: prefer_conditional_assignment (#29473) 2017-04-26 12:56:36 -07:00
jpaulsen ff46777c61 New Lint quick-fix: unnecessary_override (#29472) 2017-04-26 12:56:26 -07:00
Dan Rubel 3b790e5311 new TokenType and Keyword API
This adds two new methods and adapts most of the old references
to use these new API. Once all call sites have been updated,
the old API can be removed.

This is part one of https://codereview.chromium.org/2842643004/

* replace type == TokenType.KEYWORD with type.isKeyword
* change Keyword.syntax --> Keyword.lexeme

R=paulberry@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2842213003 .
2017-04-26 15:53:58 -04:00
Brian Wilkerson 207fffe067 Send re-analyze requests to plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2843093002 .
2017-04-26 12:36:26 -07:00
Brian Wilkerson 65f492a043 Add support for watch events and error notifications
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842013003 .
2017-04-26 09:36:26 -07:00
jpaulsen 7979eadef0 New Lint quick-fix: unnecessary_this (#29469) 2017-04-25 16:40:01 -07:00
jpaulsen b90aad2b2e New Lint quick-fix: unnecessary_lambdas (#29459) 2017-04-25 16:14:58 -07:00
Steve Messick 17360ffa6d Add colon to switch cases and default
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2837063003 .
2017-04-25 11:13:54 -07:00
Paul Berry a3311858a7 Introduce initial plumbing for type promotion in fasta.
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2829223007 .
2017-04-25 09:06:51 -07:00
Steve Messick 8c2aae7dee Fix detection of bad catch-clauses and try-statements
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842523002 .
2017-04-24 12:00:14 -07:00
jpaulsen dcba4b42cd New Lint quick-fix: prefer_collection_literals (#29378) (#29427) 2017-04-24 10:49:25 -07:00
Brian Wilkerson a81dac8288 Minor clean-up and bug fix
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2836953002 .
2017-04-24 08:49:01 -07:00
Erik Corry 2fb5d08102 Spelling a
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2841543002 .
2017-04-24 14:53:51 +02:00
Brian Wilkerson 5695e95902 Add support for three more plugin requests
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2834993002 .
2017-04-22 09:02:30 -07:00
Steve Messick 00d04dda08 Add special completion for control-flow block exits
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2834913002 .
2017-04-21 14:51:45 -07:00
Konstantin Shcheglov d780f10d72 Remove ReferencedNames(Builder).
Nobody uses them anymore, so there is no point in computing it.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2835703002 .
2017-04-21 14:28:53 -07:00
Konstantin Shcheglov e24b9c218d Remove the limited invalidation feature.
So, we remove IncrementalCompilationUnitElementBuilder, which was one
of the places that potentially modifies element models.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2834773003 .
2017-04-21 12:09:28 -07:00
Konstantin Shcheglov bd76de48ca Pass FileSystemState into FileTracker.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2828163006 .
2017-04-21 10:53:31 -07:00
Brian Wilkerson 4e3d3bdd9f Add support for converting from server to plugin protocol objects
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2830903004 .
2017-04-21 08:37:12 -07:00
Paul Berry 77d26a330c Add top level type inference logic for integer literals.
This CL hooks up enough infrastructure for doing simple top level type
inference of variables whose initializer is an int.

Additional type inference rules will be added in follow-up CLs.

R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2828253003 .
2017-04-21 04:38:18 -07:00
Steve Messick 6407af5dcb Clean up TODOs
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2830793007 .
2017-04-20 15:19:16 -07:00
Brian Wilkerson aa36e43426 Add plugin support for getAssists
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2832643005 .
2017-04-20 13:52:34 -07:00
Steve Messick b9c214f374 Compete try-statements
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2834513004 .
2017-04-20 13:09:23 -07:00
Brian Wilkerson e1a2c81d0b Update PluginWatcher to be more efficient
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2830933005 .
2017-04-20 12:39:50 -07:00
Brian Wilkerson 913560afb1 Enable missed tests
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2827353002 .
2017-04-20 11:30:36 -07:00
Brian Wilkerson f8e18d0888 Revert "Update PluginWatcher to be more efficient"
Review-Url: https://codereview.chromium.org/2834673002 .
2017-04-20 10:53:03 -07:00
Brian Wilkerson a3697af085 Update PluginWatcher to be more efficient
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2830063002 .
2017-04-20 09:25:37 -07:00
Brian Wilkerson ba3ed4ba37 Initial support for getting fixes from plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2830863002 .
2017-04-19 15:00:00 -07:00
Steve Messick 0829174516 Complete for-each and switch statements
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2826283002 .
2017-04-19 14:44:41 -07:00
Konstantin Shcheglov 91d6dcf9fb We cannot use relative URIs to reference files outside of a package.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2830733002 .
2017-04-19 10:09:14 -07:00
Erik Corry 23c0caf4dc Revert "New Lint quick-fix: prefer_collection_literals (#29378)"
This reverts commit 6a56c86c81.
This a gardener revert to fix buildbot redness.

R=karlklose@google.com, loitsch@google.com
TBR=casanueva@google.com
BUG=

Review-Url: https://codereview.chromium.org/2827863003 .
2017-04-19 12:49:07 +02:00
jpaulsen 6a56c86c81 New Lint quick-fix: prefer_collection_literals (#29378) 2017-04-18 18:55:08 -07:00