dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

4090 Commits

Author SHA1 Message Date
Devon Carew 4afc0aeb73 Fix some analysis issues. 
BUG=
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2882003002 .
 2017-05-13 16:24:47 -07:00
Devon Carew f6f98576ef Misc fixes to the analysis server spec. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2878273002 .
 2017-05-13 14:10:28 -07:00
Brian Wilkerson 3085734ef6 Generate common types into a separate library 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2880443006 .
 2017-05-13 08:12:14 -07:00
Paul Berry f4d3f6cf45 Remove .iml files from the repository. 
These files weren't providing enough benefit compared to the confusion
they were causing by showing up frequently in diffs.

R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2878103002 .
 2017-05-12 15:06:18 -07:00
Konstantin Shcheglov a4fd5d814f Extract PerformanceLogger from AnalysisDriver. 
I also added the runAsync().

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2883633002 .
 2017-05-12 14:27:50 -07:00
Paul Berry b5bc14c0b4 Begin writing a TypeInferenceListener interface. 
In the long term, this is intended to be used to communicate the
results of type inference from the front_end to analyzer.  In the
short term, it can be used to debug type inference (by uncommenting
the print statements in type_inference_listener.dart).

R=scheglov@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2878733006 .
 2017-05-12 13:31:26 -07:00
danrubel 98825b4918 improve code completion abort request tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2876793006 .
 2017-05-12 13:28:39 -07:00
danrubel 69cc6c3183 convert completion tests to use new analysis driver 
Update more tests and remove dead code from tests

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2875223003 .
 2017-05-12 11:48:20 -07:00
Konstantin Shcheglov bdedd6768b Add a way to use shared CanonicalName root to deserialize Program. 
This allows for example to add SDK into a Program, then load the
"incomplete" Program A that has only the library A, and name sequences
that references SDK classes. Because we look into the nameRoot which
aleady has SDK CanonicalName(s), we can find these names while filling
the link table and use references which point to the existing SDK
AST nodes.  Then we can load another set of library cycles, etc.

At the end we have a set of self-consistent libraries that we can
feed into DillTarget/DillLoader and resolve anothersource target
against it.

This CL is based on https://codereview.chromium.org/2872903005/
which has not been reviewed yet.

R=kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2874723002 .
 2017-05-12 10:42:08 -07:00
Brian Wilkerson bef53e72e4 Remove unintentional dependency on analysis_server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2875323002 .
 2017-05-12 10:07:37 -07:00
Mike Fairhurst e9edd2e568 Fix pubspecs for new analyzer plugin arch dependencies 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2877863002 .
 2017-05-11 14:37:46 -07:00
pq dc64c43480 Unused import cleanup. 
BUG=
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2876913002 .
 2017-05-11 14:08:47 -07:00
danrubel 66bb2d618e Remove unused analysisContext from completion request and contributors 
Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.

R=brianwilkerson@google.com, pquitslund@google.com

Review-Url: https://codereview.chromium.org/2877653002 .
 2017-05-11 09:38:50 -07:00
danrubel 6798cdfcd1 cleanup dart code completion contributors 
Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.

DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2873943003 .
 2017-05-11 09:12:36 -07:00
Brian Wilkerson 3b2c3ae5b2 Add support for built-in plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2874803003 .
 2017-05-10 13:31:20 -07:00
Steve Messick 55097a44b3 Recover from merge problem 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2868383002 .
 2017-05-10 13:12:14 -07:00
Brian Wilkerson a3ac4253b1 Remove an obsolete error from the spec and an obsolete command-line flag 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2865403005 .
 2017-05-10 09:33:43 -07:00
Brian Wilkerson 2a4772a537 Remove unnecessary tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2868233003 .
 2017-05-10 09:15:36 -07:00
Brian Wilkerson e6c8092cea Enable analysis driver in tests where possible 
R=danrubel@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2868353002 .
 2017-05-10 09:13:25 -07:00
danrubel 5b969e04f9 enable new analysis driver for completion sorter tests 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2875483002 .
 2017-05-09 16:54:43 -07:00
Brian Wilkerson 947413addc Remove an obsolete flag from test support 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2875433002 .
 2017-05-09 16:39:57 -07:00
Brian Wilkerson fbc3f3708d Remove unused reference to SearchEngine 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2872803003 .
 2017-05-09 14:32:12 -07:00
Brian Wilkerson 1f893e86a9 Clean up some warnings 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2874443003 .
 2017-05-09 13:07:06 -07:00
Brian Wilkerson 98e8f17b96 Convert server to use RangeFactory 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2869083002 .
 2017-05-09 10:08:14 -07:00
Konstantin Shcheglov bd1ee32543 Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/. 
We are going to reuse ByteStore in front_end, also for incremental
compilation.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2869803004 .
 2017-05-09 09:12:15 -07:00
pq 11558c8a90 Add trailing commas after Flutter instance creation params fixes (flutter-intellij/#f978). 
R=brianwilkerson@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/978
Review-Url: https://codereview.chromium.org/2864373003 .
 2017-05-09 07:00:15 -07:00
Paul Berry 4eee6cb5ea Fix constructor invocation type inference. 
Three problems are fixed:

- I forgot to pass the `downwards` flag when doing downwards inference.

- I forgot to initialize the `formalTypes` and `actualTypes` arrays.

- I wasn't tracking whether constructor type arguments were implicit
  or explicit, so constructor type inference wasn't actually
  happening.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2864853002 .
 2017-05-08 14:41:56 -07:00
danrubel bc310f5f1f cleanup KeywordContributor 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2871443003 .
 2017-05-08 10:03:39 -07:00
danrubel 959b7c14b8 improve completion for formal param initializers 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2864233002 .
 2017-05-08 06:50:46 -07:00
danrubel eb15a4c7c9 add constructor initializer completions 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2869653002 .
 2017-05-08 05:52:12 -07:00
Brian Wilkerson 6b8a56cd7f Switch the default from non-driver to driver in several tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2864813002 .
 2017-05-07 08:34:16 -07:00
P.Y. Laligand 21e9c40b8f Disable analysis on a few packages. (#29571) 2017-05-05 22:06:00 -07:00
Brian Wilkerson 863bd921e1 Remove the non-driver versions of several tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2863593004 .
 2017-05-05 13:46:03 -07:00
Brian Wilkerson 0b59d3f650 Convert some tests to use the driver and prepare for others to be converted 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2859993004 .
 2017-05-05 13:20:38 -07:00
Brian Wilkerson d2bbfb4f77 Make an AstProvider available to AssistProcessors 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2862143003 .
 2017-05-05 09:24:30 -07:00
Brian Wilkerson 6c2023bd07 Move ChangeBuilder to analyzer_plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2860383002 .
 2017-05-05 07:52:27 -07:00
Brian Wilkerson 0d2bfea054 Remove the use of CorrectionUtilities 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2866603002 .
 2017-05-05 06:06:57 -07:00
pq 1a394e975f Specify types in generated closure args. 
Follow-up from: https://github.com/flutter/flutter-intellij/issues/975

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2863683002 .
 2017-05-04 12:54:23 -07:00
Devon Carew f6f845c879 Fix a completion exception during import suggestions. 
BUG=
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2862793002 .
 2017-05-04 09:24:18 -07:00
Brian Wilkerson 4a9092d9c9 Change the ChangeBuilder API to use SourceRange 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2856233003 .
 2017-05-04 08:49:01 -07:00
Konstantin Shcheglov b567aeaeef Change Accessor(s) to use AstFactory to create MethodInvocation, PropertyGet/Set. 
R=ahe@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2857133004 .
 2017-05-03 14:10:54 -07:00
pq 374871da75 Add default implementation when fixing missing required closures (flutter-intellij#975) 
Fixes: https://github.com/flutter/flutter-intellij/issues/975

Also improves code generation for required lists to include empty list literals.

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2862623002 .
 2017-05-03 13:22:52 -07:00
Brian Wilkerson 78eec999e5 Fix a broken test (TBR) 
Review-Url: https://codereview.chromium.org/2861593003 .
 2017-05-03 13:21:00 -07:00
Paul Berry d842f35bb2 Add a strong mode implementation of LUB to fasta; use it to infer ?: 
R=ahe@google.com, leafp@google.com

Review-Url: https://codereview.chromium.org/2849213002 .
 2017-05-03 10:36:47 -07:00
Lasse R.H. Nielsen 7998f590b1 Update documentation on trignometric functions. 
Fixes #17515
BUG= http://dartbug.com/17515
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/40220ec0766bb2b179d3623d3f298223df842279
Review-Url: https://codereview.chromium.org/2852053002 .
 2017-05-03 09:49:14 +02:00
pq a51af38461 Widget details for Flutter children: param completions. 
R=brianwilkerson@google.com

See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2855883003 .
 2017-05-02 13:50:34 -07:00
Brian Wilkerson 9eee213363 Fix bugs found while working on tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2849253002 .
 2017-05-02 06:15:25 -07:00
Konstantin Shcheglov 37092ed677 New tests and improvements for generics in comments parsing. 
R=ahe@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2856463004 .
 2017-05-01 12:52:09 -07:00
Steve Messick 28b7710190 Complete declarations; detect invalid blocks 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2852073002 .
 2017-05-01 08:45:41 -07:00
Florian Loitsch 05e0e1ea40 Revert trigonometric function updates. 
The VM has a fingerprint on the function and failed during compilation.

Revert "Fix patch errors."

This reverts commit ff1d7488d9.

Revert "Update documentation on trignometric functions."

This reverts commit 40220ec076.

BUG=

Review-Url: https://codereview.chromium.org/2851163003 .
 2017-05-01 16:06:56 +02:00