dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2317 Commits

Author SHA1 Message Date
Jakob Roland Andersen ce4d332255 Revert "Migrated test batch 123 to Dart 2.0." 
This reverts commit 594e6cf010.

Reason for revert: Apparently, label_test failed on macOS/Windows, but not on Linux.

Original change's description:
> Migrated test batch 123 to Dart 2.0.
> 
> Bug:
> Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> Reviewed-on: https://dart-review.googlesource.com/4800
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=jakobr@google.com,floitsch@google.com

Change-Id: I7cec6458621920229e61133f868566ee65784269
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5181
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-12 14:03:11 +00:00
Jakob Roland Andersen 594e6cf010 Migrated test batch 123 to Dart 2.0. 
Bug:
Change-Id: I780329831dc189add7b192faf85161659a4a8b53
Reviewed-on: https://dart-review.googlesource.com/4800
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-12 13:28:37 +00:00
Emily Fortuna 553e4a0967 Don't make field entities for variables in boxes. 
Bug:
Change-Id: Ie31e88438da93a1d54c8c688a5ccd212bb81bb28
Reviewed-on: https://dart-review.googlesource.com/4241
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-09-11 23:32:51 +00:00
pq 2fbb267460 Revert "Migrate test block 152 to Dart 2.0." [TBR]. 
This reverts commit 9744f5d212.

Change-Id: I1299f0e9ea14c776c315dd8439bd9ab255d9060b
Reviewed-on: https://dart-review.googlesource.com/5001
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-11 18:24:16 +00:00
pq 9744f5d212 Migrate test block 152 to Dart 2.0. 
Change-Id: Iad60c7a650595703b0a0109d15d8971a4c209d84
Reviewed-on: https://dart-review.googlesource.com/3701
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-11 17:11:17 +00:00
Jakob Roland Andersen e40219d4f8 Migrated test batch 124 to Dart 2.0. 
Bug:
Change-Id: Ic6c699caadddb59b6615490a9360fd3bd8891230
Reviewed-on: https://dart-review.googlesource.com/4760
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-09-11 13:50:51 +00:00
Jakob Roland Andersen b321ef2e84 Migrated test batch 125 to Dart 2.0. 
Bug:
Change-Id: I1f4ca70c1988bacf35e1834a3e31afc084b9b291
Reviewed-on: https://dart-review.googlesource.com/4741
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-09-11 13:49:51 +00:00
Harry Terkelsen d1a34a2c7f add type variables for all classes in the hierarchy for a constructor 
Change-Id: I4c8df08e5893297c0d662bec469c8e06992369cf
Reviewed-on: https://dart-review.googlesource.com/4605
Commit-Queue: Harry Terkelsen <het@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-08 23:19:20 +00:00
Jennifer Messerly e2a92e1207 fix status of void_type_function_types_test 
The Analyzer and DDC buildbots were broken by:
https://github.com/dart-lang/sdk/commit/d76f041ace06af3048a37359a76dff47722ad853

This should get them green again.

Change-Id: I8a99a9a7a7cef9bf031465100bd8a5359e6ca9cd
Reviewed-on: https://dart-review.googlesource.com/4611
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-08 22:52:38 +00:00
Beeravolu Siva Chandra Reddy 2f096249a2 Adjust status file to get the dart2js-d8-minified bot green. 
Change-Id: I35b317f2213a3de3bd3fa92644516a399687662d
Reviewed-on: https://dart-review.googlesource.com/4480
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-08 14:25:38 +00:00
Bob Nystrom 9f69c7ddac Fix dart2js status for bad_constructor_test. 
Change-Id: If73a6d6cf3dd92cfc5b48ed031cff815575e32c7
Reviewed-on: https://dart-review.googlesource.com/4281
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-08 00:07:26 +00:00
Bob Nystrom c8aa62fe80 Fix bad_constructor_test. 
This reintroduces the previously-tested behavior (that a named
constructor can have the same name as a setter) and also cleans it up
and documents it.

Change-Id: Ia4d532a26e081ab150dfd073d1e6909f1b53a9ad
Reviewed-on: https://dart-review.googlesource.com/3386
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-07 20:31:00 +00:00
Bob Nystrom bd2a7a7993 Migrate 119. 
Change-Id: Ie62df46d0fcf745ac45f693abf392040fda9e6c1
Reviewed-on: https://dart-review.googlesource.com/3426
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-07 20:29:15 +00:00
Bob Nystrom f1e81f9014 Migrate 118. 
Change-Id: I7e520ef997291301b41c351b9f45ea3e9da74c37
Reviewed-on: https://dart-review.googlesource.com/3424
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-07 20:14:09 +00:00
Harry Terkelsen 607e3ecd69 Fixed the test by checking if typedefs are malformed. 
This prevents the getFunctionTypeOfTypedef call from failing in
checked mode by returning a MalformedType.

Revert "Revert "Add types referenced in is-checks to the class hierarchy""

This reverts commit e0a4839c3e.

Change-Id: I1e94ba5ba345c36e04e54da6e8c0580a21836838
Reviewed-on: https://dart-review.googlesource.com/3422
Reviewed-by: Harry Terkelsen <het@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-07 19:56:26 +00:00
Emily Fortuna d7e28e386d Make constructor entities and constructor body entities share the same locals map lookup. 
Bug:
Change-Id: Icdd1bfe64aaa0e2362d71f005a1037d1ab947402
Reviewed-on: https://dart-review.googlesource.com/3425
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-07 18:10:35 +00:00
Emily Fortuna 362cc88229 IMPORT COMBINATORS NEGATIVE TEST CAN'T RUN WITHOUT MAIN. 
Change-Id: I1177f323568aa1d3c91dfe7de92ba7f72366abae
Reviewed-on: https://dart-review.googlesource.com/3795
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-07 01:23:24 +00:00
Stephen Adams fa72248b75 Update dart2js kernel status again 
TBR=efortuna@google.com

Bug:
Change-Id: Ibe400980b8c8b99645eb02820a4718fde7500ef5
Reviewed-on: https://dart-review.googlesource.com/3821
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-07 00:43:54 +00:00
Emily Fortuna 14bbc64098 LANGUAGE 2 OMG STATUS. 
Change-Id: Ie6fe85905b2f493c3d42ff03598da74f2b9339e0
Reviewed-on: https://dart-review.googlesource.com/3820
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-07 00:20:22 +00:00
Bob Nystrom e9255446b3 Migrate block 117. 
Change-Id: Ie2f7d2b93120dc2f2fbef6d1c01604d240ecc7da
Reviewed-on: https://dart-review.googlesource.com/3420
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-06 23:32:58 +00:00
Stephen Adams eacbac7f90 Update dart2js kernel status 
TBR=efortuna@google.com

Change-Id: Ie25df9f9efe6093bc3c55d254a868ca093b95ee6
Reviewed-on: https://dart-review.googlesource.com/3789
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-06 23:21:41 +00:00
Emily Fortuna 0a36b589be Update test statuses from c019 tests. 
TBR

Bug:
Change-Id: I7e3c9ae36aae8bfd1bf9a2355ba8a65904d90106
Reviewed-on: https://dart-review.googlesource.com/3780
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-06 22:23:58 +00:00
Harry Terkelsen e0a4839c3e Revert "Add types referenced in is-checks to the class hierarchy" 
This reverts commit a577b303f0.

Bug:
Change-Id: I8a02bf3ef559de8af62aef9d4b7e840975bb5b47
Reviewed-on: https://dart-review.googlesource.com/3343
Reviewed-by: Harry Terkelsen <het@google.com>
 2017-09-05 23:13:29 +00:00
Jennifer Messerly 0d8d1af67f fix #30601, covariant checks for bounds were not working in some cases 
This has a few related fixes:

fix #30461, DDC now generates covariant checks for superclasses with the correct substitution.

fix #29483, Analyzer can resolve the function type literal syntax correctly when used in type bounds and type arguments.

fix #30095, replace use of DDC's StrongModeError private type with TypeError.

It also has some refactoring to simplify how DDC emits the initialization code at the start of function/method bodies. We no longer jump through AST parent pointers.

Change-Id: I7001f98cd0e00299d77bace49e19aca305abf224
Reviewed-on: https://dart-review.googlesource.com/3100
Reviewed-by: Leaf Petersen <leafp@google.com>
 2017-09-05 22:44:19 +00:00
Harry Terkelsen a577b303f0 Add types referenced in is-checks to the class hierarchy 
Change-Id: Ia250501052efc051779f75f9d582c1ceaa2c78f4
Reviewed-on: https://dart-review.googlesource.com/3384
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-05 21:53:35 +00:00
Stephen Adams 080169c51a dart2js kernel: sort constants 
reviewed: https://codereview.chromium.org/3011803002

TBR=sigmund@google.com

Change-Id: Ic444964c3d5995d12e4e00f0af44c175533b7291
Reviewed-on: https://dart-review.googlesource.com/3340
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-05 20:30:43 +00:00
Stephen Adams 87f127e639 dart2js kernel status updates 
- remove duplicates and dead language tests and update crash reasons

Bug:
Change-Id: I5027548fa0f8bd692d7013fab37bfc89fc66f315
Reviewed-on: https://dart-review.googlesource.com/3307
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-05 18:27:06 +00:00
Harry Terkelsen bb312921ac Revert "Add types referenced in is-checks to the class hierarchy" 
This reverts commit c8d2478747.

BUG=

Review-Url: https://codereview.chromium.org/3012733002 .
 2017-09-01 15:27:28 -07:00
Harry Terkelsen c8d2478747 Add types referenced in is-checks to the class hierarchy 
R=johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/3011793002 .
 2017-09-01 15:02:59 -07:00
Emily Fortuna b1dd578da7 Don't try to add abstract methods to the codegen work queue to generate bodies 
BUG=
R=johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/3012683002 .
 2017-09-01 10:21:03 -07:00
Emily Fortuna 4e10f68d2c Updated generic_methods_local_variable_declaration_test status. 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3004263002 .
 2017-09-01 10:08:09 -07:00
Johnni Winther 374df045e7 Handle forwarding constructors to unnamed mixin applications 
+ handle instance fields from mixins
+ change class sorting to put unnamed mixin applications last

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3005823002 .
 2017-09-01 19:07:02 +02:00
Emily Fortuna 5fb24d38ca Clean up status language2 status file. 
BUG=
R=kevmoo@google.com, sra@google.com

Review-Url: https://codereview.chromium.org/3011723002 .
 2017-08-31 12:16:31 -07:00
Emily Fortuna ea038bd8e0 Pass in this as a free variable to the closure class 
BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3009903002 .
 2017-08-31 10:41:19 -07:00
Paul Berry 991ea77f32 Additional test cases related to bug #30568 
These test cases verify that when a method calls super, compile-time
arity checks are performed against the actual target of super, rather
than the interface exposed by the base class.

R=lrn@google.com

Review-Url: https://codereview.chromium.org/3005893002 .
 2017-08-31 13:10:00 -04:00
Peter von der Ahé f0277b32e8 Revert "Store actual Reference(s) for additional exports." 
This reverts commit 234c4a7f49.

Revert "Fix for ScopeBuilder[] - look into setters too."

This reverts commit 7924f4c42f.

Revert "Don't include BuiltinTypeBuilder(s) into additional exports."

This reverts commit e28aac09c4.

The reason for reverting is that the two follow-up commits aren't correct.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3004973002 .
 2017-08-31 16:13:50 +02:00
Stephen Adams 9bc8e5932a Update dart2js kernel status in language and language_2 
TBR=sigmund@google.com

Review-Url: https://codereview.chromium.org/3005933002 .
 2017-08-30 15:51:29 -07:00
Janice Collins e31e611101 Fix many bots. 
This covers the following cases:

python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/bad_constructor_test/05
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/closures_with_complex_params_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_async_star_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_async_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_field_mixin6_test/01
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_field_mixin6_test/none
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_function_typedef_test/01
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_method_types_test/01
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_method_types_test/02
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/typecheck_multifield_declaration_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/unused_overridden_async_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/allocation_sinking_vm_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language/reexport_core_test
python tools/test.py -m release -c dartk language_2/bad_constructor_test/05
python tools/test.py -m release -c dartk language/reexport_core_test

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/3005863003 .
 2017-08-30 14:55:29 -07:00
Janice Collins ea523a59b7 More bot breakage fixes, covering these cases: 
python tools/test.py -m release -c dart2js -r d8 --checked --minified --fast-startup --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/async_await_catch_stacktrace_test
python tools/test.py -m release -c dart2js -r d8 --minified --fast-startup --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/async_await_catch_stacktrace_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/async_await_catch_stacktrace_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/typedef_is_test
python tools/test.py -m release -c dart2js -r d8 --minified --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/async_await_catch_stacktrace_test

BUG=
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/3011653002 .
 2017-08-30 13:14:57 -07:00
Janice Collins 05f9c0e255 Fix type_variable_promotion_test on dart2js-with-kernel. 
BUG=
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/3010753003 .
 2017-08-30 13:08:29 -07:00
Janice Collins 3a8a1ca54c Migrate test block 113 to Dart 2.0. 
Request particular attention to generic_creation_test and generic_field_mixin6_test, but all of the following required tweaks
to the status files to pass tests:

generic_closure_test
generic_function_bounds_test
generic_function_dcall_test
generic_function_typedef_test
generic_field_mixin6_test
generalized_void_syntax_test
generic_functions_test

BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/3008573002 .
 2017-08-30 08:50:16 -07:00
Janice Collins fe7c2acd4e Migrate block 163 to Dart 2.0. 
Interesting tests requiring status file or other changes:

type_variable_promotion_test
type_variable_scope_test
type_variable_static_context_negative_test - changed from negative to compile-time error
unresolved_top_level_method_negative_test - changed from negative to compile-time error
unary_plus_negative_test
unhandled_exception_negative_test
unbound_getter_test
unresolved_in_factory_negative_test -
unresolved_top_level_var_negative_test - changed from negative to compile-time error
unresolved_top_level_method_negative_test - changed from negative to compile-time error
vm/async_await_catch_stacktrace_test

BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/3008723002 .
 2017-08-30 08:05:12 -07:00
Bob Nystrom 0cae5b30fc Migrate over the status for closure_cycles_test. 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/3008863002 .
 2017-08-29 16:29:27 -07:00
Emily Fortuna 98e36f719e Add boxing for modified variables 
BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/3007743002 .
 2017-08-29 16:27:28 -07:00
Bob Nystrom a719910d78 Migrate block 116. 
Interesting bits:

- Removed some behavior that is now unreachable in the presence of
  type errors.
- Made if_null_behavior_test not a multitest since it doesn't need to
  be any more.
- Likewise, if_null_evaluation_order_test never needed to be a
  multitest.

R=lrn@google.com

Review-Url: https://codereview.chromium.org/3003933002 .
 2017-08-29 15:50:49 -07:00
Stephen Adams 4449ec4f89 dart2js kernel: Handle ir.LocalInitializer 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3009803003 .
 2017-08-29 15:45:37 -07:00
Paul Berry b8e54ea418 Add language_2 tests demonstrating bug #30568 
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/3008823002 .
 2017-08-29 15:09:23 -07:00
Bob Nystrom ebac83c3de Mark new test as failing on DDC to get the bots green again. 
Review-Url: https://codereview.chromium.org/3011553003 .
 2017-08-29 14:39:35 -07:00
Paul Berry 804bcabcc1 Add a test of the runtime type of a tearoff that uses a covariant generic parameter. 
This case has caused some confusion so I thought it would be nice to
have an explicit test case for it.

R=leafp@google.com

Review-Url: https://codereview.chromium.org/3012443003 .
 2017-08-29 10:50:42 -07:00
Alexander Aprelev 340957c8b0 Update one more dartkp test status to make vm-kernel fyi bots green. 
TBR=siva

Review-Url: https://codereview.chromium.org/3005783002 .
 2017-08-29 06:25:16 -07:00