dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2317 Commits

Author SHA1 Message Date
Johnni Winther 1fc47782e9 Update --dart2js-with-kernel status 
Review-Url: https://codereview.chromium.org/3006773002 .
 2017-08-29 11:39:41 +02:00
Stephen Adams 043708d48c Avoid Element-only assertions in generateParameterStubs 
TBR=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3008753002 .
 2017-08-28 21:23:19 -07:00
Alexander Aprelev 54289e128d Follow with few more dartk test status updates 
BUG=

TBR=asiva

Review-Url: https://codereview.chromium.org/3010603002 .
 2017-08-28 20:21:47 -07:00
Stephen Adams 0046325ebd Resort dart2js kernel status 
TBR=sigmund@google.com

Review-Url: https://codereview.chromium.org/3007733002 .
 2017-08-28 20:02:16 -07:00
Alexander Aprelev 7cbb96c199 Wholesale update tests status in attempt to make (fyi) dartkp buildbots green. 
Buildbots are here: https://build.chromium.org/p/client.dart.fyi/console.

BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/3000423002 .
 2017-08-28 18:32:21 -07:00
Régis Crelier 678de7d4e6 Mark analyzer status file for new test. 
Review-Url: https://codereview.chromium.org/3011533002 .
 2017-08-28 18:14:24 -07:00
Bob Nystrom 354f6181bf Fix DDC status files. 
- A skip for an unmigrated test was accidentally deleted. Readded it.

- test.dart now handles negative tests correctly for DDC, so fix the
  status entries for those.

Review-Url: https://codereview.chromium.org/3005753002 .
 2017-08-28 17:20:03 -07:00
Régis Crelier b3a7dd6e9d [VM generic function reification] Support generic functions in Invocation class. 
Make VM object TypeArguments a Dart instance.
Add a test verifying that noSuchMethod works with generic functions.

R=floitsch@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/3007603002 .
 2017-08-28 17:00:39 -07:00
Bob Nystrom 46320c5208 Migrate block 115. 
Interesting changes:

- A static getter colliding with an inherited non-static setter is a
  compile error, not a type warning.

- Trying to call a setter on what is only a getter is a compile error
  with no runtime behavior.

- Add support to test.dart for negative tests in DDC.

BUG=
R=jcollins@google.com

Review-Url: https://codereview.chromium.org/3005643002 .
 2017-08-28 16:17:28 -07:00
Emily Fortuna 63754bba71 Add more tests for closures and change closure indexing to be by FunctionExpression or FunctionDeclaration rather than FunctionNode. 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3003963002 .
 2017-08-28 14:24:58 -07:00
Jens Johansen 5624fef4fd Update status file for precompiled 
BUG=
R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/b54bb0cf2762d0652dd127e80413b78fa8772d42
Review-Url: https://codereview.chromium.org/3008673002 .
 2017-08-28 09:00:40 +02:00
Jens Johansen b54bb0cf27 Update status file for precompiled 
BUG=

Review-Url: https://codereview.chromium.org/3008673002 .
 2017-08-28 08:11:13 +02:00
Paul Berry 1cadaf4b80 Add tests demonstrating bugs #30547 and #30552. 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/3010483002 .
 2017-08-26 08:00:07 -07:00
Régis Crelier 343452d43f [gardening] Second attempt (last one this week) at adjusting precompiler status file. 
Review-Url: https://codereview.chromium.org/3011443002 .
 2017-08-25 18:32:29 -07:00
Emily Fortuna fba36729ec Revert "Revert "Reduce use of getClosureInfoForMember and cleanup closure_test"" 
This reverts commit e94ff86b2b.

Reapply Johnni's change with the status file updates.

BUG=

Review-Url: https://codereview.chromium.org/3008603002 .
 2017-08-25 18:14:34 -07:00
Emily Fortuna edd1ebfd6d Adding JRecord and boxing mechanics. 
Well, this introduces a few currently unused classes, but I'm trying to break the other CL up to figure out the source of the problem.

BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/3006653003 .
 2017-08-25 17:11:52 -07:00
Bob Nystrom d9d908170a Fix status for generic_methods_local_variable_declaration_test. 
I hope.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/3008583002 .
 2017-08-25 16:49:50 -07:00
Régis Crelier 10095fa7bc [gardening] Adjust precompiler status file. 
Review-Url: https://codereview.chromium.org/3002403002 .
 2017-08-25 16:31:02 -07:00
Emily Fortuna 9d5e40c74b STATUS FILES!!!! A continuation of https://codereview.chromium.org/3010453002 
BUG=

Review-Url: https://codereview.chromium.org/3006613002 .
 2017-08-25 12:21:17 -07:00
Emily Fortuna d9bfc227c9 Alphabetize the test status files. 
BUG=

Review-Url: https://codereview.chromium.org/3009603002 .
 2017-08-25 10:39:21 -07:00
Emily Fortuna a333af42f0 Boy I hope this is the last status file change after https://codereview.chromium.org/3001803002/ 
BUG=

Review-Url: https://codereview.chromium.org/3010453002 .
 2017-08-25 09:38:45 -07:00
Morten Krogh-Jespersen ef4c7d33b4 Migrating block 59, first commit, after tool has run. 
There were tests that tested only checked mode, having their name on the form xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added to the status file.

R=rnystrom@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/706d4231ea40a41dd80409c3d835fd8ec5fb5dc3
Committed: https://github.com/dart-lang/sdk/commit/da2397acacd46a51e6119d76accd7d4085f31846
Review-Url: https://codereview.chromium.org/2994383002 .
 2017-08-25 14:03:33 +02:00
Morten Krogh-Jespersen da2397acac Migrating block 59, first commit, after tool has run. 
There were tests that tested only checked mode, having their name on the form xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added to the status file.

R=rnystrom@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/706d4231ea40a41dd80409c3d835fd8ec5fb5dc3
Review-Url: https://codereview.chromium.org/2994383002 .
 2017-08-25 13:06:12 +02:00
Morten Krogh-Jespersen 706d4231ea Migrating block 59, first commit, after tool has run. 
There were tests that tested only checked mode, having their name on the form xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added to the status file.

R=rnystrom@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2994383002 .
 2017-08-25 12:10:13 +02:00
Erik Ernst 811ae1855d Adding adjusted void tests from CL 2699073003 
These tests exercise the static and dynamic semantics of `void` used in
those new locations where 'generalized void' added support form it.

They came from CL 2699073003 and were adjusted to match the result of
discussions taken after their creation (in particular, `b ? e1 : e2`
was used and expected to be allowed, but it is now a static warning in
Dart 1.x and a compile-time error in Dart 2).

The tests are located in tests/language_2, and they are testing Dart 2
behavior. In particular, usage of a value of static type `void` is a
compile-time error rather than a static warning, and `void` is
considered equivalent to `Object` in subtype checks, both statically
and dynamically.

We do not currently have any tools which will conform to the
expectations of these tests. Status files have been adjested
accordingly.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2997353002 .
 2017-08-25 10:03:24 +02:00
Emily Fortuna 69e7c53948 More status files updates after https://codereview.chromium.org/3001803002/ 
BUG=

Review-Url: https://codereview.chromium.org/3005583002 .
 2017-08-24 23:44:06 -07:00
Emily Fortuna 51b0320c76 Revert "More test status follow ups from https://codereview.chromium.org/3001803002/." 
Well, clearly this didn't edit the status files I intended and caused more havoc
than was already there. Reverting this and will follow up tomorrow morning.

This reverts commit 5a45aaafc4.

BUG=

Review-Url: https://codereview.chromium.org/3007523004 .
 2017-08-24 23:26:25 -07:00
Emily Fortuna 5a45aaafc4 More test status follow ups from https://codereview.chromium.org/3001803002/. 
BUG=

Review-Url: https://codereview.chromium.org/3005563002 .
 2017-08-24 18:17:09 -07:00
Bob Nystrom 702d6bc354 Fix status of typevariable_substitution2_test in checked mode. 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/3009543002 .
 2017-08-24 14:08:12 -07:00
Bob Nystrom af1d9354b0 Migrate many_generic_instanceof_test to language_2. 
It relies on a utility library that was already moved over, so this
gets it working again.

Review-Url: https://codereview.chromium.org/3008503002 .
 2017-08-24 12:23:32 -07:00
Bob Nystrom 615be6451e Migrate block 114 (and some of 113). 
generic_instanceof ... getter_closure_execution_order_test.

The main interesting one is generic_methods_type_expression_test. It
was testing old Dart 1.0-specific behavior and needed a lot of changes.

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/3001803002 .
 2017-08-24 10:52:29 -07:00
Stephen Adams 6101be55f1 update dart2js kernel status 
I ran update_all after removing entries in the sections (except one since zero entries currently crashes the script)

The function_type tests are turned off in language_2.status for non-strict and non-checked tests.  We should add a checked kernel target when we are a little further.

TBR=sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/3009433002 .
 2017-08-23 18:04:22 -07:00
Stephen Adams 236202382d dart2js kernel status 
TBR=sigmund@google.com

BUG=

Review-Url: https://codereview.chromium.org/3004543002 .
 2017-08-23 17:08:09 -07:00
Stephen Adams 2c6ae26aba update_all: remove user-dependent part of assertion file path 
TBR=sigmund@google.com

Review-Url: https://codereview.chromium.org/3003273002 .
 2017-08-23 16:02:55 -07:00
Stephen Adams 83ea082dd3 Redo "dart2js-kernel: implement native static methods" 
BUG=

Review-Url: https://codereview.chromium.org/2995293002 .
 2017-08-23 14:06:20 -07:00
Alexander Aprelev dff0d004d1 Update dartk test status to make dartk buildbots(vm-kernel-linux-release-x64-checked-be) greener. 
BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/3005473002 .
 2017-08-23 09:10:44 -07:00
Johnni Winther 1658036b05 Share locals between members 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2995113002 .
 2017-08-21 15:02:10 +02:00
danrubel 8df4a4afc2 multi-test for invalid double 
See comment in https://codereview.chromium.org/3002493002/

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2995943002 .
 2017-08-20 13:36:40 -04:00
Jennifer Messerly 386eb10b3d Re-land "fix #30462, update function_type tests to understand covariant generics" 
This has status fixes for VM and dart2js, otherwise the CL is unchanged.

This reverts commit 11f4152712.

R=leafp@google.com

Review-Url: https://codereview.chromium.org/2998013002 .
 2017-08-19 19:52:33 -07:00
Johnni Winther 3c8096e040 Split getClosureRepresentationInfo into MemberEntity and (ir/ast) nodes 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/3002953002 .
 2017-08-19 10:36:49 +02:00
Johnni Winther 6b36ecefe7 Handle labelled breaks 
Closes #30492

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3001233002 .
 2017-08-19 10:10:48 +02:00
Florian Loitsch 03f9c41b55 Update status file for dart2js. 
Review-Url: https://codereview.chromium.org/3001173002 .
 2017-08-18 10:52:29 +02:00
Florian Loitsch c8970ec5dc Fix status file. 
Review-Url: https://codereview.chromium.org/2996233002 .
 2017-08-18 10:45:49 +02:00
Johnni Winther 3f13324293 Fix language_2 status 
Review-Url: https://codereview.chromium.org/2998033002 .
 2017-08-18 09:13:00 +02:00
Stephen Adams 8499c8f12e dart2js kernel: minimal recognition of external native methods 
TBR=sigmund@google.com

BUG=

Review-Url: https://codereview.chromium.org/3000123002 .
 2017-08-17 21:39:14 -07:00
Stephen Adams 3021706f87 More dart2js status duplicate removal 
TBR=sigmund@google.com

BUG=

Review-Url: https://codereview.chromium.org/2996203002 .
 2017-08-17 19:17:41 -07:00
Stephen Adams fd263bc7b9 Update status files for dart2js 
Sorting tests and removing duplicates

TBR=sigmund@google.com

BUG=

Review-Url: https://codereview.chromium.org/3003443002 .
 2017-08-17 17:09:03 -07:00
Paul Berry f8d5884701 Add a test to demonstrate issue #30461 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2994373002 .
 2017-08-17 14:49:57 -07:00
Jennifer Messerly 11f4152712 Revert "fix #30462, update function_type tests to understand covariant generics" 
This reverts commit 2ea6a5dd5c.

Review-Url: https://codereview.chromium.org/2998003002 .
 2017-08-17 13:50:10 -07:00
Bob Nystrom 1196fc9cda Update status files typevariable_substitution2_test. 
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/3002873002 .
 2017-08-17 13:04:54 -07:00