In particular, the reified type of method tear-offs may substitute Object for the class type parameter. This is done when the parameter needs a covariance check. The test generator is updated to understand this distinction.
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/3002773002 .
This is the original CL plus status file fixes.
Disables auto-generated function_type tests that are not working for the Dart 2 runtime behavior, and filed #30462 to track. Also removes the separate status that was skipping these tests in DDC when $checked was unset. $checked is not a thing for Dart 2, and DDC test status should never depend on it.
This reverts commit 1b0b1a4913.
R=leafp@google.com
Review-Url: https://codereview.chromium.org/3001053002 .
Special items in this block:
- checked_mode_helper is a helper library that needed extensive modifications. Fixing it up for Dart 2.0 meant simultaneously migrating
its users in blocks 113 and 163. Renamed it to dynamic_type_helper to try to reflect what it's actually doing now.
- Many minor breakouts of compile-time errors and conversion from static warnings.
BUG=
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2999733002 .
Start:
./language[_strong]/closure_side_effect_test.dart
End:
./language[_strong]/compile_time_constant2_test.dart
Except for tests/language_2/closure_type_test.dart, all other files has been copied automatically by the tool.
R=jcollins@google.com, whesse@google.com
PS: Forgot to run git cl upload command right after the migrate_tool, which I should have done, to make the automatic and manual changes clearer.
Review-Url: https://codereview.chromium.org/3002573002 .
./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart
R=johnniwinther@google.com
NOTE: I had to bypass hooks since the analyser fails on the files that have static compile-time errors. Should I do something else?
Review-Url: https://codereview.chromium.org/3001433002 .
This mainly splits along compiler lines, but uses runtime for a couple
of things -- VM and Flutter mainly.
I did most of the work automatically by hacking up the migration script
to re-migrate the existing file, but I also went through and manually
cleaned the result up as best I could.
R=bkonyi@google.com, jcollins@google.com
Review-Url: https://codereview.chromium.org/2993043002 .
This is only moving status lines around to ensure we only have 2 sections for
$dart2js_with_kernel per file: minified and host-checked. Some entries are now
duplicated because we no longer have the $dart2js_with_kernel (non-checked)
section.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2993083002 .
This is an attempt to get DDC's bot (https://travis-ci.org/dart-lang/sdk) green and restore test coverage, without affecting the Analyzer --strong buildbot. DDC and Analyzer can generally use the same status entries, as they are running nearly identical strong mode analysis. This fixes DDC's test builder to understand status codes in the same way analyzer does, as that was causing mismatch in statuses.
This does not fix the problem that we're skipping tests instead of recording the status. So there is a bit of test coverage lost, but it restores most of DDC's coverage. We can tackle the skips either in a follow up, or as we migrate tests from *_strong to *_2.
This is a partial revert of "Revert status file changes from 58a6227198d2aa927df19f1b4862f8d0017d6da4" in commit 7be946cf3d.
Review-Url: https://codereview.chromium.org/2990213002 .
- Migrate over built_in_identifier_test since it imports a helper
library that was migrated.
- Fix some status file entries.
Also:
- Removed some old commented out status entries.
- Fix a bug in migration script.
R=jcollins@google.com
Review-Url: https://codereview.chromium.org/2992903002 .
This will enable --use-kernel tests in the dart2js bots.
After this change, running our tests will change a little bit, either of these
would work:
Option A: --use-sdk (host-checked not allowed)
python tools/test.py -m release \
-c dart2js -r d8 --dart2js-batch --report \
--dart2js-with-kernel --use-sdk \
language corelib library_2 corelib_2 \
dart2js_native dart2js_extra
Option B: pass --library-root, --host-check works here.
python tools/test.py -m release \
-c dart2js -r d8 --dart2js-batch --report \
--dart2js-with-kernel --host-checked \
--dart2js_options="--library-root=out/ReleaseX64/dart-sdk/" \
language corelib library_2 corelib_2 \
dart2js_native dart2js_extra
In the future, when fasta supports compiling sdk with @patch files, we will
be able to remove the --library-root option and simply compile the SDK from
sources at that point.
BUG=
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2988063002 .
Jennifer Messerly