dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2317 Commits

Author SHA1 Message Date
Bob Nystrom 8140e1db64 Remove support for functions in asserts in DDC. 
These are not supported in Dart 2.0:

https://github.com/dart-lang/sdk/issues/30326
Change-Id: I2e177a647c43af2bf7f37ff382234b12b8c2286c
Reviewed-on: https://dart-review.googlesource.com/4182
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-15 23:37:06 +00:00
Sigmund Cherem 1ca12788c6 Revert "Check whether type-arguments and type-parameters length match from the body builder." 
This reverts commit 321a4ec048.

Some VM tests expect to see the behavior with a raw type instead of
an invalid type. I'll revert first, then resend this CL with the default
result changed.

R=ahe@google.com

Change-Id: I2cdd855dbaec93d0a0c257f7e202518fd9b59c81
Reviewed-on: https://dart-review.googlesource.com/6342
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-15 22:15:09 +00:00
Stephen Adams dccce129e4 dart2js-kernel: Don't crash on non-constant constants 
Change-Id: I7919ccdcd72f6653d2baa3c25c5d18df982ccda4
Reviewed-on: https://dart-review.googlesource.com/5941
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-15 21:44:24 +00:00
Stephen Adams 79d918aaf3 update dart2js kernel status 
TBR=sigmund@google.com

Change-Id: Ie897e2af7153eafa10e0ddb13484e02221370ed7
Reviewed-on: https://dart-review.googlesource.com/6170
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-15 21:12:18 +00:00
Sigmund Cherem 321a4ec048 Check whether type-arguments and type-parameters length match from the body builder. 
Bug:
Change-Id: I395365393c9032ff179d675f42ca56b7981531e0
Reviewed-on: https://dart-review.googlesource.com/5620
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-15 20:37:41 +00:00
Harry Terkelsen 3a25ead178 Generate super.noSuchMethod if super call is malformed 
This doesn't fix all of the errors with 
'Error: ".function" called on null' stacktraces. 

Change-Id: I7ddc0405db7e2f028eb27028c854dab29a0adf16
Reviewed-on: https://dart-review.googlesource.com/5522
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-09-15 20:03:51 +00:00
pq b091570a09 Revert "Migrate test block 136 to Dart 2.0." 
This reverts commit f58517a87a.

Bug:
Change-Id: I1da91b30499a768aee7521c16a8ce2fc79604b15
Reviewed-on: https://dart-review.googlesource.com/6169
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-15 18:30:04 +00:00
pq f58517a87a Migrate test block 136 to Dart 2.0. 
mixin_type_parameters_super_test .. named_parameters_aggregated_test

Bug:
Change-Id: Ic2c45c6c4ff0d4f7fd239f5b5ee039fced943a49
Reviewed-on: https://dart-review.googlesource.com/6163
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-15 18:08:00 +00:00
Alexander Markov 38f10b8bbb [Tests] Update status files for compiler = dartkp configuration 
Change-Id: I9b57d569b0a2dfdf6ad456659011783095e34fd7
Reviewed-on: https://dart-review.googlesource.com/6060
Reviewed-by: Alexander Aprelev <aam@google.com>
 2017-09-15 16:57:45 +00:00
Terry Lucas ccd7c7dfc8 Cleaned up status files. 
TBR=rnystrom@google.com

Change-Id: Ia8c3e1038c33948be12837ed775947e3e096348d
Reviewed-on: https://dart-review.googlesource.com/6082
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-09-15 13:52:07 +00:00
William Hesse 4a00f7b2d6 Update statuses for slow and flaky tests that affect the CQ. 
Bug: https://github.com/dart-lang/sdk/issues/30736
Change-Id: I297e49ff179121d32d3637a7a1800ab65f8e4572
Reviewed-on: https://dart-review.googlesource.com/5767
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-15 13:14:28 +00:00
Terry Lucas 6dbb57769c Update status file results 
TBR=rnystrom@google.com

Change-Id: I8730b5a99c0c1f0f7b8ddb3fe9617eb0b9ba35f5
Reviewed-on: https://dart-review.googlesource.com/6121
Reviewed-by: Terry Lucas <terry@google.com>
 2017-09-15 06:13:09 +00:00
Terry Lucas c922a23fdb Fixed minified and precompiled errors 
TBR=rnystrom@google.com

Change-Id: I107a3f166db751059617f26dd1eb8cba4ebea75d
Reviewed-on: https://dart-review.googlesource.com/6120
Reviewed-by: Terry Lucas <terry@google.com>
 2017-09-15 05:36:43 +00:00
Terry Lucas e23dccbf97 Fixed minified failures 
TBR=rnystrom@google.com

Change-Id: I64e8fd4ef44e338e7413c327d754198995766f2a
Reviewed-on: https://dart-review.googlesource.com/6032
Reviewed-by: Terry Lucas <terry@google.com>
 2017-09-15 04:56:56 +00:00
Terry Lucas 771031ea48 Fixed analyzer errors w/o strong mode. 
TBR=rnystrom@google.com

Change-Id: Icaf4e0ec0f42b988199c8bf34d7b7411f3b8a324
Reviewed-on: https://dart-review.googlesource.com/6031
Reviewed-by: Terry Lucas <terry@google.com>
 2017-09-15 04:32:05 +00:00
Terry Lucas 83146c0689 Migrated test block 53 to Dart 2.0 
Change-Id: I14461accc36505b3c8dfcf88705ccf8c9fd817f4
Reviewed-on: https://dart-review.googlesource.com/4522
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-15 03:51:03 +00:00
Ben Konyi 3d57dbb9aa Updated status file to fix failures on dart2js-d8-minified bots 
TBR=rnystrom@google.com
Bug:
Change-Id: I123f207e308aec23c715d3dcba17c67e6f809aba
Reviewed-on: https://dart-review.googlesource.com/6021
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2017-09-14 22:52:55 +00:00
Ben Konyi 4d0a867c7a Fix failures on build bots. 
TBR=rnystrom@google.com
Bug:
Change-Id: Ife8577d530a78921f284864b24af928ef16595cf
Reviewed-on: https://dart-review.googlesource.com/6000
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-14 22:05:38 +00:00
Ben Konyi 01e5f01cfc Migrated test block 164 to Dart 2.0. 
Fairly simple block with the exception of the
causal_async_exception_stack* tests needing to be refactored to be
migrated from unittest->test.

Bug:
Change-Id: I8f4879a10730b6186bdd1b392084a2e4055262eb
Reviewed-on: https://dart-review.googlesource.com/4641
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-14 21:49:59 +00:00
Ben Konyi 795d74b35c Migrated test block 56 to Dart 2.0. 
Minor changes to make cyclic_default_values_test,
cyclic_type_variable_test, and cyclic_typedef_test strong mode clean.

Bug:
Change-Id: Icc99b07eca07f937a18fd16968619e5cd7c8ca22
Reviewed-on: https://dart-review.googlesource.com/5341
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-14 20:34:04 +00:00
Stephen Adams ee3d649a6e dart2js-kernel: Implement _DuplicatedFieldInitializerError 
Bug:
Change-Id: I14925233d4275afbb0ec8bc17752acd43e04c9ac
Reviewed-on: https://dart-review.googlesource.com/5602
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-14 18:21:38 +00:00
Bob Nystrom 12433bd5f4 Update assertion_test to no longer allow functions in asserts. 
Dart used to allow the first argument to assert() to be a function,
which it would implicitly call, but this is being removed for Dart 2.0.

https://github.com/dart-lang/sdk/issues/30326

This gets the test testing the 2.0 behavior. Since the test is now
leading the implementation, updated the status files to mark it failing.

Bug: https://github.com/dart-lang/sdk/issues/30326
Change-Id: Ia61f540f1991ecdf42ccdb47b932890e636c1bd3
Reviewed-on: https://dart-review.googlesource.com/4181
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-14 18:10:26 +00:00
Emily Fortuna 83f5b64ea1 When accessing "super" properties, capture "this". 
Bug:
Change-Id: I770aed67e2e4d078feba7d04662029e9a0a454fc
Reviewed-on: https://dart-review.googlesource.com/5601
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-14 17:37:07 +00:00
Jakob Roland Andersen d687bc6673 Migrated test batch 122 to Dart 2.0. 
Bug:
Change-Id: Icb90877af264b2f61c9e32be7420ed748cab601f
Reviewed-on: https://dart-review.googlesource.com/5741
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-14 14:42:48 +00:00
Johnni Winther 1c3269cb34 Update --dart2js-with-kernel status, some more. 
Change-Id: Ic8396e4e997118f7634e526f095e36fce62c9196
Reviewed-on: https://dart-review.googlesource.com/5720
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-14 10:59:41 +00:00
Johnni Winther 472dd74cda Update --dart2js-with-kernel status. 
Change-Id: I52ca8d63d836d6d01d39554b2f24a0451d2231ab
Reviewed-on: https://dart-review.googlesource.com/5700
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-14 10:50:08 +00:00
Johnni Winther 5aa3259698 Handle break to labeled statement 
No tests yet. Kernel doesn't support file-offsets on labeled statement.

Change-Id: I5dcfcc21433aec5ad0be26bfef5bbca0b609ba35
Reviewed-on: https://dart-review.googlesource.com/5161
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-14 08:59:11 +00:00
Jakob Roland Andersen eaafacb59d Revert "Revert "Reland "Migrated test batch 123 to Dart 2.0.""" 
This reverts commit 85e8613e66.

Reason for revert: Giving this one last try.

Wasn't able to reproduce the buildbot's failure on macOS or Windows, so
marking the entire test as RuntimeError, instead of just part of it.

GitHub issue: https://github.com/dart-lang/sdk/issues/30675

Original change's description:
> > This is a reland of 594e6cf010
> > Original change's description:
> > > Migrated test batch 123 to Dart 2.0.
> > > 
> > > Bug:
> > > Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> > > Reviewed-on: https://dart-review.googlesource.com/4800
> > > Reviewed-by: Florian Loitsch <floitsch@google.com>
TBR=jakobr@google.com,floitsch@google.com

Change-Id: I0508cf605c40125132a807a019b5cf412a393ac9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5680
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-14 08:29:07 +00:00
Stephen Adams 8cf0313be0 update dart2js status for recent test migration 
TBR=sigmund@google.com

Bug:
Change-Id: I19e51af981c9b4537df2b5ab85433a82a859313a
Reviewed-on: https://dart-review.googlesource.com/5543
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-13 21:40:40 +00:00
Stephen Adams 50f1e75af4 update dart2js-kernel status again 
moved problematic tests into a section with !$dart2js_with_kernel

TBR=sigmund@google.com

Change-Id: Iba8e38d53b8836f2a27193018466b0ef2651245b
Reviewed-on: https://dart-review.googlesource.com/5520
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-13 20:52:04 +00:00
Stephen Adams ab15abaf22 update dart2js-kernel status 
TBR=sigmund@google.com

Change-Id: If8cf3c12627d3b18346da68f5c4eb92a387fe41d
Reviewed-on: https://dart-review.googlesource.com/5504
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-13 20:32:53 +00:00
Stephen Adams b4976bbded update dart2js kernel status 
TBR=sigmund@google.com

Bug:
Change-Id: I3ac9b2ef1a4e3fd84d8039f10670e73636121d1b
Reviewed-on: https://dart-review.googlesource.com/5501
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-13 19:50:01 +00:00
Harry Terkelsen c0edd4ee0e ensure type arguments for instantiations are in the class hierarchy 
Change-Id: Ife2da89018278fa5e5a9b940f7052006f2f7f841
Reviewed-on: https://dart-review.googlesource.com/5485
Commit-Queue: Harry Terkelsen <het@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-13 18:55:48 +00:00
Ben Konyi 30dde80447 Migrated test block 57 to Dart 2.0. 
Bug:
Change-Id: I4b6845b0539fc5b8bb7118d6e920685afb0b3edc
Reviewed-on: https://dart-review.googlesource.com/5342
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-13 18:08:58 +00:00
Paul Berry 5145705d51 Test a corner case of runtime checks (closure called via method interface). 
Currently, Dart 2.0 forbids overriding a method with a getter (even if
the types are compatible), so once a method has been torn off, there's
no way to ever call the tear-off through an interface target that is a
method.  However, if we ever relax that rule and allow a method to be
overridden with a getter, it will be possible to call a torn-off
method through an interface target that is a method.  If this ever
happens, we will need to make sure that the proper covariance checks
occur.

Since overriding a method with a getter is currently forbidden, the
new tests verify that the expected compile time error occurs.
However, to future proof us against the possibility that this
restriction is ever relaxed, the tests also contain enough code to
demonstrate the runtime check that would be needed.

Change-Id: Iea3a56d86f661362ff9fb970bcc80c8f80c50f4e
Reviewed-on: https://dart-review.googlesource.com/5322
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-13 17:39:40 +00:00
Stephen Adams 0bfad6483e de-dup dart2js kernel status files 
TBR=sigmund@google.com

Bug:
Change-Id: I41d0bfdad38f0ab65649cd9d69e82097e9877fe2
Reviewed-on: https://dart-review.googlesource.com/5483
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-13 17:13:03 +00:00
pq b030b331f2 Block 137 patch (fix dart2js tests) [TBR]. 
Bug:
Change-Id: I61d788b1c0a7bdcd201225baf070f889f29e908c
Reviewed-on: https://dart-review.googlesource.com/5481
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-13 16:46:25 +00:00
pq 8da668be93 Migrate Test Block 137 to Dart 2.0. 
named_parameters_default_eq_test .. namer_test

Bug:
Change-Id: I0d0d853e94e7ca78472224405f811d1ac55c1f6c
Reviewed-on: https://dart-review.googlesource.com/5283
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-13 15:44:13 +00:00
Jakob Roland Andersen 85e8613e66 Revert "Reland "Migrated test batch 123 to Dart 2.0."" 
This reverts commit e9cd03e8f8.

Reason for revert: Still fails on macOS/Windows. Sigh.

Original change's description:
> Reland "Migrated test batch 123 to Dart 2.0."
> 
> This is a reland of 594e6cf010
> Original change's description:
> > Migrated test batch 123 to Dart 2.0.
> > 
> > Bug:
> > Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> > Reviewed-on: https://dart-review.googlesource.com/4800
> > Reviewed-by: Florian Loitsch <floitsch@google.com>
> 
> Change-Id: I34710bc1a62eb1e94d6c32f20c6438f2db7bdb54
> Reviewed-on: https://dart-review.googlesource.com/5301
> Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
> Reviewed-by: Jakob Roland Andersen <jakobr@google.com>

TBR=jakobr@google.com,floitsch@google.com

Change-Id: Ia20ce3555e88e7c366893fb6416b77a2164db05f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5362
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-13 09:21:55 +00:00
Jakob Roland Andersen e9cd03e8f8 Reland "Migrated test batch 123 to Dart 2.0." 
This is a reland of 594e6cf010
Original change's description:
> Migrated test batch 123 to Dart 2.0.
> 
> Bug:
> Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> Reviewed-on: https://dart-review.googlesource.com/4800
> Reviewed-by: Florian Loitsch <floitsch@google.com>

Change-Id: I34710bc1a62eb1e94d6c32f20c6438f2db7bdb54
Reviewed-on: https://dart-review.googlesource.com/5301
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-13 08:59:27 +00:00
Stephen Adams 5ab592a3b5 Compute field initializers in correct order with respect to type parameters and other initializers 
Change-Id: I253515188d4428de88bcca4799dac6204d3e7329
Reviewed-on: https://dart-review.googlesource.com/5299
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-13 02:16:32 +00:00
Emily Fortuna f1d0482cd1 Dart Gardening: Fix test status files after migrating test block 42. 
https://github.com/dart-lang/sdk/commit/33ee69b3e449ed26ac4e316b0afc743c6b1bf2fe did not update all the test status files correctly.

Bug:
Change-Id: Iff3ad16a28fc0a433b1de21a0ec13f710c20643a
Reviewed-on: https://dart-review.googlesource.com/5326
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-12 22:26:23 +00:00
pq a96ff2a2ba Block 152 status file fixes (in quest for greenness) [TBR]. 
Bug:
Change-Id: Id383c2cc91418e5d2f688d9f1df91d2ca3dd5ed4
Reviewed-on: https://dart-review.googlesource.com/5321
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-12 21:28:55 +00:00
Jaime Wren 33ee69b3e4 Migrated test block 42 to Dart 2.0 
The test change of '.nooooo()' -> '.field' mitigates a bunch of status file changes that would be required.  Since this is an await, and not a strong mode/ ddc/ resolution test, this test was modified in this way.

Change-Id: I54bb9ff51c2e86dd61eb41fdfc19c93bbdf22f7a
Reviewed-on: https://dart-review.googlesource.com/4142
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-09-12 21:14:41 +00:00
Alexander Markov 6fbab08b21 [Tests] Update status files for dartkp configuration 
This CL silences several tests for '$compiler = dartkp' configuration
in order to make vm-kernel-precomp-* buildbots greener.
These tests are already silenced for '$compiler = precompiler' or
'$compiler = dartk' configurations.

Change-Id: Ia3208853655868ae4cf39775d40db15218c1a1df
Reviewed-on: https://dart-review.googlesource.com/5286
Reviewed-by: Alexander Aprelev <aam@google.com>
 2017-09-12 20:08:51 +00:00
Emily Fortuna c73cbf5615 Dart gardening: Update status files for dart2js 
Bug:
Change-Id: I6b95fcd23dcf5de36ded6ad819bacfc1e99aae76
Reviewed-on: https://dart-review.googlesource.com/5292
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-12 20:05:31 +00:00
pq 050cc8f815 Migrate test block 152 to Dart 2.0. 
static_field1_test.dart .. string_interpolate_test.dart

Bug:
Change-Id: I8d5602bf5f738522bc705b67d5f797013ca67ffc
Reviewed-on: https://dart-review.googlesource.com/5043
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-12 20:00:24 +00:00
Ben Konyi cdc7a16d8e Migrated test block 166 to Dart 2.0. 
Bug:
Change-Id: Ib21357cf328ec25c1acc58c3b37a4a7bf2910fa1
Reviewed-on: https://dart-review.googlesource.com/4612
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-12 19:22:08 +00:00
Brian Wilkerson bb8d888601 Update status to fix the bots (TBR) 
Change-Id: Ie251c2b2062c28e0fd6d5b98dc8ffbcede28e35a
Reviewed-on: https://dart-review.googlesource.com/5289
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-12 19:01:45 +00:00
Brian Wilkerson f93da679a1 Support the optional comma in asserts in fasta 
Change-Id: Iab3ad9403eba353f695c5eff352d332ed07a6a6f
Reviewed-on: https://dart-review.googlesource.com/3320
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-09-12 17:21:42 +00:00