dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2317 Commits

Author SHA1 Message Date
Ben Konyi 8253f51b64 Migrated test block 140 to Dart 2.0. 
Bug:
Change-Id: I935b29026125e0318cc977a7d5c6fd45479a0d56
Reviewed-on: https://dart-review.googlesource.com/7853
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2017-09-25 14:53:02 +00:00
Ben Konyi c0364e372d Migrated test block 58 to Dart 2.0. 
No major changes.

Bug:
Change-Id: I7092880088d0fd334d6d2b1f6d4f1dbc2cb03ed2
Reviewed-on: https://dart-review.googlesource.com/7487
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-25 13:51:22 +00:00
Stephen Adams f35a0d59d3 dart2js status file fix 
Merse several regions withe the same conditions.

TBR=bkonyi@google.com
Bug:
Change-Id: I2dbac75960a383359329d49a55b4c56495052ae0
Reviewed-on: https://dart-review.googlesource.com/7960
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-23 12:23:34 +00:00
Ben Konyi 7e73bd790c Updated status file to fix failures on dart2js-d8-minified bot. 
TBR=whesse@google.com,rnystrom@google.com

Bug:
Change-Id: Ie6a35836ef5345f551acd222439814d789481ca9
Reviewed-on: https://dart-review.googlesource.com/7944
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-23 03:16:05 +00:00
Ben Konyi 24e40a0f61 Migrated test block 139 to Dart 2.0. 
Did not migrate null_bottom / null_is_bottom type tests. Modified
null_test to not run some mirrors related checks on platforms that don't
support mirrors.

Bug:
Change-Id: I7fce784f537cc298e2945a32073700083d9275f8
Reviewed-on: https://dart-review.googlesource.com/7848
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2017-09-23 00:06:38 +00:00
Ben Konyi 038c281a47 Migrated test block 131 to Dart 2.0. 
Quite a few changes were made to method_override* tests.

Bug:
Change-Id: I554c83ae766010b55f17a86caee9418d0c34cbe7
Reviewed-on: https://dart-review.googlesource.com/7683
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 21:53:58 +00:00
Stephen Adams a8f2f24b20 Update dart2js kernel status 
TBR=whesse@google.com
Bug:
Change-Id: Iad47a8c38625f1d21c3c8fa35397cea57ccea29d
Reviewed-on: https://dart-review.googlesource.com/7849
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-22 21:19:33 +00:00
William Hesse e032124c4a Update statuses for new language_2 tests on dart2js with kernel. 
This updates statuses for the tests landed in
https://dart-review.googlesource.com/c/sdk/+/7800
Bug:
Change-Id: I092e08066b3875bdceac6e369b259df4ac510d67
Reviewed-on: https://dart-review.googlesource.com/7880
Reviewed-by: Alan Knight <alanknight@google.com>
Commit-Queue: Alan Knight <alanknight@google.com>
 2017-09-22 20:04:02 +00:00
Johnni Winther 772a0aff33 Handle and report erroneous compile time constants 
Change-Id: I2ee86dbd714227e8e0894539ca64258fd11badfc
Reviewed-on: https://dart-review.googlesource.com/7820
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-22 18:57:37 +00:00
William Hesse b3e7f6d299 Recommit "migrate function type tests"" 
This reverts commit ba09eb787c, which was
a revert of ca6bec3414.
New status lines have been added to tests/languge_2/language_2_dart.js.status.

Bug:
Change-Id: I9e5b344d67df1fb00d5a51078a3d2b6113223a3e
Reviewed-on: https://dart-review.googlesource.com/7800
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 17:52:27 +00:00
pq d9326f4ab3 Migrate test block 135 to Dart 2.0. 
Bug:
Change-Id: Icda59de9bfad2e9b2683f019fb9c6fc54c12547c
Reviewed-on: https://dart-review.googlesource.com/7587
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 17:04:06 +00:00
Lasse R.H. Nielsen f625a721eb Make asyncstar_pause_test only call asyncEnd on success. 
Fixes #30814.

Bug: http://dartbug.com/30814
Change-Id: I882a5a8185a5415fd08aa005607c3469d400ba29
Reviewed-on: https://dart-review.googlesource.com/7265
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-22 09:59:01 +00:00
Erik Ernst 9cffb6aa0f Gardening: Removed status entry for language_2/vm/type_vm_test 
Change-Id: Ie9a6c0d22c672ebb291c98abb61b0634d0e485e4
Reviewed-on: https://dart-review.googlesource.com/7703
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-22 07:43:15 +00:00
Stephen Adams aa0d5a428e Hack to fix incorrect getMightBePassedToApply under --disable-type-inference 
R=sigmund@google.com

Bug:
Change-Id: Ie0378a923473e2b5ff7eaabdff499ddb01050f3e
Reviewed-on: https://dart-review.googlesource.com/7489
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-22 02:47:23 +00:00
Jaime Wren ec431ffa39 Revert "Migrated test block 60 to Dart 2.0" 
This reverts commit 9141047cd7.

Change-Id: I222dd72cabe4a69576e7f5d87e2ae61b96ac6b16
Reviewed-on: https://dart-review.googlesource.com/7636
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-21 21:34:32 +00:00
Harry Terkelsen f07c329f31 Mark failing cyclic constructor tests with issue 
Change-Id: I11c03f0e3af84fd204d20493ddda9d2423b9368d
Reviewed-on: https://dart-review.googlesource.com/7634
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-21 21:02:24 +00:00
Jaime Wren 9141047cd7 Migrated test block 60 to Dart 2.0 
Change-Id: I3b9f5ea80001adf0017599c86db3be235fbf12e1
Reviewed-on: https://dart-review.googlesource.com/7160
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-21 20:43:34 +00:00
Ben Konyi a87493f8ca Migrated test block 165 to Dart 2.0. 
Minor changes to a couple of tests to make them strong-mode clean.

Bug:
Change-Id: Id0cac7a120dbdf940d101c3e5de8c206a0ad6342
Reviewed-on: https://dart-review.googlesource.com/4613
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-21 19:00:36 +00:00
Emily Fortuna 1bf53724bb Use in correct version of CommonElements (J vs K entities) for backend. 
Bug:
Change-Id: I8731624f7453d47019fbf24be4d9d6db4d5a0318
Reviewed-on: https://dart-review.googlesource.com/7488
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-21 17:57:26 +00:00
Alexander Aprelev 02032850e5 Fix dartk checked tests 
Fix red https://build.chromium.org/p/client.dart.fyi/builders/vm-kernel-linux-release-x64-checked-be buildbot.

Change-Id: I7e5d6769d93802d397685d258f79c638aa4e2d45
Reviewed-on: https://dart-review.googlesource.com/4981
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2017-09-21 16:37:54 +00:00
Erik Ernst c49cbae7f0 Rietveld 2688903004 (spec_parser) migrated to Gerrit. 
Change-Id: Iddd1e8a795bfaed0092a30bb9d83070fe62d4a60
Reviewed-on: https://dart-review.googlesource.com/7261
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-21 09:36:10 +00:00
Florian Loitsch 7a110c071f Update status file. 
Change-Id: Ib5795d8566d8533c4cf81c69819ef58e73406c8e
Reviewed-on: https://dart-review.googlesource.com/7545
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-21 08:58:42 +00:00
Florian Loitsch 951e8dad51 Split the mock_writable test into two pieces. 
One now contains private symbols. The other doesn't.

Change-Id: I4f7586117731aad1d965060a7ff7b14050713331
Reviewed-on: https://dart-review.googlesource.com/7543
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-21 08:24:15 +00:00
Florian Loitsch f35d224654 Fix mock_writable_final_field_test and update status file. 
Change-Id: Ibe94be244fd4df23701f282e4c4329a5b606db95
Reviewed-on: https://dart-review.googlesource.com/7541
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-21 07:48:23 +00:00
Erik Ernst cf01c459f3 Updated tests for new treatment of init.formal type annotations 
Adjusted lib_2/mirrors/initializing_formals_test.dart to match new rule
for static checking on type annotations of initializing formals.

Added language_2/initializing_formals_type_annotation_test.dart to
check the 4 main situations directly.

Change-Id: Icf763c79c99274645f7967b8c3e3a3c3f6536763
Reviewed-on: https://dart-review.googlesource.com/7268
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2017-09-21 07:34:58 +00:00
Florian Loitsch 0d2bcc17db Update status files. 
Change-Id: Iebfba17da59a161aea16e802787c2b5cf4722845
Reviewed-on: https://dart-review.googlesource.com/7540
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-21 07:22:04 +00:00
Harry Terkelsen f8d4291164 update status for passing test [TBR] 
Change-Id: I9a7a4fda137822fc0b80de9d43332aab610dcc35
Reviewed-on: https://dart-review.googlesource.com/7485
Reviewed-by: Harry Terkelsen <het@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-09-20 23:06:37 +00:00
Bob Nystrom 74e4ccdeb8 Migrate block 120. 
Change-Id: Ia5a433e70ab3bdf953a116a0b65de42138125d2b
Reviewed-on: https://dart-review.googlesource.com/6347
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-20 22:23:58 +00:00
pq abfd9594fe dart2js test expectation updates (block 136 continued) [TBR]. 
More staus file whack-a-mole.

Addresses:

python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/mixin_with_two_implicit_constructors_test
python tools/test.py -m release -c dart2js -r d8 --checked --minified --fast-startup --use-sdk --dart2js-batch --reset-browser-configuration language_2/mock_writable_final_field_test
python tools/test.py -m release -c dart2js -r d8 --host-checked --dart2js-batch --reset-browser-configuration language_2/mock_writable_final_field_test

Bug:
Change-Id: Ia2f44a57b36d2c35dadf3ab4b4d2d9c483d6552c
Reviewed-on: https://dart-review.googlesource.com/7445
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-20 20:32:59 +00:00
Emily Fortuna ac98f741d5 Make JRecordFields not instance members (they were falsely categorized as such because the boxes were "classes"). 
Bug:
Change-Id: I5ea7ab26e5bb7c52a59b4f81b1489190b2d00fd0
Reviewed-on: https://dart-review.googlesource.com/7220
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-20 19:26:08 +00:00
pq 0d9032c644 Update test expectations for multiline_strings_test on windows [TBR]. 
See: https://github.com/dart-lang/sdk/issues/30336

.gitattributes updated.

Bug:
Change-Id: I7481362e64159ba28b8448d19acca5817010739d
Reviewed-on: https://dart-review.googlesource.com/7383
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-20 17:52:26 +00:00
pq 84ac5aa1c6 Updated test expectations for dart2js d8 (in quest for greenness). 
Bug:
Change-Id: I689be0aac6f266ea757eb142fb5d18414f4203f9
Reviewed-on: https://dart-review.googlesource.com/7381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-20 17:40:43 +00:00
pq 86e4c97346 Re-stage migration of test block 136 to Dart 2.0. 
Bug:
Change-Id: I562ceec87bc946bb43467ca118c88991a368657f
Reviewed-on: https://dart-review.googlesource.com/6781
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-20 16:23:00 +00:00
Stephen Adams 617f6ac197 Weaken constructor initializer assertion 
Accept a missing super-constructor call if one of the constructor
initializers always throws.  This matches dynamic error code generated
for various warnings, including duplicate final initializers.

Change-Id: If188c9d8d6d02bf9667123fbf679f1c103b5ef5a
Reviewed-on: https://dart-review.googlesource.com/7240
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-20 02:18:21 +00:00
Ben Konyi 192579020c Migrated test block 121 to Dart 2.0. 
Bug:
Change-Id: I194436597ba39b2e2b872fb58b77314ab925b3aa
Reviewed-on: https://dart-review.googlesource.com/7080
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-19 23:36:24 +00:00
Emily Fortuna 9a531f9b50 Get async/await working with the entity model. 
Bug:
Change-Id: I803cb8f8a681563d76d6eed56116267f64a9ba8a
Reviewed-on: https://dart-review.googlesource.com/7106
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-19 22:29:34 +00:00
Vijay Menon 6ce85d5f99 Revert "Remove support for functions in asserts in DDC." 
This reverts commit 8140e1db64.

Change-Id: If505903ba475324392d6c6bcdae3392f523aadc8
Reviewed-on: https://dart-review.googlesource.com/7107
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2017-09-19 21:46:13 +00:00
pq 5fa545bc84 STATUS file tweaks for string_literals_test dart2js crashers on windoze. 
Bug:
Change-Id: I50c6569db54dc36e0f97163a5c42b568eb25cfff
Reviewed-on: https://dart-review.googlesource.com/7120
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-19 21:10:21 +00:00
pq 54c29a24f5 Fix STATUS for string_interpolate_test [TBR]. 
Bug:
Change-Id: Iecfc7bd23cc85d8607bca72ca95a039bb37486aa
Reviewed-on: https://dart-review.googlesource.com/7100
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-19 18:06:28 +00:00
pq 8374f9825b Fix block 156 test migration STATUS file expectations [TBR]. 
Bug:
Change-Id: I9e6e915a90b55fbe96da54278da16587aee9e4aa
Reviewed-on: https://dart-review.googlesource.com/7040
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-19 17:12:37 +00:00
pq ced11f1b0c Migrate test block 153 to Dart 2.0. 
Change-Id: Ide65fb47af440e32648d01f46ad6f858b9faeadf
Reviewed-on: https://dart-review.googlesource.com/3742
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-19 16:20:45 +00:00
Stephen Adams f115e1926f Make DirectPropertyGet a compile time crash rather than a runtime crash 
These are infrequent, so can be better tracked as a compile-time issue.

Change-Id: I79a25c3cad1e7b003244cc5baa1a8a788586a0af
Reviewed-on: https://dart-review.googlesource.com/6761
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-19 00:25:12 +00:00
Ben Konyi dbb52fac32 Fixed failing tests on dart2js-d8-minified. 
TBR=rnystrom@google.com

Bug:
Change-Id: Iafed1fb898b78a1a5d1332473f542eb0ad63b31f
Reviewed-on: https://dart-review.googlesource.com/6766
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-19 00:06:14 +00:00
Ben Konyi 55e34cb2b0 Migrated test block 55 to Dart 2.0. 
Bug:
Change-Id: I781d22614ea06b599dd9bbe6d03f820f0cfea544
Reviewed-on: https://dart-review.googlesource.com/5482
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-18 22:08:58 +00:00
Emily Fortuna 942963fa2e Add TypeVariable analysis in closure conversion. 
Bug:
Change-Id: I4155ceb042295934cc3c9125d275dc5f034675dd
Reviewed-on: https://dart-review.googlesource.com/6025
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-18 20:26:33 +00:00
Harry Terkelsen b49dd9fe98 register SUPER_NO_SUCH_METHOD feature when appropriate 
Change-Id: If620aa0bb051d8bd014070e0a2c3e4c525dc6729
Reviewed-on: https://dart-review.googlesource.com/6643
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-09-18 19:54:12 +00:00
Jaime Wren 89b700eddd Migrated test block 54 to Dart 2.0 
Some status files touched, and some constructor initializations re-ordedered to get DDC to pass.

Some context: https://www.dartlang.org/guides/language/effective-dart/usage#do-place-the-super-call-last-in-a-constructor-initialization-list

Change-Id: Ifd371214c5620a7745d5cfbf250922ca6d67bc95
Reviewed-on: https://dart-review.googlesource.com/4083
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-09-18 18:39:12 +00:00
Karl Klose ba09eb787c Revert "migrate function type tests" 
This reverts commit ca6bec3414.

R=whesse@google.com

Change-Id: I57195534c4c32e0fcf0cd88f5171984b126be26e
Reviewed-on: https://dart-review.googlesource.com/6466
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2017-09-18 12:05:46 +00:00
Jennifer Messerly ca6bec3414 migrate function type tests 
I'd previously fixed most of these in strong mode. This also migrates the ones in the same text range.

Change-Id: Ieb637c0635502e46362594db3ce20ec414c95ffa
Reviewed-on: https://dart-review.googlesource.com/5521
Commit-Queue: Jennifer Messerly <jmesserly@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-16 05:28:43 +00:00
Stephen Adams 69b50ed990 dart2js-kernel: Fix bug with finding optional parameter default values 
Change-Id: Iefa443318124838aeafa9998e08d1143c1976dc4
Reviewed-on: https://dart-review.googlesource.com/6346
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-15 23:54:22 +00:00