dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1474 Commits

Author SHA1 Message Date
Brian Wilkerson aab7af12e9 Add fixes for two more lint rules 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3004293002 .
 2017-09-02 15:10:56 -07:00
Brian Wilkerson 170c562ffe Add fixes for two additional lints 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3007783002 .
 2017-08-29 10:18:17 -07:00
Brian Wilkerson c38c97def3 Reduce duplicated code 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3002303002 .
 2017-08-25 08:18:39 -07:00
danrubel 84a36f1b77 flag to limit file and package URI completion suggestions 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/3003233002 .
 2017-08-23 13:39:32 -04:00
Brian Wilkerson e4d44b2dcd Remove more references to the old plugin system 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3004523003 .
 2017-08-23 09:25:07 -07:00
Brian Wilkerson b999edf5ee Remove more references to AnalysisContext 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3003173002 .
 2017-08-23 07:53:14 -07:00
Brian Wilkerson b941f148a7 Remove uses of the old plugin model from the analysis server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3001413002 .
 2017-08-23 07:42:13 -07:00
Brian Wilkerson ebe2ce681e Fix ClassElement.allSupertypes to include interfaces of mixins (issue 29767) 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/3000183002 .
 2017-08-18 07:30:05 -07:00
Brian Wilkerson d87fcfd233 Correctly update positions when adding edits before them (issue 30444) 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2997073002 .
 2017-08-16 10:29:26 -07:00
Brian Wilkerson 31887d6e42 Add a test that requires adding an import 
Review-Url: https://codereview.chromium.org/2998903002 .
 2017-08-13 08:33:50 -07:00
Brian Wilkerson beae4b29f1 Handle creation of class members in files other than the file containing the error 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2998703002 .
 2017-08-09 08:57:29 -07:00
Paul Berry 89c910b9c1 Move byte_store.dart and file_byte_store.dart to their own subdirectory. 
This allows us to use the subpackage relationships test to verify that
they don't import any other parts of front_end, which paves the way
for the possibility of moving them to their own package in the future.

R=scheglov@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2990323002 .
 2017-08-07 11:04:48 -07:00
Brian Wilkerson 5b88eef0af Suggest covariant in parameter lists 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2986133002 .
 2017-07-28 10:33:07 -07:00
Brian Wilkerson 950b4108f7 Add assist to convert part-of directives 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2986903002 .
 2017-07-26 09:08:37 -07:00
Konstantin Shcheglov bdd69ccd6c Remove UriReferencedElement with its uri/uriOffset/uriEnd properties. 
The 'Move File' refactoring does not work, so I comment out most
of its code.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2982993003 .
 2017-07-19 09:31:03 -07:00
Konstantin Shcheglov 90121b528a Remove the 'Move File' refactoring. 
It has been broken since we switched to Analysis Driver.
Given that IDEA does not use it, there is little incentive to fix it.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2983783003 .
 2017-07-18 17:59:20 -07:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt. 
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
 2017-07-13 16:28:18 -07:00
Konstantin Shcheglov a673395664 Don't depend on visiting local functions. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2970403002 .
 2017-07-07 13:01:23 -07:00
Brian Wilkerson e454986288 Add code to run more tests from test_all 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2968233002 .
 2017-07-06 12:24:01 -07:00
Konstantin Shcheglov ce43a15e51 Stop depending of visiting LocalVariableElement(s) in Executableelement.visitChildren(). 
We still visit them, but analyzer and analysis_server don't need it.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2969343002 .
 2017-07-05 12:28:20 -07:00
Brian Wilkerson 3c1c22a3a1 Add a quick fix for missing new (issue 30077) 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2965063002 .
 2017-07-05 10:59:34 -07:00
Brian Wilkerson 62f43f663b Fix a bug in inline method refactoring 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2973673002 .
 2017-07-05 09:35:48 -07:00
Brian Wilkerson 2f28f5713c Fix a test so that it passes 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2968883002 .
 2017-07-03 08:39:31 -07:00
Brian Wilkerson aadafd1bd5 Use DartEditBuilder to write types and remove dead code 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2972463003 .
 2017-07-01 12:03:44 -07:00
Konstantin Shcheglov 238894eb76 Stop using ExecutableElement.localVariables in RenameClassMemberRefactoringImpl. 
This is the only / last usage in Analysis Server.
And this change fixes 3 failing tests.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2961363003 .
 2017-06-30 11:58:15 -07:00
Konstantin Shcheglov e0f4c7b467 Report only private members in the same library as overrides. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2959273002 .
 2017-06-28 13:47:33 -07:00
Konstantin Shcheglov 911263f240 Remove the old index. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2963773003 .
 2017-06-28 13:44:05 -07:00
Konstantin Shcheglov 2b64bbed6a Add SearchEngine.membersOfSubtypes(). 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2962023002 .
 2017-06-28 11:44:48 -07:00
Brian Wilkerson 7bd9e6c443 Add a mixin for assists similar to that for fixes 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2956353002 .
 2017-06-28 11:44:22 -07:00
Brian Wilkerson 6248e7cab2 Add support code to make fixes easier in plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2962903002 .
 2017-06-28 10:52:06 -07:00
Konstantin Shcheglov a2f18fdb73 Fixes and tests for adding library imports. 
R=brianwilkerson@google.com, pquitslund@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/1119

Review-Url: https://codereview.chromium.org/2955913002 .
 2017-06-26 13:16:19 -07:00
Steve Messick c26c2774ca This defines some postfix completion templates for use in the IntelliJ editor. 
R=brianwilkerson@google.com

To use it, you'll need a version of the Dart plugin with this PR patched in:
https://github.com/JetBrains/intellij-plugins/pull/534
Review-Url: https://codereview.chromium.org/2917943002 .
 2017-06-26 09:53:02 -07:00
Brian Wilkerson c9dce504cc Remove more dead code 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2959713002 .
 2017-06-26 07:31:25 -07:00
Erik Corry 029b1cb948 Spelling fixes e to i. 
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
 2017-06-24 13:41:39 +02:00
Brian Wilkerson ec8505fc79 Fix hints and clean-up obsolete comment syntax (TBR) 
Review-Url: https://codereview.chromium.org/2952233002 .
 2017-06-22 10:59:26 -07:00
Brian Wilkerson 53e01faa43 Remove unused implementation of SearchEngine and rename the driver-based implementation 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2949823002 .
 2017-06-21 09:33:51 -07:00
Brian Wilkerson 6e8453ed94 Fix invalid initializing formal by adding a field 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2946093002 .
 2017-06-21 07:56:26 -07:00
Brian Wilkerson 4337a3aeee Cleanup some unused code in some of the tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2942433002 .
 2017-06-13 14:01:17 -07:00
Brian Wilkerson 4da8380881 Convert more tests to use the new driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2939803002 .
 2017-06-13 12:04:25 -07:00
Brian Wilkerson 1e9ae646ff Clean up some hints 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2939723002 .
 2017-06-13 09:24:50 -07:00
Brian Wilkerson 65d05524ce Remove some unnecessary tests for non-driver mode 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2935733003 .
 2017-06-12 11:31:09 -07:00
Brian Wilkerson b928683560 Add a couple of lints to the options files 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2933713002 .
 2017-06-11 09:12:48 -07:00
pq b502bb6956 Prioritize required name param completions (flutter-intellij#1049). 
R=danrubel@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/1049
Review-Url: https://codereview.chromium.org/2927343002 .
 2017-06-09 10:20:16 -07:00
Brian Wilkerson 0e6586492d Make common tests consistent 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2925273003 .
 2017-06-09 08:40:16 -07:00
Brian Wilkerson 6d8b7c8806 Finish refactoring FixProcessor to use ChangeBuilder 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2930793002 .
 2017-06-08 07:56:08 -07:00
Brian Wilkerson aa33d71071 Another attempt to fix the windows tests 
Review-Url: https://codereview.chromium.org/2927873002 .
 2017-06-07 12:35:56 -07:00
Brian Wilkerson a8919b8237 Support a short-hand way to create linked edit groups 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2928723003 .
 2017-06-07 09:07:39 -07:00
Brian Wilkerson db0a8a76ae Move CompletionTarget and OpType for use by plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2924703002 .
 2017-06-06 07:07:19 -07:00
Brian Wilkerson 1c4cee9a82 Remove an obsolete test 
Review-Url: https://codereview.chromium.org/2925723002 .
 2017-06-05 14:45:11 -07:00
Brian Wilkerson dc972240d4 Remove unused IdeOptions 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2924633002 .
 2017-06-05 14:12:17 -07:00