dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1474 Commits

Author SHA1 Message Date
Brian Wilkerson e8a5e404c3 Move LocalDeclarationVisitor for use by contributors that will be moved to analyzer_plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2918343002 .
 2017-06-05 10:24:54 -07:00
Brian Wilkerson b5c630426c Update a few more methods in FixProcessor, and fix some bugs in ChangeBuilder 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2916923002 .
 2017-06-02 07:36:51 -07:00
Konstantin Shcheglov 9737664106 [Extract Method] When no selection, check for implicitly selected closure. 
R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review-Url: https://codereview.chromium.org/2907213002 .
 2017-05-30 11:11:46 -07:00
Brian Wilkerson f6c6c01211 Update some of the fixes to use ChangeBuilder 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2910683002 .
 2017-05-30 08:01:52 -07:00
Konstantin Shcheglov ab9ee72a34 Switch server tests to strong mode. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2903523003 .
 2017-05-23 14:58:53 -07:00
Brian Wilkerson 0929b7736e Convert quick assist support to use AnalysisDriver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2899843002 .
 2017-05-22 13:45:55 -07:00
Brian Wilkerson 7e47a24c8a Convert quick fix support to use AnalysisDriver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2894403003 .
 2017-05-22 10:41:57 -07:00
Steve Messick 5455f21565 Fix reparent on windows 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2892963002 .
 2017-05-19 10:28:44 -07:00
Brian Wilkerson 7d26ff6d4f Remove some more library directives 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884233004 .
 2017-05-17 08:02:08 -07:00
pq aa491e7133 Support tear-off completions for named params (in constructors) (flutter-intellij#836) 
R=danrubel@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/836
Review-Url: https://codereview.chromium.org/2883363002 .
 2017-05-16 13:40:33 -07:00
Brian Wilkerson fb982f5476 Make server use the common protocol classes 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2879273002 .
 2017-05-15 09:35:46 -07:00
Devon Carew 4afc0aeb73 Fix some analysis issues. 
BUG=
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2882003002 .
 2017-05-13 16:24:47 -07:00
Konstantin Shcheglov a4fd5d814f Extract PerformanceLogger from AnalysisDriver. 
I also added the runAsync().

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2883633002 .
 2017-05-12 14:27:50 -07:00
danrubel 69cc6c3183 convert completion tests to use new analysis driver 
Update more tests and remove dead code from tests

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2875223003 .
 2017-05-12 11:48:20 -07:00
Brian Wilkerson bef53e72e4 Remove unintentional dependency on analysis_server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2875323002 .
 2017-05-12 10:07:37 -07:00
danrubel 66bb2d618e Remove unused analysisContext from completion request and contributors 
Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.

R=brianwilkerson@google.com, pquitslund@google.com

Review-Url: https://codereview.chromium.org/2877653002 .
 2017-05-11 09:38:50 -07:00
danrubel 6798cdfcd1 cleanup dart code completion contributors 
Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.

DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2873943003 .
 2017-05-11 09:12:36 -07:00
Steve Messick 55097a44b3 Recover from merge problem 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2868383002 .
 2017-05-10 13:12:14 -07:00
Brian Wilkerson fbc3f3708d Remove unused reference to SearchEngine 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2872803003 .
 2017-05-09 14:32:12 -07:00
Brian Wilkerson 1f893e86a9 Clean up some warnings 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2874443003 .
 2017-05-09 13:07:06 -07:00
Brian Wilkerson 98e8f17b96 Convert server to use RangeFactory 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2869083002 .
 2017-05-09 10:08:14 -07:00
Konstantin Shcheglov bd1ee32543 Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/. 
We are going to reuse ByteStore in front_end, also for incremental
compilation.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2869803004 .
 2017-05-09 09:12:15 -07:00
pq 11558c8a90 Add trailing commas after Flutter instance creation params fixes (flutter-intellij/#f978). 
R=brianwilkerson@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/978
Review-Url: https://codereview.chromium.org/2864373003 .
 2017-05-09 07:00:15 -07:00
danrubel 959b7c14b8 improve completion for formal param initializers 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2864233002 .
 2017-05-08 06:50:46 -07:00
Brian Wilkerson 6b8a56cd7f Switch the default from non-driver to driver in several tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2864813002 .
 2017-05-07 08:34:16 -07:00
Brian Wilkerson 863bd921e1 Remove the non-driver versions of several tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2863593004 .
 2017-05-05 13:46:03 -07:00
Brian Wilkerson 0b59d3f650 Convert some tests to use the driver and prepare for others to be converted 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2859993004 .
 2017-05-05 13:20:38 -07:00
Brian Wilkerson d2bbfb4f77 Make an AstProvider available to AssistProcessors 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2862143003 .
 2017-05-05 09:24:30 -07:00
pq 1a394e975f Specify types in generated closure args. 
Follow-up from: https://github.com/flutter/flutter-intellij/issues/975

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2863683002 .
 2017-05-04 12:54:23 -07:00
pq 374871da75 Add default implementation when fixing missing required closures (flutter-intellij#975) 
Fixes: https://github.com/flutter/flutter-intellij/issues/975

Also improves code generation for required lists to include empty list literals.

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2862623002 .
 2017-05-03 13:22:52 -07:00
pq a51af38461 Widget details for Flutter children: param completions. 
R=brianwilkerson@google.com

See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2855883003 .
 2017-05-02 13:50:34 -07:00
Steve Messick 28b7710190 Complete declarations; detect invalid blocks 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2852073002 .
 2017-05-01 08:45:41 -07:00
jpaulsen 6ff38127d6 New Lint quick-fix: await_only_futures (#29490) 2017-04-28 14:00:52 -07:00
jpaulsen ddd9bb1be2 New Lint quick-fix: avoid_annotating_with_dynamic (#29489) 
New Lint quick-fix: avoid_types_on_closure_parameters
 2017-04-28 13:40:51 -07:00
Brian Wilkerson e55812a3f2 Unify the server and plugin versions of the generators 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2844273003 .
 2017-04-28 07:46:29 -07:00
pq daa399499d Fix following comma detection in code completion (#29503). 
BUG=
R=brianwilkerson@google.com

Fixes: https://github.com/dart-lang/sdk/issues/29503
Review-Url: https://codereview.chromium.org/2849703002 .
 2017-04-27 16:52:33 -07:00
pq efb5c5ddc5 Trailing commas for named args in Flutter cons invocations (flutter-intellij#551). 
* adds trailing commas to named params in Flutter instance creations
* adds trailing commas to default value boilerplate

See https://github.com/flutter/flutter-intellij/issues/551 for action shots. :)

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2850693002 .
 2017-04-27 14:58:02 -07:00
jpaulsen f929ab15e7 New Lint quick-fix: empty_statements (#29491) 2017-04-27 14:10:17 -07:00
pq e02902578b Fix selectionOffset testing. 
Follow-up from: https://codereview.chromium.org/2839273002/.

BUG=
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2848643003 .
 2017-04-27 10:54:24 -07:00
pq bfc071e515 Named arg completion fixes. 
Related to: https://github.com/flutter/flutter-intellij/issues/551

* fixes named arg selection offset to precede comma
* fixes inconsistent trailing commas between completions w/ and w/o prefixes

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2839273002 .
 2017-04-27 10:12:47 -07:00
jpaulsen 404f9a806c New Lint quick-fix: prefer_conditional_assignment (#29473) 2017-04-26 12:56:36 -07:00
jpaulsen ff46777c61 New Lint quick-fix: unnecessary_override (#29472) 2017-04-26 12:56:26 -07:00
Dan Rubel 3b790e5311 new TokenType and Keyword API 
This adds two new methods and adapts most of the old references
to use these new API. Once all call sites have been updated,
the old API can be removed.

This is part one of https://codereview.chromium.org/2842643004/

* replace type == TokenType.KEYWORD with type.isKeyword
* change Keyword.syntax --> Keyword.lexeme

R=paulberry@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2842213003 .
 2017-04-26 15:53:58 -04:00
jpaulsen 7979eadef0 New Lint quick-fix: unnecessary_this (#29469) 2017-04-25 16:40:01 -07:00
jpaulsen b90aad2b2e New Lint quick-fix: unnecessary_lambdas (#29459) 2017-04-25 16:14:58 -07:00
Steve Messick 17360ffa6d Add colon to switch cases and default 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2837063003 .
 2017-04-25 11:13:54 -07:00
Steve Messick 8c2aae7dee Fix detection of bad catch-clauses and try-statements 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842523002 .
 2017-04-24 12:00:14 -07:00
jpaulsen dcba4b42cd New Lint quick-fix: prefer_collection_literals (#29378) (#29427) 2017-04-24 10:49:25 -07:00
Steve Messick 00d04dda08 Add special completion for control-flow block exits 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2834913002 .
 2017-04-21 14:51:45 -07:00
Steve Messick 6407af5dcb Clean up TODOs 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2830793007 .
 2017-04-20 15:19:16 -07:00