dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1474 Commits

Author SHA1 Message Date
Konstantin Shcheglov 860a624410 New Quick Assist to wrap with Center. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I729501ba128d2b287e0731fa63c84864f7435d3c
Reviewed-on: https://dart-review.googlesource.com/38167
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-01 23:21:34 +00:00
Konstantin Shcheglov 0ff7348c7b Switch tests to use Flutter package mock that more closely resembles the actual package structure. 
So, we can test that "Wrap with Center" works when we ask for Center
in package:flutter/widgets.dart

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I3446f5cf97c1d6f2e68686de6561d894b5e95620
Reviewed-on: https://dart-review.googlesource.com/38162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-01 22:12:06 +00:00
Konstantin Shcheglov b0e5ff1a76 Add a test for a field rename that potentially conflicts with a parameter with null visible range. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/31497
Change-Id: I8293612a3dde1f794e871cf7b5a9384db3574c91
Reviewed-on: https://dart-review.googlesource.com/38100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-01 18:47:38 +00:00
Brian Wilkerson 0916cca7d2 Do not convert return type of enclosing function when adding async to nested closure (issue 30901) 
Change-Id: I8293b7784f71d4ff7846a0cca6efbfa69847b7da
Reviewed-on: https://dart-review.googlesource.com/37646
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-01-30 21:57:10 +00:00
Brian Wilkerson 0091dc986e Add an assist to convert from sync function body to async 
Change-Id: I2531c47354c76b7c4c2b16151abdcd135db21954
Reviewed-on: https://dart-review.googlesource.com/37221
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-01-29 18:07:13 +00:00
Alexandre Ardhuin 1c99838190 add quickfix for prefer_const_declarations 
Closes #31993
https://github.com/dart-lang/sdk/pull/31993

GitOrigin-RevId: d1f51397639405d05e64022c5e41659d51c7d65c
Change-Id: Iefcf9556bd5f63b01f60df5437761bf277de4fd3
Reviewed-on: https://dart-review.googlesource.com/37301
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-01-29 16:49:23 +00:00
Mike Fairhurst cb7e85a26d Support void as a Top type, with as few other changes as possible. 
Change-Id: Ife337e28fa86f9b98cdabf48a01a4e2f608aa4b8
Reviewed-on: https://dart-review.googlesource.com/35520
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-01-26 22:42:08 +00:00
danrubel 787d395389 Update code completion to suggest covariant 
In addition to updating code completion, this also
addresses comments in https://dart-review.googlesource.com/c/sdk/+/34520
* Change expect to assert `}` where expect is unnecessary
* Extract skipToLastModifier utility method
* Fix spelling

Change-Id: I6a0446d77fac995da3e4d1d2f682f75d584b275f
Reviewed-on: https://dart-review.googlesource.com/34960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-01-17 03:30:23 +00:00
Paul Berry 105b170ddb Roll package test to 0.12.29+1 and stack_trace to 1.9.0 
This required some changes to analysis_server, since analysis_server
used to have its own version of pumpEventQueue().  Since
pumpEventQueue() is now provided by the test package, I've removed
analysis_server's version, and I've updated some of the call sites to
pass in "times: 5000" to replicate the old analysis_server behavior.

This also required some changes to analyzer, since the fail() method
is now marked as @alwaysThrows, so no code may follow it without
producing a dead code hint.

Change-Id: Ie5ef3a5cc685c18da02de699e59f63f3bb8865f7
Reviewed-on: https://dart-review.googlesource.com/32683
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-01-07 14:22:23 +00:00
Dan Rubel a459bc8b7c Add fasta parser constructor reference recovery 
This CL fixes/improves 2 keyword contributor situations
when analyzer is using the fasta parser:

* Recover gracefully given a constructor reference
  followed by a dot without an identifier

* Include a colon whenever suggesting the 'default' keyword

Change-Id: I393ef16130c7d1288ac4c18e6fdc17dbbe1421ea
Reviewed-on: https://dart-review.googlesource.com/32145
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-01-03 20:42:24 +00:00
Brian Wilkerson 4b36e4e6c8 Handle converting expression function bodies with a throw expression 
Change-Id: Ic1692b5196ea117263e008b105a8db6a97b9a40a
Reviewed-on: https://dart-review.googlesource.com/31962
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-01-02 19:17:53 +00:00
Brian Wilkerson c40d9821dc Prepare for optional new/const 
Change-Id: I138fffc3f03f2925d5b33cd7f340543789d4b6e6
Reviewed-on: https://dart-review.googlesource.com/31960
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-01-02 16:33:24 +00:00
Brian Wilkerson 8e7781ea9e Convert remaining tests to use ResourceProviderMixin 
Change-Id: I7bd0941a415737bd3c9c55e9650f2a982937f777
Reviewed-on: https://dart-review.googlesource.com/31961
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-01-02 16:33:14 +00:00
Brian Wilkerson 1d8a5d77c1 Convert more tests to use ResourceProviderMixin 
Change-Id: Ia4cce51e33c79c82a989bfda9b8303dfaa72e103
Reviewed-on: https://dart-review.googlesource.com/31880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-01-02 00:47:34 +00:00
Brian Wilkerson 98e0c26a89 Convert several test classes to use ResourceProviderMixin 
Change-Id: I1c85c6f29ae74cca0b594fc1f9ddae098b815e72
Reviewed-on: https://dart-review.googlesource.com/31860
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-01-01 16:21:02 +00:00
Brian Wilkerson 09edf6b3fe Remove an unused import 
Change-Id: I67c1b7a1bf24fcfb83d7ceb4be60d1492c6c54af
Reviewed-on: https://dart-review.googlesource.com/31405
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-28 16:41:13 +00:00
Dan Rubel 1231e90fee Code complete identifiers not directly referenced by the analyzer AST 
The fasta parser sometimes "drops" unexpected tokens during recovery.
When this happens, the dropped or skipped token is not reported to
the listeners, and thus does not become part of the analyzer's AST.
These tokens are still in the token stream, but will not be found
by the existing CompletionTarget mechanism.

For example, the fasta parser parses
'if (v i) {}' as 'if (v) {}' and drops the 'i' token.

This CL introduces a new CompletionTarget.droppedToken field.
If a keyword or identifier has been dropped by the parser,
but overlaps the code completion offset, then that token
is placed into this new field.

In the example above, when code completing the 'i',
the CompletionTarget will now be
containingNode = '(v)'
entity         = ')'
droppedToken   = 'i'

Change-Id: I15e43529ab4a72de9500c521be278fa13ae68d99
Reviewed-on: https://dart-review.googlesource.com/31285
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-12-22 21:55:35 +00:00
Dan Rubel 3392f32e50 Update code completion of async keywords 
This updates the KeywordContributor for use with the fasta parser
and cleans up several code completion tests by introducing
a 'usingFastaParser' flag.

Change-Id: Ife2d945065c23ccd9f2d8e85e5c24a6b956c75ae
Reviewed-on: https://dart-review.googlesource.com/30902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-12-21 15:36:11 +00:00
Dan Rubel 4e8c6e7862 Add more fasta parser field recovery 
Change-Id: I8a63e04c80931d2b2e8b24a547cc845837dee5d8
Reviewed-on: https://dart-review.googlesource.com/30625
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-12-20 00:38:38 +00:00
Dan Rubel 166cc11a64 Add fasta parser function expression recovery 
Change-Id: Id5e27b8f186da23fd141fda12621f1ae3bcd1f8c
Reviewed-on: https://dart-review.googlesource.com/30580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-12-19 20:57:43 +00:00
Dan Rubel c2ae2137c9 Improve code completion suggestions in argument lists 
This updates keyword code completion to suggest 'async', 'async*',
and 'sync' in new situations. This is necessary given that the fasta
parser recovers in a slightly different way than the analyzer parser.

Change-Id: I44cb42bc02874811df94a6586c7b9c9b5d7574c9
Reviewed-on: https://dart-review.googlesource.com/30460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-12-19 16:06:52 +00:00
Brian Wilkerson 941b3b25c3 Clean up some failing tests 
Change-Id: I79d951bab655ac322750222f921e055ad6ed6ef9
Reviewed-on: https://dart-review.googlesource.com/29040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-13 14:16:36 +00:00
Brian Wilkerson 081074ebf4 Completion suggestion relevance influenced by parameter types (issue 31592) 
Change-Id: I8f03dea74fac8080bc628128a0f32b09784d0248
Reviewed-on: https://dart-review.googlesource.com/28780
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-12 18:40:59 +00:00
Konstantin Shcheglov 0fb3ff477f Issue 31589. Return only unique top-level declarations. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/31589
Change-Id: Ife9c607071bba90afb04ceb828203664fab49861
Reviewed-on: https://dart-review.googlesource.com/28122
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-12-11 16:54:33 +00:00
Jens Johansen 22d0696d91 [CFE] Move front-end API under src/ 
This CL deprecates the front-end API and moves it into src/api_prototype.

For now all usages have been updated to point to the new location,
but they should be updated to use custom-client invocations instead (e.g.
one specific way for DDC, another for dart2js etc.)

Bug:
Change-Id: I9b4f41f6ebf55d42510fd35240d942d1dc7292d6
Reviewed-on: https://dart-review.googlesource.com/24822
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2017-12-01 08:42:16 +00:00
Devon Carew 331c3ab82f Only show dart files in the imports code completion. 
Bug:
Change-Id: Ib2e48422e85c6abcdf0c8af33a8f80e6d36111f5
Reviewed-on: https://dart-review.googlesource.com/23700
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-25 22:20:08 +00:00
Devon Carew dd6e86a2e0 Update flutter code completion to work for slivers. 
Bug:
Change-Id: I87868135fd742d443b4fc2c8a4cae49902502b85
Reviewed-on: https://dart-review.googlesource.com/21880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2017-11-19 01:20:26 +00:00
Konstantin Shcheglov 5ea30b4e3d Rename performace_logger.dart to performance_logger.dart 
R=paulberry@google.com, sigmund@google.com

Bug:
Change-Id: Ib7b6d122dff3ddabde3db2270daa777a269e04ed
Reviewed-on: https://dart-review.googlesource.com/18512
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-11-03 20:24:00 +00:00
Konstantin Shcheglov c5722c682b Don't propose the 'Remove Type' Quick Assist when there is no initializer. 
R=brianwilkerson@google.com

Bug:
Change-Id: If87a9b171ac0672772ee971051687a171c0bcd06
Reviewed-on: https://dart-review.googlesource.com/18510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-11-03 20:13:00 +00:00
Konstantin Shcheglov 2470d9fc74 Don't suggest to/from expression body Quick Assist when selection is in the expression. 
Flutter return expressions in build() methods can be quite long,
and it is surprising to see this Quick Assist, and not clear to
what it will be applied. Especially when the method is so long that you
don't even see its beginning.

R=brianwilkerson@google.com, devoncarew@google.com

Bug:
Change-Id: Ib245c34f3cbc51add23810c025ebda9d8471ee9b
Reviewed-on: https://dart-review.googlesource.com/17621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-31 18:51:37 +00:00
Konstantin Shcheglov 68a89d10ef Fix for EOL when adding missing overrides for not empty classes. 
R=brianwilkerson@google.com

Bug:
Change-Id: I95a801fed5925959fd9db58c96ecb60fbf7e6899
Reviewed-on: https://dart-review.googlesource.com/17540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-31 17:46:35 +00:00
Konstantin Shcheglov 6b1658906e Support for Flutter is not limited to code correction. Move to utilities. 
R=brianwilkerson@google.com

Bug:
Change-Id: Idaa90946710fcbec2a35a91eb35b5ead68cf4170
Reviewed-on: https://dart-review.googlesource.com/16621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-25 19:11:38 +00:00
Konstantin Shcheglov 577bb2dc7e Extract shorten() into string utils. 
R=brianwilkerson@google.com

Bug:
Change-Id: I68d17461b4b5b478df5713cadb120a130f492406
Reviewed-on: https://dart-review.googlesource.com/16602
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-25 18:54:34 +00:00
Konstantin Shcheglov 4c86f98d7a Drop the 'Flutter' word from names, expect that clients will use the 'flutter' import prefix. 
R=brianwilkerson@google.com

Bug:
Change-Id: I0275557bad66f03ed0d1b8388119b168d70bfad4
Reviewed-on: https://dart-review.googlesource.com/16600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-25 17:14:01 +00:00
Konstantin Shcheglov c2f1af6378 First steps for computing Flutter outlines. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug:
Change-Id: Ib8151df40439a28da536d467a5c0e7354fcfba51
Reviewed-on: https://dart-review.googlesource.com/16338
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-25 17:00:56 +00:00
Konstantin Shcheglov 82d90f6773 Add tests for isFlutterWidget() and isFlutterWidgetCreation(). 
R=brianwilkerson@google.com, devoncarew@google.com

Bug:
Change-Id: I7946941e458e1ba538921b0e8552dbe555fb0aab
Reviewed-on: https://dart-review.googlesource.com/16303
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-24 21:26:48 +00:00
Devon Carew e6a34d78f1 Improve the extract method refactoring for flutter build() methods. 
Bug:
Change-Id: Ic957eede0989b9cd171212425d5da0aad83bc941
Reviewed-on: https://dart-review.googlesource.com/11740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-10-08 01:41:41 +00:00
Konstantin Shcheglov fcecf07f92 Make names suggestions for index operator to use only 's' suffix. 
R=brianwilkerson@google.com

Bug:
Change-Id: I69d60eb23a1100e8776199dfb3082314062e231a
Reviewed-on: https://dart-review.googlesource.com/12220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-07 01:40:16 +00:00
Brian Wilkerson 31cf7dda06 Do not create parameters for non-final fields 
Change-Id: Id7d213d3408739301217c1638d050d0b3946fc76
Reviewed-on: https://dart-review.googlesource.com/12100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-10-06 18:39:11 +00:00
Konstantin Shcheglov e925eb125c Fix type code for typedefs after switching to GenericTypeAliasElement. 
https://dart-review.googlesource.com/c/sdk/+/9421

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I25d60ff904f15e6eeefff97b08ba9870d69733db
Reviewed-on: https://dart-review.googlesource.com/9460
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-29 04:27:53 +00:00
Konstantin Shcheglov d4dec4e1a4 Create GenericTypeAliasElement for both FunctionTypeAlias and GenericTypeAlias nodes. 
Some pain points are:

1. It is a breaking change. I think I will break it even more by removing
   FunctionTypeAliasElement altogether.

2. We lose ability to keep track that this FunctionType is instantiation
   of a typedef. Just like in Kernel.

3. We sometimes have to look up to see if the GenericFunctionTypeElement
   is a function in a named GenericTypeAliasElement.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ib250cc446a0ed5b8969f16f7cc6293ef4acf01a8
Reviewed-on: https://dart-review.googlesource.com/9421
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-29 00:39:05 +00:00
Brian Wilkerson c0bf4ab395 Handle recursive import/export graph in completions 
Change-Id: Ia164c13f3119f569d781292353acc17243c8a464
Reviewed-on: https://dart-review.googlesource.com/7000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-19 18:01:04 +00:00
Devon Carew 2b3b0272c4 Switch to using specific throws calls instead of general throwsA() calls. 
Bug:
Change-Id: Id604dca1b8c3060c1d12c9ed0b1493771d2eb0d6
Reviewed-on: https://dart-review.googlesource.com/5883
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2017-09-14 18:04:44 +00:00
Devon Carew b12d010064 Remove the use of deprecated package:test API. 
Bug:
Change-Id: I671678117f72efac5efd60d7b4e459dffcce47c6
Reviewed-on: https://dart-review.googlesource.com/5542
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-13 21:55:00 +00:00
Konstantin Shcheglov f7eba2359b Create new style GenericFunctionTypeElementImpl for function typed parameters. 
ParameterElement.parameters/typeParameters always return empty lists.

This was initially landed as https://dart-review.googlesource.com/c/sdk/+/3401,
but was rolled back because of dartdoc breakage.

R=brianwilkerson@google.com

Bug:
Change-Id: I328355fa4520536dfd0029966ad9f9af2e63a7d2
Reviewed-on: https://dart-review.googlesource.com/5000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-11 19:15:11 +00:00
Konstantin Shcheglov 1b4239d2e4 Export ByteStore and its implementations from front_end. 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug:
Change-Id: Ie2e3413a7f143e270cec2bd3ae4564ad7cc315b1
Reviewed-on: https://dart-review.googlesource.com/3840
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-09-07 19:23:21 +00:00
Lasse Reichstein Holst Nielsen 76a3b431bb Revert "Create new style GenericFunctionTypeElementImpl for function typed parameters." 
This CL broke the SDK API-doc generation.
See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fclient.dart%2Fdart-sdk-linux-be%2F15242%2F%2B%2Frecipes%2Fsteps%2Fgenerate_API_docs%2F0%2Fstdout

Change-Id: I2b4acd766fb65e82a29b73412833e04112ba9dc4
Reviewed-on: https://dart-review.googlesource.com/3460
Reviewed-by: Jonas Termansen <sortie@google.com>
 2017-09-06 10:43:11 +00:00
Konstantin Shcheglov a3f8740bbd Create new style GenericFunctionTypeElementImpl for function typed parameters. 
ParameterElement.parameters/typeParameters always return empty lists.

R=brianwilkerson@google.com

Bug:
Change-Id: I5200df9e891031437d6e597f30fa54399b7d00e1
Reviewed-on: https://dart-review.googlesource.com/3401
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-06 02:31:11 +00:00
Brian Wilkerson 28381b8f06 Add completion of keywords in partial field declarations 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/3006033002 .
 2017-09-03 13:04:06 -07:00
Brian Wilkerson 0db33f7053 Add fixes for more lints 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3009063002 .
 2017-09-02 15:11:29 -07:00