b936ffb329
Move several libraries out of the public API
...
Change-Id: I8259de00134310f25b1c6168940aea5190488999
Reviewed-on: https://dart-review.googlesource.com/51443
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-04-17 17:35:27 +00:00
1ff525c7f4
Add tests and fix a problem in inverting expressions.
...
R=brianwilkerson@google.com , danrubel@google.com
Change-Id: I4085efd1a4457f01ccb6cf62bd535fed61a1217a
Reviewed-on: https://dart-review.googlesource.com/49541
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2018-04-04 18:29:05 +00:00
4089111540
Revert "Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled.""
...
This reverts commit e5ed23fdb5R=brianwilkerson@google.com
Change-Id: Ida33856e965f06f773025f3c625d6ab3bace80a8
Reviewed-on: https://dart-review.googlesource.com/49280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-04-03 22:29:09 +00:00
e5ed23fdb5
Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled."
...
This reverts commit a1e4d8e0bfbrianwilkerson@google.com , devoncarew@google.com
>
> Change-Id: I8a96a5ccceae57c3ed5c1f2e0fd4897a7e99df03
> Reviewed-on: https://dart-review.googlesource.com/48883
> Reviewed-by: Devon Carew <devoncarew@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=devoncarew@google.com ,scheglov@google.com ,brianwilkerson@google.com
Change-Id: Ie3acf0794ed7b8264682e29aaa4bc1516fce6981
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/48900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-30 19:24:46 +00:00
bed5debbeb
Callable object support in Analyzer and DDC.
...
Fixes #32156
Fixes #32157
Fixes #32426
This also fixes `implements Function` so it has no effect in Dart 2
(it is ignored for the purposes of subtyping.)
Change-Id: Ibec9c77cd516b8b97fef68a579998598d0acf8c6
Reviewed-on: https://dart-review.googlesource.com/45141
Commit-Queue: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-03-30 18:14:55 +00:00
a1e4d8e0bf
Don't do implicit new/const code generation with --preview-dart-2 enabled.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I8a96a5ccceae57c3ed5c1f2e0fd4897a7e99df03
Reviewed-on: https://dart-review.googlesource.com/48883
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-30 18:07:25 +00:00
ce1d52481c
Don't remove unused imports when there are unresolved symbols.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/32124
Change-Id: If1b7b57bd98922768f28584325f668ba612c69d7
Reviewed-on: https://dart-review.googlesource.com/48705
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-29 21:44:19 +00:00
98f627f989
Issue 32708. Make GenericFunctionTypeElementForLink implement GenericFunctionTypeElementImpl.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/32708
Change-Id: I50e3bf46ca276dbffed9cccb39d800bebb9aec68
Reviewed-on: https://dart-review.googlesource.com/48761
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-29 19:47:29 +00:00
506ac7f953
Rework linker type inference using ExprBuilder.
...
This CL changes the way linker type inference works. Instead of
walking the operations in an UnlinkedExpr in order and inferring types
directly, it first builds an AST for the expression using ExprBuilder,
then uses ResolverVisitor to resolve the AST and perform type
inference.
This helps ensure that summary type inference and ordinary AST-based
type inference produce the same result, since they now use the same
core algorithm. In particular, this means that summary type inference
now does downwards inference properly.
Since the ResolverVisitor makes greater use of the element model than
the rest of the linker, this required implementing additional methods
in the linker's element model.
This CL includes some minor fixes to ExprBuilder that were uncovered
during testing. It also contains some minor changes to
ResolverVisitor to make it work during linking.
Fixes #32525 .
Fixes #32394 .
Change-Id: I5ec9b2bf5565ad30b8cc856475334323dc118da8
Reviewed-on: https://dart-review.googlesource.com/48741
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-03-29 17:16:39 +00:00
859632b439
Fixes for uninitialized fields of Flutter widgets create constructors in Flutter style.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/2021
Change-Id: Ia5c8989d463ce7071b31069313e4638dea7b13a6
Reviewed-on: https://dart-review.googlesource.com/48700
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-28 20:28:28 +00:00
59de9710ea
Complete Flutter's setState() as a whole statement, with a closure, and the caret inside the closure.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1916
Change-Id: I90b8c11c5435e1981fb334a4762bbe2131f3064f
Reviewed-on: https://dart-review.googlesource.com/48526
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-28 04:26:36 +00:00
8d1a0749b9
Create parameters only for unique referenced elements.
...
R=brianwilkerson@google.com
Change-Id: I1aad38c68454016846601b861432695eb6632242
Reviewed-on: https://dart-review.googlesource.com/48444
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-26 19:17:18 +00:00
cde2d81676
Check for name conflict in 'Extract Widget' refactoring.
...
R=brianwilkerson@google.com
Change-Id: Ifa620eafa32e4c2ce8b062328b562d6991ddfa0b
Reviewed-on: https://dart-review.googlesource.com/48442
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-26 18:54:38 +00:00
b0f3cd9022
'Extract Widget' should be available on the names of instance creation too.
...
R=brianwilkerson@google.com
Change-Id: I1a6c35a4d420da1663501d08e9032281c294c368
Reviewed-on: https://dart-review.googlesource.com/48341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-26 00:17:24 +00:00
ea1d1d7621
Support for extracting methods with parameters.
...
R=brianwilkerson@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1250
Change-Id: I906e14feba246a7704fbbcdaa358730be5916a47
Reviewed-on: https://dart-review.googlesource.com/47945
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-23 00:26:45 +00:00
696be0ae46
Initial support for extracting methods.
...
No support for method arguments and multiple invocations yet.
R=brianwilkerson@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1250
Change-Id: I11b817676e254b2a456d97d60d2ab45893a65e68
Reviewed-on: https://dart-review.googlesource.com/47940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-22 19:51:58 +00:00
dc5a8b2e91
Improve the fix to add an explicit cast
...
Change-Id: I748bd56265ea3072a3b7ed49fa77f6a9e91c3093
Reviewed-on: https://dart-review.googlesource.com/47242
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-03-22 15:27:27 +00:00
8658a7403e
Check for references/writes to superclass members.
...
R=brianwilkerson@google.com
Change-Id: I9907df6d773923fe6801034208a21f17fc86178b
Reviewed-on: https://dart-review.googlesource.com/47581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-21 19:42:25 +00:00
a8986cf45a
Support for parameters for extracted widget.
...
R=brianwilkerson@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1250
Change-Id: Iccb46976f3b92ed7dddac0e80f6ff48d905a495f
Reviewed-on: https://dart-review.googlesource.com/47542
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-21 18:51:13 +00:00
6469f4c78a
Support for extracting widget from a function.
...
R=brianwilkerson@google.com
Change-Id: I2775ac681f14d26d96a872aae98c473062d47305
Reviewed-on: https://dart-review.googlesource.com/47380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-20 23:29:19 +00:00
8abeb56ebb
Basic 'Extract Widget' refactoring.
...
Only a widget creation expression can be extracted.
Not exposed through Analysis Server API.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I6a47cc1851d69b54a2812bd6a5320c287d5b9eae
Reviewed-on: https://dart-review.googlesource.com/47360
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-20 21:24:56 +00:00
746c2557a2
Correctly handle casts of Set in quick fix
...
Change-Id: I00067a03b41cc0ace16501fc21b990b91ea0af61
Reviewed-on: https://dart-review.googlesource.com/46944
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-03-17 14:55:38 +00:00
f6f1327fbe
Add a fix to add an explicit cast
...
Change-Id: Ib27b2609cce14ea6d7c1666388c653e757b82a64
Reviewed-on: https://dart-review.googlesource.com/46881
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-03-16 16:43:58 +00:00
2881ebcd78
Fix for lint non_constant_identifier_names.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/32488
Change-Id: I76580a581845d8c6d3c8003b6b0f631a5fc40cdb
Reviewed-on: https://dart-review.googlesource.com/46822
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-15 22:44:44 +00:00
a0295ffa0e
Convert analysis_server tests to pass under preview-dart-2
...
Change-Id: Ibfdc53c7b1252166d44a0bda077e464a8c474572
Reviewed-on: https://dart-review.googlesource.com/46574
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-03-15 18:49:24 +00:00
693390a776
Index and search implicit references to optional positional parameters.
...
R=brianwilkerson@google.com
Change-Id: Icf5f48118aeccbc137f125f9e730c9fe84200063
Reviewed-on: https://dart-review.googlesource.com/45922
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-09 23:23:49 +00:00
8d47a6e86f
Add a fix for lints that recommend using final (issue 32473)
...
Change-Id: I9ba38998e99c6102c0b69a2a3f8427416d087f2e
Reviewed-on: https://dart-review.googlesource.com/45900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-03-09 22:09:18 +00:00
602a8c2a7b
Clean up usage of deprecated constants
...
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-03-09 01:02:49 +00:00
215aa21172
Boost completion relevance for more cases.
...
R=brianwilkerson@google.com
Change-Id: Ib5fe69d3a0d20e29f36575e692a7418b6744ca83
Reviewed-on: https://dart-review.googlesource.com/44281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-28 19:32:56 +00:00
4cf5b7df12
Boost relevance for compatible types in '==' and switch/case.
...
Probably less Flutter specific, but still useful.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I979e1a0640494a4a6cbedcec90781bc165c94f31
Reviewed-on: https://dart-review.googlesource.com/44000
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-27 17:36:40 +00:00
716daa3b0d
Add assists to convert between literal string styles
...
Change-Id: I691ff29d0bdc5a01cef6736f403025d1eee912d0
Reviewed-on: https://dart-review.googlesource.com/43580
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-02-24 21:45:32 +00:00
9567305bd6
Set selection position for Flutter move widget up/down assists.
...
This requires also changes to Dart plugin for IntelliJ, because currently
we use exit position only when there are linked edits. I attempted to
implement it myself, it mostly works, but there are race condition
complications.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Iff1a79ebb0cb7e0eabfe59e45d8dde7559c60a0f
Reviewed-on: https://dart-review.googlesource.com/43600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-24 17:14:30 +00:00
316af55593
Suggest enum constants for imported enums.
...
So, you can complete `Column(crossAxisAlignment: ^)` and get all of
the CrossAxisAlignment right away for selection. Or you can start
typing `center` and by the time when you typed first letters, you get
several completion suggestions. There are several enums with `center`,
but because we give compatible types higher relevance, the correct
one is always the first.
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I6c2082668c6b25bf23e070915b5df03081ff0d5c
Reviewed-on: https://dart-review.googlesource.com/43485
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-23 19:26:36 +00:00
cc3e062578
Set higher relevance for exact type and subtype completions.
...
Exact type get the largest relevance boost, subtypes a smaller boost,
and the rest has default relevance for its element kind.
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: Ibb38caedc314e9cf476de2116aeb61bcec8c8a08
Reviewed-on: https://dart-review.googlesource.com/43263
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-23 06:05:13 +00:00
cbacb35d51
Fix selection range from override contributor and contribute when there is a leading annotation
...
Change-Id: If43dd85531d1c9cdcba0f750b299990c10991538
Reviewed-on: https://dart-review.googlesource.com/43140
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 20:22:29 +00:00
0ce1a92d98
Suggest constructors for implicit creation in previewDart2.
...
R=brianwilkerson@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I43270f47fb43402d1a9e0f7d9814494ffd83bb5e
Reviewed-on: https://dart-review.googlesource.com/43080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-22 18:03:12 +00:00
c840168ef2
Fix CombinatorContributorTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I198378b707df36852d4d7a90f98e4542b95c218c
Reviewed-on: https://dart-review.googlesource.com/42944
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 17:53:26 +00:00
5da95d7c9f
Fix AssistProcessorTest on Windows
...
Note: This fixes one of the tests but the other still fails. I believe
that's because of https://github.com/dart-lang/sdk/issues/32278 and
should pass once that issue is fixed.
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I6469b75de39e6476353da303c9c72cfba2da922e
Reviewed-on: https://dart-review.googlesource.com/43006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 17:37:11 +00:00
6074dcfdae
Fix LibraryPrefixContributorTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I7073e516109570ca80b1890368351e22b9ed844f
Reviewed-on: https://dart-review.googlesource.com/43004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 17:10:38 +00:00
82a1702cc8
Fix OverrideContributorTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I68f0691007820e5efbabca58b6436d0c68d81487
Reviewed-on: https://dart-review.googlesource.com/43005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 17:05:43 +00:00
f94a0f54e6
Fix CommonUsageSorterTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ie90a0b8823816d8b64f261e561183c35fb1737c8
Reviewed-on: https://dart-review.googlesource.com/43001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 16:56:03 +00:00
812b635ea3
Fix CompletionManagerTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I6b521604141b4584c4ed17470e7ea25b060af841
Reviewed-on: https://dart-review.googlesource.com/43003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 16:51:53 +00:00
6437794e32
Fix LocalLibraryContributorTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ie57904d6eac2eabe8538400b4e56b2c414aebb35
Reviewed-on: https://dart-review.googlesource.com/42921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 16:39:43 +00:00
e7d57c8535
Fix RenameClassMemberTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I57804f6c168cccdbfee62f8fa6b60b40f260015b
Reviewed-on: https://dart-review.googlesource.com/42946
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 16:17:33 +00:00
04830ac262
Fix RenameUnitMemberTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I98f2c5025615adf52919ea87d637a47ee50fe760
Reviewed-on: https://dart-review.googlesource.com/42942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 16:11:53 +00:00
9e96a89628
Fix NamedConstructorContributorTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I47d47bf7275f4e78d6e077d5f2c1e0ec4246c150
Reviewed-on: https://dart-review.googlesource.com/42943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 16:06:03 +00:00
0796ea4ee5
Fix RefactoringLocationTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ieead4b1d434740078a6383cafb426ddc4bbe002b
Reviewed-on: https://dart-review.googlesource.com/42941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 15:51:33 +00:00
1c44401f2e
Fix LocalReferenceContributorTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I75a3b5200f6ef06c3c14233d45c897ae8bdd655c
Reviewed-on: https://dart-review.googlesource.com/42923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 15:46:23 +00:00
427506d1f0
Fix LibraryMemberContributorTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I53c12fc79d0d5bf9331eb42714d7a6c29a5325af
Reviewed-on: https://dart-review.googlesource.com/42940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 15:36:43 +00:00
6a82f29e32
Fix ArgListContributorTest on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I04faca9575387faeca1cf6b505f05c15a1b0e670
Reviewed-on: https://dart-review.googlesource.com/42920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 15:29:36 +00:00
Brian Wilkerson