dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1474 Commits

Author SHA1 Message Date
Konstantin Shcheglov 0346acf550 Don't suggest generative constructors of abstract classes. 
So, we don't suggest EdgeInsetsGeometry for 'padding: ', even though
it is the type of the parameters. But we still suggest its subclasses
EdgeInsets and EdgeInsetsDirectional.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: If2d7ba550ec76e4f66cb81e1346466b5f1a30464
Reviewed-on: https://dart-review.googlesource.com/42888
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 02:03:33 +00:00
Konstantin Shcheglov fcccab9199 Filter constructor completions by required type. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I88eb345bfa7f0a65d135e5fdcb443d5dadd695c5
Reviewed-on: https://dart-review.googlesource.com/42882
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-21 23:12:31 +00:00
Konstantin Shcheglov ebd16bd33f New Quick Fix 'Convert to named arguments'. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1100
Change-Id: I317204424c38313c8c3eb844d9e8bb574118aa66
Reviewed-on: https://dart-review.googlesource.com/42860
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 20:07:09 +00:00
Danny Tuppeny 23127d04b6 Fix test_ArgDefaults_function_with_required_named test on Windows 
The changes in addSource are so that the driver gets the convertedPath
(newFile already converts).

The change in the test is to format a path for importing on Windows - it
seems that importing a file with an absolute path is a bit wonky on
Windows (I presume since this is testing imports it's using absolute
paths for a reason).

The helper in the Mixin is for doing the conversion from a Windows path
to an importable version of it (this has many questions to answer and
maybe already exists somewhere?).

See #32095.

Change-Id: Ifed137ac354f9d0527344020c719e0c3c81ccf3e
Reviewed-on: https://dart-review.googlesource.com/42681
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 18:49:19 +00:00
Danny Tuppeny d66e6b1c6e Fix refactoring tests on Windows 
This hand-built JSON fails on Windows because the paths being inserted
only have a single slash ("C:\test.dart") but in the real results the
JSON is encoded correctly and hhas two paths.

This works around the issue by JSON-encoding the filename but really the
whole object should be serialised to JSON properly.

Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I8aa418e8e3e6377ed01fe3bbecc3242f3a012629
Reviewed-on: https://dart-review.googlesource.com/42742
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 18:49:12 +00:00
Danny Tuppeny 358a8502fd Fix UriContributorTests on Windows 
See #32226.

Change-Id: I685b0b5875001a56af5c3cf623fe9bca7261b478
Reviewed-on: https://dart-review.googlesource.com/42740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 17:56:59 +00:00
Danny Tuppeny 20578644c0 Fix all remaining broken FixProcessorTest tests on Windows 
See #32226.

Change-Id: Idc80d0ac7441e1db8c0213093b9b79d4b3e70315
Reviewed-on: https://dart-review.googlesource.com/42700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 17:19:19 +00:00
Danny Tuppeny 40e3f9addc Convert paths for mock SDK libraries to fix tests on Windows 
The other lines on this method are calling `provider.convertPath` around their paths but these ones do not, which is causing almost all analysis server tests to fail on Windows (for me - I can't explain them not
failing builds). This causes the hard-coded paths like `/lib/core/core.dart` to be fixed up to `C:\lib\core\core.dart` which is what the server is looking for (because at the other end the paths *have* been fixed up).

See #32226.

Closes #32230
https://github.com/dart-lang/sdk/pull/32230

GitOrigin-RevId: 1adeee23f8ac8efc8acf61caf5f769e4ec44c030
Change-Id: Id9bf195967db0912c6f4b67bd79d504e627b8aab
Reviewed-on: https://dart-review.googlesource.com/42300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-20 18:55:38 +00:00
Brian Wilkerson ed88a91f62 Generate an import fix when an undefined function might be a constructor invocation 
Change-Id: I1cc98cb14d66db6b241e2a5b008f45881c41d13b
Reviewed-on: https://dart-review.googlesource.com/42340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-19 22:03:22 +00:00
Konstantin Shcheglov ded8dd2ad3 Don't add explicit 'new' when previewDart2. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32175
Change-Id: I05c5845a6e511698833045f99716231974e57b61
Reviewed-on: https://dart-review.googlesource.com/42320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-19 19:51:44 +00:00
Brian Wilkerson b48c12a000 Use the selection computed by the builder in the override contributor 
Change-Id: I85b7700bc137388d878c66282660df0d4b8d95af
Reviewed-on: https://dart-review.googlesource.com/42100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-16 20:52:52 +00:00
Konstantin Shcheglov b17ac68b60 Add <Widget> type arguments for wrapping with Column/Row. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I6e8ee33c453e552965d14ecb95391eb55b7b0bc6
Reviewed-on: https://dart-review.googlesource.com/42025
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-16 18:45:17 +00:00
Brian Wilkerson 0501c740ac Member overrides invoke the overridden member and the display label uses ellipses 
Change-Id: I9cb2db1514a8a2798cb3ec69d3d71047573a8dd4
Reviewed-on: https://dart-review.googlesource.com/41903
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2018-02-16 14:12:27 +00:00
Konstantin Shcheglov 7d0877dbf6 Remove unused methods in assist/fix tests. 
R=brianwilkerson@google.com

Change-Id: I6aa5ef067bb3cee4cbd8ffc01bf60bf0637f773e
Reviewed-on: https://dart-review.googlesource.com/41880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-15 19:13:35 +00:00
Konstantin Shcheglov 1e999ed9fe It is OK to inline Column with a single item in 'children' into a 'child'. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Ifa2a300b2735ab635bbaeeee08ce21ad8a7db9b7
Reviewed-on: https://dart-review.googlesource.com/41901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-15 18:25:57 +00:00
Konstantin Shcheglov 95f336a667 Don't suggest imports of private libraries from other packages. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1661
Change-Id: I5e458e8815d4f8df3e2f22bdfdc21c7203cefde0
Reviewed-on: https://dart-review.googlesource.com/41620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-15 17:11:56 +00:00
Konstantin Shcheglov 425e07d721 If selection in 'Extract Method' does not cover any node, extract the smallest covering expression. 
Two comments.

1. We need also to change the Dart plugin for IntelliJ to not select
   the whole line when selection if empty. The whole line is almost
   never a good choice for Flutter.

2. This is not fully consistent with "Extract Lolal" where we give the
   client the list of possible expressions to extract and the user can
   then choose. Here we use just the smallest one. If we want to make
   it consistent, we will need to enchance the protocol and the plugin.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I87a752234d9c825d78a6d787d2b21d1b252166c2
Reviewed-on: https://dart-review.googlesource.com/41520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-14 20:43:13 +00:00
Konstantin Shcheglov b5cb793fbd Convert unresolved 'children:' into 'child:'. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I3ea3f8a8be2e942a3fd00060519a7dbfeae6fb36
Reviewed-on: https://dart-review.googlesource.com/41481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-14 20:23:43 +00:00
Konstantin Shcheglov 4232ac99e8 Fix for surround-with linked edit positions. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32106
Change-Id: Ia899171aa38dd1283b72cdd100a0f5b678e9b565
Reviewed-on: https://dart-review.googlesource.com/41420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-14 18:55:33 +00:00
Konstantin Shcheglov 4749057586 Don't suggest converting unresolved 'child:' to 'children:'. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/841
Change-Id: Ib16b8a1e28e18cec9fd30a2f7d364355ce70b757
Reviewed-on: https://dart-review.googlesource.com/41060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-13 23:30:51 +00:00
Konstantin Shcheglov 51eb30dbba New Quick Assists 'Move widget down/up'. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1638
Change-Id: I84dd60d30409fde430bb9ba3eb794c3c404d66b1
Reviewed-on: https://dart-review.googlesource.com/41023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-13 23:01:41 +00:00
pq f2e063c35e Selection range calculation for override completions. 
Change-Id: If3a56c6b5274d5615742ded1ab213918331f4a0c
Reviewed-on: https://dart-review.googlesource.com/41021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-13 22:44:13 +00:00
Konstantin Shcheglov 83840eef9b Suggest 'Convert to children:' only when on 'child:'. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32135#issuecomment-365367458
Change-Id: I3891409c1fc1ae9cc4cc8731c1c452be9cba66ea
Reviewed-on: https://dart-review.googlesource.com/40960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-13 21:49:19 +00:00
Konstantin Shcheglov ff6347e448 Rename 'Replace with children' to 'Remove widget'. 
R=devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32135#issuecomment-365377923
Change-Id: I9da2c04590a32a28d109d7722df137e1a31712d1
Reviewed-on: https://dart-review.googlesource.com/40961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-02-13 20:10:19 +00:00
pq 35221ce1fc Override completion displayText implementation. 
Change-Id: If19ccb00145ec4befec2be575af48709f122b511
Reviewed-on: https://dart-review.googlesource.com/40510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-13 19:15:26 +00:00
Konstantin Shcheglov fdeadfd7e9 Don't suggest to center the Center widget. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32135
Change-Id: Ic6ab36a2ad5ac9b7737383700a0513feee4f3946
Reviewed-on: https://dart-review.googlesource.com/40920
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-13 18:46:44 +00:00
Brian Wilkerson 850ec64864 Add a fix to make const instance fields static (issue 32128) 
Change-Id: I1ca5cbf95f28ed36133bd562d3b7ce6a58d19ce6
Reviewed-on: https://dart-review.googlesource.com/40640
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-02-12 23:40:08 +00:00
Konstantin Shcheglov 19500670b9 Rename Flutter assist constants to better reflect what they are doing. 
Particularly that "reparent" is "wrap", and "move up/down" is "swap".

R=brianwilkerson@google.com

Change-Id: Ie6fcaa178e41a161061f05b81a8b1cff506b0714
Reviewed-on: https://dart-review.googlesource.com/40620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-12 22:26:29 +00:00
Konstantin Shcheglov c1d5d843af Add identifiers for Quick Assists. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I07cd18ae38f98793f960a2c7bd971527eaa6d7d6
Reviewed-on: https://dart-review.googlesource.com/40140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-12 20:56:09 +00:00
Brian Wilkerson 356064c716 Add an assist to convert from an in-line function type to a generic function type 
Change-Id: I1277283df593c96f37c90a90f923ded12cb331a2
Reviewed-on: https://dart-review.googlesource.com/40503
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-02-12 16:58:32 +00:00
Konstantin Shcheglov 7cffd55c41 Don't suggest anything right after double or integer literals. 
R=brianwilkerson@google.com, danrubel@google.com

Change-Id: Ib8b9091daedb1e1921ae3c454e83a5b96d94a71a
Reviewed-on: https://dart-review.googlesource.com/40471
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-02-12 01:18:35 +00:00
Konstantin Shcheglov 456890cd2c Enable completion in AssertInitializer. 
R=brianwilkerson@google.com, danrubel@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1101
Change-Id: Id17a701cac0e98afc373cf89089916cf5f983cff
Reviewed-on: https://dart-review.googlesource.com/40472
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-12 01:01:31 +00:00
Konstantin Shcheglov befb4f943a Check that the declaration with unimplemented members is ClassDeclaration (not ClassTypeAlias). 
Another exception from logs.

R=brianwilkerson@google.com

Change-Id: I87ee5a7ad9c7171b23714a23f8ee861688bbf331
Reviewed-on: https://dart-review.googlesource.com/40467
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-09 20:41:39 +00:00
Konstantin Shcheglov 49686f7ffa Don't insert a trailing comma after a missing required argument, when there is on already. 
R=brianwilkerson@google.com

Change-Id: I47819c9d2698880f793de2e3c056e1112b1b8f57
Reviewed-on: https://dart-review.googlesource.com/40402
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-09 19:01:49 +00:00
Konstantin Shcheglov 0ee998b675 Replace 'throw fail()' with just 'fail()'. 
I saw these new warnings after SDK update.

R=brianwilkerson@google.com

Change-Id: I0c8113404758918ee2edf3c3392d135f466a6da1
Reviewed-on: https://dart-review.googlesource.com/40420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-09 18:54:49 +00:00
pq a4ecc44c30 Completion protocol API for overrides. 
Proposed API to allow IDEs to ask a suggestion for a displayText which may differ from the value to insert (the completion).

Also, adds a new OVERRIDE suggestion kind.

See: https://youtrack.jetbrains.com/issue/WEB-31130










Change-Id: Ic0644308d746ac7771bc27bc2ff2789444733af3
Reviewed-on: https://dart-review.googlesource.com/40101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-09 17:57:17 +00:00
Konstantin Shcheglov 59716fede1 New Quick Asists for Flutter: 'Replace with child' and 'Replace with children'. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1283
Change-Id: Ic50de9739cdab5cd82649dcbd8370c5e728d2ee3
     https://github.com/flutter/flutter-intellij/issues/1756
Reviewed-on: https://dart-review.googlesource.com/40240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-02-09 17:09:18 +00:00
Konstantin Shcheglov 87d73de98a New Quick Assist 'Convert to StatefulWidget'. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/31823
Change-Id: I0970a9f674f456cee20e96d4b3be3a4e3d577a8a
Reviewed-on: https://dart-review.googlesource.com/39921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-08 17:39:34 +00:00
Brian Wilkerson 39448ff521 Improve creation of overriding methods (issues 30730 and 30759) 
Change-Id: I96a06f6ad2646d4590804c2e5d8d7f6ab95dbd74
Reviewed-on: https://dart-review.googlesource.com/39844
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-07 22:16:00 +00:00
Konstantin Shcheglov f3242f8533 Fix for some cases of indentation in 'Move widget up/down'. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/Dart-Code/Dart-Code/issues/495
Change-Id: I62c8374a1b7a578886bad1fec5a7c8eaf83cf231
Reviewed-on: https://dart-review.googlesource.com/39841
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-07 20:08:19 +00:00
Konstantin Shcheglov c9c9e10432 New quick assist to put selected widget(s) into new Column/Row. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Idba133a70c3c8bfe8f88c7a58afbe909617d4292
Reviewed-on: https://dart-review.googlesource.com/39340
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-06 22:02:13 +00:00
Konstantin Shcheglov cfa159ceb3 Wrap any Flutter widget expressions, not just instance creations. 
Relanding https://dart-review.googlesource.com/c/sdk/+/38922 with all
changes.

Change-Id: I40b533521f420eccf2f4f86cf9e722ab498636e2
Reviewed-on: https://dart-review.googlesource.com/39201
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-06 18:20:13 +00:00
Konstantin Shcheglov 1d95d50192 Revert "Wrap any Flutter widget expressions, not just instance creations." 
This reverts commit 9356382e6b.

Reason for revert: Landed incomplete change.

Original change's description:
> Wrap any Flutter widget expressions, not just instance creations.
> 
> So, we can wrap references to widgets, e.g. variables.
> 
> R=​brianwilkerson@google.com, devoncarew@google.com
> 
> Change-Id: Idc233251a3f5a62e47a0899c27f524537a3497d3
> Reviewed-on: https://dart-review.googlesource.com/38922
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=devoncarew@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: I0b7c75802e328bc3ae7fdc4c2be6fab663bac570
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-06 17:36:13 +00:00
Konstantin Shcheglov 9356382e6b Wrap any Flutter widget expressions, not just instance creations. 
So, we can wrap references to widgets, e.g. variables.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Idc233251a3f5a62e47a0899c27f524537a3497d3
Reviewed-on: https://dart-review.googlesource.com/38922
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-06 17:35:34 +00:00
Konstantin Shcheglov 60473b9ff9 Produce 'Convert into async function body' only when on a function header. 
Practically everywhere aside the function body itself, because bodies
can be pretty long.

R=brianwilkerson@google.com

Change-Id: Ia3bbf4c196ce44a2972654512624b8171b394585
Reviewed-on: https://dart-review.googlesource.com/38880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-05 22:20:55 +00:00
Konstantin Shcheglov c16575c1f2 Issue 30884. Index MethodInvocation type arguments. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/30884
Change-Id: I0597d56d72fbff804ecf1a2f435815d02678eba6
Reviewed-on: https://dart-review.googlesource.com/38784
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-05 19:34:46 +00:00
Brian Wilkerson 740a0e751e Rework part of DartChangeBuilder to deal better with type parameters (issue 31199) 
Change-Id: I1946e6070c0dcffaa02f61b9c7f857168a050a27
Reviewed-on: https://dart-review.googlesource.com/38483
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-02-05 18:21:36 +00:00
Brian Wilkerson c492dc1084 Add a test for issue 30884 
Change-Id: I79c999965aa4dcdc49b94ea09f7863e75f2dc07e
Reviewed-on: https://dart-review.googlesource.com/38484
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-05 17:12:27 +00:00
Konstantin Shcheglov 65e6697cf8 Add 'Add padding' quick assist. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I03ed7ec1c25dd8e9ee7b115d95f24baeee016251
Reviewed-on: https://dart-review.googlesource.com/38341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-02 21:26:39 +00:00
Brian Wilkerson fba13af5a9 Finish updating OverrideContributor to use DartChangeBuilder 
Change-Id: Ib3190e6825994c9e727fb80a319cfc04be943b76
Reviewed-on: https://dart-review.googlesource.com/38143
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-02 16:19:37 +00:00