dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1474 Commits

Author SHA1 Message Date
Steve Messick b9c214f374 Compete try-statements 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2834513004 .
 2017-04-20 13:09:23 -07:00
Steve Messick 0829174516 Complete for-each and switch statements 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2826283002 .
 2017-04-19 14:44:41 -07:00
Konstantin Shcheglov 91d6dcf9fb We cannot use relative URIs to reference files outside of a package. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2830733002 .
 2017-04-19 10:09:14 -07:00
Erik Corry 23c0caf4dc Revert "New Lint quick-fix: prefer_collection_literals (#29378)" 
This reverts commit 6a56c86c81.
This a gardener revert to fix buildbot redness.

R=karlklose@google.com, loitsch@google.com
TBR=casanueva@google.com
BUG=

Review-Url: https://codereview.chromium.org/2827863003 .
 2017-04-19 12:49:07 +02:00
jpaulsen 6a56c86c81 New Lint quick-fix: prefer_collection_literals (#29378) 2017-04-18 18:55:08 -07:00
Steve Messick 6a19d96ee2 Complete for-statement 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2824233002 .
 2017-04-18 15:20:31 -07:00
jpaulsen c386e41f25 New Lint quick-fix: avoid_init_to_null (#29367) 2017-04-18 14:13:53 -07:00
Steve Messick b9f9ad24f1 Add completion for do-stmt, refactor for reuse 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2816943005 .
 2017-04-17 10:56:26 -07:00
Steve Messick eadc6af226 Statement completion framework with a few examples 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2803313002 .
 2017-04-07 13:55:50 -07:00
Dan Rubel 99aefce48c do not allow built-in keywords to specified when refactoring 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2802433002 .
 2017-04-04 17:13:42 -04:00
Brian Wilkerson dd49e79f74 Add context information to driver and add hooks for plugin management 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2795743002 .
 2017-04-03 10:13:45 -07:00
Konstantin Shcheglov 483066a697 Fix for Quick Fix to import SDK classes. 
It's not 100% replacement, we handle SDK libraries just as any other
library, if it has not been imported yet somewhere, we don't know
about it. But probably this covers the most often case of using a
library in a new file of the project that already uses this SDK
library.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2781963002 .
 2017-03-28 14:15:52 -07:00
pq 5a237935f0 Fix tests to verify defaultArgListString specified as null are null. 
* introduces a sentinel default value to ensure that we know when asserting if `null` was specified or the result of an excluded optional arg

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2769223004 .
 2017-03-24 11:53:00 -07:00
pq 4a9cabf493 Arglist children: default value gen fixes. 
* fixed arglist codegen (include params)
* fixed defaultTextRange generation (and added tests)
* cleanup (followup from https://codereview.chromium.org/2768273003/

R=brianwilkerson@google.com, danrubel@google.com

See: https://github.com/flutter/flutter-intellij/issues/832
Review-Url: https://codereview.chromium.org/2771123002 .
 2017-03-24 09:36:24 -07:00
pq 6f846bcd53 <Widget> boilerplate for Flutter children: suggestions. 
Cleanup (tracked in TODOs) and consolidation to follow.

R=brianwilkerson@google.com, danrubel@google.com

See: https://github.com/flutter/flutter-intellij/issues/832
Review-Url: https://codereview.chromium.org/2768273003 .
 2017-03-23 15:20:42 -07:00
pq df06af12eb Completion boilerplate for Flutter cons children (flutter-intellij#463) 
* plumbs IDE options into completion requests
* simple POC test

More tests and a bit of cleanup to come.

R=brianwilkerson@google.com

See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2771653002 .
 2017-03-22 15:14:28 -07:00
Steve Messick 221125d1ac Add quick-fix to convert child: to children: 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2753123003 .
 2017-03-17 14:49:42 -07:00
Jacob Richman a993294503 Format all analyzer packages 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2753923003 .
 2017-03-16 16:11:43 -07:00
Steve Messick 9a9074bf6b Add assist to convert child: to children: in Flutter new-exprs 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2749283004 .
 2017-03-16 07:44:05 -07:00
pq f33d072d91 Correct target of ADD_MISSING_REQUIRED_ARGUMENT fixes (flutter-intellij#788) 
* corrects insert target of `ADD_MISSING_REQUIRED_ARGUMENT` fixes
* updates `assertHasFix` to optionally verify fix target

R=brianwilkerson@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/788
Review-Url: https://codereview.chromium.org/2749373002 .
 2017-03-15 13:27:27 -07:00
pq cc0036d5ad Calculate text ranges for default args. 
Continued work on generating sensible default contents for args in completions.

Calculated text ranges allow us to produce linked edits in the IDE.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2727343002 .
 2017-03-02 13:14:49 -08:00
pq d826b1f931 Default arg support continued (flutter-intellij#553). 
Default arg support for:
  * inherited refs
  * imported refs
  * type members
  * local constructors

BUG=
R=brianwilkerson@google.com, scheglov@google.com

See: https://github.com/flutter/flutter-intellij/issues/553
Review-Url: https://codereview.chromium.org/2728653004 .
 2017-03-01 15:00:47 -08:00
pq d1bfe8bccb Calculate default args for local reference completions. 
First step towards wiring up default args for completions.

See: https://github.com/flutter/flutter-intellij/issues/553

Next up: similar enhancements for type_members, imported_refs, etc.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2722253002 .
 2017-03-01 11:45:01 -08:00
Steve Messick b3ed30b822 Add assists to move Flutter widgets up and down one level. 
Fixes:
https://github.com/flutter/flutter-intellij/issues/461

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2724473002 .
 2017-02-27 15:03:51 -10:00
pq 174a50bb89 Missing @required arg quick fix improvements. 
* fixes missing `HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS` case
* improve quick fix message (add name)
* update codegen

BUG=
R=scheglov@google.com

Fixes: #28830
Review-Url: https://codereview.chromium.org/2707223003 .
 2017-02-22 06:43:43 -08:00
Steve Messick 2da528aeac Add assist to reparent a list of Flutter widgets 
Apparently I forgot to sort the test file, so there's a bit of code rearrangement there.

I added the optimization to the filter from the previous CL here, too.

R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2701023002 .
 2017-02-17 13:11:30 -08:00
Steve Messick 7945b65449 Add assist to reparent Flutter widget 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2701563003 .
 2017-02-17 08:35:47 -08:00
pq e2808dff23 Add fix for missing @required params. 
Groundwork for: https://github.com/flutter/flutter-intellij/issues/553

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2692983003 .
 2017-02-15 09:02:44 -08:00
Konstantin Shcheglov 663b7f665e Analysis.getHover should return the field's documentation for field formal parameters. 
Also return the parameter's element with completion suggestion.

R=brianwilkerson@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/385

Review-Url: https://codereview.chromium.org/2681233005 .
 2017-02-10 08:49:40 -08:00
Konstantin Shcheglov 0a09ff53c3 Include the field documentation for named field formal parameter completion suggestions. 
R=brianwilkerson@google.com, devoncarew@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/385

Review-Url: https://codereview.chromium.org/2683233002 .
 2017-02-09 13:24:25 -08:00
danrubel 1680c434f2 suggest method references in named expressions 
Fix https://github.com/dart-lang/sdk/issues/25386

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2679503002 .
 2017-02-06 12:59:05 -05:00
danrubel 02adcc9614 suggest catch and finally keywords 
After a try block that does not have a "catch" block,
suggest the "catch" keyword and nothing else.
After a "catch" block, suggest the "finally" keyword.

Fix https://github.com/dart-lang/sdk/issues/27560

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662973007 .
 2017-02-06 12:57:57 -05:00
Konstantin Shcheglov 7d2447d795 Replace computeNode() with AstProvider in search. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2672973002 .
 2017-02-03 10:40:44 -08:00
Konstantin Shcheglov f600f5f9de Stop using Element.computeNode() in refactorings and fixes. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2669353002 .
 2017-02-02 17:24:31 -08:00
Dan Rubel f33c3c1676 complete named params in constructors 
This add completion suggestions for named parameters
in constructors and factories, and prevents other suggestions
such as type names, identifiers, etc when they are not appropriate.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2671533002 .
 2017-02-01 14:36:41 -05:00
Konstantin Shcheglov 75fff1fdb6 Implement completion in WithDirective. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2665053004 .
 2017-01-31 15:06:54 -08:00
Janice Collins 93c3a194ad Better error message for missing async with await 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662483003 .
 2017-01-27 10:48:27 -08:00
Konstantin Shcheglov fcd5f16d10 Stop using SDK summary bundle. Analyze dart:xxx as any other libraries. 
Unfortunately this makes runnings tests about 30% slower :-(

I suspect that's because we have to build unlinked and linked summaries
for SDK libraries again and again for every tiny test.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2653683004 .
 2017-01-24 18:32:26 -08:00
Konstantin Shcheglov 5f6ea67c1e Make Analysis Server tests use MockSdk again. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2650803005 .
 2017-01-24 13:49:48 -08:00
Konstantin Shcheglov a483610a96 Issue 28386. Implement search for potential usages with the new analysis driver. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28386

Review-Url: https://codereview.chromium.org/2653493006 .
 2017-01-23 14:07:01 -08:00
Konstantin Shcheglov 0160332713 Issue 28027. Move Null to the bottom in the Analyzer. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/28027

Review-Url: https://codereview.chromium.org/2638183002 .
 2017-01-18 11:15:11 -08:00
Konstantin Shcheglov 8d326e9a14 Report StateError if the DartSDK for an AnalysisDriver does not have summary. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2639743002 .
 2017-01-17 20:46:00 -08:00
Brian Wilkerson 22f561e914 Reapply "Add support for generic function type syntax, part 1" 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2622303006 .
 2017-01-11 14:10:05 -08:00
Brian Wilkerson 85b1e7abbe Revert "Add support for generic function type syntax, part 1" 
Review-Url: https://codereview.chromium.org/2624283003 .
 2017-01-11 13:30:52 -08:00
Brian Wilkerson 1cd918533d Add support for generic function type syntax, part 1 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2613383003 .
 2017-01-11 13:12:10 -08:00
Konstantin Shcheglov e80a54e432 Fix the rest of the completion tests with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2618243002 .
 2017-01-08 15:16:33 -08:00
Konstantin Shcheglov 0c4cc3fdaf Fix the last Quick Fix test. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2619633003 .
 2017-01-06 16:37:12 -08:00
Konstantin Shcheglov 7fc5bc3634 Remove REPLACE_IMPORT_URI Quick Fix. 
I decided that it is not so useful to worth adding special support
for it with the new analysis driver.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2616163002 .
 2017-01-06 14:56:20 -08:00
Konstantin Shcheglov 0377beb128 Update 'Add final field formal parameters' Quick Fix to support the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2618923003 .
 2017-01-06 14:34:49 -08:00
Konstantin Shcheglov d5fc0cda3b Fix Quick Fix tests that used AnalysisContext. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2615303002 .
 2017-01-06 14:31:38 -08:00