Commit Graph

64479 Commits

Author SHA1 Message Date
William Hesse 150c58c13f [infra] Shard app-kernel tests that were causing timeouts
Change-Id: Ia55315278faba496313e6b6b5e041b149780d228
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95401
Reviewed-by: Jonas Termansen <sortie@google.com>
2019-03-06 13:59:46 +00:00
Dmitry Stefantsov 105912339c [cfe] Inherit SpreadElement from Expression, not ExpressionJudgment
Change-Id: I1de77a0589f49f4c94c00ffc62c2b1ba66820333
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95121
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2019-03-06 13:59:06 +00:00
Samir Jindel a85e481d3d [vm/gardening] Fix status file for entrypoints_verification_test.
Fixes https://github.com/dart-lang/sdk/issues/35957

Change-Id: I215538cfa8dcda733bf29aaa3fa2a73817663bb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95646
Commit-Queue: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
2019-03-06 13:56:36 +00:00
Brian Wilkerson fa0d99156f Remove task model initialization
Change-Id: I1c0bfd80f94b3d0f41a73d4df0fbe1b3514697c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95562
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-03-06 13:43:46 +00:00
Brian Wilkerson 3712235e0e Remove the task graph and the tool that produces it
Change-Id: I8fa4b1e1646f4072fafa4521648f0ec158e4cebc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95561
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-03-06 13:43:37 +00:00
Alexander Thomas 99d028be77 [infra] Make promote.py work with newer versions of gsutil
Newer versions of gsutil fail when rm -rf'ing non-existing directories.
Check if the directory exists before trying to remove it.

Change-Id: I57283526f9d13ed5a923b1f5c9d91710ec8d1b60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94861
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2019-03-06 12:43:07 +00:00
Kevin Millikin 9d9f599ca9 [cfe] Compile spread in sets
Compile spread in sets analogously with lists.

Change-Id: Ieb3e139064a1174f7bb1c33aa82b21ca47fe768f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95620
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
2019-03-06 11:37:27 +00:00
Aske Simon Christensen b5a1f6c36b Reland "[CFE] Move constant evaluation number semantics handling to front end."
This is a reland of c2b466b09f

Original change's description:
> [CFE] Move constant evaluation number semantics handling to front end.
> 
> JavaScript number semantics is currently implemented as the simplistic
> version previously present in DDC. This is a starting point for fully
> detailed JS number semantics.
> 
> Change-Id: Id728b3dacec892a5cbf7ece0d9faea51427f5f9b
> Reviewed-on: https://dart-review.googlesource.com/c/94746
> Commit-Queue: Aske Simon Christensen <askesc@google.com>
> Reviewed-by: Sigmund Cherem <sigmund@google.com>

Change-Id: I1a488ef41bda819d34cb45cd481fd8fd88bfb01e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95460
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
2019-03-06 10:30:37 +00:00
Johnni Winther ea6e83004b Use @pragma instead of package:meta/dart2js in tests
Change-Id: I16c0ed6f391a417d8faa55e68cde902d91e3db32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95220
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2019-03-06 08:32:05 +00:00
Konstantin Shcheglov 2448445826 Make IfStatementImpl use IfMixin.
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I32f967a392a96692b6633f8ee62072404cdeaa11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95425
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-03-06 02:19:54 +00:00
Liam Appelbe 7ba8995917 Download ABI dills during gclient sync
This currently doesn't do anything because ABI_VERSION == OLDEST_SUPPORTED_ABI_VERSION, so there are no versions to download.

Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I5616151dd9dc407d918cbfe9044354f3a41a2e1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95300
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
2019-03-06 01:07:14 +00:00
Alexander Markov dc1f2bd087 [vm] Avoid assertion for non-finalized type parameter of expression evaluation function
This is the follow-up for https://dart-review.googlesource.com/c/sdk/+/95061.

Fixes https://github.com/dart-lang/sdk/issues/36117

Change-Id: I70d7a753fcb4d4063510548e74d635a35447b3dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95540
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2019-03-06 00:35:34 +00:00
Liam Appelbe ef969c8c7e Revert "Update the build bot name restriction in upload_abi_dills.sh"
This reverts commit 4eedef85a3.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Update the build bot name restriction in upload_abi_dills.sh
> 
> https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919793391094101904/+/steps/upload_abi_dills/0/stdout
> 
> Bug: https://github.com/dart-lang/sdk/issues/36047
> Change-Id: I35c6c6b8365007b681e0daf6e8ef8a5634370dd2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95488
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,liama@google.com

Change-Id: Icce78b35149d9a43dadeedcbfa97eb7153e8b74f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95560
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
2019-03-06 00:26:36 +00:00
Bob Nystrom 57f16820cd Add tests for "await" inside spread, if, and for.
These don't try to comprehensively cover every interaction of async
and the new syntax, but they should test that an implementation handles
an await appearing in all the various places in the new syntax where an
expression is permitted.

Change-Id: I4852815002fcad6697f3bad4103693b1d4288d06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94121
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2019-03-06 00:10:04 +00:00
Ben Konyi cbc404b6de [VM] Cleanup status files some more
Change-Id: Ib7560d864b5506b2629413ccb1d70b8281e16315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95040
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
2019-03-05 23:47:14 +00:00
Mayank Patke dc02d859f4 Ensure all SetConstantValues are JavaScriptSetConstants.
Change-Id: Ifa89be6cb2ce856bd10465f2502e28f0ceb72586
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95487
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2019-03-05 23:41:29 +00:00
Paul Berry f112b672e7 Use ListLiteral.elements2 instead of ListLiteral.elements.
ListLiteral.elements will soon be deprecated.

Change-Id: If61755da665c57d4e226eaebcbe089e14208685b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95424
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-03-05 23:33:48 +00:00
Paul Berry 4a7f9d7c11 Remove FindNode.setLiteral method.
I accidentally left this out of 47b417c88e.

Change-Id: Ife4f3e1ceb82417ab7b9246dc4d6d36020e963c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-03-05 23:33:24 +00:00
Ryan Macnak 2922878ce9 [vm, compiler] Fix GuardFieldTypeInstr to update the original field.
Change-Id: I698b6f3315e76f6d491f514333cf38e035ad6e79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95423
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2019-03-05 23:06:22 +00:00
Liam Appelbe 4eedef85a3 Update the build bot name restriction in upload_abi_dills.sh
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919793391094101904/+/steps/upload_abi_dills/0/stdout

Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I35c6c6b8365007b681e0daf6e8ef8a5634370dd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95488
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
2019-03-05 22:58:12 +00:00
Ryan Macnak 60de5b4983 [vm] Avoid quadratic growth in (Malloc)TextBuffer and ZoneTextBuffer.
In particular, avoid quadratic memory use in ZoneTextBuffer.

Change-Id: I8d2ea77d35cd3c2c353ae557a2ee676ee8413653
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95483
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2019-03-05 22:32:22 +00:00
Liam Appelbe c921716a30 Add upload_abi_dills.sh to dart-sdk-linux in test_matrix.json
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I8e39df90a768ced8ce97d6496e4f411540225fb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95285
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
2019-03-05 20:48:31 +00:00
Paul Berry 47b417c88e Remove FindNode methods related to AST data structures that will be removed.
ForStatement and ForEachStatement will be removed in favor of
ForStatement2.  MapLiteral and SetLiteral will be removed in favor of
SetOrMapLiteral.  This CL changes FindNode methods to match, and
adjusts callers.

Change-Id: I89990f63aa277acd31458d485e897ebf0c6cf61f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-03-05 20:39:41 +00:00
Konstantin Shcheglov c793038137 Identify flutter_web in Flutter.
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36056
Change-Id: I53d0fd2c565369981c6615f356f0b44344683dac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95484
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-03-05 20:20:31 +00:00
Dmitry Stefantsov 1da7c0d472 [cfe] Fix type checks in spreads within lists and sets
Change-Id: Id0eb5bc798fdd425cf1bc46d60efb3a1d5455938
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95383
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2019-03-05 19:54:11 +00:00
Dmitry Stefantsov 09a1cf67e6 [cfe] Don't replace spreads with invalid expressions after inference
Change-Id: Ie6081b1471ee8b1697fe93f8b79b630bf6577fe7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95120
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2019-03-05 19:54:11 +00:00
Alexander Markov 51a334caa7 [vm] Remove kernel reading from BuildArgumentTypeChecks
This change is a preparation for decoupling flow graph building of
special functions from kernel reading.

Change-Id: Ied90bc6894cdfa48f49c71e980079967c8c4fbb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95061
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-03-05 18:48:51 +00:00
Konstantin Shcheglov 927e758e96 Stop using package:html in analyzer.
Related to https://github.com/dart-lang/sdk/issues/35802

R=brianwilkerson@google.com

Change-Id: I875a8dc657900137c5a7b59f2820b30a81b23405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95480
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-03-05 18:36:41 +00:00
Danny Tuppeny 53438199a4 Tweak version numbers in LSP readme
Change-Id: I9dfa1165d41115ef6f30fd0718c75c058e8c968a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95380
Auto-Submit: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
2019-03-05 18:16:31 +00:00
Dan Rubel 58a0487125 more tests for 34610 and 36009
https://github.com/dart-lang/sdk/issues/34610
https://github.com/dart-lang/sdk/issues/36009

Change-Id: I840047fe53fe99b0e2c8b778a84b0598334ab295
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-03-05 18:00:31 +00:00
Daco Harkes 2071d1284d [vm/ffi] Fix crash on toString for dart:ffi trampoline functions
Change-Id: I8af3373619dca690a2f5e60f737714e1ac413408
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95500
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
2019-03-05 17:43:56 +00:00
pq aacd8c7711 de-dup machine format errors
Fixes: https://github.com/dart-lang/sdk/issues/36062.

Change-Id: I489a5fe991e715c5067479a29c1cddbd4de57c49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-03-05 17:33:51 +00:00
Liam Appelbe cc455ecc1d Add use_abi_version flag, and plumb ABI version to version.h
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: Ie810cbd5079e1939bf190e06f6c2494bb4ab0805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95282
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
2019-03-05 17:16:11 +00:00
danrubel 96e982f054 Improve await-outside-async error recovery
Fix https://github.com/dart-lang/sdk/issues/36048

Change-Id: If40baa44a0aefa301c042bc1002d92e577bd3b9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95302
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-03-05 17:08:31 +00:00
Dan Rubel e033b676dd fix parser crash in unterminated string literal inside unterminated interpolation
Fix https://github.com/dart-lang/sdk/issues/35900

Change-Id: I96d83e0c93d9e9c22d5b30048dc210672b1c003c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95043
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-03-05 15:35:58 +00:00
Samir Jindel ed8357cf83 Re-land "[vm/ffi] Stress tests for FFI functions.""
We will only run the tests on supported configurations. Issues are open
to expand coverage.

This reverts commit 1d3a0d5129.

Change-Id: I28d90f36a97914dc0cb04c39046cb4bdafe1740b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95023
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
2019-03-05 14:17:08 +00:00
Johnni Winther 6227ab0b97 Replace @ForceInline with @pragma in dart:html
Change-Id: I73afc500438d3fba92f549c8c1955f5ccad47751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95033
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2019-03-05 12:17:18 +00:00
Johnni Winther 204651f3ab Replace package:expect annotations with @pragma
Change-Id: Ib43d0d71a3ee8b0f0e6d676e6a3e448a107b7ca5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95180
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2019-03-05 11:00:17 +00:00
Daco Harkes 45e6f83cd6 gitignore visual studio project files
Change-Id: Id7d2c3775f4b37b15b6ee680681c09d44164a9ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94742
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2019-03-05 10:53:17 +00:00
Sigurd Meldgaard ca24e7aa10 [vm] Allow no main method when doing type flow analysis
Change-Id: I97fce485ad1792766d34ad365b359b44c8aacb61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95385
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2019-03-05 10:38:38 +00:00
Aske Simon Christensen c769743f67 [CFE] Transform constants in annotations on all parameters.
The constant transformer would only transform optional parameters,
since these are the only ones that can contain default values. This
caused it to miss annotations on required positional parameters.

Change-Id: I49bfc84a1a533cec87db557306fdeb3569156947
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93981
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
2019-03-05 10:18:37 +00:00
Kevin Millikin 718b36ed73 [cfe] Use for-in instead of List.addAll for list spread
The translation of `...e` into `list.addAll(e`) is not correctly
typed.  `List.addAll` requires its argument to have type `Iterable<E>`
where E is the list's element type.  Spread only requires that the
elements of e have type E.

Instead translate `...e` into `for (E elt in e) list.add(elt);`.

Change-Id: I9a5794048d33901a2b0dfae2e592a031d1155be8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95381
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
2019-03-05 09:28:27 +00:00
Aske Simon Christensen 99093c0610 [fasta] Required but not inferred constant context.
Add a new kind of constant context in the body builder for expressions
that must be constant but where constness is not inferred.

This context is used for parameter default values and initializing
expressions for non-final fields in classes containing at least one
const constructor.

Fixes https://github.com/dart-lang/sdk/issues/34191

Change-Id: I200ca88586b19335b185dad0839dfad4eef1f75f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93520
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2019-03-05 09:23:57 +00:00
Aske Simon Christensen 822ebdd1e0 [fasta] Wrap non-const variable accesses inside const expressions.
Change-Id: I8761031da2419a47a947a02721d4ffd86ac7c531
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93504
Reviewed-by: Peter von der Ahé <ahe@google.com>
2019-03-05 09:23:57 +00:00
Johnni Winther 013cf68624 Replace js_helper annotations with @pragma
@ForceInline is still used by dart:html, will be removed in a later CL.

Change-Id: I480325fe91cc6baefb17ead49f839442e023d441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95160
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2019-03-05 08:56:18 +00:00
Jens Johansen 1a88421d39 Allow to change .package uri in incremental compiler
Change-Id: Ic36fd000e2a3ea2870460b68821c7404f6e62a1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95140
Reviewed-by: Peter von der Ahé <ahe@google.com>
2019-03-05 07:39:31 +00:00
Jens Johansen 2695cdfbb1 Change incremental compiler to take entry points (plural)
Change-Id: I03203cdeb11ab7bc6116779642909ebc7220c619
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95122
Reviewed-by: Peter von der Ahé <ahe@google.com>
2019-03-05 07:39:31 +00:00
Konstantin Shcheglov 3124125008 Move Flutter utility methods into a class, which can be instantiated either with regular package:flutter, or with package_flutter_web.
The factory constructors does not yet choose one, will do in a
following CL.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36056
Change-Id: I7fabe9da571ea80ce993d9303217ccd8b085e8a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95283
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-03-05 05:51:41 +00:00
Jenny Messerly 5a8bdc7f34 [dartdevc] fix #36052, missing key in map should result in null
Change-Id: Ic32fb8689fd2163e162b80ad4682e9b10ba4eaee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94920
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
2019-03-05 01:15:30 +00:00
Brian Wilkerson 643895befc Fix two failing tests on the bots (TBR)
Change-Id: I607ae4c59b85e8720e1efbc1d60842168318d410
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-03-05 00:45:35 +00:00