dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

64479 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dmitry Stefantsov 9f6476392c Reland "[cfe] Compile null-aware spreads in non-const maps" 
This is a reland of 3160b084d8

Original change's description:
> [cfe] Compile null-aware spreads in non-const maps
> 
> Change-Id: I22ee0b8821835bf8f2417f5fb4433898d06e7c36
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96060
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

Change-Id: I46198eb380a1813723376e894d5d32261b25dfcb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96132
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-08 19:04:43 +00:00
Dmitry Stefantsov 10b38fd3f9 Reland "[cfe] Handle spread elements of static type Null" 
This is a reland of 0a13ef7d03

Original change's description:
> [cfe] Handle spread elements of static type Null
> 
> Change-Id: Idec027766e77237c25fe2274426f92e24f45dec4
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96043
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

Change-Id: I222c2b153cdf0ed47a0e83aff5deca4686c10343
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96131
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-08 19:04:03 +00:00
Dmitry Stefantsov c31be8ab5c Reland "[cfe] Disambiguate between sets and maps with spreads" 
This is a reland of b817b274c2

Original change's description:
> [cfe] Disambiguate between sets and maps with spreads
> 
> Change-Id: I8da95178d0864dd0d59232a902cdb142be7f135e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95649
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

Change-Id: Id22b7513230f6410dc2af5146d292fc7fc47a0aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96130
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-08 19:03:27 +00:00
Paul Berry 8430281a6b Add an implementation of ScopedVisitor.visitForEachPartsWithDeclaration. 
Change-Id: I659609caa84e837801a0a38871c8bb8bb0c8948c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-08 18:58:58 +00:00
Régis Crelier 6da340bf76 Reland "[VM runtime] Dual mapping of executable pages." 
This is a reland of 44186dfdcd

Original change's description:
> [VM runtime] Dual mapping of executable pages.
> 
> Change-Id: Iaad78d324e25462ce951f4df26974a6a368c50b7
> Reviewed-on: https://dart-review.googlesource.com/c/93377
> Commit-Queue: Régis Crelier <regis@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>

Change-Id: I7a0caa078950637d9fe831732577fd2467061099
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95263
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-03-08 18:33:02 +00:00
Régis Crelier 2b501b21aa Revert "[cfe] Disambiguate between sets and maps with spreads" 
This reverts commit b817b274c2.

Reason for revert: very red bots, gardener not going to blindly approve all redness

Original change's description:
> [cfe] Disambiguate between sets and maps with spreads
> 
> Change-Id: I8da95178d0864dd0d59232a902cdb142be7f135e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95649
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

TBR=dmitryas@google.com,askesc@google.com,kmillikin@google.com

Change-Id: I008c42a5b50da98af32c923b233130920fdb2546
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96127
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-08 17:39:34 +00:00
Régis Crelier ff5f5de1be Revert "[cfe] Handle spread elements of static type Null" 
This reverts commit 0a13ef7d03.

Reason for revert: very red bots, gardener not going to blindly approve all redness

Original change's description:
> [cfe] Handle spread elements of static type Null
> 
> Change-Id: Idec027766e77237c25fe2274426f92e24f45dec4
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96043
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

TBR=dmitryas@google.com,askesc@google.com,kmillikin@google.com

Change-Id: I1cc4656cd7ed8d360dcc4736fe510ece9ea3bf8d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96126
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-08 17:35:43 +00:00
danrubel b2cb604b9d improve literal list/map/set control flow recovery 
* new ExpectedElseOrComma parser error code
* update recovery tests to enable control flow recovery
* rework test to call parser.parseLiteralListSuffix rather than parser.parseLiteralListSuffix

Fix https://github.com/dart-lang/sdk/issues/36141

Change-Id: I5bdee19eb3828de8fbdc514a3820afaa1309df99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-08 17:31:33 +00:00
Nicholas Shahan d2d098405f [tests] Fix some control flow collections tests 
- Remove tests that expect ForElements in const collections.
- Add missing value (or was it the key) in map.

Change-Id: Ic61cbb4326a105618ae4ea169655411359c52045
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96020
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-03-08 17:27:38 +00:00
Régis Crelier 1a2c93ae00 Revert "[cfe] Compile null-aware spreads in non-const maps" 
This reverts commit 3160b084d8.

Reason for revert: very red bots, gardener not going to blindly approve all redness

Original change's description:
> [cfe] Compile null-aware spreads in non-const maps
> 
> Change-Id: I22ee0b8821835bf8f2417f5fb4433898d06e7c36
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96060
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

TBR=dmitryas@google.com,askesc@google.com,kmillikin@google.com

Change-Id: Icd37478bc7a3b9ccddf2daba215fa8c138063c4e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96124
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-08 17:19:36 +00:00
Régis Crelier afccd8cbc7 Revert "[cfe] Handle spread map entries of static type Null" 
This reverts commit ccd2c85a1a.

Reason for revert: very red bots, gardener not going to blindly approve all redness

Original change's description:
> [cfe] Handle spread map entries of static type Null
> 
> Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
> Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

TBR=dmitryas@google.com,askesc@google.com,kmillikin@google.com

Change-Id: Ia8f60993222851a73291662f75556b2e4111a6f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96123
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-08 17:19:35 +00:00
Jonas Termansen 6c8dbd84a0 [infra] Support different local named configurations in tools/test.dart. 
This change lets one download the results for one named configuration but do
the local testing with another named configuration. This change addresses
the issue of developers needing to do local testing where there is no
builder matching their local environment. This allows e.g. a dart2js
developer on Windows to use the results for the Linux variant of the same
named configuration, which should be identical or close enough for the
comparison to be meaningful.

Fixes https://github.com/dart-lang/sdk/issues/36151

Change-Id: I1a387a9767cdf5ba99964535478201c0142f15e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96102
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-08 16:56:40 +00:00
Paul Berry 166c5e4b38 Use subtype rather than assignability to disambiguate maps/sets. 
This causes the implementation to match the spec.  Also, it's an
important distinction because the analyzer allows the user to change
the meaning of assignability checks using the analysis option
"implicit_casts: false".  We don't want this option to change the
meaning of set/map disambiguation.

Change-Id: I2a870209a31b4344c0568ecfe741bf731d9489a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-08 16:20:23 +00:00
Lasse R.H. Nielsen 2e9ff26527 Fix overflow bug in BigInt implementations. 
Fixes #36105

Bug: http://dartbug.com/36105
Change-Id: I9adf70d11474f844d2a4fbf5fcc3754562b1cf65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95644
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-03-08 16:11:08 +00:00
Brian Wilkerson 9a7679e9e1 Remove some of the tests of the task framework to reduce references to it 
Change-Id: I1ec466bfbbcb9279169f6d076db72cece38dcd6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-08 16:03:23 +00:00
Brian Wilkerson 6e359857e4 Move ConstantEvaluationTarget out of the task model 
Change-Id: I961f033e871a05ba38383b79865ed2795a1d452f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95984
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-08 16:03:03 +00:00
Dmitry Stefantsov ccd2c85a1a [cfe] Handle spread map entries of static type Null 
Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 15:46:31 +00:00
Dmitry Stefantsov 3160b084d8 [cfe] Compile null-aware spreads in non-const maps 
Change-Id: I22ee0b8821835bf8f2417f5fb4433898d06e7c36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96060
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 15:46:31 +00:00
Dmitry Stefantsov 0a13ef7d03 [cfe] Handle spread elements of static type Null 
Change-Id: Idec027766e77237c25fe2274426f92e24f45dec4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96043
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 15:46:31 +00:00
Dmitry Stefantsov b817b274c2 [cfe] Disambiguate between sets and maps with spreads 
Change-Id: I8da95178d0864dd0d59232a902cdb142be7f135e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95649
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 15:46:31 +00:00
Paul Berry 0e054b1c6e Some fixes for UI-as-code type inference 
Change-Id: I72711aad365e95f2f1b20d7f23d7765a9581ff4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96022
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-08 15:39:19 +00:00
pq 8d88316246 fix for unawaited_futures 
Change-Id: I9ef54b1d30dd651ebd2fe20c4ce89808879da529
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95982
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-08 14:20:56 +00:00
Samir Jindel 5eefbd8d14 [vm/ffi] Add a slot for RawPointer::address. 
Change-Id: I55f803264ecf8555ffacbd42ec01c7581d335c93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94750
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-03-08 14:17:36 +00:00
Aske Simon Christensen ff55d429f6 [kernel] Collection concatenation nodes. 
These arise when the constant evaluator partially evaluates collections
containing spreads or control-flow constructs with unevaluated
subexpressions. They are removed by the final constant evaluation.

Change-Id: Icdd155c4805cbcefe6aa4b45c2f85ec258e7bd36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95760
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-08 13:08:55 +00:00
Dmitry Stefantsov 52ff930338 [cfe] Desugar map spread entries in non-const map literals 
Change-Id: Ie8f6cc0294888716f4e0349ba07320e684e26e1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95640
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 12:08:42 +00:00
Dmitry Stefantsov 76ff150df4 [cfe] Add type inference for spreads in map literals 
Change-Id: Ibe39deb9c1a022b30b70e677150925205e58d8b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94741
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 12:08:42 +00:00
Vyacheslav Egorov 95b0e57ac5 [gardening] Disable ASAN's coredump suppression via ASAN_OPTIONS. 
Change-Id: I4dd48fa14261b3a25e7f3abce5bd55a4c0f4111d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96100
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-08 12:06:35 +00:00
Jens Johansen 235e5f3709 Allow component to easily adopt libraries at will 
Change-Id: Ia84d56b4c7d7403467b04e90c2b63859ecee509d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96042
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-03-08 11:01:17 +00:00
Jens Johansen 64d8a16563 API changes to incremental compiler to support modular compilation 
Change-Id: I2b86eefaebbeb0ede06ed2e433868585c3df2461
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95780
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-08 10:40:07 +00:00
wtoalabi 6231ba0b18 Added appropriate comma within comment. 
Closes #35685
https://github.com/dart-lang/sdk/pull/35685

GitOrigin-RevId: 25e6bca8cb266e0922062ca55228eec06467b110
Change-Id: I17318554d6114e3ec030884afb3edd0a7d899252
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/89980
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2019-03-08 10:23:07 +00:00
Jonas Termansen 283cabf1a1 [infra] Reject unexpected extra arguments in approve_results. 
Change-Id: I441572d5e6d99aa3f3ff3427f8562fa417405d09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95643
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-08 09:39:12 +00:00
Daco Harkes 299c6457cf [vm/ffi] Fix style guide violation 
Change-Id: I669c392a0400632bba66d6de814f7101444a8990
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95820
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2019-03-08 09:11:07 +00:00
Johnni Winther b8069cbeca Refactor computation of modular data 
Add ModularStrategy as a step towards loading modular data from disk.

Change-Id: I9d0baebef8899794742164be4350bedbd3da5b68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95650
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-08 08:36:07 +00:00
Johnni Winther 889d5d9240 Fix type error in node_tracer 
From https://dart-review.googlesource.com/c/sdk/+/94749
This is triggered by set literal testing.

Change-Id: I151f9154410790820e1f4d6301b0ccde52a72767
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95441
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-08 08:21:47 +00:00
Vyacheslav Egorov 2fb6cd9f5f [vm] Fix Service::RequestAssets 
Unwrapping of API handles can only occur when thread is in the VM
execution state.

Change-Id: I14183f4553d0dd972b4bafb1e3771cf2655c1867
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96040
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2019-03-08 07:19:47 +00:00
Ben Konyi 585eb7f507 [ VM / Service ] Added disableBreakpoints parameter to evaluate, evaluateInFrame and invoke RPCs 
- Setting the `disableBreakpoints` parameter to true will result in any
breakpoints hit during execution resulting from an evaluate or invoke
call to be ignored.
- Default behavior is the same (break on breakpoints).
- Updated Observatory eval box to disable breakpoints.
- Added tests

Change-Id: Ibf40f8a8de018718435118e13cc2e969f8ed7944
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95320
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
 2019-03-08 02:19:06 +00:00
Brian Wilkerson 9b0ac9ee03 Extract diagnostic tests in preparation for supporting ui-as-code features 
Change-Id: Icfeb982a37b501b22189d87de42398c3f1516bee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95961
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-08 02:10:47 +00:00
Ryan Macnak 93d42679f0 [vm, arm64, fuchsia] Check for stack overflow / interrupts based on DSP instead of CSP. 
Broken by b2d22be0f3, which skips kicking CSP forward to save on code size.

Change-Id: I8fda8631d94c9a696039545b83425b799cabde46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95962
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-03-08 01:01:47 +00:00
Sam Rawlins 05be278603 Split MISSING_RETURN tests 
Change-Id: I001d3dd2f1c2d1200ede738aa8d838fc0924ba1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-03-08 00:32:17 +00:00
Vyacheslav Egorov 1dd4559271 [vm] Add Native->VM transitions when dereferencing API handles. 
For example setting return value unwraps handles and stores
raw pointer values to the stack which might race with GC
in another thread.

This CL adds assertions in helper methods from Api class which
unwrap API handles and fixes all places that were revealed by
those assertions.

Caveat: we still permit to check whether handle contains
Smi or not without entering VM state - because GC does not
change this property.

Bug: b/127482366
Change-Id: I59f08c2a91935995514fb70607c2777aa2844d94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95654
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-08 00:06:37 +00:00
Dan Rubel 34953ffd7d Cleanup some NNBD flags 
* rename LibraryAnalyzer.isNonNullableMigrated to isNonNullableLibrary
* rename visitors isNonNullableMigrated to isNonNullableUnit

Change-Id: I46a7472a7cf91e1783b95fa4845f54b8f7f8a659
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-07 22:02:16 +00:00
Brian Wilkerson a47ffd2b50 Fix some errors in the control flow collections tests 
Change-Id: I87ba6b3d2860439c33b62c02e8f9294d65d31abc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95900
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-03-07 21:54:55 +00:00
Liam Appelbe e1dfad1f2c Attempt 4 at the upload abi dills script 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I89ddbcbd91d09f6a86a01e6d0b66798784a8c0eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95882
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-07 21:43:46 +00:00
Konstantin Shcheglov 4b609422e9 Make AVAILABLE_SUGGESTION_SETS and related APIs non-experimental. 
R=brianwilkerson@google.com

Change-Id: I1facae905319f050636126b021f56f353f81d6f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95661
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-07 21:29:36 +00:00
Zach Anderson 8332fb0631 [vm] Adds an API call to dump the CPU profile to the timeline 
Used in https://fuchsia-review.googlesource.com/c/topaz/+/258655

Change-Id: I79b102e0d318d7be3bae44fb88f81bb8086a10d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94400
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2019-03-07 21:28:26 +00:00
pq ccf756dae5 Integration testing to ensure server lint name representations are correct. 
If lint names do not match, associated fixes are never shown.

See https://dart-review.googlesource.com/c/sdk/+/95743 for the kind of bug this should guard against.


Change-Id: I27b33c56b9f9242497a03972129806863d2287a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-07 21:01:06 +00:00
pq 34e1c93906 add prefer_null_aware_operators error code association 
Change-Id: I23210abe2c17b166d7a628ab374b4fdba0df1e22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-07 20:35:47 +00:00
Aart Bik 5c7b07f783 [dart/vm] Fix bug in kernel binary flow graph builder 
Rationale:
Found by DartFuzz. One of the trickier bugs I had to debug.
While building the flow graph from kernel, the finalizer
builder expects the program context to be in the same state
as when the finalizer was seen first, not the context seen
by the breaking/continuing statement. This was done partially,
but only partially. Finding loop context or breakable
and switchable blocks was missing. Something only
a fuzzer can find :-)

https://github.com/dart-lang/sdk/issues/36076

Change-Id: Ie63912c5fad4d3c15f6559b60cc102b237949957
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95720
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-07 20:16:18 +00:00
Adam Barth 07b2f82203 [fuchsia] Remove unused header 
This header is no longer needed and will be removed soon.

Change-Id: I5d96b725bc2a7c6695bb5248377075b00fe7fc6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95880
Commit-Queue: Zach Anderson <zra@google.com>
Auto-Submit: Adam Barth <abarth@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2019-03-07 20:10:21 +00:00
Aart Bik a6a5a2b635 [dart/fuzzer] Added more Dart constructs 
Rationale:
More generation-based fuzz cases to cover
more Dart constructs. Already found first
new bug.

https://github.com/dart-lang/sdk/issues/36076

Change-Id: I77a9a589d89c1fb0a57a202fb88d046cf15d058e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95303
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-07 19:08:05 +00:00