dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

64479 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mayank Patke bc5d613533 Fix typo in diagnostic when non-bool is passed to logical or. 
Change-Id: I406c062359a0dfbb89f22a6a6cb25017eed740e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96823
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-03-13 18:12:23 +00:00
Kevin Moore 7d560f8385 Remove outdated entries from .packages 
Change-Id: I52caf28cdfa17b0481f24d317ffb384bac13284e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96822
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2019-03-13 17:10:12 +00:00
Alexander Markov ee529e3451 [vm] Fix typo forwader => forwarder 
Change-Id: I67906e25ddaf2fb6650f61dad7c12c96b6367222
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96821
Commit-Queue: Samir Jindel <sjindel@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-03-13 16:39:02 +00:00
Konstantin Shcheglov 2ddb2d2d20 Change 'analyze tests co19_2' to use '-asserts'. 
Change-Id: I9ed20ff353fcbdc8042589e619b275e84d5dc7e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96820
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-13 16:25:42 +00:00
Alexander Markov b03db45379 [vm] Decouple flow graph building of dynamic invocation forwarders from kernel reading 
Change-Id: I65f8fb5f3817630870e752ecb14ff3fb0506e7ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96711
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-03-13 16:14:12 +00:00
Alexander Aprelev 6587483d33 [frontend] Dont re-report compile-expression errors. 
Fixes dartbug.com/36091

Change-Id: I122359ad2377499511118c943dc8c27347fb2007
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96406
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2019-03-13 15:31:52 +00:00
Konstantin Shcheglov 81fa14eb3c Hollow out AnalysisContextImpl. 
R=brianwilkerson@google.com

Change-Id: I4ebc67de74cc4bbda63c9f0a8f7c11dbc3f25b21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96720
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-13 15:18:22 +00:00
William Hesse b10a6bd5ce [testing] Multitests' copied imports should not be read-only 
Change-Id: I4f2957385336f5f56fa804360aca902b019aac58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96801
Auto-Submit: William Hesse <whesse@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2019-03-13 14:11:12 +00:00
Clement Skau 9684748784 Removes superfluous Dart_ExitScope() call in CreateVmServiceIsolate. 
Bug: Crash in Dart in CreateVmServiceIsolate() when bin::VmService::Setup() fails.
Change-Id: I9c640daa49fc9894d00523e0d986154cc4d4e062
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96802
Auto-Submit: Clement Skau <cskau@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Clement Skau <cskau@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2019-03-13 13:58:04 +00:00
Brian Wilkerson 4a7556840f Rename tests ending with Test_Driver 
Change-Id: I1b4822630a2508e8a41ba6c5564eae5a54f56622
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96740
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-13 13:38:22 +00:00
Kevin Moore 8c3f74817e dartfmt -w --fix dart:collection 
Change-Id: Ia643bb49fe22150f794a187a71c19ad4c61b5694
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96663
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2019-03-13 13:31:52 +00:00
Kevin Millikin afb459f7fa [cfe] Iterate map entries in map spreads 
There was a missing call to the getter Map.entries in the translation
of map spreads.  Fixes https://github.com/dart-lang/sdk/issues/36173

Change-Id: I211a61173c383f1c64032eb04491d03e4331cc9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96780
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-03-13 12:13:52 +00:00
Vyacheslav Egorov ed5bc9c538 [vm] Fix AssertAssignable strengthening sometimes using wrong deopt_id. 
For some reason this code used deopt_id from the environment attached
to the AssertAssignable instruction, rather than deopt_id from the
instruction itself.

Under certain conditions this deopt_id is -1 which usually does
not cause any problems because no other code uses it.

Compiler is now changed in a way that only sets Environment::deopt_id_
for outer environments and innermost environment always has deopt_id_ set
to DeoptId::kNone.

This bug manifested itself as a very rare crash on lib_2/convert/chunked_conversion_utf8_test.dart
test on optcounter bot.

This change also converts an assertion that verifies that deoptimization target
always exists into a FATAL to make such crashes more informative.

TEST=runtime/tests/vm/dart/licm_and_assert_strengthening_test.dart

Change-Id: Ib58237b0f4ae279dcf9d88cac031156e88bf4828
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96657
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2019-03-13 12:13:12 +00:00
Sergey G. Grekhov 8436dca626 [co19] DEPS updated 
Change-Id: I487418f0a8a1cad37585d985ac2da6807556b4f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96620
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-13 12:12:06 +00:00
Daco Harkes a43c525de2 Reland "[vm/ffi] Support Windows 64 bit" 
Enables dart:ffi on Windows 64 bit.

Note that function_stress_test.dart fails in two different ways, these are known bugs. https://github.com/dart-lang/sdk/issues/36138

Relanding: Fixed compilation on Android.

Closes: https://github.com/dart-lang/sdk/issues/35771
Change-Id: I7d0c8b64ca8c1726b7d264d4fd9213299a9f7df6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96781
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2019-03-13 11:47:37 +00:00
Johnni Winther 3bc3205e39 Move ConstantValue handling outside BehaviorBuilder 
Change-Id: Ie397c7e1a927e694de2d5968c9c962c024713633
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96659
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-13 10:34:37 +00:00
Johnni Winther 63e22ea497 Remove unused parts of NativeDataBuilder 
Change-Id: I449e0906f098f5d72f82894c6c24f5975da49e6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96656
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-13 10:34:37 +00:00
Johnni Winther f307524421 Support native member annotations through ir constants 
Change-Id: I247385c951d3a794afe7e4066b3b1d1ea14a76b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96641
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-13 09:08:27 +00:00
Peter von der Ahé 7cfe216e6b TypeInferrer.library is null iff topLevel 
Change-Id: I6164a0d0334d6a4300fd683dbdd31c8eb81398c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96654
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-03-13 06:46:21 +00:00
Peter von der Ahé 03ecefc0b2 Move ShadowMember.resolveInferenceNode to TypeInferenceEngine 
Change-Id: Ib1c200c3b04fd2a078a130ba93e4b0e738604464
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96653
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-13 06:46:21 +00:00
Peter von der Ahé c7270f25fe Add Declaration.isAnonymousMixinApplication 
Change-Id: Iea0568a6d280db2f811af8579c1146820bbb2c31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96652
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-13 06:46:21 +00:00
Peter von der Ahé 0cbce074ac Add toString to Substitution 
Change-Id: I7fb82f781aeafb4ef4a037c405a7201e9b52ba1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96651
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-13 06:46:21 +00:00
Peter von der Ahé b990c503c8 Fix typo in mixin transformer 
Change-Id: Ie351a9419a1957f777f229c6caf8515a90c0e6d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96649
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-13 06:46:21 +00:00
Peter von der Ahé da3c23bdaa Test override-based inference when inheriting conflicting types 
Change-Id: If7c1b0bf3111b05c5e2b083da749453a4ba9e675
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96648
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-13 06:46:21 +00:00
Peter von der Ahé f200c37553 Enable extra VM options in fasta script 
Change-Id: Ib7f68bee7155dcf4ad49d6b17bea6eb071f31f8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96646
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-13 06:46:21 +00:00
Peter von der Ahé 69c1d1096d Update test as combined member signature would fail 
Change-Id: Ifc336b706fa1315f206f2214eb233489bd21c763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96645
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-13 06:46:21 +00:00
Peter von der Ahé 68aeb5cec2 Tweak error messages related to inference and overriding. 
Change-Id: I216da55c0b5a6c6cc5b6f26f7a4565ae1e392c72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96644
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-13 06:46:21 +00:00
Konstantin Shcheglov 0a337bb36f Report CONST_SPREAD_EXPECTED_LIST_OR_SET and CONST_SPREAD_EXPECTED_MAP. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I70eb31a19c447d17b4cc60ae2ff3caadb35cc6bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96712
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-13 06:40:05 +00:00
Régis Crelier 1bd36d694d [vm runtime] Dynamically disable dual mapping of code on some platforms. 
Until a better solution is found, disable dual mapping of code on docker
containers that fail setting exec permissions on dual mappings.

Change-Id: Ic7477e1ef70ae0ea4d0187284702d5a3ee594edf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96668
Commit-Queue: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Auto-Submit: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-12 23:42:35 +00:00
Zichang Guo 0bd674c374 [VM-Runtime] set environment when creating detached process 
environ variable should be updated if user provides environment. It only update for normal processes.
Bug= https://github.com/dart-lang/sdk/issues/36132

Change-Id: I2a4639ed53e7376534578a0b1b251025ffaa2278
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96147
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-03-12 21:09:35 +00:00
Konstantin Shcheglov 578fdb0408 Call becomeMap/becomeSet() in AstCloner. 
So, that we have a decided kind for constants.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Iee2937e8d525c16e57c8efb4807806edeb19e125
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-12 21:08:04 +00:00
Mike Fairhurst 382cd59388 Update completion target tests for new map syntax 
Change-Id: Ibb059d802aac92af6331e19f0b14aca03859ac42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96524
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2019-03-12 21:04:35 +00:00
Liam Appelbe 1db664764a Revert "Copy abi dills in create_sdk build rule" 
This reverts commit 49a0502f49.

Reason for revert: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919160881488492768/+/steps/build_host_debug/0/stdout

Original change's description:
> Copy abi dills in create_sdk build rule
> 
> Bug: https://github.com/dart-lang/sdk/issues/36047
> Change-Id: If73dbe5a62eff54ac0f712dada14ccd4c68c293e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96500
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,asiva@google.com,liama@google.com

Change-Id: I90610bc43606a8cb148c9a3d9a1cab532176df8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96665
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-12 20:48:56 +00:00
Régis Crelier a39833d957 Reland "Reland "[VM runtime] Dual mapping of executable pages."" 
This is a reland of 6da340bf76

Original change's description:
> Reland "[VM runtime] Dual mapping of executable pages."
> 
> This is a reland of 44186dfdcd
> 
> Original change's description:
> > [VM runtime] Dual mapping of executable pages.
> > 
> > Change-Id: Iaad78d324e25462ce951f4df26974a6a368c50b7
> > Reviewed-on: https://dart-review.googlesource.com/c/93377
> > Commit-Queue: Régis Crelier <regis@google.com>
> > Reviewed-by: Ryan Macnak <rmacnak@google.com>
> 
> Change-Id: I7a0caa078950637d9fe831732577fd2467061099
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95263
> Reviewed-by: Ryan Macnak <rmacnak@google.com>

Change-Id: I3a01f0e67d733c5db41618f691431e72c1e1cb2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96422
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-12 20:45:45 +00:00
Liam Appelbe 49a0502f49 Copy abi dills in create_sdk build rule 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: If73dbe5a62eff54ac0f712dada14ccd4c68c293e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96500
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-12 20:24:07 +00:00
Vyacheslav Egorov 23eb57c2bf Revert "[vm/ffi] Support Windows 64 bit" 
This reverts commit 7f812dea1a.

Reason for revert: Flutter build is broken on Golem.

Original change's description:
> [vm/ffi] Support Windows 64 bit
> 
> Enables dart:ffi on Windows 64 bit.
> 
> Note that function_stress_test.dart fails in two different ways, these are known bugs. https://github.com/dart-lang/sdk/issues/36138
> 
> Closes: https://github.com/dart-lang/sdk/issues/35771
> Change-Id: I73012123f2bd90b737fdc1c87c9a9630c20d5660
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95647
> Commit-Queue: Daco Harkes <dacoharkes@google.com>
> Reviewed-by: Samir Jindel <sjindel@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,sjindel@google.com,dacoharkes@google.com

Change-Id: I5be4538e3c99632a852e4dfb856248eb437fb3ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96683
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2019-03-12 19:55:17 +00:00
Paul Berry 22c2c7ffd8 Sort declarations in build_mode.dart 
Change-Id: I0fa24b9733c2423ea253d75fd533b4ba2fef415e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96700
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-12 19:27:06 +00:00
Alexander Thomas e2b5559c77 [infra] Use gclient.py to apply patches to bypass update_depot_tools 
apply.sh calls gclient, but the default gclient script always runs
update_depot_tools but that is not available on bots. Calling
gclient.py directly avoids that.

Change-Id: Ief80b4822277aa5a0d075c324eed0ef15a81359d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96682
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-12 18:18:14 +00:00
Alexander Markov f4b524cdf1 [vm] Extract reading of parameter covariance attributes 
This change extracts code which reads kernel in order to get
covariance attributes of parameters into a separate function.
This removes code duplication and makes it easier to hook up
reading of covariance attributes from bytecode in future.

Change-Id: Ia19caf3edaf45df9e0bb1bdc715fac21d26788dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96560
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-03-12 17:58:46 +00:00
Brian Wilkerson 16e40cef2f Generate a diagnostic when a set or map literal is ambiguous 
Change-Id: Ia105468cf921ee2548ed48e286297e10f921a986
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96541
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-12 17:50:40 +00:00
Alexander Thomas b89d08355b [infra] Only move coredump files on shards 
On shards, the files don't need to be tar.gz'ed because the isolate
server will zip them and there aren't many files so tar'ing them doesn't
add much.

Change-Id: I696fe4c64fcee879bb9240e9d1990d2053aa8346
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96655
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2019-03-12 17:43:16 +00:00
Daco Harkes 7f812dea1a [vm/ffi] Support Windows 64 bit 
Enables dart:ffi on Windows 64 bit.

Note that function_stress_test.dart fails in two different ways, these are known bugs. https://github.com/dart-lang/sdk/issues/36138

Closes: https://github.com/dart-lang/sdk/issues/35771
Change-Id: I73012123f2bd90b737fdc1c87c9a9630c20d5660
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95647
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-12 17:30:26 +00:00
Alexander Markov 469da726d6 [vm] Put covariance attributes into Field flags 
This change reduces number of places where we need to re-parse
kernel field declarations in order to get covariance attributes.

Change-Id: I7d33d3787726270b93d16eda59b09345749a38fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96407
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-03-12 17:30:16 +00:00
pq 09087490e2 update hasFix lookup table 
Change-Id: Ie8386cf9fbdedfc6e8d08ce4939af60f623292a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-12 16:43:27 +00:00
pq bb7b5fcd37 add missing fix tests 
Change-Id: I5c01d0a551050ce9bca36003efa0f6743a7965c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-12 16:39:27 +00:00
pq 48a5c3825a assist to convert to absolute imports 
Change-Id: I2fd6ca7ec1184d56dfe97d430dc9a6c28a8c64bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-12 16:35:21 +00:00
Vyacheslav Egorov b3927f66df [gardening] Mark tests that crash as crashing 
This blocks crash uploading which should resolve redness on Mac
which produces huge core dumps.

Change-Id: Iad3f5e1be246d0de6db0aa3eee47b2f6777f5889
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96658
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
 2019-03-12 16:31:22 +00:00
Paul Berry 2d6ddf2aff Remove unnecessary override from PartialResolverVisitor 
Change-Id: If05409eadb6dd0baa39dfa6bfe087ae046fe57db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96661
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-12 15:09:12 +00:00
Paul Berry ba3b9b3b65 Sort static_type_analyzer_test.dart 
Change-Id: I4767ea98e947279d1af5d4295d1c8e66c02dee80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96660
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-12 14:59:42 +00:00
Jonas Termansen 1edc6d4b4d [infra] Fix approve_results not erroring properly if tryjobs lack results. 
Fixes https://github.com/dart-lang/sdk/issues/36157

Change-Id: I9c85cc9e54a5c09353c74897f39d01b0784ab2b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96650
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-12 14:51:24 +00:00