dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

64479 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Alexander Thomas 001d4ed85d [infra] Update checked in SDKs to 2.2.1-dev.1.1 
TBR=whesse@google.com

Change-Id: I222bb6d0fbed9251afcf7d778ef8a42d1917646f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97101
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2019-03-15 12:48:54 +00:00
Samir Jindel 85f8d3c047 [vm] Build FFI trampolines with IL. 
Bugs fixed: dartbug.com/36033, dartbug.com/36034, dartbug.com/36155.

Change-Id: Ic463dd2d299018e03f840ecedc8b7dfa350c6b95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94860
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2019-03-15 12:38:54 +00:00
Samir Jindel 4e68a04f3e [vm] Minor improvements to FFI function tests. 
Most importantly, we move resolution of symbols in function_test to the toplevel
so the same function object is re-used on each invocation. This makes it possible to
tests repeated invocations with the optimization counter enabled.

Also added some comments and new tests.

Change-Id: I3772a1f15d1ad9924c8583112ddf3b1349fb6c09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96083
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-03-15 12:38:54 +00:00
Paul Berry 652948175e Use a dynamic downward inference context for invalid ambiguous set/map literals. 
Change-Id: I734c77f41b28f27751548e58bfeabb40e0bfa95e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96965
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-15 12:19:05 +00:00
William Hesse d6ffee639b [co19] Roll co19 
Change-Id: I9fa1568bc172636b2ed3d1c2f73e88d9d3950ba1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96947
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-15 12:05:39 +00:00
Sigurd Meldgaard cded39ebf3 DEPS rename protobuf_tag to protobuf_rev 
Change-Id: I92ab357fbc2079d7f49699af5b877d4485a54992
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97083
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2019-03-15 11:36:34 +00:00
Daco Harkes e6c3bc4ba9 [gardening] update Flutter engine patch file 
Change-Id: Iba80d75ba342a3e97f35ffea3b394f97e8b86efe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97080
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-15 10:34:44 +00:00
Johnni Winther d0c4d6b329 Take variance into account when computing rti checks 
Change-Id: Ie3f93a6ac1fbf796b1c66bf29d2e9de51f5dee13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96942
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-15 09:40:14 +00:00
Johnni Winther 3e794ec16a Add tests for rti emission on function types 
Change-Id: Iee612110afbb83947a7869df3c49138a9ba34832
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96906
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-15 09:40:14 +00:00
Alexander Thomas 4ca57befd7 [dartfmt] Bump dart_style to 1.2.4 
TBR=whesse@google.com

Closes: https://github.com/dart-lang/sdk/issues/36190
Change-Id: If89601251c335e141d0cb5a2e592535c5b7ccec3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96949
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2019-03-15 09:15:46 +00:00
Kevin Millikin 495b9c4519 Remove set-literals experimental flag from tests 
The set-literals feature has shipped and is on be default.  There is
no longer any need to pass it as an option to tests and the tools
cannot remove support for the flag while it is used in tests.

Change-Id: Ibf105ec01193ebb08d6e22600e6c7748897cc2ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96941
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-03-15 07:41:11 +00:00
Sigurd Meldgaard 7c496bfd76 Update protobuf version in DEPS 
Change-Id: I92644d74cbdbb51d1f191dc19de261f90ca7493a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96782
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2019-03-15 07:34:51 +00:00
Alexander Aprelev eb47bc112e [gardening] Rename flutter/flutter patch so it matches engines hash. 
Change-Id: Iacf28ee3096411527dfa263890825e9ffefe513a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97060
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-15 05:14:33 +00:00
Alexander Aprelev de2d83b9e3 [gardening] Fix flutter patch after recent dart roll into engine. 
Change-Id: I452f3b79a9f58deb8ded515f8ce6a4e80fc1f8c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97041
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-15 04:35:00 +00:00
Konstantin Shcheglov 262878086d Extract _ConstLiteralVerifier and split it into literal / operation methods. 
R=brianwilkerson@google.com

Change-Id: I4e3412625cd8c1350bdf7dbc32d92000bc53600e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96986
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-15 00:33:13 +00:00
Bob Nystrom 092a552a52 Fix spread disambiguation test. 
Using runtime objects of the right type so that the spread doesn't
throw at runtime before we can check its type.

Change-Id: I6838079ff7f0f0267796058eee4c077c993484d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97002
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-03-15 00:15:28 +00:00
Sigmund Cherem 888596af88 Add support for a production dart2js mode in test.dart 
Change-Id: Ia828cb46106f044313e579f1c4b23ec92c6a2d44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96862
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-14 23:59:28 +00:00
Mark Zhou 90d0443848 [dartdevc] Implementing block expressions and set constants 
Change-Id: I8d04a6f256f41f7810e33c22a333d4807dad7049
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95673
Commit-Queue: Mark Zhou <markzipan@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2019-03-14 23:05:48 +00:00
Alexander Aprelev c52e1b83fb [vm/frontend_server] Fix outdated flutter patch. 
This is follow-up to https://dart-review.googlesource.com/c/sdk/+/95920.

Change-Id: Ie9b57f84d38b4acf66b0d03af646f65c69c21b6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96988
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-14 23:00:14 +00:00
Ben Konyi 59525264e8 [ VM / dart:isolate ] Added ability to set names for spawned isolates. 
Fixes issue #34059

Change-Id: I315498b02edc184e9e408c93eddb78aa1a5a8a1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/90341
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-03-14 22:23:09 +00:00
Nicholas Shahan 0ee1413095 [dartdevc] Initial support for control flow collections 
- Only supports ddc with analyzer frontend.
- Basic support for IfElement and ForElement nodes used in collection literals.

Issue: #36005
Change-Id: I0d93f8b5fa06c1dbbbf83eb3d9bd3a4834e32366
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95964
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2019-03-14 22:09:18 +00:00
Brian Wilkerson c3005ee81f Add error codes for expressions in maps and map entries not in maps 
Change-Id: I2fdebac61f697710b4fd945f694c28626dabee93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96985
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-14 22:01:53 +00:00
Sigmund Cherem 1b5f7c1047 Remove unnecessary flags for dart2js from test.dart 
Change-Id: I751688fba97d605de69164068fe2377d80087127
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96861
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-14 22:01:13 +00:00
Ben Konyi 1efe7e2518 [ VM / Service ] Added getMemoryUsage RPC and MemoryUsage object to service protocol 
Change-Id: If15e49d7aab93382c15529a738b492552faf5376
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95489
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-03-14 21:53:49 +00:00
Alexander Aprelev 35fb67158b [vm/frontend] Change frontend server interface so compile response contains delta of sources files that were used by the compiler. 
This is needed so that for incremental compilation client knows which files need to be tracked for changes, need to be reported as invalidated for next recompilation cycle(see https://github.com/flutter/flutter/pull/29004)

Change-Id: I8c9e7800b55335497a4cbecfd35cec7390528eb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95920
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-03-14 21:53:08 +00:00
Konstantin Shcheglov 208f8b5441 Restore checks for leaf elements in ErrorVerifier. 
We still need to check static types of leaf elements.
But constants might report additional errors using actual value types.

This fixes regressed:
co19_2/LanguageFeatures/Control-flow-collections/static_semantics_A01_t02/09
co19_2/LanguageFeatures/Control-flow-collections/static_semantics_A01_t02/11

R=brianwilkerson@google.com

Change-Id: Id3a6f650507f4b51028ccbde914da9fae836ed03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-14 21:11:47 +00:00
Brian Wilkerson 0f4a208c3e Revert "Add hints to check the SDK constraints for both set literals and for the ui-as-code features" 
This reverts commit 5fdb3c5057.

Reason for revert: This change broke the flutter bot.

Original change's description:
> Add hints to check the SDK constraints for both set literals and for the ui-as-code features
> 
> Change-Id: I1046e57304d56e6d7f088ea1a8a054318a45ac37
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96837
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: Ib29592b382cfd3d6b8c39caefc0db63495af1a0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-14 21:08:39 +00:00
Régis Crelier 00a478ca80 [VM runtime] Do not leak file descriptors of dual mappings to child processes. 
This applies to linux only and is a suggested precaution.

Change-Id: I81cc345eb2c316530de1fd779cdf392804a68490
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96982
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-14 20:47:14 +00:00
Brian Wilkerson 5fdb3c5057 Add hints to check the SDK constraints for both set literals and for the ui-as-code features 
Change-Id: I1046e57304d56e6d7f088ea1a8a054318a45ac37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96837
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-14 20:25:24 +00:00
Konstantin Shcheglov ca2fc831c4 Check types of values in constant List/Set against the element types. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I19c2b37596dae8fd9f3afb1fadf842be4c944b44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-14 19:53:44 +00:00
Paul Berry 7c3ab264e5 Change link methods to take a DeclaredVariables object. 
Change-Id: I6cc36f9152fb90642ec3261418e60ac3bdbe5acf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96922
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-14 19:52:24 +00:00
Ryan Macnak f7a36792b2 [vm] Fix memory leaks in --load_compilation_trace and --load_type_feedback. 
Bug: https://github.com/dart-lang/sdk/issues/36208
Change-Id: I08142c1840a57fcd1023e7cd8bb26ab4039cfa9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96963
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-03-14 19:26:13 +00:00
Dan Rubel 5d6e17a20d Improve initializer missing comma recovery 
Fix https://github.com/dart-lang/sdk/issues/33241

Change-Id: Iab230a9f10f51b1d5ca22a8b8d74751a51d5f9f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-14 19:25:04 +00:00
Sigmund Cherem a8c94d0b52 Remove tools we no longer need to manage status files 
Change-Id: Ia106c48cdbecaa8eec722ee11cbc9b6813989477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96860
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-03-14 19:16:24 +00:00
Brian Wilkerson c5624274e1 Update the SDK constraints to match the fact that set literals are being used 
Change-Id: I0c1de0d972a38ebd5c4f0b2fc2cda4258b63339f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96981
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-14 19:12:44 +00:00
Nate Bosch 28d697a6c1 Enforce override annotations in dart2js 
Update the excludes in the test directory analysis options to match the
files that were not updated to add override annotations.
Update the excludes in `testing.json` to match the analysis options.

With a consistent analysis options test config the diagnostics in
editors will match what is enforced by the test.

Also clean up the no longer required `enableSuperMixins` config.

Change-Id: If0e23642c25e0b5c1aced6a5a8c8c05a6da538f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96836
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2019-03-14 18:47:05 +00:00
Paul Berry 5e1397fc4e Remove unused import 
Change-Id: I18837fe28a92fffc3a8f80460f34f14e94bb19de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96962
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-14 17:56:16 +00:00
Stevie Strickland ae8a47e92c Add changelog entry for RegExp lookbehind support. 
Change-Id: Iafc99d75bcfeaa5a236bdff7808bace1b153445e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96945
Auto-Submit: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2019-03-14 17:24:04 +00:00
Jonas Termansen 1c02016b7b [infra] Fall back on inexact baseline commits in test.dart. 
This change makes test.dart handle if the baseline commit hasn't been built
on the requested builder and instead attempts to search for whether there's
results for up to 25 preceding commits, which it then uses as an inexact
baseline.

Closes https://github.com/dart-lang/sdk/issues/36211

Change-Id: Ie44042c67c9460826736f4a2cf159d8d7b455f0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96944
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-14 17:04:36 +00:00
Régis Crelier e2a86d9081 [VM runtime] Use memfd_create instead of shm_open for dual mapping of code. 
Detect both at compile time and runtime for memfd_create support and disable
dual code mapping if not available.

Change-Id: I6908e6c116a60218bb5002378470011dfe76a257
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96845
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-03-14 16:56:34 +00:00
Konstantin Shcheglov 7418238239 Implement LibraryElementForLink.session and return (empty) AnalysisSessionForLink. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://buganizer.corp.google.com/issues/127956822
Change-Id: Ifc93882d9ae7ae6079497fb10f3feea7ac6fb9e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96864
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-14 15:39:18 +00:00
Konstantin Shcheglov 806ec1161f Issue 3270. Put StreamBuilder's type argument into linked edit. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/3270
Change-Id: I8e4d10029c7eab1f9edeaeed97ac4d54a74d81cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96865
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-14 15:31:42 +00:00
Konstantin Shcheglov eeb19b0416 Remove usages of ExtensionManager and package:plugin in general. 
R=brianwilkerson@google.com

Change-Id: I489e72464474b3d40d7678f44562f65934f93288
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-14 15:31:08 +00:00
Martin Kustermann 6c5194cfe1 [VM/Flutter] Remove 2 golden-file tests completely to avoid flutter analyze warning about missing copyright header 
This should turn 3head green and hopefully the next engine->flutter roll
fixes the golden expectation files.

Change-Id: Ic52216a965c0981e187d2186653428ee52f1ac47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96943
Auto-Submit: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-14 14:52:12 +00:00
Stevie Strickland f31b7928ae [VM] Adding regexp lookbehind assertion support. 
See https://github.com/tc39/proposal-regexp-lookbehind
for a high-level description of the feature and examples.  This is one of the
features requested in https://github.com/dart-lang/sdk/issues/34935.

This work takes the feature as present in the v8 engine and appropriately
merges it into our irregexp fork. Notable changes to the irregexp codebase to
introduce this feature:

-----

We can no longer assume that all matching proceeds forwards, since lookbehind
matching proceeds backwards. Similarly, we cannot assume that we can only be
at the start of a string if we started matching from that point. The direction
of matching must also be taken into consideration when doing bounds checking,
which previously assumed the engine would never attempt to look before the
start of a string.

-----

We may now parse backreferences to captures before the capture they
reference, since we parse regular expressions left to right, but lookbehinds
perform captures as they evaluate the string from right to left.  Since
RegExpBackReference objects contain a pointer to their corresponding capture,
this means that we may need to create RegExpCapture objects prior to the
parsing of the corresponding captured subexpression.

Thus, RegExpCapture objects are now only initialized with their index, and the
body is set later when the subexpression is encountered and parsed. This means
any method that operates on the body of a RegExpCapture can no longer be const,
which also affects the rest of the RegExpTree class hierarchy. This also means
that we don't have a valid max_match length for backreferences based off the
capture body, and must assume they can end up being any length.

-----


Change-Id: Iffe0e71b17b1a0c6fea77235e8aee5c093005811
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94540
Commit-Queue: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-14 14:26:47 +00:00
Aske Simon Christensen dfb6d250b1 [kernel] Better printing of string and unevaluated constants. 
This makes the printed constant pool easier to read.

Change-Id: I54d8223faeed9cb92454f4f0128f60b7e839ee42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96904
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-03-14 13:54:59 +00:00
Kevin Millikin c9e9b76d4d Skip control-flow-collections tests on all runtimes 
This feature is under development in the front end.  Testing it on the
runtimes leads to numerous spurious status changes.  Skip the tests
for now.  The intent is that when a backend change causes a test to
start passing, then that test will be un-skipped.

Change-Id: I6c8c1f45315607039240c3edc61ba8340ae9cda0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96902
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-14 13:09:07 +00:00
Michael Thomsen 1af9d3e14b Update breaking-changes.md 
Closes #36172
https://github.com/dart-lang/sdk/pull/36172

GitOrigin-RevId: 9cdf8c273fd887c82ccc61ff963e31343ad2780a
Change-Id: I200beb7667fad38abcf5b5e25ebbdfbd41c61d5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96920
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2019-03-14 12:35:56 +00:00
Aske Simon Christensen dbea5c6884 [fasta] Commandline option to leave environment constants unevaluated. 
Also, outdated description of -D option corrected.

Change-Id: Ie1dc011adc3ce2f5293826c96f22700a6528c9a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96880
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-03-14 11:30:07 +00:00
Martin Kustermann 10a8663e74 [VM/Flutter] Disabled golden tests until next engine -> flutter roll (which probably fixes it) 
Change-Id: I16cb739cf33af3b357b242a1b02ae48515e00dbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96900
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-14 10:47:46 +00:00