dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

64479 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Liam Appelbe 48ac0bdd72 Revert "Attempt 3 at the upload abi dill script" 
This reverts commit 94a382bfb8.

Reason for revert: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919623995548729328/+/steps/upload_abi_dills/0/stdout

Original change's description:
> Attempt 3 at the upload abi dill script
> 
> Bug: https://github.com/dart-lang/sdk/issues/36047
> Change-Id: I1e8c28b30485e745fe773c2acfb334f4ef3aa1be
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95707
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,liama@google.com

Change-Id: I9eec3ca373ade1a7573eaa9999521c45213b060f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95881
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-07 18:43:39 +00:00
Sam Rawlins bc02b6ce7d Split DEAD_CODE tests into their own file 
Change-Id: I7d550ec240a10b839791cb5e00216c739af12d8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95666
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-07 18:28:37 +00:00
Dan Rubel 6c1a05a388 update non-nullable flag in ErrorVerifier for angular plugin 
Change-Id: Ib4cb1a7426a15402c85ed9ef0fa9932f4b3f40b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-07 18:17:57 +00:00
pq da831bda20 fix lint name for unnecessary_overrides 
Change-Id: Id6c879d52bb8cbe0c46d1701b382716846947926
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-07 18:11:57 +00:00
Alexander Markov f2a8e71ff9 [vm] Decouple flow graph building of implicit closure functions from kernel reading 
Change-Id: I6bf5ad6ed76c363904ae1765d8303eff4a799363
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95706
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-03-07 18:09:48 +00:00
Brian Wilkerson f44fecbe39 Fix the way type arguments for iterable and map are accessed 
Change-Id: I8d11fd4c10b8a5bc9fde633aba9987dba0ad59a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95742
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-07 18:04:12 +00:00
Liam Appelbe 94a382bfb8 Attempt 3 at the upload abi dill script 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I1e8c28b30485e745fe773c2acfb334f4ef3aa1be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95707
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-07 17:33:09 +00:00
Liam Appelbe 924a934fe1 Shrink the stack headroom if the stack is very small 
Bug: https://github.com/dart-lang/sdk/issues/36100
Change-Id: I9d887e74c7f888dbeebaf02556522d375e30b97f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95703
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-07 17:32:59 +00:00
Konstantin Shcheglov e5a833b06b Comment out test that unexpectedly passes on Windows. 
TBR

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I34b9816ccc5d25c6b78b7db09ab7c0d70cf9c6c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95801
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-07 17:09:18 +00:00
Martin Kustermann 72548cde13 Revert "[vm, gc] The mutator's TLAB and the interpreter's lookup cache must be visited even if the mutator is unscheduled." 
This reverts commit 253499fe68.

Reason for revert: This seems to have caused new heap verification failures, e.g.

python tools/test.py -n dartkp-linux-debug-x64 lib_2/convert/streamed_conversion_json_utf8_decode_test
...                                                                                                                                                                                                                                                              
stderr:                                                                                                                                                                                                                                                       
Verifying before Scavenge...../../runtime/vm/raw_object.cc: 36: error: New object missing kNewBit: f3f3f3f3                                                                                          
                                                                                                           
version=2.2.1-edge.253499fe68b1efaed5c2be699b4e59af3703c0f3 (Thu Mar 7 01:01:02 2019 +0000) on "linux_x64"
thread=219499, isolate=isolate(0x55efd3734900)                                                            
  [0x000055efd10532e6] dart::Profiler::DumpStackTrace(bool)                                           
  [0x000055efd10532e6] dart::Profiler::DumpStackTrace(bool)                                   
  [0x000055efd1053224] dart::Profiler::DumpStackTrace(void*)                                        
  [0x000055efd13a6805] Dart_DumpNativeStackTrace                                                                                                                                                                                                             
  [0x000055efd13b7313] dart::Assert::Fail(char const*, ...)                                                                                                                                                                                                   
  [0x000055efd1073ac8] dart::RawObject::Validate(dart::Isolate*) const                                                                                                                                                                                        
  [0x000055efd1379c51] dart::VerifyObjectVisitor::VisitObject(dart::RawObject*)                                                                                                                                                                              
  [0x000055efd1376a43] dart::Scavenger::VisitObjects(dart::ObjectVisitor*) const                                                                                                                                                                             
  [0x000055efd136098b] dart::Heap::VisitObjectsNoImagePages(dart::ObjectVisitor*) const                                                                                                                                                                      
  [0x000055efd13632f3] dart::Heap::CreateAllocatedObjectSet(dart::Zone*, dart::MarkExpectation) const                                                                                                                                                        
  [0x000055efd1363522] dart::Heap::VerifyGC(dart::MarkExpectation) const                                                                                                                                                                                      
  [0x000055efd1377144] dart::Scavenger::Scavenge()                                                                                                                                                                                                            
  [0x000055efd1361b06] dart::Heap::CollectNewSpaceGarbage(dart::Thread*, dart::Heap::GCReason)                                                                                                                                                                
  [0x000055efd1360330] dart::Heap::CollectMostGarbage(dart::Heap::GCReason)                                                                                                                                                                                   
  [0x000055efd135fff5] dart::Heap::AllocateOld(long, dart::HeapPage::PageType)                                                                                                                                                                               



Original change's description:
> [vm, gc] The mutator's TLAB and the interpreter's lookup cache must be visited even if the mutator is unscheduled.
> 
> Bug: TC-384
> Change-Id: Ic3dcc2fea3e80ef181f8891ccb00a8e2e33fc077
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95670
> Reviewed-by: Alexander Aprelev <aam@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>

TBR=aam@google.com,rmacnak@google.com,alexmarkov@google.com,regis@google.com

Change-Id: Ia1e2cbf7c059e22a2c71f28cb641f07ccd3dddab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: TC-384
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95821
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-07 16:56:20 +00:00
Samir Jindel bdb07f4a1f [vm/ffi] Fix garbage collection of ffi.Pointer subtypes. 
Fixes https://github.com/dart-lang/sdk/issues/36125.

Change-Id: Ib9069d1e15684c785b86954ed8c14e5fdde35fec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95652
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-03-07 15:56:08 +00:00
pq cab4a7b48d fix lint name for unnecessary_brace_in_string_interps 
Change-Id: I7df7540b4b4574df8e807b313988ed6a4bf6a26b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-07 15:33:33 +00:00
pq 00aeae4ca8 add fix for no_duplicate_case_values 
See: https://github.com/dart-lang/linter/issues/1374.

Change-Id: Ia09f2530c9a943b8b80fda63fb313b752748264a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95709
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-07 15:26:26 +00:00
pq 593405afda add fix for use_rethrow 
See: https://github.com/dart-lang/linter/issues/1374.

Change-Id: I7e79ad37681afdbd94d7968451a768e74217578e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95708
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-07 15:25:26 +00:00
Kevin Moore 1551d9c660 Include correct stack during error with Stream.join 
Fixes https://github.com/dart-lang/sdk/issues/36135

Change-Id: I0f5397acde81ed74a28b7dd25bc81d34ac21a130
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95740
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2019-03-07 14:52:26 +00:00
danrubel 309140693c Revise non-nullable flag from AstBuilder to ErrorVerifier 
This is one step in refactoring non-nullable enablement

* update AstBuilder to record isNonNullable in CompilationUnitImpl
* update ErrorVerifier to pull non-nullable from CompilationUnitImpl

Change-Id: I78e5f529330f10f294ad1c1b3b7ac8b672a5ee9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95426
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-07 13:29:45 +00:00
Daco Harkes 2d3b1055d3 [vm/ffi] remove RuntimeError/Fail expectation from status files 
Change-Id: Iaff947c213ac6cff666202fca16b3775bcc10413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95782
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-03-07 13:16:06 +00:00
Martin Kustermann b4e9e46f81 [Gardening] Add tools/diff_results.dart which can query the test results database and report a diff in test results from two commits 
The tool can be used to diff the results of two commits on a set of builders.
The user has to pick the revisions to ensure that both of them have results for the given revisions.

Unfortunately it currently seems to also give false-positive because of flaky tests.


Usage:

    sdk % dart tools/diff_results.dart -b 'vm-*' 6cf71022a8 \
                                                 7df88e5755

      ...

      language_2/control_flow_collections/if_promotion_test/none null -> (expected: Pass, actual: CompileTimeError)
	 on vm-dartkb-linux-{debug,release}-x64
	 on vm-kernel-asan-linux-release-x64
	 on vm-kernel-checked-linux-release-x64
	 on vm-kernel-linux-release-{simarm,simarm64}
	 on vm-kernel-optcounter-threshold-linux-release-{ia32,x64}
	 on vm-kernel-precomp-android-release-arm
	 on vm-kernel-precomp-bare-linux-release-{x64,simarm,simarm64}
	 on vm-kernel-precomp-linux-release-simarm
	 on vm-kernel-precomp-linux-{debug,release,product}-x64
	 on vm-kernel-precomp-obfuscate-linux-release-x64
	 on vm-kernel-precomp-win-release-x64
	 on vm-kernel-precomp-{mac,linux,win}-release-simarm64
	 on vm-kernel-reload-linux-{debug,release}-x64
	 on vm-kernel-reload-mac-{debug,release}-simdbc64
	 on vm-kernel-reload-rollback-linux-{debug,release}-x64
	 on vm-kernel-{linux,win}-{debug,release}-ia32
	 on vm-kernel-{mac,linux,win}-{debug,release,product}-x64
	 on vm-kernel-{mac,linux}-{debug,release}-simdbc64

Change-Id: Ibd3a0bdcec238c1fc0d147147b6fe4a7bb74819d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93954
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-03-07 12:50:10 +00:00
Aske Simon Christensen f1cc9c7cf1 [cfe] Classes for if, for and for-in elements. 
Change-Id: Ibb20435c8c64dc66f6ed9f731a3a53481bfef60a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95653
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-07 11:41:25 +00:00
Kevin Millikin e3f0ca80e5 [cfe] Compile null-aware spreads in non-const lists and sets 
Change-Id: I0be204a03bf4ddeb8950ec443952e9e99197b125
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95641
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-03-07 10:11:05 +00:00
Kevin Millikin e8fa9a019b [ddc] Fix a front end test failure 
This code causes a front_end test failure.  The code in question also
just looks wrong.

Change-Id: I8d3e7e4cd6fc4e919b48e5784bab84302b5639b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95657
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-03-07 08:47:13 +00:00
Daco Harkes b71f6afd2c [vm/ffi] enable function stress test on macos 
Change-Id: I92f676ac6c9733123b7cccf4dc24cb723a2b0594
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95655
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-03-07 08:20:08 +00:00
Zichang Guo 4ec72c1eb1 [VM-Runtime]Fix source report coverage to not include field without function initializer 
Fix issue created by 89173. Also rename HasInitializer to HasInitializerFunction to distinguish from has_initializer.

Bug= https://github.com/flutter/flutter/issues/28542

Change-Id: Id9f898937c2f4f350a6d619019dc12611505801f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95680
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-03-07 02:04:41 +00:00
Ryan Macnak 253499fe68 [vm, gc] The mutator's TLAB and the interpreter's lookup cache must be visited even if the mutator is unscheduled. 
Bug: TC-384
Change-Id: Ic3dcc2fea3e80ef181f8891ccb00a8e2e33fc077
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95670
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-03-07 01:01:02 +00:00
Ryan Macnak 980e5c7b57 [vm] Mark VM isolate objects at heap finalization instead of allocation. 
Avoids unnecessary branching in allocation.

Also, rename the VMHeap bit to ReadOnly to reflect its current usage.

Change-Id: Ic6060eec263cef0a3fc92f253dff976cea45bdb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95063
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-07 00:20:30 +00:00
Ryan Macnak e48ad45fbd [vm, interpreter] Enable field guards. 
Bug: https://github.com/dart-lang/sdk/issues/36131
Change-Id: I8aa538bc96d10d14322c875228dbd7a97ddf114b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95491
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-07 00:19:40 +00:00
Brian Wilkerson a7d790bbbe Fix cast exception in resolution 
Change-Id: Iefa49b509bec67522bbd916c41fc301d5d9d3811
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95705
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 23:57:31 +00:00
Mark Zhou 2f53b7913c [dartdevc] Including the current library for members from within an InstanceConstant 
This resolves an issue where private fields of const objects would fail to properly initialize.

Change-Id: I587c27d2c2212929babc6b4168cffc9770ae9c86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95490
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-03-06 22:42:26 +00:00
Paul Berry 0124541d5f Deprecate AST data structures that will be obseleted by the "UI as code" feature 
- ForStatement and ForEachStatement will be replaced by ForStatement2.
- MapLiteral and SetLiteral will be replaced by SetOrMapLiteral.

To ease the transition, the old classes are subtypes of the new
classes, so even though the analyzer still creates instances of the
old classes, clients should be able to start referring to the new
classes in their code.  The analyzer will stop creating instances of
MapLiteral and SetLiteral when the experimental flags for the "UI as
code" feature are turned on, and will stop creating instances of all 4
classes when we bump the major version number (which should happen
sometime in March).

For visitors, we've updated the base classes with the following default methods:
  visitForStatement(node) => visitForStatement2(node);
  visitForEachStatement(node) => visitForStatement2(node);
  visitMapLiteral(node) => visitSetOrMapLiteral(node);
  visitSetLiteral(node) => visitSetOrMapLiteral(node);

So clients should be able to start revising their visitors to override
the new visit methods rather than the old ones, and the visit methods
in the base classes will automatically forward to the new visit
methods.

Change-Id: Ifde3a2aa3c8c49ce4e65dfaabf086db4dabb73f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95665
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-06 21:43:50 +00:00
Alexander Thomas 1751135fc3 [infra] Increase number of shards on app-* builders 
TBR=whesse@google.com

Change-Id: I4e8ae26d1a90666370f3e678efbd944d5a665f7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95656
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-06 21:23:10 +00:00
Adam Barth 6988347b53 [fuchsia] Migrate to lib/sys/cpp 
We now use lib/sys/cpp, which is part of the Fuchsia SDK, rather than
lib/component/cpp, which is being deleted.

Change-Id: I3eaae74cc0403923886f9872d4327e46ec8915c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95700
Auto-Submit: Adam Barth <abarth@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2019-03-06 21:16:30 +00:00
Anthony Bullard 995b1c9adc FE Server shouldn't try to invalidate other file schemes 
When trying to invalidate files when using a multi-
root file system, if a .dill file that is being
used to initialize an incremental compiler contains
both files with a custom marker scheme, as well as
an internal one like `org-dartlang-sdk`, it will
throw when it encounters the internal scheme.

This commit remedies the issue, but this is my
first CL to the SDK, I'm not sure if this is
the best approach.

Other approaches may be:

- Ignore dartlang internal file schemes only
- Catch errors from entity.exists instead of filtering

And I'm sure there are many others.

Change-Id: Idc7aba4b41eb5cf7f66db492f0ea6e26252779c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94680
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-06 21:14:40 +00:00
Ryan Macnak 975cc65c17 [vm, interpreter] Implement interpreter stubs for IA32. 
Change-Id: I7bb7e51cb46868abcc10c7dcc7cbf1db1ccdc35c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95264
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-06 21:09:30 +00:00
pq 85dec3423c add fix for unnecessary_new lint 
See: https://github.com/dart-lang/linter/issues/1374.

Change-Id: I945d393b0b46cf87b5400be1bfdb501c31646988
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95669
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 20:55:00 +00:00
Brian Wilkerson 17bf9d13b1 Delay disambiguating maps and sets until we know whether there are any conflicts 
Change-Id: If55d8ab011047107f34a05a08e60ee54eabc0b44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95668
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-03-06 20:47:45 +00:00
Brian Wilkerson 079309fcd6 Create curly braces when resynthesizing map and set literals 
Change-Id: I918624f0a07a02c98fdd2725a18fb3fd945eca8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95664
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 20:21:07 +00:00
Paul Berry 68c9909ef8 Re-apply workaround for bug fixed by closures containing type promotions in variables with inferred types. 
ba5644b76c fixed an analyzer bug causing
a crash when a top level variable requiring type inference contained a
closure involving type promotion, and removed some explicit types that
were present in the analyzer to work around the bug.

Although the bug has been fixed now, the fix hasn't rolled out in a
release of the SDK.  So to avoid people seeing analysis server crashes
when editing the analyzer, I'm re-introducing the workaround.

Change-Id: I5e61345021cd33cb9ad1f017a7619815a38c6a1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95667
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-06 20:12:07 +00:00
Ryan Macnak 68946df573 [vm] Also print version information in assertion failures, not just faults. 
Populate the dynamic symbol table for gen_snapshot.

Change-Id: Ib4712d2f481948f646ba4f5e353e0837b6391eab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95682
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-03-06 20:02:18 +00:00
Liam Appelbe 0c231060f4 Revert "Another attempt to fix the upload script." 
This reverts commit 0e578056e9.

Reason for revert: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919710985306895504/+/steps/upload_abi_dills/0/stdout

Original change's description:
> Another attempt to fix the upload script.
> 
> Bug: https://github.com/dart-lang/sdk/issues/36047
> Change-Id: I2302bd3ee2072651cebcc1179e9778dc4c617965
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95662
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,liama@google.com

Change-Id: Ibe5c52ae0005ea8aa0e69862a19b54cd64864974
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95702
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-06 19:40:39 +00:00
Konstantin Shcheglov d1e60e0f3d Remove @failingTest from a test that stopped failing. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Id0fb24e38b09acce28b401d941f9ff81729b9e1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95701
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-06 19:35:58 +00:00
Zach Anderson 825d03c585 [vm] Remove malloc_hooks support for jemalloc 
Fuchsia is switching/has switched to scudo.

Change-Id: I0c829518652053243bf3f8db675e562ccfb448f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95663
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2019-03-06 19:16:27 +00:00
Paul Berry 8bb8d11859 Prepare to publish analyzer_plugin version 0.0.1-alpha.7 
We need a version of analyzer_plugin that supports analyzer 0.35.x.

Change-Id: I581ed6951f3e7f68d86743bfdfdf387a10c73f30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95681
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-06 18:57:13 +00:00
Liam Appelbe 0e578056e9 Another attempt to fix the upload script. 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I2302bd3ee2072651cebcc1179e9778dc4c617965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95662
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-06 18:01:37 +00:00
Konstantin Shcheglov 90b61e2fde Start implementing linker and resynthesizing. 
Change-Id: Id1ad7925082f642d5dad7b01fa02b6c8cb76cf06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-06 17:29:29 +00:00
Konstantin Shcheglov a1226b1490 Write and read almost all nodes. 
CommentReference is not done yet.

Also skipped deprecated:
  visitListLiteral2
  visitMapLiteral2
  visitSetLiteral2

And about to be deprecated?
  visitForEachStatement
  visitForStatement
  visitMapLiteral
  visitSetLiteral


  Now we can resolve, write and read back into AST everything in pkg/.
  Some statistics:

R=brianwilkerson@google.com, paulberry@google.com

totalContent: 34814665 characters
totalWriteTime: 18140 ms
totalWriteBytes: 305675628
totalReadTime: 2761 ms
Change-Id: I2f92bb47c124d5ba040d8f66f762d23603c17609
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 17:20:49 +00:00
Paul Berry ba5644b76c Fix handling of closures containing type promotions in variables with inferred types. 
Promotion analysis requires the localVariableInfo data structures to
be set; these are set by the VariableResolverVisitor.  So we need to
ensure that this visitor runs prior to type inference.

Change-Id: I579301beb101f32a1965f9eb8f07b1196d232b8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95422
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-06 17:16:19 +00:00
Daco Harkes 7a98559781 [vm/ffi] make Pointer.toString() uniform on all operating systems 
Change-Id: I805c8b3c56a18a253c5005945cab47d5a6aa26cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95648
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
 2019-03-06 16:48:09 +00:00
Daco Harkes 12fcb9136c [cfe] Make resolveInputUri available for pkg/vm 
use function suggested by ahe


[gardening] fix incremental compiler file encoding on Windows

Change-Id: I50fd02389afabe4903d9d88d009d58330515f825
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95642
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-06 15:31:09 +00:00
pq 5441ff672b add fix for unnecessary_const lints 
See: https://github.com/dart-lang/linter/issues/1374.

Change-Id: Ieeddf25718ddde77a9e52cb93cbcf34ca2c1f81f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95542
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 15:28:59 +00:00
Jonas Termansen 9645b19060 [infra] Link to the documentation in the new workflow tools. 
Change-Id: Idf8181a1d007fa624e04087a7949f5f04da3b077
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95645
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-06 15:06:40 +00:00