dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

64479 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dmitry Stefantsov b36c56ff84 [cfe] Add type inference for spreads in list literals 
Change-Id: I4076fe82a0b4c0780dc53cc51f9abba3b1d85e8c
Reviewed-on: https://dart-review.googlesource.com/c/94520
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-01 15:17:13 +00:00
Dmitry Stefantsov e4aa4325b7 [fasta] Enable spread collections in unit tests 
Change-Id: Id417704bdd15f8244f16fd61715f43910f678f7f
Reviewed-on: https://dart-review.googlesource.com/c/94541
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-01 15:17:13 +00:00
Aske Simon Christensen 1471b8e444 Revert "[CFE] Move constant evaluation number semantics handling to front end." 
This reverts commit c2b466b09f.

Reason for revert: Broke precompiled, DDC and others.

Original change's description:
> [CFE] Move constant evaluation number semantics handling to front end.
> 
> JavaScript number semantics is currently implemented as the simplistic
> version previously present in DDC. This is a starting point for fully
> detailed JS number semantics.
> 
> Change-Id: Id728b3dacec892a5cbf7ece0d9faea51427f5f9b
> Reviewed-on: https://dart-review.googlesource.com/c/94746
> Commit-Queue: Aske Simon Christensen <askesc@google.com>
> Reviewed-by: Sigmund Cherem <sigmund@google.com>

TBR=sigmund@google.com,askesc@google.com

Change-Id: I732c75b72df0e0f084ad2784349bee346ae5b7ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/95027
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-03-01 14:34:15 +00:00
Jens Johansen 6e06047004 AST to Text more resilient in writeAdditionalExports 
Change-Id: If2a3e87f935e75421802358b028894a8fbb093d9
Reviewed-on: https://dart-review.googlesource.com/c/95025
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-03-01 14:24:53 +00:00
Aske Simon Christensen c2b466b09f [CFE] Move constant evaluation number semantics handling to front end. 
JavaScript number semantics is currently implemented as the simplistic
version previously present in DDC. This is a starting point for fully
detailed JS number semantics.

Change-Id: Id728b3dacec892a5cbf7ece0d9faea51427f5f9b
Reviewed-on: https://dart-review.googlesource.com/c/94746
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-01 13:30:53 +00:00
Jonas Termansen b60b664b16 [infra] Make gclient sync quiet when nothing is updated. 
The 7zip dependency is only used on Windows. Use gclient's OS-specific
hook feature to only download it while on Windows. This avoids the
download from google cloud storage from needlessly saying it is doing
nothing.

There's no reason to point out the sysroot is already up to date as this
makes gclient output several lines of text with zero information.

Change-Id: Id1c212c8a951612c413e9834867fe90f6dca6a20
Reviewed-on: https://dart-review.googlesource.com/c/94752
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
 2019-03-01 13:02:23 +00:00
Paul Berry 9a0a3fd8c1 Eliminate uses of old AST node types from analyzer_plugin 
Change-Id: I1dc8e1d51d96c5fc4e6b8c77b143c8cc9564f63e
Reviewed-on: https://dart-review.googlesource.com/c/94761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-01 10:03:22 +00:00
Johnni Winther ba4cfb8613 Initial computation of initializer complexity through the scope visitor. 
Change-Id: I2951624a0ad901c7c518b6e5d2f147dceae870cc
Reviewed-on: https://dart-review.googlesource.com/c/94382
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-01 08:37:12 +00:00
Mike Fairhurst 15515d86e3 Reland "[analyzer] Constant verifier support for SetOrMapLiteral" 
Original change's description:
> Revert "[analyzer] Constant verifier support for SetOrMapLiteral"
> 
> This reverts commit 9c6315c199.
> 
> Reason for revert: Do not have permission to approve the bot failures.
> 
> Original change's description:
> > [analyzer] Constant verifier support for SetOrMapLiteral
> > 
> > Change-Id: Iaa189aa7ad733af3f702546f1d7a379630b61aa7
> > Reviewed-on: https://dart-review.googlesource.com/c/94581
> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> > Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
> 
> TBR=paulberry@google.com,brianwilkerson@google.com,mfairhurst@google.com
> 
> Change-Id: Id7f48506994cc5b8de506f9830f12d794f186e21
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/94981
> Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>

TBR=paulberry@google.com,brianwilkerson@google.com,mfairhurst@google.com

Change-Id: I7e514b646c1c62532e6f19201db6ea3428cb96d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/95000
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-03-01 08:01:24 +00:00
Mike Fairhurst 9bec44d1e2 Revert "[analyzer] Constant verifier support for SetOrMapLiteral" 
This reverts commit 9c6315c199.

Reason for revert: Do not have permission to approve the bot failures.

Original change's description:
> [analyzer] Constant verifier support for SetOrMapLiteral
> 
> Change-Id: Iaa189aa7ad733af3f702546f1d7a379630b61aa7
> Reviewed-on: https://dart-review.googlesource.com/c/94581
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Auto-Submit: Mike Fairhurst <mfairhurst@google.com>

TBR=paulberry@google.com,brianwilkerson@google.com,mfairhurst@google.com

Change-Id: Id7f48506994cc5b8de506f9830f12d794f186e21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94981
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-03-01 07:43:04 +00:00
Kevin Moore d73bc49420 DEPS: update html, http_parser, logging, package_resolver, source_span 
Change-Id: I18b8268e7ad5c211f83f323957440e29b50ec0d7
Reviewed-on: https://dart-review.googlesource.com/c/94805
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-01 07:08:32 +00:00
Mike Fairhurst 9c6315c199 [analyzer] Constant verifier support for SetOrMapLiteral 
Change-Id: Iaa189aa7ad733af3f702546f1d7a379630b61aa7
Reviewed-on: https://dart-review.googlesource.com/c/94581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2019-03-01 06:36:17 +00:00
Konstantin Shcheglov 67366ed771 Support for @Variant and @VariantId in generator. 
It also includes a sample how it looks in IDL and generated.
I will remove it before landing.

R=paulberry@google.com

Change-Id: I4c60b33e623cf9c55d46a8dd9624377e5a0f5053
Reviewed-on: https://dart-review.googlesource.com/c/94921
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-03-01 02:43:30 +00:00
Ian McKellar 16fc751e49 [fuchsia] Clean-up after the FIDL string/vector types transition 
This cleans up what was introduced in:
https://dart-review.googlesource.com/c/88122

Change-Id: If7596a3dd57af25d91fe880104e5aafd301c57f4
Reviewed-on: https://dart-review.googlesource.com/c/94922
Auto-Submit: Ian McKellar <ianloic@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-03-01 02:01:19 +00:00
Alexander Markov 1d3a0d5129 Revert "[vm/ffi] Stress tests for FFI functions." 
This reverts commit b186a270e4.

Revert "[vm] Fix windows build after "[vm/ffi] Stress tests for FFI functions.""

This reverts commit 3dcc0c69a1.

Revert "[vm] Update status file for standalone_2/ffi/function_stress_test"

This reverts commit 9d609426b2.

Revert "[gardening] Skip ffi/negative_function_test on asan bot"

This reverts commit 223f407af5.

Reasons for revert:
1) timeouts on app-kernel-linux-debug-x64 bot when it
tries to deflake new tests.
2) crash dump archiving fails on vm-kernel-asan-linux-release-x64
when trying to archive crash dumps from these tests.

Issue: https://github.com/dart-lang/sdk/issues/36033
Issue: https://github.com/dart-lang/sdk/issues/36034
Change-Id: Ifa338fb96b490e8137a8aa6a4a62f4a6f9e6ea83
Reviewed-on: https://dart-review.googlesource.com/c/94963
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
 2019-03-01 01:37:09 +00:00
Ryan Macnak 24df9cc588 [vm] Implement interpreter stubs for ARM, SIMARM and SIMARM64. 
Change-Id: If49e656bb3c016d42bc5588c6026116f2aff5076
Reviewed-on: https://dart-review.googlesource.com/c/94682
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-01 01:25:19 +00:00
Ben Konyi e8d6e2f704 [ VM ] Updated SourceReport tests with correct token positions 
Change-Id: I6aa49e715043a1ba463425e53018c5078a272129
Reviewed-on: https://dart-review.googlesource.com/c/94962
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-03-01 00:48:59 +00:00
Alan Knight 19dbd70363 Catch errors in formatting function types 
Change-Id: Ifa889ab486da4b86a2738857bf2c6d8a8ed0cfe4
Reviewed-on: https://dart-review.googlesource.com/c/93125
Commit-Queue: Alan Knight <alanknight@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2019-03-01 00:47:59 +00:00
Ryan Macnak 2259695037 [vm, gc] Document object representation. 
Change-Id: I18fea69cc86161c2f960854e636bfe07a44789cb
Reviewed-on: https://dart-review.googlesource.com/c/94841
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-03-01 00:32:25 +00:00
Alexander Markov 223f407af5 [gardening] Skip ffi/negative_function_test on asan bot 
This newly added test causes crash dump archiving to fail on
vm-kernel-asan-linux-release-x64 bot. This causes bot to fail
although the test failure was approved.

The test was added in b186a270e4.

Issue: https://github.com/dart-lang/sdk/issues/36033
Issue: https://github.com/dart-lang/sdk/issues/36034
Change-Id: I9ac201124db239d9c4bcce176c54e66cfdf1b54e
Reviewed-on: https://dart-review.googlesource.com/c/94961
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-02-28 23:44:49 +00:00
Paul Berry c2e48195f0 Rename UiAsCodeVisitorMixin to UIAsCodeVisitorMixin 
To conform to Dart style rules

Change-Id: I1cc7ef76d0d723725f6d0393ca6e2b7538fc2f3e
Reviewed-on: https://dart-review.googlesource.com/c/94900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-28 21:42:09 +00:00
Brian Wilkerson 48ee388791 Fix a typo in a shared test 
Change-Id: I096e459ffeae70f944d03715081c3b9f653b01a6
Reviewed-on: https://dart-review.googlesource.com/c/94843
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-02-28 21:25:49 +00:00
Paul Berry 545ebe1741 Prepare to publish analyzer 0.35.3 
This is needed so that we can publish a version of analyzer_plugin
that depends on it; also so that dartfmt work on "UI as code" features
can proceed.

Change-Id: I7647fd69fec28b9e788f89e915c14779815fcc02
Reviewed-on: https://dart-review.googlesource.com/c/94803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-28 20:54:19 +00:00
Paul Berry 17195d2667 Eliminate uses of old AST node types from dev_compiler 
Change-Id: I839ed26a159a48e39378e94b4884faf65e3bb028
Reviewed-on: https://dart-review.googlesource.com/c/94365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-28 20:46:16 +00:00
danrubel a417659fcd debug dartfix test 
... by ensuring that logged information is echoed to console

Change-Id: I8e9c71d0fc6f164637c35d28415cdf02e9a47b9a
Reviewed-on: https://dart-review.googlesource.com/c/94880
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-28 20:39:16 +00:00
Aart Bik a10b0d8763 [vm/compiler] LICM and CSE improvements 
Several improvements
(1) makes implicit control dependence of a null check
    explicit by means of data dependence (already
    done for bounds checks); also see the doc in
    runtime/docs/compiler/data_dep_for_control_dep.md
(2) improves CSE properties of various IL nodes
(3) allows LICM on invariant code that may-throw
    as long as the visible behavior is preserved

https://github.com/dart-lang/sdk/issues/35323
https://github.com/dart-lang/sdk/issues/34684

Change-Id: Icb4520a649da38eddc3d7c85af21427d3c64d22e
Reviewed-on: https://dart-review.googlesource.com/c/93822
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-28 19:29:06 +00:00
Ben Konyi ff6f61c872 [VM / Observatory ] Remove needless stacktrace print when adding to closed socket 
Change-Id: Idc31b45fd880ff0233c7cbeb31a22d43fbcea01e
Reviewed-on: https://dart-review.googlesource.com/c/94840
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-02-28 18:35:03 +00:00
Paul Berry a51c9f15cc Make optype compatible with previous versions of analyzer. 
Change-Id: Ifdf460a9a114fc10d6f1a4afc5d41c8894978840
Reviewed-on: https://dart-review.googlesource.com/c/94802
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-28 18:21:03 +00:00
Paul Berry a2eac98753 Merge HintCodeTest_Driver into HintCodeTest. 
This is necessary because the internal code base considers a test file
to fail if it doesn't run any tests.

Alternative fixes considered:

- Put a dummy test in hint_code_test.dart
- Rename hint_code_test.dart to a name that doesn't end in _test.dart

Change-Id: I64fa2be7c76b4d2a85ee9b46ba1a1c21ae2903ae
Reviewed-on: https://dart-review.googlesource.com/c/94800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-28 17:50:09 +00:00
Samir Jindel 9d609426b2 [vm] Update status file for standalone_2/ffi/function_stress_test 
Change-Id: I15eba297fb13a57ea4a9cd70364916ceba20ee3a
Reviewed-on: https://dart-review.googlesource.com/c/94755
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-28 17:42:53 +00:00
Alexander Markov bab9d2ad05 [vm] Remember GenericCovariantImpl in TypeParameter 
Previously, in order to get GenericCovariantImpl property of a type
parameter we had to (re-)read kernel.

This change is a preparation for decoupling flow graph building of
special functions from kernel reading.

Change-Id: I48b45d2cece683ac3a3bd0ed506ddfcc3c526826
Reviewed-on: https://dart-review.googlesource.com/c/94641
Commit-Queue: Régis Crelier <regis@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-02-28 17:38:19 +00:00
Samir Jindel 3dcc0c69a1 [vm] Fix windows build after "[vm/ffi] Stress tests for FFI functions." 
Change-Id: Iac44ba54452c8ae831202fa0c41b896b83a4a2fa
Reviewed-on: https://dart-review.googlesource.com/c/94754
Commit-Queue: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-02-28 17:34:47 +00:00
danrubel 1596f437bd debug dartfix test 
This test passes when run locally, but fails on the bots.
Time to gather more information.

Change-Id: Iccfbd52161b03f8119017612fc66f899cc9e5178
Reviewed-on: https://dart-review.googlesource.com/c/94801
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-28 17:18:49 +00:00
William Hesse fa8ba53b52 [infra] Add a script that appends fields with previous results to result data 
Change-Id: I19ea044308744c16caee47f4755a18fc19990c77
Reviewed-on: https://dart-review.googlesource.com/c/94544
Reviewed-by: Jonas Termansen <sortie@google.com>
 2019-02-28 16:59:11 +00:00
Samir Jindel b186a270e4 [vm/ffi] Stress tests for FFI functions. 
Change-Id: I75251b92688b70b4d14eda7b1fddef0fe94c60fe
Reviewed-on: https://dart-review.googlesource.com/c/94384
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2019-02-28 16:40:36 +00:00
Paul Berry 7dec865054 Add set literal support to the flutter outline computer 
Change-Id: I1d5f3dfdc4987bd7dc91dbd78ff5649667aa23b0
Reviewed-on: https://dart-review.googlesource.com/c/94760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-28 15:35:36 +00:00
Lasse R.H. Nielsen 7c70ab1817 Revert change that empirically doesn't improve code for dart2js stopwatch. 
Change-Id: Ib7a29c51c9d503c251fb28be4edc0becdc0a68c2
Reviewed-on: https://dart-review.googlesource.com/c/94745
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2019-02-28 14:12:26 +00:00
Sigurd Meldgaard 895bc90509 Sync pub client to newest version 
```
git log --oneline --no-decorate 980fc947db32bca6ae7d07fbb4ad0fcdba0050ec..3c060aae47985e9a248b850f1d0450304a5c97e3
3c060aae Usage: pub global activate <package> [version-constraint] (#2051)
93783b60 Improve the error when encountering a non-local package with a path dep
2b4056b0 Lint tweaks for Dart 2.2
135e10af Update last modified date directly in `touch` (#2014)
```

No relevant changes for the changelog

Bug: https://github.com/dart-lang/sdk/issues/36026
Change-Id: I2dcaad614f5fbd511712d4713c7b008d7ff710f1
Reviewed-on: https://dart-review.googlesource.com/c/94744
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2019-02-28 13:43:17 +00:00
Paul Berry 39f365f3b9 Sort declarations in parser.dart. 
Change-Id: I000193878307686d52e5b02cd3e6cdaafed68959
Reviewed-on: https://dart-review.googlesource.com/c/94681
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-28 12:48:56 +00:00
Paul Berry 8af83b19d6 Sort declarations in ast_builder.dart. 
No functional change.

Change-Id: If695a7437482aef1de7013aa404260f3602bdc93
Reviewed-on: https://dart-review.googlesource.com/c/94642
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-28 12:48:16 +00:00
Paul Berry 0adddfbeab Eliminate uses of old AST node types from analysis server 
Change-Id: Ifc97c6e08cb40cf98c519b442d10d921b2cccd05
Reviewed-on: https://dart-review.googlesource.com/c/94364
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-28 12:37:56 +00:00
Aske Simon Christensen 120328aff7 [fasta] Commandline option to enable asserts 
Since Fasta is only concerned with compile-time behavior, the option
only affects asserts in initializers in const constructors when
evaluated during constant evaluation.

Change-Id: I534cc7cc1f33f9b34d15550d38ea930ed7ac6709
Reviewed-on: https://dart-review.googlesource.com/c/94740
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Auto-Submit: Aske Simon Christensen <askesc@google.com>
 2019-02-28 12:11:16 +00:00
Aske Simon Christensen 82c5c5bbb2 [fasta] Only read compiler context at construction in kernel_target. 
Change-Id: I0f62f4e993353a336101fe0babb9d1dc58844020
Reviewed-on: https://dart-review.googlesource.com/c/94743
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-02-28 12:11:16 +00:00
Johnni Winther 9a4c49f301 Update field analysis tests to prepare for eager initializer improvements 
Change-Id: Ie9611ed269a42be4d7c406739cf935d569d8606a
Reviewed-on: https://dart-review.googlesource.com/c/94297
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-28 10:32:06 +00:00
Peter von der Ahé 75370569fc Fall back to DillLoader when computing types in SourceLoader 
Change-Id: I01242136e6598a55b24ca28cff2258529882064b
Reviewed-on: https://dart-review.googlesource.com/c/94502
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-02-28 10:12:46 +00:00
Peter von der Ahé 78ba3dab7a Rename ImplicitType to ImplcitFieldType 
Change-Id: I98cee54149fbe4c450919f72e7ab07e319b8fb34
Reviewed-on: https://dart-review.googlesource.com/c/94721
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-02-28 10:12:26 +00:00
Johnni Winther 1720704594 Recognize effectively constant static fields 
Change-Id: Ic8f7a014a6af2f9d8854e0731fe0d2df11b554da
Reviewed-on: https://dart-review.googlesource.com/c/94281
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-28 09:12:26 +00:00
Peter von der Ahé ba31e448ca Finish implementing IsIntersectionSubtypeOf 
Change-Id: I1b2958269545a5e562b664d51d945d328f46d0d5
Reviewed-on: https://dart-review.googlesource.com/c/94299
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-28 09:08:56 +00:00
Kevin Millikin 5f095b7039 [Fasta] Add support for spread in map literals 
Spreads are compiled as if they were spread elements in list or set
literals.  When one occurs in a map literal it is translated to a new
spread map entry.

Change-Id: Ic618b1e85e595b4c2cd65e184b9d2c49e9c34b79
Reviewed-on: https://dart-review.googlesource.com/c/94547
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-02-28 06:05:00 +00:00
Vijay Menon 3b8591d13e [ddc] Initial impl for invoking service extension 
Change-Id: Ibdd61eb390c2b62641318ca60fb76b43a4a3cb27
Reviewed-on: https://dart-review.googlesource.com/c/94660
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2019-02-28 00:53:42 +00:00