Commit Graph

25510 Commits

Author SHA1 Message Date
blois@google.com bcf24e3c00 Fixing polymer element registration when extending tag extensions
BUG=14127
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//33903003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29006 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 16:20:04 +00:00
sigmund@google.com 357af01f40 Fix prop_attr_reflection_test in drt/dartium (fixes issue 14295)
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//34213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29005 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 16:18:14 +00:00
fschneider@google.com 593abec44c Fix bug with load elimination in checked mode.
Definitions that are redefined through AssertAssignable must be
unwrapped to number loads/stores correctly for them.

Fix test expectations for tests that are passing now that the
corresponding co19 test was changed.

BUG=https://code.google.com/p/dart/issues/detail?id=13543
R=srdjan@google.com

Review URL: https://codereview.chromium.org//35093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29001 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 16:03:48 +00:00
jmesserly@google.com 077dd5c0b5 mark polymer csp tests as failing
BUG=

Review URL: https://codereview.chromium.org//34623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28988 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 07:56:39 +00:00
ajohnsen@google.com 7ed07c2bc8 Fix typo in http_body_test.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//34423003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28983 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 06:03:45 +00:00
ajohnsen@google.com 08239af74a Wait for server response in http_body_test before closing client and server.
BUG=https://code.google.com/p/dart/issues/detail?id=14275

Review URL: https://codereview.chromium.org//34383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28982 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 05:40:40 +00:00
justinfagnani@google.com 88f372316b Fix missing declaration for local variable in interop.js
BUG=
R=cbracken@google.com

Review URL: https://codereview.chromium.org//32843006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28979 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 02:41:10 +00:00
sigmund@google.com aabf7503ad Mark fail/timeout in dartium test while we investigate.
Review URL: https://codereview.chromium.org//28613005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28978 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 01:10:28 +00:00
sigmund@google.com 2ec8210e03 Mark polymer tests as failing in windows.
Review URL: https://codereview.chromium.org//34093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28973 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 00:21:00 +00:00
sigmund@google.com 4d357c5148 Improves how to initialize polymer apps and fixes polymer build and linter to
match Dartium semantics (Issue 14238). In particular:
  - only one script tag is allowed per document
  - initPolymer can be call from init.dart or the users main method, the build
    process knows how to call the user's main given the new Dartium semantics.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//27903006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28971 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 23:30:23 +00:00
jmesserly@google.com 0145636d89 fix analyzer issue in listorder_test
also fix polymer test/run.sh to test analyzer again

Review URL: https://codereview.chromium.org//32253003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28962 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 22:08:20 +00:00
jmesserly@google.com d19b192972 simple fix: loosen type annotations for ShadowRoot
R=sigmund@google.com

Review URL: https://codereview.chromium.org//32903004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28957 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 21:51:41 +00:00
jmesserly@google.com 821e6fec2a Several fixes here to fix bugs and get our tests into a reliable state:
* customElementsReady future. We don't fire Polymer.onReady until custom elements are ready too

* deploy without dart.js by default. This is the expected deployment mode for real apps. Also make sure we test this on DRT and compiler==js, so Pete can change Dartium without causing build breaks :)

* stop using "package:observe" test "performMicrotaskCheckpoint" hack in Polymer. This was too blunt; it affected timing of all async operations. Instead we only trigger Observable.dirtyCheck. It's using the latest Zone API as well.

* mixin ChangeNotifier explicitly. This is mainly to fix a quirk of our test environment (test server loads "packages/polymer" in untransformed mode, causing it to pick up Observable instead of ChangeNotifier).

* fix change watchers to blacklist "attributeChanged" :)

* fix serializeValue to only use the runtime value

* fix deserializeValue to get the right Type for dart:core types

* cleanup prop_attr_reflection_test to use mutation observer

R=blois@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//29823005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28956 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 21:49:51 +00:00
sigmund@google.com 580d807b66 Transformer plugin for polymer. This will make it possible (one day) to use
polymer transformers in pub-build and pub-serve by writing:

transformers:
  - polymer:
      entry_points: web/index.html

I say one day because there are still a few pending bugs on the vm and the pub
side of things that need to be resolved before this works.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//28053008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28942 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 19:21:52 +00:00
ajohnsen@google.com 31bfc41409 Make setDirectoryHandler and setErrorPageHandler setters, and add a jailRoot property.
While being on by default, disabling jailRoot allows following links to
outside the root directory.

BUG=https://code.google.com/p/dart/issues/detail?id=14196,https://code.google.com/p/dart/issues/detail?id=14193
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//31633003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28926 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 12:21:04 +00:00
ajohnsen@google.com 64bc9874f9 Add README file for http_server package.
BUG=https://code.google.com/p/dart/issues/detail?id=14192
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//32003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28923 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 09:21:37 +00:00
ajohnsen@google.com e598c1c6e2 Fix comment.
BUG=

Review URL: https://codereview.chromium.org//31633005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28922 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 08:53:03 +00:00
ajohnsen@google.com 2c02feaa38 Expose the HttpRequest object in HttpRequestBody, making all request properties available.
BUG=https://code.google.com/p/dart/issues/detail?id=14259
R=sethladd@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//31813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28919 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 08:07:11 +00:00
jmesserly@google.com b85a54ec6d fix Polymer to work with latest JS interop
both places we used dart:js were broken for different reasons :). On the bright side, a huge hacky workaround is gone!

R=jacobr@google.com

Review URL: https://codereview.chromium.org//31423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28915 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 01:38:52 +00:00
jacobr@google.com 8ada3f245e TBR: fix failing polymer test
Marked todomvc as failing. TBR

BUG=

Review URL: https://codereview.chromium.org//30423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28906 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-19 05:30:12 +00:00
nweiz@google.com 2f53ba7b48 Make barback propagate logs synchronously.
R=alanknight@google.com

Review URL: https://codereview.chromium.org//29763003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28893 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 22:58:08 +00:00
nweiz@google.com 3c132b1e28 Properly parse friendly stack traces without columns.
Review URL: https://codereview.chromium.org//28783006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28892 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 22:57:06 +00:00
nweiz@google.com 54d951a769 Make stack frames without columns print correctly.
This works around issue 14233.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//29323004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28884 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 21:55:41 +00:00
scheglov@google.com 9a411f83f0 Don't evaluate << because of possible overflow.
Applied same change to Dart version to fix crash.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//29313003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28873 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 19:37:56 +00:00
scheglov@google.com 715f296ee0 Restore CompilationUnit.lineInfo in Java and Dart.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//29083004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28869 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 18:27:54 +00:00
kevmoo@j832.com 7802e835ae fix for Set.add tweak in r28863
R=blois@google.com

Review URL: https://codereview.chromium.org//29463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28866 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 17:54:21 +00:00
kevmoo@j832.com cf134382a1 Set.add returns true if item has been added, otherwise false
BUG= https://code.google.com/p/dart/issues/detail?id=3546
R=floitsch@google.com

Review URL: https://codereview.chromium.org//26280002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28863 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 17:24:24 +00:00
lry@google.com 256993d635 mark barback test "too_many_open_files_test" as flaky
minor cleanups on previous patch

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//28823004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28853 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 11:41:04 +00:00
kustermann@google.com f35b9c485f Mark pkg/polymer/test/attr_mustache_test as flaky on dart2js-ff
R=ricow@google.com

Review URL: https://codereview.chromium.org//28593004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28849 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 09:24:04 +00:00
lry@google.com 948743a78c Scanner for UTF-8 byte arrays
Introduces a SourceFile based on UTF-8 byte arrays and a scanner for
such source files.

Substrings are computed lazily. This should save some memory because
substring tokens in classes that are not used by some program are

R=kasperl@google.com

Review URL: https://codereview.chromium.org//27510003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28843 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 06:40:07 +00:00
scheglov@google.com f50bafb140 Attempt to fix build.
I have to restore CompilationUnit.lineInfo, because it is used by clients.
Also added tweak to avoid using internal NodeList.elements, which was changed.

TBR

R=brianwilkerson@google.com,alanknight@google.com,iposva@google.com
BUG=

Review URL: https://codereview.chromium.org//28193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28842 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 06:07:21 +00:00
scheglov@google.com ba323713a2 Remove unused assignment. Fixes pub tests.
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//27752004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28839 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 23:55:42 +00:00
scheglov@google.com 581b368515 New analyzer_experimental snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//27278004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28831 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 22:14:19 +00:00
blois@google.com ee30fc06fb Converting Polymer and TemplateElement to use deprecated Node.document
Because Polymer dart2js tests actually execute dart, the bots are red because the corresponding changes haven't made it into Dartium.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//27773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28830 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 22:04:11 +00:00
justinfagnani@google.com e32d5c24c3 Cleanup JS() expressions.
New Constructor for JsObject that preserves the correct prototype.
Type check user-supplied values that pass through to JS().
Don't call _convertToJs(this)

Based on: https://chromiumcodereview.appspot.com/26092003/

R=ahe@google.com, alexandre.ardhuin@gmail.com

Review URL: https://codereview.chromium.org//26270003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28813 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 18:13:40 +00:00
nweiz@google.com 66e568e6ce Work around issue 14125 in stack_trace by adding a dummy setter.
R=rnystrom@google.com
BUG=13945

Review URL: https://codereview.chromium.org//27416002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28811 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 18:09:58 +00:00
blois@google.com e3b35dabb6 Renaming Node.document back to Node.ownerDocument
With custom elements, the document instance variable creates an odd conflict with the document global.

BUG=14099
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//27602002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28810 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:55:38 +00:00
sigmund@google.com 829a775cdc Log exceptions caught in polymer expressions
BUG=https://code.google.com/p/dart/issues/detail?id=12130
R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//26619002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28805 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:17:54 +00:00
kustermann@google.com fc8082b75e Mark more polymer tests + todomvc (which usees polymer) as flaky
Review URL: https://codereview.chromium.org//27699002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28798 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 12:37:31 +00:00
floitsch@google.com 5d40cc5729 Mark instance_attrs_test as flaky.
Review URL: https://codereview.chromium.org//27688002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28796 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 10:44:20 +00:00
sigmund@google.com 728114e4c6 Update status on browser-only tests.
Review URL: https://codereview.chromium.org//26967009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28779 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 04:27:45 +00:00
jmesserly@google.com 38c4cd1f6b package:observe fix various api issues
in particular:
provide oldValue/newValue/target in PropertyChangeRecord -- https://code.google.com/p/dart/issues/detail?id=12075
use == in notifyPropertyChange -- https://code.google.com/p/dart/issues/detail?id=12463
remove Mixin/Base suffix -- https://code.google.com/p/dart/issues/detail?id=13353
remove ChangeRecord.changes -- https://code.google.com/p/dart/issues/detail?id=14128

other changes:
rename PropertyChangeRecord.field to .name (it's not just fields)
PathObserver rethrows errors from inside the getter/setter to help debug those
PathObserver now looks up Map keys using Strings instead of Symbols.
generic type on PropertyChangeRecord, MapChangeRecord

I stopped short of adding "target" to List/Map change record but am interested in a follow up to address that: https://code.google.com/p/dart/issues/detail?id=14157

R=sigmund@google.com

Review URL: https://codereview.chromium.org//27618002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28774 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 03:32:40 +00:00
sigmund@google.com 6c4e38b81e Practically remove boot.js, adds the initialization from the Dart side of
things, and fixes examples to work this way.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//27518006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28773 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 02:43:50 +00:00
zra@google.com 3f5cacdc87 Updates status file for slow test on simarm, simmips
Review URL: https://codereview.chromium.org//26174004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28727 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 15:20:21 +00:00
kustermann@google.com a43e7cf2c8 Mark pkg/barback/test/too_many_open_files_test as slow
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//26906009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28724 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 13:41:34 +00:00
lrn@google.com 8b1d5720f7 Change "typedef" to "class" in core library and related tests.
R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//27300003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28712 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 09:02:46 +00:00
jmesserly@google.com 6d5f00c4ab rebuild shadow_dom at 12db94a66c79aa203d2dd59d239c60a3b3d44ed0
R=dgrove@google.com

Review URL: https://codereview.chromium.org//26662009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28705 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 02:49:57 +00:00
rnystrom@google.com bd4f848856 Use file pool to handle running out of file descriptors.
BUG=https://code.google.com/p/dart/issues/detail?id=13752

Review URL: https://codereview.chromium.org//27242002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28702 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:59:47 +00:00
jmesserly@google.com d583f16e4f add @MirrorsUsed to observe/polymer/polymer_exprs pkgs
Fairly straightforward. @observable and @CustomTag are metaTargets, so no changes needed for types that use those. The only other changes are for data binding to objects with built in change notification. In that case, we add package:observe's @reflectable annotation. Other than that, just a few other things in mirrors that are now locked down appropriately to only reflect on the things they need.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//26967004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28689 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 22:55:47 +00:00
jmesserly@google.com ceb15d891c fix PolymerElement.bind to call reflectPropertyToAttribute w/ prop name
This is the fix for issue 14060
Polymer.js fix is at: https://github.com/Polymer/polymer/pull/319

R=sigmund@google.com

Review URL: https://codereview.chromium.org//27417002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28688 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 22:41:19 +00:00