Commit Graph

25510 Commits

Author SHA1 Message Date
justinfagnani@google.com 03eb80a189 Maintain referential integrity of proxy instances in dart:js
Rename DartProxy to DartObject in JavaScript to be symmetrical with JsObject

R=ahe@google.com, alexandre.ardhuin@gmail.com

Review URL: https://codereview.chromium.org//26092003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28686 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 21:43:16 +00:00
nweiz@google.com 999840c105 Track the original assets more efficiently in Phase.
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//26598002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28685 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 21:40:59 +00:00
sigmund@google.com 24eb8baa5a Small fix to boot.js so it can work with CSP if an existing html-import tag is
present.

Note: this will be deleted soon when we deprecate boot.js (a week or so).

R=jmesserly@google.com, sergeygs@chromium.org

Review URL: https://codereview.chromium.org//27246006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28675 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 19:10:53 +00:00
blois@google.com f2573b0a0a Converting Polymer's WebComponentsLoaded to an onReady future
This avoids double-firing of the event when the CustomElements polyfill is present and allows tests to wait for the future without worrying about missing the event.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//27307004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28665 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 17:37:24 +00:00
jmesserly@google.com 958feffd78 fix dart2js warnings in polymer_expressions pkg
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//26318004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28627 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 02:54:24 +00:00
blois@google.com 43d834bae9 Updating todomvc for some polymer changes
Should have caught some earlier, but I just added the base class validation.

TBR
BUG=

Review URL: https://codereview.chromium.org//26660004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28624 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 00:52:15 +00:00
blois@google.com 74bf998319 Fixing polymer example code for Polymer element change
TBR
BUG=

Review URL: https://codereview.chromium.org//26196005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28623 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 00:42:10 +00:00
blois@google.com 89978b4e03 Fixing Polymer linter warnings error on transform changes
TBR
BUG=

Review URL: https://codereview.chromium.org//26564010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28622 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 00:20:57 +00:00
blois@google.com 1cb69bc901 Fixing bots after Polymer element integration
TBR
BUG=

Review URL: https://codereview.chromium.org//27274002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28621 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 23:46:17 +00:00
blois@google.com 4d0d82a043 Updating Polymer to derive from custom elements.
BUG=
R=jmesserly@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//26051002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28617 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 22:46:54 +00:00
pquitslund@google.com e9e3dd9606 Formatter library entry-point for the masses (w/ gypi update).
(Note the manual change in resource_sources.gypi.  I verified that this works locally.)

R=jmesserly@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//27247002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28613 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 21:46:06 +00:00
pquitslund@google.com f3ea6bd578 Another SVN mv and stab at build greeness [TBR].
Review URL: https://codereview.chromium.org//26262005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28601 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 18:52:19 +00:00
pquitslund@google.com 5df969e78f Revert of move in quest for greenness [TBR].
Review URL: https://codereview.chromium.org//27233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28600 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 18:44:10 +00:00
pquitslund@google.com 9bea8ece04 Proper formatter library for popular consumption.
R=brianwilkerson@google.com, keertip@google.com

Review URL: https://codereview.chromium.org//27224002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28596 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 18:36:35 +00:00
lrn@google.com 8922b1065c Add EfficientLength marker interface to some iterabels.
Use that in List.from and other methods to be more efficient when possible.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//26681002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28575 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 10:40:00 +00:00
floitsch@google.com 43bbab4e09 Mark error_test as timeout.
Review URL: https://codereview.chromium.org//27103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28570 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 16:49:40 +00:00
floitsch@google.com 0f7a0bd7b1 Rename runAsync to scheduleMicrotask.
R=lrn@google.com

Review URL: https://codereview.chromium.org//26151002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28569 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 15:52:17 +00:00
floitsch@google.com fcf5c20aeb Mark prop_attr_reflection_test as failing.
Review URL: https://codereview.chromium.org//27090003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28566 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 13:53:20 +00:00
floitsch@google.com dc9c5f42ed Redo StreamTransformers so they work with Stack traces.
Since this involved a breaking change I cleaned up more of the
StreamTransformer API.

This CL also deprecates the getAttachedStackTrace method.

R=ajohnsen@google.com, lrn@google.com, nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//25354003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28562 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 12:34:34 +00:00
blois@google.com 1f788e54c9 Marking Polymer's prop_attr_reflection_test as fail
Change in symbol name is causing test to fail, opened bug.

TBR
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//27054007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28560 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 00:22:34 +00:00
justinfagnani@google.com cee2b116ce Revert "Maintain referential integrity of proxy instances in dart:js"
This reverts commit bf87105c535cd2f6fa28904547b4e9f2804bc301.

BUG=

Review URL: https://codereview.chromium.org//26742008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28557 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 21:28:15 +00:00
terry@google.com 8992076c3c - Added @mixin and @include support for top-level and declarations.
- Added parameter support for mixins.
- Support var definition with multiple parameters as an @include parameter.
- Support @extend and @extend with nested selectors.
- Removed hoisting var and cycle checks - can only reference known vars.
- Added bunch of tests.

BUG=

Review URL: https://codereview.chromium.org//23819036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28555 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 21:03:04 +00:00
justinfagnani@google.com b2316c569a Maintain referential integrity of proxy instances in dart:js
Rename DartProxy to DartObject in JavaScript to be symmetrical with JsObject

R=ahe@google.com, alexandre.ardhuin@gmail.com

Review URL: https://codereview.chromium.org//26092003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28547 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 20:24:18 +00:00
alanknight@google.com 8cb396fafb Mark the intl file-reading tests slow on debug mips
R=zra@google.com

Review URL: https://codereview.chromium.org//26491005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28529 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 17:10:20 +00:00
rnystrom@google.com 2c095c78d9 Make pub build use barback.
BUG=https://code.google.com/p/dart/issues/detail?id=13880
R=alanknight@google.com

Review URL: https://codereview.chromium.org//26933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28524 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 16:17:06 +00:00
ajohnsen@google.com 86e664e645 Preserve '\' in filenames for uploads, as Windows/IE contains them.
BUG=http://code.google.com/p/dart/issues/detail?id=13928
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//26973004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28515 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 12:36:14 +00:00
floitsch@google.com 4be547c705 Adapt streams for additional stackTrace argument.
R=lrn@google.com

Review URL: https://codereview.chromium.org//25094002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28511 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 12:02:20 +00:00
floitsch@google.com 956243966a Add second argument to Future error handlers.
R=lrn@google.com, nweiz@google.com

Review URL: https://codereview.chromium.org//25027004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28510 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 11:42:39 +00:00
lrn@google.com a144c11369 Make JSON encoder take extra function argument to use instead of toJson calls.
Defaults to callin toJson() on unconvertible objects.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//25548010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28507 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 11:34:50 +00:00
kustermann@google.com b24a73c137 Remove unittest-based wrapping from our testing scripts
The unittest-based wrapping of tests is completely broken and will be removed
with this CL. ('none-drt' is the last configuration where we currently still do
unittest-based wrapping.)

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//26162007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28501 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 09:01:17 +00:00
lrn@google.com 04c230b114 Add Set.lookup method to get the instance in the set.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//26832002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28499 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 07:16:20 +00:00
rnystrom@google.com 88e476d0d9 Fix observe package to work with new barback logger.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//26863008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28492 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 00:21:40 +00:00
rnystrom@google.com 8abeb673a2 Improve barback/pub logging.
Barback now lets you provide a logger, and pub gives it one that
pipes through pub's logging infrastructure. I'll need this to
get pub build using barback and easily testable with well-defined
console output.

BUG=https://code.google.com/p/dart/issues/detail?id=13880
R=alanknight@google.com

Review URL: https://codereview.chromium.org//26572010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28486 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 23:16:59 +00:00
jmesserly@google.com b16ddf6c12 use symbol literals instead of const ctor
R=rnystrom@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//26734004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28485 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 22:55:17 +00:00
sigmund@google.com 5df1c0d7f9 Fix bug in polymer expressions where input-value bindings are incorrectly
updated twice, losing the cursor position.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//26649002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28480 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 21:29:07 +00:00
sethladd@google.com 0ee64024d9 clarify docs for onmutation
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//26882005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28473 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 19:51:25 +00:00
zra@google.com a644c01748 Updates status file for flaky test on simmips.
Review URL: https://codereview.chromium.org//26855003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28456 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 15:04:31 +00:00
ajohnsen@google.com 326f48d476 Expand usage of defaultEncoding in HttpBody in the http_server package.
This fixes a few cases where other default encodings was used. Given
that we operate with the concept of a default encoding, to use that
encoding makes more sense.

BUG=https://code.google.com/p/dart/issues/detail?id=13928
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//26685004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28453 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 14:08:55 +00:00
blois@google.com 1426a55a47 Adding platform patches to allow custom elements polyfill to work with Shadow DOM.
The specific issue was that elements existing in the page before the tag was registered was causing issues. This is encountered with the <polymer-element> tag.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//26558008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28434 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 00:30:08 +00:00
pquitslund@google.com 3c769a4598 Formatter method cascade indents.
In keeping with the current style guide suggestion:

"DO use four spaces for method cascades."

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//26164007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28427 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 22:34:48 +00:00
scheglov@google.com afb3cc7f01 Issue 13918. final fields induce setters that are illegal to call
https://code.google.com/p/dart/issues/detail?id=13918

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//26746002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28415 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 20:30:42 +00:00
sigmund@google.com e99e22f299 Show error message if dart.js is also together with boot.js on the page.
Address: http://code.google.com/p/dart/issues/detail?id=12423

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//26636002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28409 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 17:43:33 +00:00
vsm@google.com 334fd6bf07 Mark spawnFunction tests as Fail on Dartium
See corresponding Dartium CL:
https://chromiumcodereview.appspot.com/26397003/

This disables spawnFunction on DOM enabled isolate (i.e., where
dart:html is available).  spawnFunction should continue to work on
non-DOM enabled isolated.  spawnUri should be unaffected.

R=asiva@google.com

Review URL: https://codereview.chromium.org//26616002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28406 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 16:25:28 +00:00
pquitslund@google.com 6e94dd119f Update formatter main to use prefered Utf8Decoder.
R=devoncarew@google.com

Review URL: https://codereview.chromium.org//26502003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28392 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 23:30:30 +00:00
nweiz@google.com 96e9dce1d4 Make PhaseOutput emit a new AssetNode whenever it changes outputs.
Previously, PhaseOutput produced a single AssetNode whose value it
would update whenever the forwarded output changed. This worked well
for a while, but once Phase started caring about the AssetNode's
origin, it became problematic. PhaseOutput would change the origin,
but Phase would have no way of knowing this, and the AssetNode would
end up sorted into the wrong place (treated as a forwarded node when
it shouldn't be, or vice versa).

This CL fixes that issue by removing the possibility of modifying an
AssetNode's origin. PhaseOutput now just creates a new AssetNode
instead. This has the additional benefit of cleaning up some
duplicated code in Phase.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//26413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28386 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 22:20:28 +00:00
devoncarew@google.com 71689ab3a5 Fix an issue where test timeouts would cause no more tests to execute.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//26359002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28383 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 21:56:57 +00:00
pquitslund@google.com d35f745cac Code formatter transform for empty constructor bodys (a la Style guide).
From the guide: "DO terminate empty constructors with a ‘;’ and not ‘{}’."

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//26229004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28380 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 21:38:56 +00:00
vsm@google.com 5fbbb5c53b Revert "Fix status files"
This tests all pull in dart:io but do not use them.

This CL temporarily made them work:
- https://chromiumcodereview.appspot.com/26490003/

This CL restores the previous (and I think correct) behavior:
- https://chromiumcodereview.appspot.com/26540002/

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//26541002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28374 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 19:25:31 +00:00
vsm@google.com 879d006d47 Fix status files
Note: about 25 tests started passing on Dartium with:
https://chromiumcodereview.appspot.com/26490003/

Need to understand why & if this is legit.

TBR=jacobr@google.com

Review URL: https://codereview.chromium.org//26533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28368 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 17:33:58 +00:00
jmesserly@google.com 64b7cb0756 mark test failing for issue 13890
Review URL: https://codereview.chromium.org//26453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28359 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 07:21:45 +00:00