084dc19054
fix PathObserver to avoid try+catch
...
also fixes staticwarnings
R=sigmund@google.com
Review URL: https://codereview.chromium.org//51483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29498 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 22:18:37 +00:00
e65fe5e0be
Use Platform rather than dart:platform in scheduled_test.
...
R=rnystrom@google.com
TBR
Review URL: https://codereview.chromium.org//50303006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29497 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 22:08:49 +00:00
ee811fe9e8
pkg/unittest: tiny cleanup
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//51233005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29496 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 22:01:37 +00:00
a89afc71ba
Revert "Fixed expect, protect methods to allow any set of arguments"
...
Commit https://code.google.com/p/dart/source/detail?r=29487
Issues with Function, checked mode, and closures
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//49793005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29495 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 21:19:33 +00:00
742f0ae726
Clean up some pub and scheduled_test integration with the new isolate API.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//50303005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29493 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 21:18:03 +00:00
2c6e98e6f9
Remove StaticWarning designation now that test is updated
...
TBR=blois@google.com
Review URL: https://codereview.chromium.org//51303003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29491 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 21:03:08 +00:00
a04c9c1359
Add test for @published with noscript
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//47603017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29489 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 20:56:38 +00:00
65fbaac86b
Remove obsolete test
...
TBR=blois@google.com
Review URL: https://codereview.chromium.org//51403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29488 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 20:47:12 +00:00
562237a67e
Fixed expect, protect methods to allow any set of arguments
...
removed dependency on meta, fixed dart2js warning about double type check
R=sigmund@google.com
Review URL: https://codereview.chromium.org//46883011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29487 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 20:43:18 +00:00
c638273b84
Revise barback logging patch.
...
R=nweiz@google.com
Review URL: https://codereview.chromium.org//48993007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29483 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 20:01:12 +00:00
60b57c3a38
Update headings to use sentence case.
...
R=kathyw@google.com
Review URL: https://codereview.chromium.org//51003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29462 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 17:23:32 +00:00
57efa5da8c
Revert "Remove @deprecated features."
...
There were more uses of the deprecated features.
Review URL: https://codereview.chromium.org//50313004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29443 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 12:54:37 +00:00
72e1d263dc
Remove @deprecated features.
...
R=alanknight@google.com , rnystrom@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//48293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29438 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 12:00:44 +00:00
e2434065ce
Expose 'serveFile' on VirtualDirectory.
...
This makes it possible to easy forward directory requets to e.g.
'index.html'.
BUG=http://code.google.com/p/dart/issues/detail?id=14333
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//47513008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29430 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 10:17:30 +00:00
9c3dd5d2fd
fix event logging
...
R=sethladd@google.com
Review URL: https://codereview.chromium.org//50323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29414 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 06:07:32 +00:00
3336d7d194
Inherit @published from base class (fix issue 13937)
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//49793004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29412 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 03:40:47 +00:00
2a8f2fd63f
Return zone from initPolymer
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//48763008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29410 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 02:54:48 +00:00
c70f1f7cf5
Build fixes: adds arguments to the pub-build plugin to configure whether 'js'
...
and 'csp' options. Ensure we can call main in the generated code (no need to
export init.dart anymore).
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//47933006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29409 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 02:50:58 +00:00
c2790caa6a
Avoid sending needless data between isolates in "pub serve" and "pub build"
...
Previously when passing barback assets between isolates, pub would eagerly send
the entire contents of the asset. Now it waits to do so until some code actually
subscribes to the asset's data stream.
BUG=14430
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//43143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29408 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 00:18:19 +00:00
9cb7129067
Support Safari 6.1's new stack trace format in pkg/stack_trace.
...
R=rnystrom@google.com
BUG=14534
Review URL: https://codereview.chromium.org//48273005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29399 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 21:50:23 +00:00
0f20feb9ca
Make docgen able to generate pkg docs and save the package names
...
R=terry@google.com
Review URL: https://codereview.chromium.org//35743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29387 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 20:10:57 +00:00
9039835b60
New analyzer snapshot.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//49383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29384 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 19:46:48 +00:00
bc7c3b0301
The request may be canceled by http_body, thus allow that when testing.
...
BUG=https://code.google.com/p/dart/issues/detail?id=14381
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//46043003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29358 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 13:20:24 +00:00
4520b66da6
Mark pkg/unittest/test/missing_tick_test as timeout
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//48533003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29351 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 11:19:37 +00:00
94ebff2225
Bugfix in test.dart, adding of specialized test outcomes for analyzer
...
This CL will:
- fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases
we did not report that the analyzer was missing a warning).
- make the outcome of running the analyzer on a test be one of:
* CompileTimeError
* MissingCompileTimeError
* StaticWarning
* MissingStaticWarning
- Make status file updates using the new Expectation markers
- Remove support for '@static-clean':
Previously running the analyer on a test could either result in
'Pass' or in 'Fail'. The '@static-clean' annotation has been used
as a (poor) mechanism to distinguish between errors and warnings.
Having the 4 markers mentioned above means we can remove '@static-clean'
- Remove 100 lines of rotted legacy code in our testing scripts.
- Make a status file entry for every test that has analyzer errors or warnings
R=ricow@google.com
Review URL: https://codereview.chromium.org//46163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29350 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 10:39:38 +00:00
02322a7d2d
Increase the 20 second timeout value of the unittest framework higher
...
Tests going over the 20 seconds is causing us random failures on the buildbots.
Until we have a custom unittest configuration for our testing scripts, we'll
increase the default timeout to 2 minutes.
R=ricow@google.com
Review URL: https://codereview.chromium.org//48493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29349 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 10:36:47 +00:00
bc55def467
Better triaging for this failure: usage of Type.toString makes the test fail in minified mode.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//48183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29344 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 08:17:06 +00:00
ba1b2e34d6
Fix suggestions about using init.dart
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//46563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29336 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-27 23:50:56 +00:00
b14b77dfb9
Test does not pass in minified mode.
...
Review URL: https://codereview.chromium.org//47763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29334 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-27 20:57:43 +00:00
5e06168ea7
Fix issue 12336: there was a bug when updating phis at exit of a block with a HTypeKnown instruction.
...
By making the update an assignment, we were generating the wrong order of copies. Since the checked input of HTypeKnown may have a name, we need to make it a copy.
Review URL: https://codereview.chromium.org//44143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29331 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-27 19:29:12 +00:00
d0f5d11552
http_server depends on path
...
BUG=
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//47313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29330 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-27 19:19:39 +00:00
92e3661fa0
pkg/logging: added stackTrace support
...
Plus:
* don't expose mutable children collection from Logger
* remove superfluous field
* other tweaks
BUG=https://code.google.com/p/dart/issues/detail?id=14416
R=sethladd@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//46233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29324 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-27 17:38:45 +00:00
36258e823c
Fixing merge issue of removal of polymer/platform.dart
...
Some additional references came in from Siggi's change that I missed on the merge.
TBR
BUG=
Review URL: https://codereview.chromium.org//46863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29312 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-26 17:08:21 +00:00
18ea023a9d
Fixes from polymer.dart API review
...
Primary breaking changes are:
- polymer/platform.dart is removed
- Rather than platform.flush, use scheduleMicrotask(Observable.dirtyCheck)
- Rather than endOfMicrotask, use either scheduleMicrotask or Future.value
- Polymer.job removed, use Timer instead (and upvote bug 14414 for timer.restart if you really want the job semantics)
This change is bringing up some really weird timing issues in the tests- I don't think any are inherent to the change itself but is more indicative of larger issues.
BUG=13666
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//41293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29311 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-26 16:33:25 +00:00
509d0afd74
Remove all_test from analyzer package.
...
We use it only locally.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//46633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29308 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-26 02:00:12 +00:00
c42ec6584d
pkg/unittest: remove testState
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//26443003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29307 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-26 01:33:23 +00:00
4e67584f5a
Update samples with latest polymer and Dartium changes
...
R=blois@google.com
Review URL: https://codereview.chromium.org//45753003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29305 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-26 01:15:49 +00:00
00d017bc9e
Comment out resolver tests.
...
They always should be commented, because we cannot get SDK path on bot.
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//46513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29304 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-26 01:00:03 +00:00
68386823d1
Update polymer to commit b7200854b2441a22ce89f6563963f36c50f5150d
...
This brings over the changes to event dispatching.
R=blois@google.com
Review URL: https://codereview.chromium.org//44573005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29303 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-26 00:42:21 +00:00
7ac0b7d0bd
Rename analyzer_experimental to analyzer.
...
R=jmesserly@google.com , pquitslund@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//45573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29302 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 23:59:38 +00:00
34085ccdb5
port Node.bind to bd0a0591920da9091b326627a46a104a92c7efe7
...
the first step to fix https://code.google.com/p/dart/issues/detail?id=13950
R=sigmund@google.com
Review URL: https://codereview.chromium.org//42433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29294 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 21:39:06 +00:00
8fe853e4ad
(this is intended to be submitted together with a dartium change.)
...
Now that Dartium requires a single script tag, it no longer tags inline script
tags with their line number, so we don't need the mapping logic in polymer
anymore.
R=jmesserly@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//41983004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29291 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 21:27:26 +00:00
6a72655d1b
Very simple version of Isolates.
...
R=ajohnsen@google.com , iposva@google.com , kasperl@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//27215002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:23:00 +00:00
e85ecab139
Fix build after analyzer_experimental API change.
...
TBR
R=jmesserly@google.com
BUG=
Review URL: https://codereview.chromium.org//44943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29265 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 17:58:41 +00:00
ab4a7a15d1
New analyzer_experimental snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//42863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29260 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 16:55:54 +00:00
746d924e59
co19-roll to r641
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//44263003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29255 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 15:07:10 +00:00
c0a460e2cb
Mark pkg/polymer_expressions/test/bindings_tes as flaky
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//44383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29253 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 14:07:28 +00:00
3a01260611
Remove dart:json
...
BUG= http://dartbug.com/12843
R=floitsch@google.com , fschneider@google.com
Review URL: https://codereview.chromium.org//40323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29240 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 10:30:34 +00:00
3253eb3b84
Update status files to account for 14400 being fixed.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//40443004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29215 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 21:51:53 +00:00
d93cbb1e41
fix binding to $ from polymer templates
...
https://code.google.com/p/dart/issues/detail?id=14172
there were two issues:
* "$" needs to be reflectable
* the Map needs to be observable so templates can detect when keys get added (happens after template instantiation)
R=sigmund@google.com
Review URL: https://codereview.chromium.org//41383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29208 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 21:12:29 +00:00
jmesserly@google.com