dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

3345 Commits

Author SHA1 Message Date
Peter von der Ahé b195d435f3 Remove FieldBuilder.hasTypeInferredFromInitializer 
Change-Id: I912dd23c6b61a4cefb5cf1aee6860a8813c1c758
Reviewed-on: https://dart-review.googlesource.com/c/86427
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-20 18:06:34 +00:00
Peter von der Ahé e45e334548 Rename strong mode to legacy mode in package:kernel 
Change-Id: Ia4a8a9cac7817a8db5771ec82541b556c705f7c8
Reviewed-on: https://dart-review.googlesource.com/c/86353
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-20 18:06:34 +00:00
Daniel Hillerström cc5c78cfd2 Clean up of static semantics check for redirecting factories. 
This CL removes the redundant/specialised implementation of
`isSubtypeOf` whose sole purpose was to enable prettier error messages
as printing of function types weren't particularly pretty. With
@askesc's work on prettier error printing (and being post the Dart 2.1
release) there is no longer a need to have special logic for
redirecting factories.

Change-Id: If9b20f0b304b970da42a495b0ed3e82494d82ed0
Reviewed-on: https://dart-review.googlesource.com/c/82067
Commit-Queue: Daniel Hillerström <hillerstrom@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-12-20 07:23:45 +00:00
Dan Rubel 958cad66c6 Refactor parser insertParens callsites 
... not to rely on token stream modification during recovery.

Also, rename
* parseRequiredArguments --> ensureArguments
* parseParenthesizedCondition --> ensureParenthesizedCondition

Change-Id: I72181609e6275b5b738a234ded713608861e4691
Reviewed-on: https://dart-review.googlesource.com/c/87626
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-20 01:28:18 +00:00
Peter von der Ahé de65d6892a Remove legacyMode from type inference 
Change-Id: I78a13470e5707c9d26fe1796ad24ba507d93a9e8
Reviewed-on: https://dart-review.googlesource.com/c/86358
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-19 17:21:51 +00:00
Peter von der Ahé cbe30dc0d5 Remove Target.disableTypeInference 
Change-Id: I440b07258a79796092e14abf816f257d9af40427
Reviewed-on: https://dart-review.googlesource.com/c/86357
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-19 17:21:51 +00:00
Peter von der Ahé bf5ae2215b Store token in ImplicitType 
Change-Id: I35c9a5b79b41a8c9df1afee6195b2c3ebdc22838
Reviewed-on: https://dart-review.googlesource.com/c/86356
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-19 17:21:51 +00:00
Peter von der Ahé 141fd9e426 Disable type inference: override checks 
Change-Id: I5dd3500ffe70815a9b693653666dafa152a62e33
Reviewed-on: https://dart-review.googlesource.com/c/86349
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-19 17:21:51 +00:00
Aske Simon Christensen 0df70ab15b Special type for signalling missing type arguments on literals 
This eliminates most fields on ListLiteralJudgment, SetLiteralJudgment
and MapLiteralJudgment. Only the inferred type remains.

Change-Id: Ie79d2ec1c4f426a55397611f976e2a0746b4dcb1
Reviewed-on: https://dart-review.googlesource.com/c/86766
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-12-19 16:13:34 +00:00
Aske Simon Christensen 1ce14103e8 Remove MapEntryJudgement 
Change-Id: I9d80a91c5b15987f81f95936e8b4768385e4ffab
Reviewed-on: https://dart-review.googlesource.com/c/86764
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-12-19 16:13:34 +00:00
danrubel c0b5a28417 Refactor Parser.checkFormals 
... so that it does not rely on modification of the token stream for recovery

Change-Id: Iabd6c50efdd803e4ac3e2decaa5fb2af5e3fbb18
Reviewed-on: https://dart-review.googlesource.com/c/87625
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-19 02:09:41 +00:00
danrubel c52ff42c55 Add TokenStreamGhostWriter for parser lookahead 
This adds a new TokenStreamRewriter which does not modify the
existing token stream but instead sequences tokens such that the
new tokens lead into the existing token stream.
This is useful when using the parseExpression method
to lookahead and find the next token after the expression.

Change-Id: Id51e015f4381af65220530d07042e306b939baa3
Reviewed-on: https://dart-review.googlesource.com/c/87622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-18 22:01:48 +00:00
danrubel 4163478f9b Update AstBuilder to build AST with nullable types 
... as part of adding NNBD as outlined in
https://github.com/dart-lang/language/issues/110

This CL updates the parser to recognize two specialized comments at the
beginning of a library of the form '//@NNBD' and '//@NNBD*' for use
by the analyzer to aid developers when converting their libraries
to be non-nullable by default.

In addition, the AstBuilder now populates the generated analyzer AST
with nullable type information.

Change-Id: I80d221dd138973aa32f05bde631245d9ac6ee10f
Reviewed-on: https://dart-review.googlesource.com/c/87540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-18 16:31:13 +00:00
Peter von der Ahé 68d41b9547 Disable type inference: don't store initializer tokens 
Change-Id: Ib47282b5187a5d0b95d9a068dab1645b15aa7abe
Reviewed-on: https://dart-review.googlesource.com/c/86348
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-12-18 14:45:52 +00:00
Peter von der Ahé 0c084022af Disable type inference: don't create a type inference engine 
Change-Id: Icb143279adbf7a5b83384e5de8b3856d884ac5ef
Reviewed-on: https://dart-review.googlesource.com/c/86347
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-18 14:45:52 +00:00
Peter von der Ahé 12085156c1 Disable type inference: types of initializing formals 
Change-Id: I20887336af4596ad3ed1d83e82767d27f1a4d589
Reviewed-on: https://dart-review.googlesource.com/c/86346
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-18 14:45:52 +00:00
Dan Rubel 48093f5f9d Revert "Add support for parsing simple nullable types" 
This reverts commit c5fd11b5d6.

Reason for revert: Conditional expression lookahead may modify the token stream

Original change's description:
> Add support for parsing simple nullable types
> 
> ... as part of adding NNBD as outlined in
> https://github.com/dart-lang/language/issues/110
> 
> This only supports parsing simple nullable types
> such as int? and List<int>? while subsequent CLs
> will add support for parsing more complex types.
> 
> Change-Id: I144858946cb115755af437299899c2631105bf8c
> Reviewed-on: https://dart-review.googlesource.com/c/87501
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Dan Rubel <danrubel@google.com>

TBR=brianwilkerson@google.com,danrubel@google.com

Change-Id: Ie1f47e7384ff51159aa2ebeb21561455b8e6287f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/87620
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-18 14:32:33 +00:00
danrubel c5fd11b5d6 Add support for parsing simple nullable types 
... as part of adding NNBD as outlined in
https://github.com/dart-lang/language/issues/110

This only supports parsing simple nullable types
such as int? and List<int>? while subsequent CLs
will add support for parsing more complex types.

Change-Id: I144858946cb115755af437299899c2631105bf8c
Reviewed-on: https://dart-review.googlesource.com/c/87501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-18 11:29:33 +00:00
Peter von der Ahé 54d1118a66 Remove Loader.typeInferenceEngine 
Change-Id: I5ecbb3308436bc7ecee98ea7b15a1ec669a5c621
Reviewed-on: https://dart-review.googlesource.com/c/86344
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-12-17 14:33:49 +00:00
Peter von der Ahé 8dea395b18 isEligibleForTopLevelInference accounts for type inference disabled 
Change-Id: Ibffdf6b25dab39522868f2a927929f86deecb7d6
Reviewed-on: https://dart-review.googlesource.com/c/86343
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-17 14:33:49 +00:00
Peter von der Ahé 472bf29904 Disable type inference: Don't generate shadow wrappers 
Change-Id: Ibab49c3614f5e54fe15bdcb135f25db7070d84ca
Reviewed-on: https://dart-review.googlesource.com/c/86342
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-17 14:33:49 +00:00
Peter von der Ahé f504d61c96 Generate optional parameter initializers in BodyBuilder 
Change-Id: I3f33c660e25564dbdf907d6331cf391537113549
Reviewed-on: https://dart-review.googlesource.com/c/86341
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-17 14:33:49 +00:00
Peter von der Ahé b46077332b Disable type inference: local function return types 
Change-Id: I5491150ccf4ddcb8c7905c66b5fc2b5b17d1239d
Reviewed-on: https://dart-review.googlesource.com/c/86340
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-17 14:33:49 +00:00
Peter von der Ahé 6ec321f2b7 Sort classes topologically when checking for cycles 
Change-Id: I4d2fd8a1d3f2d369e69ed93665ce43ca4747b02d
Reviewed-on: https://dart-review.googlesource.com/c/86204
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-17 14:33:49 +00:00
danrubel 9de66d87b8 Revert support for parsing simple nullable types 
This reverts commit bc8c7cf782

Reason for revert: Breaks parsing less common conditionals (e.g. b ? c = true : g();)

Original change's description:
> Add support for parsing simple nullable types
>
> ... as part of adding NNBD as outlined in
> https://github.com/dart-lang/language/issues/110
>
> This only supports parsing simple nullable types
> such as int? and List<int>? while subsequent CLs
> will add support for parsing more complex types.

Change-Id: I49a21a85dca19241e3b23ed5c9fb6084e70f2000
Reviewed-on: https://dart-review.googlesource.com/c/87284
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-14 18:47:42 +00:00
danrubel e2007126eb Revert support for simple nullable type return value in generalized function type 
This reverts commit 11d081d115

Reason for revert: Breaks parsing less common conditionals (e.g. b ? c = true : g();)

Original change's description:
> Add support for simple nullable type return value in generalized function type
>
> This only supports nullable return values of the form
>
> <identifier> '?' 'Function' '(' ...
>
> This is an increment CL in the ongoing effort to add nullable type support
> as outlined in https://github.com/dart-lang/language/issues/110

Change-Id: I99bce29619d4e448193e3c81fa86a982791b1f77
Reviewed-on: https://dart-review.googlesource.com/c/87283
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-12-14 16:48:18 +00:00
Dan Rubel 6376482e20 Revert "Add support for prefixed nullable type" 
This reverts commit 7720689931.

Reason for revert: Breaks parsing less common conditionals (e.g. b ? c = true : g();)

Original change's description:
> Add support for prefixed nullable type
> 
> This adds support for nullable types of the form
> 
> <identifier> '.' <identifier> '?'
> 
> and
> 
> <identifier> '.' <identifier> '?' 'Function' '(' ...
> 
> This is an increment CL in the ongoing effort to add nullable type support
> as outlined in https://github.com/dart-lang/language/issues/110
> 
> Change-Id: I526aecbe64bacbd442cea0b4c52d36ff23b0443b
> Reviewed-on: https://dart-review.googlesource.com/c/87083
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Dan Rubel <danrubel@google.com>

TBR=brianwilkerson@google.com,danrubel@google.com

Change-Id: Ib5e74b4aad239f561a33eae9d95dffa2693037f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/87282
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-14 15:12:51 +00:00
Dmitry Stefantsov e98701ea33 [fasta] Allow const constructors in mixin applications 
Closes #33644, closes #33645, closes #32223.

Bug: http://dartbug.com/33644
Bug: http://dartbug.com/33645
Bug: http://dartbug.com/32223
Change-Id: Ia30efb8f450e62bfeb65c8b7fd7e23871ef0e87e
Reviewed-on: https://dart-review.googlesource.com/c/68368
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-14 12:37:30 +00:00
Aske Simon Christensen 07ae5ad066 Error for ambiguous set/map literals with too many type arguments 
Change-Id: Icfdeb5e13ecefbc0a431c2d36904c8064a29a5b2
Reviewed-on: https://dart-review.googlesource.com/c/87041
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-12-14 11:52:18 +00:00
Dmitry Stefantsov cdbb2a74a1 Reland [fasta] Invoke constructors of mixin applications in super invocations 
Reland of https://dart-review.googlesource.com/c/sdk/+/86200.

TBR=aam@google.com

Change-Id: Id3137cf5c7f87492db5bf3aabb505ac04529fa2c
Reviewed-on: https://dart-review.googlesource.com/c/87079
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-14 11:21:58 +00:00
Kevin Millikin 87f309463a Stop using asynchronous async in Fasta 
Change all the places that still used old-style asynchronous async in
Fasta.  These were mostly in testing.

Change-Id: I102209aa54c7c6e658b9d6ec98167af62bf12f3e
Reviewed-on: https://dart-review.googlesource.com/c/87074
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-12-14 08:17:35 +00:00
danrubel 7720689931 Add support for prefixed nullable type 
This adds support for nullable types of the form

<identifier> '.' <identifier> '?'

and

<identifier> '.' <identifier> '?' 'Function' '(' ...

This is an increment CL in the ongoing effort to add nullable type support
as outlined in https://github.com/dart-lang/language/issues/110

Change-Id: I526aecbe64bacbd442cea0b4c52d36ff23b0443b
Reviewed-on: https://dart-review.googlesource.com/c/87083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-13 23:24:04 +00:00
Dan Rubel 11d081d115 Add support for simple nullable type return value in generalized function type 
This only supports nullable return values of the form

<identifier> '?' 'Function' '(' ...

This is an increment CL in the ongoing effort to add nullable type support
as outlined in https://github.com/dart-lang/language/issues/110

Change-Id: I42febae9f88f7e4d8b05907988deab97c7a7425c
Reviewed-on: https://dart-review.googlesource.com/c/87081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-12 19:13:24 +00:00
Alexander Aprelev 4ed049d782 Revert "[fasta] Invoke constructors of mixin applications in super invocations" 
This reverts commit 7d1ebf260a as it
breaks vm-kernel-precomp-obfuscate-linux-release-x64, kernel-precomp
bots.

Change-Id: Icf7ba0fc2c3781c34b1c4327655f958c809d99fe
Reviewed-on: https://dart-review.googlesource.com/c/87120
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-12-12 18:32:53 +00:00
Dan Rubel 1ff82c5081 Update endFunctionType event to take questionMark token 
... which in this CL will always null.
This is another step when adding NNDB support as outlined in
https://github.com/dart-lang/language/issues/110

Change-Id: I3974fcb885c63be4af9d1007258383f3f8191ae0
Reviewed-on: https://dart-review.googlesource.com/c/87080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-12 16:10:23 +00:00
Kevin Millikin a8493e1b50 Flip the default value of the Kernel syncAsync flag 
In Kernel's TargetFlags, this flag still defaulted to false.  Flip the
default to true and update all client code in the SDK.  The
expectation is that many of the places that now pass false explicitly
really just want the default, but that will be verified separately and
then the flag will be removed.

Change-Id: I2a38eb53f280f21f59bb1d2e88c42516f827fd39
Reviewed-on: https://dart-review.googlesource.com/c/85448
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-12-12 14:23:54 +00:00
Dmitry Stefantsov 7d1ebf260a [fasta] Invoke constructors of mixin applications in super invocations 
Change-Id: I24859587e1ba0e63a8219a60e1218c1ce5c83f24
Reviewed-on: https://dart-review.googlesource.com/c/86200
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-12 14:09:28 +00:00
Peter von der Ahé 8cb7ab9567 Ensure that Object doesn't have supertypes 
Change-Id: Ife632785bdac0d26fb6db1463636fd9a1fec51e1
Reviewed-on: https://dart-review.googlesource.com/c/86201
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-12 10:55:29 +00:00
Peter von der Ahé 1046bf66d4 Ensure patch parts know they're patches 
Change-Id: I159634af72a34b9537c8d77a2f0a6258d8344bd7
Reviewed-on: https://dart-review.googlesource.com/c/86021
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-12-12 09:55:15 +00:00
Dan Rubel bc8c7cf782 Add support for parsing simple nullable types 
... as part of adding NNBD as outlined in
https://github.com/dart-lang/language/issues/110

This only supports parsing simple nullable types
such as int? and List<int>? while subsequent CLs
will add support for parsing more complex types.

Change-Id: I3cc5c65d20bf3732a39cab0e823b2f7332342866
Reviewed-on: https://dart-review.googlesource.com/c/86961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-11 23:48:04 +00:00
Dan Rubel e2db9676d9 add asNonNullable() to existing type infos 
This adds code to ignore trailing `?` in `as` and `is` expressions
because the trailing `?` may be part of the larger expression.
At the moment, this change is a no-op, but will become active
when a subsequent CL lands support for nullable types as part of
https://github.com/dart-lang/language/issues/110

Change-Id: I829d6aee0f11957ca9b5e143000005031649449f
Reviewed-on: https://dart-review.googlesource.com/c/86960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-12-11 23:48:04 +00:00
danrubel 2a85a3433e Update handleType event to take questionMark token 
... which in this CL will always null.
This is the first step when adding NNDB support as outlined in
https://github.com/dart-lang/language/issues/110

Change-Id: If3810bcaf1b73e70924f09d619e2a84e7d5ba8d6
Reviewed-on: https://dart-review.googlesource.com/c/86860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-11 16:21:05 +00:00
Peter von der Ahé abdd6ca0d1 Verify that we don't emit SyntheticExpressionJudgment 
Change-Id: I4973d6731a8095cb3bc58f13f8db522fe3984af8
Reviewed-on: https://dart-review.googlesource.com/c/86020
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-12-11 14:55:57 +00:00
Dan Rubel 089f098849 Auto generate more analyzer error codes 
* MISSING_CATCH_OR_FINALLY
* STACK_OVERFLOW
* INVALID_OPERATOR_FOR_SUPER
* VAR_AND_TYPE

Change-Id: Ib308cd979f9c5644c28ab1f927fa9cc8add38269
Reviewed-on: https://dart-review.googlesource.com/c/86462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-12-07 11:46:48 +00:00
Aske Simon Christensen 2cdd29b516 Handle set literals in body builder. 
Change-Id: I522429b11b7fb52e6c10fc47023ca11117ab1195
Reviewed-on: https://dart-review.googlesource.com/c/85767
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-06 14:46:58 +00:00
Aske Simon Christensen 44926fd572 Shadow node for set literals 
Change-Id: I7a626f4ded6c435c5d50661e9b2ef64b9d784ac9
Reviewed-on: https://dart-review.googlesource.com/c/85766
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-06 14:46:58 +00:00
Peter von der Ahé b3b6a53cd3 Remove ForInJudgment 
Fixes https://github.com/dart-lang/sdk/issues/31790

Change-Id: I685fe1e769913e1bcfbd2eeda3655cdc14886dec
Reviewed-on: https://dart-review.googlesource.com/c/85949
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-12-05 20:04:55 +00:00
Dan Rubel 4264f3c619 Remove unused fasta error code mapping 
Change-Id: I349513235e43260496bd90a4e6074e673d3ba096
Reviewed-on: https://dart-review.googlesource.com/c/85782
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-12-05 14:35:36 +00:00
Peter von der Ahé 035bb3d04e Remove various shadow nodes related to labels 
Change-Id: I081f77393b58d54aa59f7cb6258f164d686d7b0c
Reviewed-on: https://dart-review.googlesource.com/c/85948
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-05 12:58:56 +00:00
Peter von der Ahé 90aa12feed Build catch blocks in BodyBuilder 
Change-Id: I824605519eba227402083d30f00f95710bcf3ae6
Reviewed-on: https://dart-review.googlesource.com/c/85902
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-05 12:58:56 +00:00