dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

3345 Commits

Author SHA1 Message Date
Dan Rubel f3344f3c13 Update parser to report error for missing comma 
Fix https://github.com/dart-lang/sdk/issues/35213

Change-Id: Ia9a1628f15bebf0c915f5d16712f98ac614896e8
Reviewed-on: https://dart-review.googlesource.com/c/85021
Auto-Submit: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-21 16:17:48 +00:00
Dan Rubel 9677ec9a14 Fix parsing complex function expressions 
Fix https://github.com/dart-lang/sdk/issues/35177

Change-Id: I378314741bbbe555f9cdc2b95dcfd5ce71a15efa
Reviewed-on: https://dart-review.googlesource.com/c/84660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-16 21:49:30 +00:00
danrubel 85986c818a First cut fasta parser support for set literals 
Change-Id: I9075a6ac3ef833f14d8861d2c020f81b7c5c8694
Reviewed-on: https://dart-review.googlesource.com/c/84561
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-16 01:26:47 +00:00
Dan Rubel 737f44a8dd Add type argument count to type info in fasta parser 
This adds a new accessor in the fasta parser support classes
for determining the number of type arguments. This will be used
when adding support for set literals to disambiguate a set literal
from a map literal.

Change-Id: If32c12d198f6d88fb06527817cec038c22428d53
Reviewed-on: https://dart-review.googlesource.com/c/84461
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-14 22:36:43 +00:00
Peter von der Ahé d4f9d36dee Rewrite comments to refer to legacy mode instead of strong mode 
Change-Id: Ib272c3834d5e8fc4592981bb33a9b3cf21df1e5f
Reviewed-on: https://dart-review.googlesource.com/c/84412
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-11-14 10:39:12 +00:00
Peter von der Ahé 9931b77802 Rename strongMode constructor parameter of TypeSchemaEnvironment to legacyMode 
Change-Id: I713dcf4a2f614893832fb4d18dcaa23c67ffd9c5
Reviewed-on: https://dart-review.googlesource.com/c/84409
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-11-14 09:59:07 +00:00
Peter von der Ahé 6995ac59a8 Rename strongMode parameter of computeDefaultTypesForVariables to legacyMode 
Change-Id: If47734fc15eecbfc50142f29edb707c163e9b969
Reviewed-on: https://dart-review.googlesource.com/c/84408
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-11-14 09:59:07 +00:00
Peter von der Ahé 9b852e00a1 Update comment in body_builder.dart to say legacyMode 
Change-Id: I294eabfcf6d58f84d41cd540339bce4b5b4616a3
Reviewed-on: https://dart-review.googlesource.com/c/84407
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-11-14 09:59:07 +00:00
Peter von der Ahé a0e08e1468 Rename strongMode parameter of getRedirectionTarget to legacyMode 
Change-Id: Id9254f2fe0151eb24552356a2a7ea3ec1ad34cd4
Reviewed-on: https://dart-review.googlesource.com/c/84406
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-11-14 09:51:39 +00:00
Peter von der Ahé 7b020f5ae3 Rename InterfaceResolver.strongMode to legacyMode 
Change-Id: I4d77f735d2442d278f6edbc8559ee408d8f207e8
Reviewed-on: https://dart-review.googlesource.com/c/84405
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-11-14 09:50:59 +00:00
Peter von der Ahé d412f50f03 Rename TypeInferrerImpl.strongMode to legacyMode 
Change-Id: Ib25ed980d64ddae4cfb2bd0cd121bf1173a8af1b
Reviewed-on: https://dart-review.googlesource.com/c/84403
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-11-14 09:32:15 +00:00
Peter von der Ahé e761241f9e Rename TypeInferenceEngine.strongMode to legacyMode 
Change-Id: Ie1df26dafd9f2dbbe582c7348c3e35028423049d
Reviewed-on: https://dart-review.googlesource.com/c/84402
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-11-14 08:54:54 +00:00
Peter von der Ahé 98e207d1d2 Rename KernelTarget.strongMode to legacyMode 
Change-Id: I218af5f568d9aa20853c38b04370bc2d51612a82
Reviewed-on: https://dart-review.googlesource.com/c/84401
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-11-14 08:48:49 +00:00
Peter von der Ahé 10f210f83b Use factories for instantiating TypeInferrer 
Change-Id: Id34b7767b7333dc66a970906f934ad81d2a276a6
Reviewed-on: https://dart-review.googlesource.com/c/84400
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-11-14 08:46:48 +00:00
Brian Wilkerson 86e1bb0cc7 Add a TokenType for the new shift operator (>>>) 
Change-Id: Ie9edc88a6ca97e01854d0fe52c31b86bf3f043c1
Reviewed-on: https://dart-review.googlesource.com/c/84126
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-13 14:40:03 +00:00
Peter von der Ahé deaf5f4528 Only check bounds on recompiled libraries 
Change-Id: Ib9226c2eebc524f3b0fe4655df648c18a218e95c
Reviewed-on: https://dart-review.googlesource.com/c/84031
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-11-12 12:50:39 +00:00
Peter von der Ahé c1db6b5336 Only track type promotion of locals 
Change-Id: Ib576bc70128a5b0b045d5083f06a19e822c302b4
Reviewed-on: https://dart-review.googlesource.com/c/84026
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-11-12 11:38:22 +00:00
Peter von der Ahé afe3e68841 Is-not doesn't lead to promotion 
Change-Id: I2458248080e58564bc0ae807adf731802f5ef2cc
Reviewed-on: https://dart-review.googlesource.com/c/84025
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-11-12 11:35:22 +00:00
Peter von der Ahé 0d051a4c65 Don't wrap no-argument sends 
Change-Id: I20f80e49bc748a52ec23a59a582e37fa949a47be
Reviewed-on: https://dart-review.googlesource.com/c/84023
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-11-12 11:30:16 +00:00
Peter von der Ahé efcca56e36 Ensure stack is empty after top-level declarations 
Change-Id: Ia87347af2511afa7a47ebc5e3170597ef263e5cd
Reviewed-on: https://dart-review.googlesource.com/c/83383
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-11-12 11:27:17 +00:00
Peter von der Ahé 47cada07ac Start computing scopes for type promotion 
Change-Id: Ica551b3f04557ed269446293c7aa989bc7528fbb
Reviewed-on: https://dart-review.googlesource.com/c/82998
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-11-12 11:18:42 +00:00
Sigmund Cherem b484aada21 Remove library-root option - replace it with a libraries-spec option instead 
Change-Id: Ie1df52cdaa7ab4381a4c1b94c61a1210f0f31b5f
Reviewed-on: https://dart-review.googlesource.com/c/83641
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-11-09 22:40:28 +00:00
Dan Rubel 35c6c79ebc Fix parsing getter with prefixed name 
Fix https://github.com/dart-lang/sdk/issues/34610

Change-Id: I7004814af69b35d143779857a6bbd4bb639e257c
Reviewed-on: https://dart-review.googlesource.com/c/83240
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-08 14:31:43 +00:00
Peter von der Ahé c24073f442 Add events for grammar-term forInitializerStatement 
Change-Id: I2876085cca0e8c7e553fa14d786a2b4bd7f18470
Reviewed-on: https://dart-review.googlesource.com/c/83380
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-11-07 13:21:15 +00:00
Peter von der Ahé f882af1c33 Include file name in scanner test chain 
Change-Id: Ifca81ba39d14895cbe025f349d97a02e6b07856f
Reviewed-on: https://dart-review.googlesource.com/c/82994
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-11-06 13:18:40 +00:00
Peter von der Ahé 0fd4a51e2c Recover from default values in function types 
Fixes https://github.com/dart-lang/sdk/issues/35035

Change-Id: I29fe0d792998c43f49877d97b61b3afc16c43cef
Reviewed-on: https://dart-review.googlesource.com/c/82984
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-11-06 11:39:32 +00:00
Peter von der Ahé da93e27833 Improve position on field initializers. 
Change-Id: Id62a0c6bbef46fc4745036c63c1cbe93eeb105a3
Reviewed-on: https://dart-review.googlesource.com/c/82585
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-11-02 14:32:31 +00:00
Kevin Millikin ad2db25ce6 Do not add constructors to mixin declarations 
Mixin declarations cannot be instantiated or extended, so they should
not have constructors.  Adding a compiler-generated constructor causes
us to try to add an invocation of the default superclass constructor.
Because the superclass constraint is encoded as a superclass this can
cause a spurious error that is impossible to fix.

Fixes https://github.com/dart-lang/sdk/issues/35011

Change-Id: Ia8f99d00b1a5b042da233d54f3cc1f0c6345e779
Reviewed-on: https://dart-review.googlesource.com/c/82447
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-02 10:45:10 +00:00
Jens Johansen 993f7260c1 Labeled variable declarations shouldn't introduce a new scope 
Before, e.g.
```
main() {
  L: var x, y;
  x = 42;
  y = x;
}
```

would produce something like
```
static method main() → dynamic {
  {
    dynamic x;
    dynamic y;
  }
  x = 42;
  y = x;
}
```

i.e., the variable declaration was in another scope, and their usage
isn't legal.

This CL fixes that by either
a) (the normal case) not wrapping it --- the label is not used anyway.
b) (the case that cannot happen) put a label on the first part so the
   output would be something like
```
  L: dynamic x;
  dynamic y;
  x = 42;
  y = x;
```

Fixes #34943.

Change-Id: I24132665dab53fb8fb024f73dd11e0d1f1945812
Reviewed-on: https://dart-review.googlesource.com/c/82063
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-02 10:20:42 +00:00
Martin Kustermann 8953788993 [VM] Convert const Symbol("..") to SymbolConstants in kernel2kernel transformation 
Issue https://github.com/dart-lang/sdk/issues/34911

Change-Id: Ib504d57b5a529a04f511f737af4cec0ff0590250
Reviewed-on: https://dart-review.googlesource.com/c/82069
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-02 09:28:15 +00:00
Dmitry Stefantsov c560ee9399 [fasta] Remove temporary map typedefInstantiations 
Change-Id: Ife72d3b9a2b4f150e5d4e3548409fadec1dc3146
Reviewed-on: https://dart-review.googlesource.com/c/82226
Auto-Submit: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-01 18:55:04 +00:00
Peter von der Ahé 5896627fb8 Handle when being asked to compile a part 
Change-Id: I64499d36c0b8f2b5d6d87786a16040b7cfeedae9
Reviewed-on: https://dart-review.googlesource.com/c/82221
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-11-01 09:29:11 +00:00
Peter von der Ahé cf73e08b71 Use InvalidType, not DynamicType on cyclic typedefs 
Change-Id: Icbaae7dffe7284f34df2b4ab28b985040ba7d2bf
Reviewed-on: https://dart-review.googlesource.com/c/81825
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-31 12:50:48 +00:00
Peter von der Ahé f9c41634fb Test framework for type promotion 
Change-Id: I82d57516e1ac845f1f1e14b5dabf355d9179c221
Reviewed-on: https://dart-review.googlesource.com/c/80820
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-31 12:39:38 +00:00
Peter von der Ahé 43472d72fb Update package:front_end to use FunctionType.typedefType 
Change-Id: I08d9c896a42d00f43df2bb84249054f0aaf63e0d
Reviewed-on: https://dart-review.googlesource.com/c/82201
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-31 08:56:57 +00:00
Aske Simon Christensen 48d8b32e2a Allow factory constructors to have the same name as an instance member. 
Fixes https://github.com/dart-lang/sdk/issues/34965

Change-Id: I807adbe027229f95d49a611e1e6a310a7029c65a
Reviewed-on: https://dart-review.googlesource.com/c/82060
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-10-30 13:54:52 +00:00
Peter von der Ahé be2aa508d2 Create Kernel type parameters earlier 
In principle, this should have little effect, but for function type aliases
(typedefs), this means that the number of type parameters is always correct
as it has been the case for classes for a while.

Change-Id: I73cb1285be7c43b304ce5e1ecc1b17078687fb99
Reviewed-on: https://dart-review.googlesource.com/c/82061
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-30 13:04:41 +00:00
Peter von der Ahé f10c3b9e95 Remove workaround for missing typedef information. 
Fixes https://github.com/dart-lang/sdk/issues/34655
Fixes https://github.com/dart-lang/sdk/issues/34979
Change-Id: I14552a491f24b5c64cceeeb7d0273685352f7118
Reviewed-on: https://dart-review.googlesource.com/c/81408
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-30 11:15:54 +00:00
Aske Simon Christensen 4794449ba6 Added some missing quotes to types in messages. 
Change-Id: I68422f2b6fb5c89024fb521f180cbb141ea36187
Reviewed-on: https://dart-review.googlesource.com/c/80640
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-10-30 10:48:29 +00:00
Aske Simon Christensen c00921eb1c Set default type to Object when bound is explicitly Object. 
This fixes the instantiated type for type parameters of function types
(whose default types are otherwise not computed) when the bound is
explicitly specified as Object.

It also enables error reporting to detect if a bound on a type variable
was specified or not, so that when a generic function type is printed,
the bound can be printed if and only if it was originally specified.

Fixes https://github.com/dart-lang/sdk/issues/34920

Change-Id: I9ad3f1cacb1b36eaef139d50c8e73cc7a8cc915b
Reviewed-on: https://dart-review.googlesource.com/c/81405
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-30 10:48:29 +00:00
Peter von der Ahé 1215d9163a Add more status kinds 
Change-Id: I02ef33de66e529f9cf229fc24975f2c084b6a093
Reviewed-on: https://dart-review.googlesource.com/c/81800
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-29 13:21:50 +00:00
Peter von der Ahé ac3e4b320f Handle field formal initializers of duplicated fields 
Fixes https://github.com/dart-lang/sdk/issues/34912

Change-Id: Icc85f8d5c989c6d9b0e3798c1469c63922a7e346
Reviewed-on: https://dart-review.googlesource.com/c/81413
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
 2018-10-29 11:17:39 +00:00
Dmitry Stefantsov aba7969e27 [kernel] Add DartTypeVisitor1 
Change-Id: I4eba2c4f9366096cc42f00004014680500d983ac
Reviewed-on: https://dart-review.googlesource.com/c/81406
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-25 13:08:18 +00:00
Martin Kustermann dec268cfae [VM] Catch non-instantiated type arguments for constant partial instantiation expression 
This makes us report the following error

  * in JIT:

  Unhandled exception:
  'test.dart': error: Type arguments must be instantiated in partial instantiation.
  #0      main (...)
  ...

  * in AOT:

  test.dart:7:28: Error: The type '#lib1::C::T' is not a constant, only instantiated types are ...
    const C({this.callback = _defaultCallback});
                           ^
  test.dart:7:17: Context: While analyzing:
    const C({this.callback = _defaultCallback});
                ^
  test.dart:5:37: Error: The type '#lib1::C::T' is not a constant, only instantiated types are ...
    void foo([dynamic Function(T) f = _defaultCallback]) {}
                                    ^
  test.dart:5:33: Context: While analyzing:
    void foo([dynamic Function(T) f = _defaultCallback]) {}
                                ^
  test.dart:11:38: Error: The type '#lib1::bar::T' is not a constant, only instantiated types are ...
  void bar<T>([dynamic Function(T) f = _defaultCallback]) {}
                                     ^
  test.dart:11:34: Context: While analyzing:
  void bar<T>([dynamic Function(T) f = _defaultCallback]) {}



Issue https://github.com/dart-lang/sdk/issues/32912

Change-Id: I05c7019119a50a9cc38939d9cb41aeaa06c853bc
Reviewed-on: https://dart-review.googlesource.com/c/81278
Auto-Submit: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-10-25 09:23:18 +00:00
Peter von der Ahé 1546ff6752 Add class TypeArgumentIssue 
Change-Id: Ie46fa496c10e8c78182bb3aeeab1836464259f42
Reviewed-on: https://dart-review.googlesource.com/c/81269
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-25 09:07:26 +00:00
Peter von der Ahé 724573e332 Rename findBoundViolations to findTypeArgumentIssues 
Change-Id: I10bf8afa4a7e7656725bdb5bb05aff9a1252bff3
Reviewed-on: https://dart-review.googlesource.com/c/81265
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-25 09:07:26 +00:00
Peter von der Ahé 94b9d05349 Move bounds checks to own file. 
Change-Id: I0954bdb2633c0fae8d760bff05e5be8bbba59c57
Reviewed-on: https://dart-review.googlesource.com/c/81262
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-25 09:07:26 +00:00
Dmitry Stefantsov cf0a99a89b [fasta] Check type arguments in method invocations while doing inference 
Fixes #34899

Bug: http://dartbug.com/34899
Change-Id: I4db7612925d0938cc6ec381c4de8073d50d61aac
Reviewed-on: https://dart-review.googlesource.com/c/81266
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Auto-Submit: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-24 10:00:23 +00:00
Kevin Millikin 5c9060283b Change parameter 'silent' => 'instrumented' 
This requires flipping the default value from false to true.  I can
never remember what "silent" entails.  It sounds like it might
suppress some error reporting, but what it actually does is suppress
the instrumentation used for checking comments in the test input
files.

Hopefully this name is more obvious.

Change-Id: I922c7107eae32a5d4206aaa6d4507310289ca64d
Reviewed-on: https://dart-review.googlesource.com/c/81261
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-24 08:45:40 +00:00
Peter von der Ahé 2c6eabd3c4 Compute substitution map on kernel objects instead of builders 
Fixes https://github.com/dart-lang/sdk/issues/34856

Change-Id: I150a390ea19e684e7951c1354c09fd40845e4328
Reviewed-on: https://dart-review.googlesource.com/c/81006
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-22 12:41:59 +00:00