dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

3345 Commits

Author SHA1 Message Date
Paul Berry ec5ba8a252 Revert "Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden." 
This reverts commit 6699384ddd.

Reason for revert: Breakages in Flutter - see https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8923238548150736816/+/steps/analyze_flutter/0/stdout

Original change's description:
> Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Bug: https://github.com/dart-lang/sdk/issues/34437
> Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
> Reviewed-on: https://dart-review.googlesource.com/c/91170
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I07c96c8131c16b2748a403f38d5f15b814131c63
Reviewed-on: https://dart-review.googlesource.com/c/91360
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-01-28 17:09:24 +00:00
Jens Johansen 5cf4e543b8 Handle mis-included parts differently 
If, for instance, including something that is not a part of the file
you include it from, previously we would copy things over anyway, and
other libraries wouldn't be able to use it
(for instance including it would fail).

Now, instead, we don't include it, structurally pretending the "part of"
line wasn't there (that is, we don't copy things over and other libraries
are free to include it).

As before, an error is given, but errors doesn't 'cascade' into other
libraries that (before this change) couldn't use the included file.

Change-Id: Ica6225c437ea7dd66f9e8955e638f442b2df8f97
Reviewed-on: https://dart-review.googlesource.com/c/90380
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-01-28 14:20:45 +00:00
Aske Simon Christensen f066c05319 Rename klass getter on InstanceConstant to classNode 
This achieves consistency with similar getters in the API.

This is technically a breaking change, since it changes a published
part of the Kernel API. Since the constants API is relatively new and
so far only used internally in the AOT compiler, the change is
expected to be unproblematic.

Closes https://github.com/dart-lang/sdk/issues/35696

Change-Id: I3ca30922580d226ccbdb6f77496983c21ef2102b
Reviewed-on: https://dart-review.googlesource.com/c/90220
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-01-28 13:31:05 +00:00
Kevin Millikin e169134203 [Fasta] Fix a typo in a class name 
Change-Id: Ia2bc80d7a9ba3dc7716f8052e367c7711646a839
Reviewed-on: https://dart-review.googlesource.com/c/91145
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-28 11:53:41 +00:00
Peter von der Ahé 591df5263f Fix typo in omitPlatform documentation 
Change-Id: Id490a6b051b0ef74cae709157d4ae537495e9583
Reviewed-on: https://dart-review.googlesource.com/c/90680
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-01-28 08:21:36 +00:00
Konstantin Shcheglov 6699384ddd Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
Reviewed-on: https://dart-review.googlesource.com/c/91170
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-26 20:12:55 +00:00
Dan Rubel 874f9d0bdf Refactor for statement parsing 
This CL introduces 2 new parser listener events
in preparation for parsing for control flow structures
in literal lists, sets, and maps.

Change-Id: I230f36cded714a13e4badb401fe5b5906c93a2da
Reviewed-on: https://dart-review.googlesource.com/c/91144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-25 18:15:00 +00:00
danrubel 56123f08b0 Update parser to support simple if/else control flow in literal lists, sets, and maps 
Change-Id: I740beea833ed1ad76582ad5232549bd204981808
Reviewed-on: https://dart-review.googlesource.com/c/90901
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-24 22:22:50 +00:00
Peter von der Ahé 15dc147226 Prevent serialization of synthetic kernel nodes 
Change-Id: Iad2300d8fa5384b5d692c5598c9311e600427dd2
Reviewed-on: https://dart-review.googlesource.com/c/90003
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-24 18:55:44 +00:00
Liam Appelbe c6e0d56a41 [VM] Add experimental flags to gen_kernel. 
Bug: https://github.com/dart-lang/sdk/issues/35602
Change-Id: I41cc7fcfe2ec520d4b6cf1d8e9535c618b09637d
Reviewed-on: https://dart-review.googlesource.com/c/90540
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-01-23 19:43:09 +00:00
danrubel 5543fce9a3 add limited support for parsing if control flow entries in lists, sets, and maps 
This updates the parser to handle two if control flow entries
* `if` condition entry
* `if` condition spread-collection

... and also addresses comments in
https://dart-review.googlesource.com/c/sdk/+/90500

Change-Id: Ibabec8f0f4da918ef4cfe429405dae82ba74c129
Reviewed-on: https://dart-review.googlesource.com/c/90620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-23 17:57:05 +00:00
danrubel 55197eafd7 Refactor literal list, set, and map parsing for control flow collections 
This refactors the existing spread collection parsing in preparation
for control flow collection parsing.

Change-Id: I1fc5aa31449999145f7a63da1d34c7b8858cf5d4
Reviewed-on: https://dart-review.googlesource.com/c/90500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-23 17:57:05 +00:00
Daco Harkes 591b52f1c5 [frontend] report transformation error messages through library loader 
Change-Id: I7280d02e42785742fc800f7e44b1913408dcada5
Reviewed-on: https://dart-review.googlesource.com/c/90460
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-23 10:39:07 +00:00
Peter von der Ahé 9d02ca176a Follow up to CL 88941 
Change-Id: I17a9e62da9b23e84447d5d121477ccda2cfc2339
Reviewed-on: https://dart-review.googlesource.com/c/89581
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-23 08:41:50 +00:00
Peter von der Ahé c0d46344ef Implement double dispatch for types 
Change-Id: Id4eb18cff0fc18d47055b63351be6adc5ce7aec5
Reviewed-on: https://dart-review.googlesource.com/c/89583
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-01-23 08:03:34 +00:00
Peter von der Ahé 31ef7add9b Simplify ClassHierarchyBuilder API 
Change-Id: Id5b6951713c22fa7f414de2ca9d34673107ebe80
Reviewed-on: https://dart-review.googlesource.com/c/89547
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-01-22 17:24:52 +00:00
Peter von der Ahé 70b02ea06d Remove double synthetic wrap to fix crash in for-in 
Fixes https://github.com/dart-lang/sdk/issues/35651

Change-Id: I80c07453cae3e4901785db65546a396bc99c3183
Reviewed-on: https://dart-review.googlesource.com/c/89515
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2019-01-21 14:39:02 +00:00
Jens Johansen d2270fcda7 Avoid ConcurrentModificationException with problemsAsJson and patch files 
Change-Id: I8663b99376b90c42bfdcad7eff7da47002b98eb0
Reviewed-on: https://dart-review.googlesource.com/c/90386
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-01-21 12:18:24 +00:00
Jens Johansen 865743a273 Include all non-dart and non-package libaries in fasta testing 
Change-Id: Ied4ded0f601a5a2bf683cbc63cec724623b12796
Reviewed-on: https://dart-review.googlesource.com/c/90227
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-21 12:10:56 +00:00
Peter von der Ahé b0017d758c Refer to correct locations in SDK (and other dill files) 
Fixes https://github.com/dart-lang/sdk/issues/35559
Fixes https://github.com/dart-lang/sdk/issues/35558

Change-Id: I902273759c6d3076779ccf120a79fd972d939827
Reviewed-on: https://dart-review.googlesource.com/c/90181
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-01-18 12:37:24 +00:00
Kevin Millikin c9a55b437a [Kernel] Remove the dedicated fromEnvironment constants 
These can be represented as an unevaluated static invocation.

Change-Id: Ib827345f1f65a09f1a856eae33366722a2e613d2
Reviewed-on: https://dart-review.googlesource.com/c/90008
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-01-18 10:10:42 +00:00
Jens Johansen e3302cdb8f Follow-up to storing problems in the ast 
Change-Id: I2bfe8ad8d86806e0f5ffa026566cfa234b82154b
Reviewed-on: https://dart-review.googlesource.com/c/90005
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-01-18 07:15:36 +00:00
Kevin Millikin b00193fa5f [Kernel] Signal an error for invalid native invocations 
Calls to the factory constructor 'new List' can turn into static
invocations of a backend-specific factory function.  Signal an error
instead of crashing.

Change-Id: Id0a8a7f0f847c03225b7fa9da2351032d15522e0
Reviewed-on: https://dart-review.googlesource.com/c/90006
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-01-17 15:12:04 +00:00
Peter von der Ahé 21c42e914e Compute supertypes 
Change-Id: I85fd7894b026180b1bc418602c0f09fcfea0a543
Reviewed-on: https://dart-review.googlesource.com/c/89543
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-17 14:23:07 +00:00
Peter von der Ahé 181b3898eb Follow up on review comments 
Change-Id: Ie5c3d31630b638653e5e27002b029915b8f940cf
Reviewed-on: https://dart-review.googlesource.com/c/89542
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-17 14:23:07 +00:00
Peter von der Ahé 660c33fde6 Add TypeBuilder.declaration 
Change-Id: Iede4bde8e30bb4ac034c0cb0db49a843ff84d48b
Reviewed-on: https://dart-review.googlesource.com/c/89541
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-17 14:23:07 +00:00
Peter von der Ahé ef2e000a52 Share expectation matching 
Change-Id: I15e8d4c622a7980e170cf38e2ff57738ea57f01c
Reviewed-on: https://dart-review.googlesource.com/c/89521
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-17 14:23:07 +00:00
Aske Simon Christensen e3d6709289 Error message for circular constant expressions 
Handles the situations described in #34204 and #34189 when front-end
constant folding is enabled.

Change-Id: I64fd8449ac1661f6fe67411113c6f99d8009547c
Reviewed-on: https://dart-review.googlesource.com/c/90007
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-01-17 14:21:47 +00:00
Jens Johansen dab228e55f Save problems in ast - fasta changes 
Change-Id: Id38f5e7495c245e5a7b161b55c58b8826c146a80
Reviewed-on: https://dart-review.googlesource.com/c/90000
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-17 10:46:13 +00:00
Peter von der Ahé ddc1de50d6 Use ClassHierarchyBuilder in all modes. 
Change-Id: Ia4df46c2e9f6edc25274492c4a7ea85a4f4b95e1
Reviewed-on: https://dart-review.googlesource.com/c/88959
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-17 09:39:44 +00:00
Kevin Millikin e36ad1dad0 [Kernel] Build an invalid constant for evaluation errors 
An invalid constant is (currently) represented by an unevaluated
invalid expression.  Using this instead of null fixes 63 out of 125
CFE constant-evaluation crashes with constant-update-2018 and
correctly signals 26 more previously-missed compile-time errors.

Change-Id: I5b4de3995b3a59978dfa08fc542ef0f027572eb6
Reviewed-on: https://dart-review.googlesource.com/c/89506
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-01-17 07:26:04 +00:00
danrubel b81c1b2095 Parse spread collections in map literals 
This CL adds support for parsing spread collection entries in map literals.
For now, all listeners report an error on the spread collection tokens
'...' and '...?' until support has been added for those listeners.

Change-Id: I299bb1524fda39746471c07e618df6a2305b1a2e
Reviewed-on: https://dart-review.googlesource.com/c/89860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-17 01:32:35 +00:00
Peter von der Ahé 8ba2de2344 Sort context for conflicting inherited members 
Change-Id: I3a1893c6ea268b4bb1518aa8f098b3524aa4f1ba
Reviewed-on: https://dart-review.googlesource.com/c/88957
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-01-16 15:46:22 +00:00
Kevin Millikin 215f6620e7 [Kernel] Signal errors on static fields in constant contexts 
Fasta allows some non-const static field access in constant contexts
which leads to the constant evaluator trying to evaluate them.  Signal
an error instead of crashing.  This will double-report errors for the
cases that Fasta already catches, and we should fix that
double-reporting.

Fix unbounded recursion in printing unevaluated constants (writeNode
called visitUnevaluatedConstant which called defaultConstant which
called writeNode...).

Fix a spurious trailing comma in printing of instance constants.

Change-Id: Idff3169a3a56432ad67c27ff9c267ef355c4c1dc
Reviewed-on: https://dart-review.googlesource.com/c/89514
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-01-16 15:07:58 +00:00
Peter von der Ahé 9b5eabdaca Fix crash in color support 
Change-Id: Ibf1ad2a77ba5d1de3ae66ca64c43fe1b22a5da0a
Reviewed-on: https://dart-review.googlesource.com/c/89513
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-01-16 11:43:24 +00:00
Kevin Millikin 5f10aed19c [Kernel] Don't print static fields in instance constants 
Instance constants don't have any of the class's static fields, so we
should not try to print them.

Change-Id: Id52bf7c25c805a21cf3a48c58efe84a720d0d2dd
Reviewed-on: https://dart-review.googlesource.com/c/89508
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-01-16 10:34:33 +00:00
Peter von der Ahé bdb51e2837 Improve input path handling and remove extra schemas. 
Change-Id: I02a403284a2cc71cac908be4a7ec9f858cb5db47
Reviewed-on: https://dart-review.googlesource.com/c/89509
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-01-16 10:17:03 +00:00
Kevin Millikin 8a91948c03 [Kernel] Properly signal compilation errors for constants 
Instead of simply printing a message, properly signal a Fasta problem for
constant errors.  This causes 68 tests (presumably missing compile-time
errors) to start passing with --enable-experiment=constant-update-2018.

Change-Id: Ia9f1809305bbef7b4652ce49acf6fb9c18408207
Reviewed-on: https://dart-review.googlesource.com/c/89580
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-01-16 08:15:34 +00:00
Dan Rubel 4ec9dbf1d0 Add set literal spread collection parsing support 
Change-Id: I12f4675a3a034a82acc16c4d189b001d52c23039
Reviewed-on: https://dart-review.googlesource.com/c/89681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-16 01:48:36 +00:00
Dan Rubel b55bc09f1f Add list literal spread collection parsing support 
Change-Id: I96098e35baf44660b3f7a49952fde64def9998c7
Reviewed-on: https://dart-review.googlesource.com/c/89680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-15 21:16:05 +00:00
Sam Rawlins 3154bb0d37 Stop using external deprecated members in front_end 
Change-Id: I3fa03de568f72bfc3adb46efcfa2b61b781c706b
Reviewed-on: https://dart-review.googlesource.com/c/89020
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-15 18:55:10 +00:00
Dan Rubel 21edbbbac6 Add spread collection token to scanner 
Change-Id: I1932d7c7fa6daba244ad2d93ddc7e2de18100fee
Reviewed-on: https://dart-review.googlesource.com/c/89600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-15 16:42:39 +00:00
Aske Simon Christensen ecc1411685 Print constant table when printing libraries. 
Change-Id: Ia474f3ddbe23be14d40789b0587ceeee92813106
Reviewed-on: https://dart-review.googlesource.com/c/89548
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-01-15 15:10:33 +00:00
Peter von der Ahé 999c2a7582 Check for conflict with static members 
Change-Id: I7966f2211104b54bfa4f2b026ad8a706d3f2bd6c
Reviewed-on: https://dart-review.googlesource.com/c/88956
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-01-15 14:41:04 +00:00
Peter von der Ahé 3f44bd1bf9 Check for conflicts in mixins 
Change-Id: I5443508d8454b2c903b65e253ecda223485787ad
Reviewed-on: https://dart-review.googlesource.com/c/88945
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-15 14:41:04 +00:00
Peter von der Ahé aa59b20b4b Don't report conflicts twice 
Change-Id: I9dca391da6a2afc747fcf73656ab0224201cb097
Reviewed-on: https://dart-review.googlesource.com/c/88943
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-15 14:41:04 +00:00
Peter von der Ahé 3ef8c296bd Improve detection of conflicts with inherited members and setters 
Change-Id: Ifb2fc2ca2e3d812a8e2a56e4fc43c8cfd02f15d5
Reviewed-on: https://dart-review.googlesource.com/c/88942
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-15 14:41:04 +00:00
Peter von der Ahé 50fa633c4a Report InheritedMembersConflict correctly 
Notice that no conflict is reported when an inherited
setter is in conflict with an inherited member. This is
implemented in a later CL.

Before we would only use InheritedMembersConflict when merging
interfaces, but as the new test cases demonstrate, that's not
sufficient.

Change-Id: I690dde1b59499d3ee0967b3f118b0b3b58898442
Reviewed-on: https://dart-review.googlesource.com/c/88941
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-15 14:41:04 +00:00
Kevin Millikin d9944433af [Kernel] Clean up error reporting in constant evaluation 
Make the constant evaluator take an explicit error reporter so we have
to opt in to using the "simple" one that reports errors in an ad hoc
way.  This is the start of a change to use Fasta-controlled error
messages throughout and eventually get rid of the simple error
handler, and to continue constant evaluation after the first constant
error.

Change-Id: If6b1801edab6063754b642cf4a603abf9d63103a
Reviewed-on: https://dart-review.googlesource.com/c/89501
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-01-15 11:34:42 +00:00
Peter von der Ahé 950b92104d Extract method reportInheritanceConflict 
Change-Id: Iea1808c45a1380feaf0c298c341f00c74cde7c57
Reviewed-on: https://dart-review.googlesource.com/c/88940
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-14 13:06:30 +00:00