Flip the default value of the Kernel syncAsync flag

In Kernel's TargetFlags, this flag still defaulted to false.  Flip the
default to true and update all client code in the SDK.  The
expectation is that many of the places that now pass false explicitly
really just want the default, but that will be verified separately and
then the flag will be removed.

Change-Id: I2a38eb53f280f21f59bb1d2e88c42516f827fd39
Reviewed-on: https://dart-review.googlesource.com/c/85448
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>

pkg/analyzer_fe_comparison/lib/src/kernel.dart

@@ -64,7 +64,7 @@ ComparisonNode _diagnosticMessageToNode(DiagnosticMessage message) {
 
 CompilerOptions _makeCompilerOptions(Uri packagesFileUri, Uri platformUri,
     DiagnosticMessageHandler onDiagnostic) {
-  var targetFlags = TargetFlags(syncAsync: true);
+  var targetFlags = TargetFlags();
   var target = NoneTarget(targetFlags);
   var fileSystem = StandardFileSystem.instance;
 

pkg/compiler/lib/src/kernel/loader.dart

@@ -69,7 +69,7 @@ class KernelLoaderTask extends CompilerTask {
         String platform = '${targetName}_platform.dill';
         initializedCompilerState = fe.initializeCompiler(
             initializedCompilerState,
-            new Dart2jsTarget(targetName, new TargetFlags()),
+            new Dart2jsTarget(targetName, new TargetFlags(syncAsync: false)),
             _options.librariesSpecificationUri,
             _options.platformBinaries.resolve(platform),
             _options.packageConfig);

pkg/compiler/tool/generate_kernel.dart

@@ -25,7 +25,8 @@ import 'package:kernel/target/targets.dart';
 main(List<String> args) async {
   ArgResults flags = _argParser.parse(args);
   var options = new CompilerOptions()
-    ..target = new Dart2jsTarget("dart2js", new TargetFlags(legacyMode: true))
+    ..target = new Dart2jsTarget(
+        "dart2js", new TargetFlags(legacyMode: true, syncAsync: false))
     ..packagesFileUri = Uri.base.resolve('.packages')
     ..setExitCodeOnProblem = true
     ..linkedDependencies = [

pkg/front_end/lib/src/base/processed_options.dart

@@ -290,8 +290,8 @@ class ProcessedOptions {
   bool get bytecode => _raw.bytecode;
 
   Target _target;
-  Target get target => _target ??=
-      _raw.target ?? new NoneTarget(new TargetFlags(legacyMode: legacyMode));
+  Target get target => _target ??= _raw.target ??
+      new NoneTarget(new TargetFlags(legacyMode: legacyMode, syncAsync: false));
 
   /// Get an outline component that summarizes the SDK, if any.
   // TODO(sigmund): move, this doesn't feel like an "option".

pkg/front_end/test/fasta/expression_test.dart

@@ -388,7 +388,7 @@ Future<Context> createContext(
   final List<DiagnosticMessage> errors = <DiagnosticMessage>[];
 
   final CompilerOptions optionBuilder = new CompilerOptions()
-    ..target = new VmTarget(new TargetFlags())
+    ..target = new VmTarget(new TargetFlags(syncAsync: false))
     ..verbose = true
     ..fileSystem = fs
     ..sdkSummary = sdkSummary

pkg/front_end/test/fasta/generator_to_string_test.dart

@@ -100,8 +100,11 @@ main() {
         new KernelTarget(
                 null,
                 false,
-                new DillTarget(null, null,
-                    new NoneTarget(new TargetFlags(legacyMode: true))),
+                new DillTarget(
+                    null,
+                    null,
+                    new NoneTarget(
+                        new TargetFlags(legacyMode: true, syncAsync: false))),
                 null)
             .loader,
         null,

pkg/front_end/test/fasta/incremental_hello_test.dart

@@ -35,7 +35,7 @@ void diagnosticMessageHandler(DiagnosticMessage message) {
 test({bool sdkFromSource}) async {
   final CompilerOptions optionBuilder = new CompilerOptions()
     ..packagesFileUri = Uri.base.resolve(".packages")
-    ..target = new VmTarget(new TargetFlags(legacyMode: true))
+    ..target = new VmTarget(new TargetFlags(legacyMode: true, syncAsync: false))
     ..legacyMode = true
     ..onDiagnostic = diagnosticMessageHandler;
 

pkg/front_end/test/fasta/messages_test.dart

@@ -461,7 +461,7 @@ class Compile extends Step<Example, Null, MessageTestSuite> {
         new CompilerOptions()
           ..sdkSummary = computePlatformBinariesLocation(forceBuildDir: true)
               .resolve("vm_platform_strong.dill")
-          ..target = new VmTarget(new TargetFlags())
+          ..target = new VmTarget(new TargetFlags(syncAsync: false))
           ..fileSystem = new HybridFileSystem(suite.fileSystem)
           ..onDiagnostic = messages.add,
         main,

pkg/front_end/test/fasta/super_mixins_test.dart

@@ -105,7 +105,7 @@ testEnabledSuperMixins() async {
   var missingSuperMethodNames = new Set<String>();
   var options = new CompilerOptions()
     ..onDiagnostic = _makeDiagnosticMessageHandler(missingSuperMethodNames)
-    ..target = new NoneTargetWithSuperMixins(new TargetFlags());
+    ..target = new NoneTargetWithSuperMixins(new TargetFlags(syncAsync: false));
   await compileScript(testSource, options: options);
   Expect.setEquals(
       const <String>['baz', 'foo', 'quux'], missingSuperMethodNames);

pkg/front_end/test/fasta/testing/suite.dart

@@ -291,8 +291,11 @@ class Outline extends Step<TestDescription, Component, FastaContext> {
       CompilerContext.current.disableColors();
       Component platform = await context.loadPlatform();
       Ticker ticker = new Ticker();
-      DillTarget dillTarget = new DillTarget(ticker, context.uriTranslator,
-          new TestVmTarget(new TargetFlags(legacyMode: legacyMode)));
+      DillTarget dillTarget = new DillTarget(
+          ticker,
+          context.uriTranslator,
+          new TestVmTarget(
+              new TargetFlags(legacyMode: legacyMode, syncAsync: false)));
       dillTarget.loader.appendLibraries(platform);
       // We create a new URI translator to avoid reading platform libraries from
       // file system.

pkg/front_end/test/fasta/unlinked_scope_test.dart

@@ -49,8 +49,11 @@ class MockLibraryBuilder extends KernelLibraryBuilder {
             new KernelTarget(
                     null,
                     false,
-                    new DillTarget(null, null,
-                        new NoneTarget(new TargetFlags(legacyMode: true))),
+                    new DillTarget(
+                        null,
+                        null,
+                        new NoneTarget(new TargetFlags(
+                            legacyMode: true, syncAsync: false))),
                     null)
                 .loader,
             null,

pkg/front_end/test/incremental_load_from_dill_test.dart

@@ -356,7 +356,8 @@ CompilerOptions getOptions(bool strong) {
   final Uri sdkRoot = computePlatformBinariesLocation(forceBuildDir: true);
   CompilerOptions options = new CompilerOptions()
     ..sdkRoot = sdkRoot
-    ..target = new VmTarget(new TargetFlags(legacyMode: !strong))
+    ..target =
+        new VmTarget(new TargetFlags(legacyMode: !strong, syncAsync: false))
     ..librariesSpecificationUri = Uri.base.resolve("sdk/lib/libraries.json")
     ..onDiagnostic = (DiagnosticMessage message) {
       if (message.severity == Severity.error ||

pkg/front_end/tool/_fasta/entry_points.dart

@@ -346,7 +346,7 @@ Future<List<Uri>> computeHostDependencies(Uri hostPlatform) async {
   // mode), this is only an approximation, albeit accurate.  Once Fasta is
   // self-hosting, this isn't an approximation. Regardless, strong mode
   // shouldn't affect which files are read.
-  Target hostTarget = getTarget("vm", new TargetFlags());
+  Target hostTarget = getTarget("vm", new TargetFlags(syncAsync: false));
   return getDependencies(Platform.script,
       platform: hostPlatform, target: hostTarget);
 }

pkg/front_end/tool/perf_common.dart

@@ -71,7 +71,7 @@ DiagnosticMessageHandler onDiagnosticMessageHandler({bool legacyMode: false}) {
 // legacyMode flag get merged, and we have a single way of specifying the
 // legacy-mode flag to the FE.
 Target createTarget({bool isFlutter: false, bool legacyMode: false}) {
-  var flags = new TargetFlags(legacyMode: legacyMode);
+  var flags = new TargetFlags(legacyMode: legacyMode, syncAsync: false);
   if (isFlutter) {
     return legacyMode
         ? new LegacyFlutterTarget(flags)

pkg/kernel/lib/target/targets.dart

@@ -22,7 +22,7 @@ class TargetFlags {
   TargetFlags(
       {this.legacyMode: false,
       this.treeShake: false,
-      this.syncAsync: false,
+      this.syncAsync: true,
       this.programRoots: const <ProgramRoot>[],
       this.kernelRuntime});
 }

pkg/vm/bin/kernel_service.dart

@@ -87,7 +87,7 @@ abstract class Compiler {
 
     options = new CompilerOptions()
       ..fileSystem = fileSystem
-      ..target = new VmTarget(new TargetFlags(syncAsync: true))
+      ..target = new VmTarget(new TargetFlags())
       ..packagesFileUri = packagesUri
       ..sdkSummary = platformKernelPath
       ..verbose = verbose

pkg/vm/test/common_test_utils.dart

@@ -32,7 +32,7 @@ Future<Component> compileTestCaseToKernelProgram(Uri sourceUri,
     {Target target, bool enableSuperMixins: false}) async {
   final platformKernel =
       computePlatformBinariesLocation().resolve('vm_platform_strong.dill');
-  target ??= new TestingVmTarget(new TargetFlags())
+  target ??= new TestingVmTarget(new TargetFlags(syncAsync: false))
     ..enableSuperMixins = enableSuperMixins;
   final options = new CompilerOptions()
     ..target = target

pkg/vm/test/incremental_compiler_test.dart

@@ -29,7 +29,7 @@ main() {
   final sdkRoot = computePlatformBinariesLocation();
   final options = new CompilerOptions()
     ..sdkRoot = sdkRoot
-    ..target = new VmTarget(new TargetFlags())
+    ..target = new VmTarget(new TargetFlags(syncAsync: false))
     ..linkedDependencies = <Uri>[platformKernel]
     ..onDiagnostic = (DiagnosticMessage message) {
       fail("Compilation error: ${message.plainTextFormatted.join('\n')}");

pkg/vm/test/transformations/type_flow/summary_collector_test.dart

@@ -49,7 +49,7 @@ class PrintSummaries extends RecursiveVisitor<Null> {
 }
 
 runTestCase(Uri source) async {
-  final Target target = new TestingVmTarget(new TargetFlags());
+  final Target target = new TestingVmTarget(new TargetFlags(syncAsync: false));
   final Component component = await compileTestCaseToKernelProgram(source);
   final Library library = component.mainMethod.enclosingLibrary;
   final CoreTypes coreTypes = new CoreTypes(component);

pkg/vm/test/transformations/type_flow/transformer_test.dart

@@ -18,7 +18,7 @@ import '../../common_test_utils.dart';
 final String pkgVmDir = Platform.script.resolve('../../..').toFilePath();
 
 runTestCase(Uri source) async {
-  final target = new TestingVmTarget(new TargetFlags());
+  final target = new TestingVmTarget(new TargetFlags(syncAsync: false));
   Component component =
       await compileTestCaseToKernelProgram(source, target: target);