dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

21307 Commits

Author SHA1 Message Date
Martin Kustermann a347973cb2 [vm/ffi] Fix function_gc_test to use correct native for joining a helper thread 
Change-Id: I1dd326f006254024914532ed2408949666749328
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112381
Reviewed-by: Clement Skau <cskau@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-08-09 08:32:50 +00:00
Johnni Winther b614253cdb Test CFE constants in side-effects test 
Change-Id: I720a4e1b574a19aebb93dfab17a372f987f2cb71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99153
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-08-09 07:11:52 +00:00
Mayank Patke af5a466e3b [dart2js] (Old RTI) Check function subtypes after checking for FutureOr. 
Change-Id: I7d2feab60295304377e48fddce901aea1c79ce19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112481
Reviewed-by: Stephen Adams <sra@google.com>
 2019-08-09 02:41:30 +00:00
Leaf Petersen 6d9c651fdd Fix typos in static_extension_internal_resolution tests. 
Fix #37791
Fix #37792

Change-Id: Id00f7e3eacb6c44ed1914ad0a5748bc800a80af4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112404
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-08 22:11:00 +00:00
Nicholas Shahan 8c834efae9 [dartdevc] Skip all tests on DDC for extension methods 
We expect to turn down DDC in favor of DDK before shipping extension methods so
they will never be implemented.

Change-Id: I4f4ddfbf37ccec965d53b21eac9223e75b87d93c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112420
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-08-08 22:00:22 +00:00
Alexander Thomas 17aa00cf91 [co19] Skip LayoutTests and WebPlatfromTest 
These tests test the browsers more than Dart. They are outdated, flaky,
and, therefore, often ignored by the teams working web technologies.

This CL Skips them pending their removal in an upcoming co19 roll.

Change-Id: I0646fbcbd06ea9ea4d74ec07149bfe3b8011a57d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112344
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2019-08-08 18:59:09 +00:00
Martin Kustermann a3f5dfc5ec [vm/gardening] Disable isolate/ping_pause_test 
Issue https://github.com/dart-lang/sdk/issues/37787

Change-Id: I2fb6c329ab4ba06136e2b8564440c4dcbb0045ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112348
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-08-08 15:36:43 +00:00
Samir Jindel b12e2ce0b4 [vm] Make FFI code protection test wait for helper to terminate before continuing. 
Addresses https://github.com/dart-lang/sdk/issues/37779

Change-Id: I3ee7ec890be9c859737e8676a00047e46643e050
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112258
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-08-08 10:07:42 +00:00
Leaf Petersen d2048763d4 Add tests of internal extension method resolution. 
This adds tests verifying expected error and non-error cases for
resolution of symbols referenced from inside of the definition of an
extension method or a class, which have overlapping definitions in
various different scoping levels.

Change-Id: I753cc80c0dfdefb3e44429e8bb085c8af3ceb685
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111882
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-08-07 23:20:56 +00:00
Leaf Petersen 7b46191f45 Remove incorrect super bounded test, and add tests for bounds 
violations in extension method applications.

Fix #37765

Change-Id: I26d286251b0e832577dc170b9a41594c52e25377
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112149
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-07 19:36:24 +00:00
Samir Jindel 9b5abe523f Re-land "[vm/ffi] Enable creating an ExternalTypedData from a Pointer." 
Changes from original:

- Finalize the specific ExternalTypedData class before allocating.
- Add new import to all FFI patch files to not depend on the order the patch files
  are applied.

Original CL is in patchset 1.

Change-Id: I85c5e0d8bce15d8120575b6dbaae311c64aa6ec2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112242
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2019-08-07 13:10:30 +00:00
Samir Jindel e59a4a2b42 [vm/ffi] Call natives through stubs if write-protection is enabled without dual-mapping. 
Addresses the Dart -> Native half of dartbug.com/37629

Change-Id: I242b7f3a14dd105334a8b6e5c089b173c398491e
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111280
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-08-07 11:37:20 +00:00
Mayank Patke 8740bb5c68 [dart2js] New RTI tests for generic functions. 
Change-Id: I583cbe3929308746db3f526da71cd1f158d176f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111992
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-08-07 04:16:57 +00:00
Robert Nystrom 0400e4695b Update tests/README to point to new doc. 
Change-Id: I353d9a4a5a81a2dbd8b55839a0760f1ec78a418a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112120
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-08-06 22:19:42 +00:00
Leaf Petersen 1aa98e5dc6 Fix incorrect getter names in basic_static_extension_test and 
static_extension_inference_test .

Fix #37763
Fix #37764

Change-Id: Ibf25b55ba9357c6b0de33e8c20af3f9e1f2e45d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112143
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
 2019-08-06 21:46:17 +00:00
Ben Konyi c262cbd414 Revert "[vm/ffi] Enable creating an ExternalTypedData from a Pointer." 
This reverts commit ddd83d256f.

Reason for revert: Causing build failures in the Flutter engine, blocking the SDK roll. Build error:

org-dartlang-sdk:///third_party/dart/runtime/lib/ffi_patch.dart:76:3: Error: Type 'TypedData' not found.
  TypedData asExternalTypedData({int count: 1}) =>
  ^^^^^^^^^



Original change's description:
> [vm/ffi] Enable creating an ExternalTypedData from a Pointer.
> 
> Fixes dartbug.com/37738
> 
> Change-Id: I65c6741978d36cd1c255039a4dd8a06190ea4366
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111736
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Daco Harkes <dacoharkes@google.com>

TBR=vegorov@google.com,sjindel@google.com,dacoharkes@google.com

Change-Id: I90a9cb5e2894c0bc064e620cef0a0f51505ac05d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112047
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-08-06 19:52:11 +00:00
Aart Bik 193985777d [vm/compiler] Propagate call type to load indexed 
Rationale:
AOT's TFA sometimes knows a bit more about the result
type of a call that is later recognized as an indexed
load. This CL preserves that type for later use, improving
decision on operations that consume this load.

https://github.com/dart-lang/sdk/issues/37719

Change-Id: I5f88e03b68b4f7aec6e39a8ca94f243c2796730d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112028
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-08-06 19:28:29 +00:00
Samir Jindel ddd83d256f [vm/ffi] Enable creating an ExternalTypedData from a Pointer. 
Fixes dartbug.com/37738

Change-Id: I65c6741978d36cd1c255039a4dd8a06190ea4366
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111736
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-08-06 15:38:27 +00:00
Leaf Petersen 6f551f040b Fix a few extension method test bugs. 
Fixes https://github.com/dart-lang/sdk/issues/37749 .
Fixes https://github.com/dart-lang/sdk/issues/37748 .

Change-Id: I31f32964b33679e09d5a71ac39cc51343c0384d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112030
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
 2019-08-05 23:14:07 +00:00
Sam Rawlins 2bf13fd058 Add a language test for Object().runtimeType. 
Fixes #15917

Change-Id: I4dd00385ba84f4c65ec0c0e2a9b0a4f6748d1396
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111963
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-08-05 17:27:57 +00:00
Stephen Adams 6ff32127f4 Redo "[dart2js] new-rti: Add 'minified:' tag to minified names" 
This reverts commit ac6a3d9369.

Change-Id: Ia8c9bde36e21ad12e9cd08c688043d4b08ae35e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111873
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2019-08-03 01:42:50 +00:00
Ryan Macnak d08c203e30 Add various missing argument checks to dart:io natives. 
Avoid reflective access to mirrors creating invalid reflectees.

Change type checks in embedding API functions to return UnhandledExceptionErrors instead of APIErrors so they are catchable by Dart.

Fixes invocation_fuzz_test.

Bug: https://github.com/dart-lang/sdk/issues/15274
Bug: https://github.com/dart-lang/sdk/issues/23869
Bug: https://github.com/dart-lang/sdk/issues/37680
Change-Id: Ife3e3cb894c59620b0318e4e08947a3d1d45bab9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110620
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-08-01 23:32:40 +00:00
Johnni Winther 972d4e9a75 [cfe] Move relativize code from dart2js to cfe 
Change-Id: I2e07dcf91adf65965583189972b0c27cc0aee526
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111427
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-08-01 21:07:50 +00:00
Ryan Macnak b66cd42372 [vm] Fix deadlock in isolate shutdown, take 2. 
Enter a safepoint when waiting for child isolate spawns to complete, since the child isolate now requires its parent (along with all other members of the isolate group) to participate in safepoints.

Adjust shutdown of ThreadPool isolates to re-enter the isolate before waiting for outstanding spawns.

Bug: https://github.com/dart-lang/sdk/issues/37679
Change-Id: I760c0f75b77a3884ac3f4757f0c6920a417f3453
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111524
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-08-01 19:04:11 +00:00
Nicholas Shahan 6cec64691b [dartdevc] Remove variance from type bounds in generic function subtypes 
As I understand in early versions of strong mode generic function subtypes could
have contra-variance in the bounds of the type parameters. Now the spec states
they must be equal.

Fixes #36501

Tested and passing with the fixed language_2/generic_function_bounds_test
https://dart-review.googlesource.com/c/sdk/+/109726

Change-Id: Ie11d6318a542867e0541d81e2a18e5e25d3f0d9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110361
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-08-01 19:00:06 +00:00
Stephen Adams 5456641022 More canonicalization_hashing tests 
These behave poorly on dart2js.

Change-Id: I15f73dce79912151e172038932dbedf5dd725530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110640
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-08-01 18:03:56 +00:00
Jens Johansen a69c81ac34 Id testing for directories with .packages etc 
We should also be able to test for larger examples, so this CL adds
support for directories where all files are included. If the directory
contains a .packages file that is used so we can test packages too.

Change-Id: Iceda03505575bd9e5604a6e374b7f5fa7185a82e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111421
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-01 09:25:28 +00:00
Jens Johansen d49de8b68f succinct option for id testing 
Add a "-s" (succinct) option to have a more dense output.
Meant for use together with "-a" so one can get a quick overview of how
many tests fail, e.g.
out/ReleaseX64/dart pkg/front_end/test/id_testing/id_testing_test.dart -a -s

Change-Id: I9e1d91694be76e6c66bf0f3c9168783f920a5bf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110914
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-01 09:25:28 +00:00
Alexander Markov 99d7701004 [gardening] Skip timing out co19_2/LibTest/isolate tests on dartkb bots 
These tests result in flaky timeouts and cause infra timeouts on
vm-dartkb-linux-debug-simarm64 bot, so skipping them until the timeout is fixed.

Issue: https://github.com/dart-lang/sdk/issues/37699
Issue: https://github.com/dart-lang/sdk/issues/37679

Change-Id: Iece10ba248319deb0cc8506274dd5d2e785003fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111522
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-07-31 23:26:21 +00:00
Vijay Menon 2390a25341 [dartdevc] emit base types (void/dynamic) eagerly 
This is a somewhat roundabout way to prevent a hot restart from redefining these types.
This fixes the issues arising: https://github.com/dart-lang/sdk/issues/37259.
Should more cleanly separate fields reset on a hot restart from ones preserved.

Change-Id: Id0c45cbeed67b574c3259e1f87a405137ae93575
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111315
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2019-07-31 16:04:34 +00:00
Aart Bik 361d27e20b [dart/vm] Fix bug in parallel move/register allocator 
Rationale:
Another one bites the dust due to fuzzing! The attached
small reproducer assert failed in debug and crashed
in release due to "any" allocation in the parallel move.

https://github.com/dart-lang/sdk/issues/37633

Change-Id: Ie9044cb7fa86dfdb1ba312599f57db76bec47611
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110540
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2019-07-30 20:42:05 +00:00
Teagan Strickland f822dfa3ea Reland "[vm/compiler] Implement new inlining pragmas." 
This change introduces two new pragmas:

* `@pragma('vm:never-inline')`
* `@pragma('vm:prefer-inline')`

These replaces the old way of specifying AlwaysInline or NeverInline
annotations when the (now removed) --enable-inlining-annotations flag
was used.

Bug: https://github.com/dart-lang/sdk/issues/36571
Change-Id: Iee152c1d67abde8d58c58fa967449d36e77c8c93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110440
Commit-Queue: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-07-30 12:01:06 +00:00
Clement Skau 50c68d1f30 [Test] Fixes flaky racing in lib_2/isolate/spawn_uri_test. 
This is similar to https://dart-review.googlesource.com/c/sdk/+/108410.

Prior to this fix, the test was running at ~3% flaky locally:
  ~> tools/test.py -n dartk-optcounter-linux-release-x64 lib_2/isolate/spawn_uri_test --repeat=100

Change-Id: I7d6422eaf5e56ec8fbe0c287da12b19bf13716db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110913
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-07-30 10:26:46 +00:00
Stephen Adams 4b35a044c9 [dart2js] new-rti: Make all closures have class type 'Closure' 
Change-Id: I6713449b61a717907a5f8eac8fa3e2bea7e11ddd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111202
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2019-07-30 01:29:47 +00:00
Mike Fairhurst 2f96be9ee3 [analyzer] Allow references of 'this' in late field initializers 
Change-Id: Ic464a1d8402404ca79f2281780bf3d408bbb948a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110550
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-07-29 20:23:03 +00:00
Stephen Adams 73cbfd3826 [dart2js] new-rti: Emit new rti for constants 
Change-Id: Ia4b5f55a4836d02d79b8c01cb68b6d23fb3cdc3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110940
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-29 20:17:03 +00:00
Clement Skau bdec682558 [Test] Fixes flakiness in spawn_function_test caused by racing. 
Previously the test would create and run an isolate, then checking the debugName of the isolate.
However, if the isolate ran to completion and got collected before the check happened, the debugName would be null, causing the test to fail.

The test was running at about 1.5% flakiness when run locally before.
With the change no flakiness was observed across several couple hundred runs.

Tested:
    tools/test.py -n dartk-optcounter-linux-release-x64 \
        lib_2/isolate/spawn_function_test --repeat=1000
Change-Id: I0aea6bbae08fbe321e1bea7301655ad06ec3dcd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108410
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2019-07-29 10:24:58 +00:00
Mayank Patke 05fdac2769 [dart2js] Support optional named parameters in function RTI. 
Change-Id: I985f1e75ddf118c029704789791432d167d26b74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110765
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-07-27 00:33:27 +00:00
Brian Wilkerson 1d14f239b0 Fix one of the language tests 
The identifier `in` is a reserved word and hence cannot be used as a variable name.

Change-Id: I557430e1f87573d19bfb22d7c09120139baa3731
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110581
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-07-26 17:59:43 +00:00
Johnni Winther 78224f9b0c [cfe+analyzer+dart2js] Support union markers in id-testing 
Supports markers like `cfe|analyzer.` to annotated that the expected
result is for both `cfe` and `analyzer`.

Change-Id: Ie69809db5f63a9ee9b87ff1513b819fe85ce0bce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110500
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-26 17:18:01 +00:00
Johnni Winther bcfe26cba0 [cfe] Fail early on unsupported evaluated constants 
The many different entrypoints to the CFE have repeatedly shown problems
with targets that do not support unevaluated constants being used
without providing an environment.

Making the targets opt-in to supporting unevaluated constants will
give the users of CFE early notice that CFE is used inconsistently
(as opposed to the backends failing when they happen to see an
UnevaluatedConstant node that they don't support).

Change-Id: I98c80df3a551823598e413e2895f5649f22f7c22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110561
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-26 16:57:51 +00:00
Nicholas Shahan 0ca1582afd Revert "[dartdevc] Temporarily skip const stress tests in DDK" 
This reverts commit 8fb4240bcb.

Reason for revert: Fix has been merged.
https://dart-review.googlesource.com/c/sdk/+/109640/16

Original change's description:
> [dartdevc] Temporarily skip const stress tests in DDK
> 
> Revert this change once fixes have landed for DDK.
> 
> Issue: #37523
> Change-Id: I2855c647ceb5b9831466d8da458e6e7bcd810ee9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110543
> Auto-Submit: Nicholas Shahan <nshahan@google.com>
> Commit-Queue: Nicholas Shahan <nshahan@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>

TBR=vsm@google.com,nshahan@google.com

Change-Id: Iace2084460eb42b0ebe05f72b8511c16fc1b28a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Issue: #37523
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110600
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-07-25 23:50:46 +00:00
Mike Fairhurst db25ef8a9c Report unnecessary ! 
Change-Id: Ie5fbe1e7697c2911eb9ff931bcf5d2e1cef9d171
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108944
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-25 21:45:09 +00:00
Paul Berry 8b24e21980 Rename extension methods syntax test so that it actually runs. 
The test infrastructure only runs tests whose name ends in "_test.dart".

Change-Id: I42bde31cf49318b87c270b4df9cc71fd9b89999c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110460
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-07-25 20:23:10 +00:00
Ryan Macnak 938d3be958 Revert "Add various missing argument checks to dart:io natives." 
This reverts commit ba72890aa7.

Reason for revert: Crash in bytecode modes

Original change's description:
> Add various missing argument checks to dart:io natives.
> 
> Change type checks in embedding API functions to return UnhandledExceptionErrors instead of APIErrors so they are catchable by Dart.
> 
> Fixes invocation_fuzz_test.
> 
> Bug: https://github.com/dart-lang/sdk/issues/15274
> Bug: https://github.com/dart-lang/sdk/issues/23869
> Change-Id: Ia6103e7ffceda897e475c1a3ba534c2f4b910475
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110020
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=sortie@google.com,rmacnak@google.com,asiva@google.com

Change-Id: Ib52ec03caf4b177cd91bb1d366df51588bf23177
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/15274, https://github.com/dart-lang/sdk/issues/23869
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110580
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-07-25 19:18:23 +00:00
Nicholas Shahan 8fb4240bcb [dartdevc] Temporarily skip const stress tests in DDK 
Revert this change once fixes have landed for DDK.

Issue: #37523
Change-Id: I2855c647ceb5b9831466d8da458e6e7bcd810ee9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110543
Auto-Submit: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-07-25 19:01:37 +00:00
William Hesse f771a1f978 Skip deep constant nesting test on Windows dart2js. It crashes infrastructure. 
Bug: https://github.com/dart-lang/sdk/issues/37631

These tests cause the dart2js batch mode compiler process
to resist termination somehow on Windows, which locks the dart.exe executable
and prevents sharding task cleanup.

Change-Id: Ica19e9d262f0b5b97c263205ba6fac030a3bedb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110444
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-07-25 17:17:45 +00:00
Leaf Petersen b74ae33406 Fix various issues with a generic method test 
Fix various issues with language_2/generic_function_bounds_tests,

including:
  - Overly specific expectations on print formats of types
  - Outdated expectation of contra-variance for generic method bounds
Change-Id: I5135a743cc58773af144b2d9e6685667c9be7d41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109726
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-25 16:43:52 +00:00
Ryan Macnak ba72890aa7 Add various missing argument checks to dart:io natives. 
Change type checks in embedding API functions to return UnhandledExceptionErrors instead of APIErrors so they are catchable by Dart.

Fixes invocation_fuzz_test.

Bug: https://github.com/dart-lang/sdk/issues/15274
Bug: https://github.com/dart-lang/sdk/issues/23869
Change-Id: Ia6103e7ffceda897e475c1a3ba534c2f4b910475
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110020
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-07-25 16:40:04 +00:00
Clement Skau a2aec5eb06 [test] Deflakes, un-excepts http_close_test. 
http_close_test was given a test exception in issue 28380.

This CL adds Expects to check for the expected number of error
on both server and client in testClientCloseWhileSendingRequest.
It also moves the server.close() into the server error handler
to make sure we don't flakily close the server before all requests
are fully sent and received in both ends.
This should get rid of:
HttpException: Connection closed while receiving data, uri = /
  #0      _HttpIncoming.listen [...]

The modified test has been unflaky across a few hundred test runs
locally.

A few lints were also fixed in the process such as 'unnecessary new'.

Bug: https://github.com/dart-lang/sdk/issues/28380
Change-Id: I3470f70f7965c34f73da71489511e1cb2d1b7e42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109964
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-07-25 08:27:34 +00:00