dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

21307 Commits

Author SHA1 Message Date
Johnni Winther bae176b073 [cfe+dart2js] Add shared constant evaluation test. 
Change-Id: I11fa0f576c5d177d85d3c17cfa075b7dd91326b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108604
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-07-11 10:49:23 +00:00
Johnni Winther fdd3822e3c [cfe+dart2js] Move annotation testing logic to front_end 
Change-Id: Ic53c3d34d5c56232ac011e99972ef8f145aac6da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108602
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-07-11 10:49:23 +00:00
Lasse Reichstein Holst Nielsen 84c7929c1f Small fixes. 
Fix typo in test, add @Since markers to new constructors.

Change-Id: I31abbf41049a3d5820d82165ab16ce8357c79132
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108722
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-11 10:39:03 +00:00
Lasse R.H. Nielsen ac41a20081 Update language_2/nested_generic_closure_test.dart. 
No longer depends on the unspecified `Type.toString`.

Bug: http://dartbug.com/37452
Change-Id: Ie7eeeecdc8970831082e763edc46f195a8bfc7e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108275
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-07-10 09:46:41 +00:00
Daco Harkes 52858391e6 [frontend/ffi] Remove const Pointer() 
Fixes: https://github.com/dart-lang/sdk/issues/37396

Change-Id: I6f53360297a3e1c9cc505c6f781cd5c55a041c6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108415
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-07-10 07:52:41 +00:00
Mike Fairhurst 449b799c21 Test that null cannot be used because its potentially nullable 
Change-Id: I344157c31225f92f1a8a931b9ffe23feebcb15de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102500
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2019-07-09 22:05:15 +00:00
Stephen Adams 803658a6d8 [corelib_2] fix bigint_from_test for web platforms 
Change-Id: Ib97814ba6b30822296c24026ddcd09f119508ed7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108422
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-09 18:25:52 +00:00
Vyacheslav Egorov 5479175012 Remove incorrect test. 
Symbol constructor can't be used to create symbols for private names.

Closes https://github.com/dart-lang/sdk/issues/34377
Closes https://github.com/dart-lang/sdk/issues/30848
https://github.com/dart-lang/sdk/issues/36433
https://github.com/dart-lang/sdk/issues/34904

Change-Id: Ibe551c43a9209e1f483cea8178665890d52799aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108416
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2019-07-09 17:32:29 +00:00
Lasse R.H. Nielsen 25319ef7a6 Fix bug in codegen/string_escapes_test.dart. 
Both a bug in the framework and the test not mathcing the current specification
of multiline strings.

Fixes #33060

Bug: http://dartbug.com/33060
Change-Id: I8937c768f560d119cb16f3684d9407db2ab04c35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108408
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-09 13:56:32 +00:00
Samir Jindel 7acecda2cc [vm/ffi] Fix FFI Utf8 example. 
Change-Id: Ic6c93c94f1187595b0dab2c912ebf4851ac85fe5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108406
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-07-09 11:37:44 +00:00
Stephen Adams bfc7d21da6 Remove useless dart2js_extra/class_test 
TBR=johnniwinther@google.com

Change-Id: I2c6b08f139e3404961a91166d6f2393e935ccd0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108368
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-08 23:27:12 +00:00
Siva Annamalai 06c3d7ad3a Revert "Rereland "[vm/ffi] SimDBC on Arm64 Android"" 
This reverts commit 9bccb7ba4a.

Reason for revert: This continues to cause failures in the Flutter engine builds. The latest error is
ERROR: /b/s/w/ir/k/src/out/ios_release/Flutter.framework/Flutter exports unexpected symbols:
     (__TEXT,__text) _FfiTrampolineCall

Original change's description:
> Rereland "[vm/ffi] SimDBC on Arm64 Android"
> 
> Fixed iOS Flutter build.
> 
> Change-Id: Id585dea5286e776bb0f333296ac99ef634d61e7d
> Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try, app-kernel-linux-debug-x64-try, vm-kernel-linux-debug-simdbc64-try,vm-kernel-mac-debug-simdbc64-try,vm-kernel-reload-mac-debug-simdbc64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108262
> Reviewed-by: Samir Jindel <sjindel@google.com>
> Commit-Queue: Daco Harkes <dacoharkes@google.com>

TBR=sjindel@google.com,asiva@google.com,dacoharkes@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ieb5a2a2960e214ee48a2375e88211d2792b0fff9
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try, app-kernel-linux-debug-x64-try, vm-kernel-linux-debug-simdbc64-try, vm-kernel-mac-debug-simdbc64-try, vm-kernel-reload-mac-debug-simdbc64-try, vm-kernel-linux-debug-ia32-try, vm-dartkb-linux-debug-simarm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108421
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-07-08 21:38:48 +00:00
Todd Volkert cab2ca275d Update Socket to be a Stream<Uint8List> 
Bug: https://github.com/dart-lang/sdk/issues/36900
Change-Id: I600c28aebbe35f9e650f969adf356dda4eb0cacd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104524
Commit-Queue: Todd Volkert <tvolkert@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-08 16:42:47 +00:00
Lasse R.H. Nielsen aee65636ba Add constructors to Stream which creates single data or error event streams. 
Change-Id: I3f570b15d29601a488dc634ab3cc563783868ac2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108102
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-07-08 13:38:54 +00:00
Samir Jindel 33a5745c49 [vm/ffi] Add missing free() to structs_test.dart 
Fixes crash on ASAN bot.

Change-Id: I70d0cc863b86c40d5c5c15841ecbbf2a91493e6c
Cq-Include-Trybots: luci.dart.try:vm-kernel-asan-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108273
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-07-08 09:08:51 +00:00
Samir Jindel fcc72ad83f [vm/ffi] Support FFI in AOT (excluding callbacks). 
Move generation of Function objects for native trampolines to the Precompiler, so they can be generated during AOT and tree-shaken if possible.

Issue dartbug.com/35765

Change-Id: I0e69b7e0b22db73e3a40f2fe445660e57ddb6fa9
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-bare-linux-release-simarm64-try, vm-kernel-precomp-bare-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-dartkb-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107407
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-07-05 21:59:27 +00:00
Stephen Adams f0d6f119de Make nested_generic_closure_test work for dart2js 
Change-Id: I07fa89b184cd542ebd028dbf70279ee6d64cd1cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107834
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-05 21:05:07 +00:00
Stephen Adams 0a538a4e62 Avoid truncating shift in lib_2/math/low_test 
Change-Id: I7902c0839663775abb94c3e2dcfee14ac8e4beb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108281
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-05 19:47:47 +00:00
Stephen Adams 8673b5e491 Avoid non-web-integer literals in corelib_2/num_sign_test 
Change-Id: I756ef8129b0e1c7024833fb98ed96eea987dbb59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108280
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-05 19:43:47 +00:00
Stephen Adams f0da490328 Avoid non-web integer literal in corelib_2/growable_list_test 
dart2js will now fail with an unchecked ConcurrentModificationError.

Change-Id: I54ddc4198538f4b9276ef0f4692fd74590a38135
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108240
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-05 15:52:47 +00:00
Stephen Adams 7b13c45bcc Fix negation precedence and non-web-integers in corelib_2/int_xxx_tests 
Change-Id: Ia464ac9c33e19483559abc600e8933aad0499fb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108163
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-05 14:23:56 +00:00
Paul Berry c0932a8af6 Move annotated_code_helper.dart into front_end. 
This avoids the need for the analyzer to depend on the unpublished
package sourcemap_testing.

Change-Id: I7632df2028d4f3557d2c5c4a3a75510cda968efd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108268
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-05 11:40:25 +00:00
Stephen Adams f41d6de111 [corelib_2] Split date_time_test to increase coverage 
After moving ~175 lines to other files, the remaining ~1200 lines of
tests in date_time_test.dart passes on dart2js.


Change-Id: Id8366b90083c22f71e5ff2e3f36ac1f0358ec8e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108220
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-04 15:16:55 +00:00
Daco Harkes 9bccb7ba4a Rereland "[vm/ffi] SimDBC on Arm64 Android" 
Fixed iOS Flutter build.

Change-Id: Id585dea5286e776bb0f333296ac99ef634d61e7d
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try, app-kernel-linux-debug-x64-try, vm-kernel-linux-debug-simdbc64-try,vm-kernel-mac-debug-simdbc64-try,vm-kernel-reload-mac-debug-simdbc64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108262
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2019-07-04 13:20:05 +00:00
Johnni Winther 4ceefdbe4c Rename ElementId to MemberId and use member: prefix instead of element: 
Change-Id: I71c82318357881230edcaeefe1d86ceb50473c73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108261
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-04 12:53:55 +00:00
Johnni Winther aeee6139f5 [cfe] Extract Id, DataRegistry and DataExtractor from dart2js 
This is a step towards sharing tests based on annotated code between
the CFE and the analyzer.

Change-Id: Ia0f4b78717042af5544d92b0a259d6693547e722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108260
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-07-04 12:53:55 +00:00
Stephen Adams 0272c1d863 Split language_2/truncdiv_test 
Move zero case out to increase coverage of non-zero cases.

Change-Id: Iaa3a1dbe1fc952bcccb16dca2f6543a9d367d61c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107826
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Auto-Submit: Stephen Adams <sra@google.com>
 2019-07-04 07:58:05 +00:00
Stephen Adams 4babccd988 Fix non-web integer literals in corelib_2/bigint_test 
Change-Id: I9cb66de2db293a033073ced7e6b9e3d19a1f3fb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108204
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-07-04 02:49:29 +00:00
Stephen Adams 738d9f9666 Avoid non-web integer literal in language2/list_test 
Change-Id: I926dc7b9e9eabd098c4561ea95e1e3568522902f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107922
Commit-Queue: Stephen Adams <sra@google.com>
Auto-Submit: Stephen Adams <sra@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-07-04 01:01:26 +00:00
Siva Annamalai b5aeaa6796 Revert "Reland "[vm/ffi] SimDBC on Arm64 Android"" 
This reverts commit a515a0c256.

Reason for revert: There are still issues here, the flutter engine build for ios_debug again fails with this error:
ld: warning: arm64 function not 4-byte aligned: FfiTrampolineCall from obj/third_party/dart/runtime/vm/compiler/libdart_vm_jit.ffi_dbc_trampoline_arm64.o
ld: warning: arm64 function not 4-byte aligned: .loop from obj/third_party/dart/runtime/vm/compiler/libdart_vm_jit.ffi_dbc_trampoline_arm64.o
ld: warning: arm64 function not 4-byte aligned: .done from obj/third_party/dart/runtime/vm/compiler/libdart_vm_jit.ffi_dbc_trampoline_arm64.o
Undefined symbols for architecture arm64:
  "_FfiTrampolineCall", referenced from:
      dart::Simulator::Call(dart::Code const&, dart::Array const&, dart::Array const&, dart::Thread*) in libdart_vm_jit.simulator_dbc.o
ld: symbol(s) not found for architecture arm64

Original change's description:
> Reland "[vm/ffi] SimDBC on Arm64 Android"
> 
> This reverts commit 0abff7b2bb and fixes the assembly file.
> 
> Change-Id: Ibef58c932c843aebb4de227ac5fc7664d463173f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107746
> Auto-Submit: Daco Harkes <dacoharkes@google.com>
> Reviewed-by: Samir Jindel <sjindel@google.com>
> Commit-Queue: Daco Harkes <dacoharkes@google.com>

TBR=sjindel@google.com,asiva@google.com,dacoharkes@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia5fd52180f7d9dfce588db361ce17dfb6f05254d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108206
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-07-04 00:57:23 +00:00
Stephen Adams 02fe07bbd3 [dart2js] new-rti: Set Array instance type 
TBR=fishythefish@google.com

Change-Id: I6268ae5c67ef0e3632e6c46cc7f17a72b2ca4964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108020
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-04 00:29:28 +00:00
Stephen Adams 327f5eb826 Fix for issue 37429 
Fix by not tracking very large or negative sizes.

TBR=johnniwinther@google.com

Bug: 37429
Change-Id: Ibb3c7499f0afaec8cbb9398f780294ad0befeab2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108202
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-03 22:24:57 +00:00
Konstantin Shcheglov 2ea7e5513b Perform type promotion when NNBD, using flow analysis. 
Mostly just implementing existing interface LocalVariableTypeProvider,
and moving type promotion tests into a separate file.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: If864cb2c300f01a152f40c51cffa7f17028ad200
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-03 20:33:08 +00:00
Stephen Adams c100308ba6 Repro for inferring arrays with out of range lengths 
See https://github.com/dart-lang/sdk/issues/37429

We will change the bogus number(s) to something better when the bug is fixed.

TBR=johnniwinther@google.com

Change-Id: Ibcc085a14770acd61ac2bb596910254a6f2f3219
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108060
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-03 18:30:21 +00:00
Stephen Adams 052874e93e Avoid non-web integer literal in corelib_2/int_round_test 
Also fix precedence bug.

Change-Id: I4b4746e0adfd0ff354d85519665ae23742f8703a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107838
Auto-Submit: Stephen Adams <sra@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-03 16:20:07 +00:00
Alexander Thomas 744bb47361 [infra] Remove custom timeouts for dart2js compiler config 
These were probably added in Dart 1 because --checked carried a much
higher performance penalty. Today, most tests finish within 1 minute. If
certain configs need longer timeouts these should be specified in the
named configuration in test_matrix.json.

Change-Id: I91c456475971059297e16b9902dc16c2b23f9c9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107880
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2019-07-03 12:48:47 +00:00
Samir Jindel fc6cb0ac21 [vm/ffi] Revamp struct representation in FFI. 
See dartbug.com/37229 for details.

Change-Id: I63490e41c512ffc9312803985a6f6d4be1586c0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101291
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-07-02 23:12:13 +00:00
Stephen Adams 1f02c10b9a Update language_2/const_map4_test for type inference 
Change-Id: Id81d974b0889e7c469ed40c85955f9b18265c634
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107927
Auto-Submit: Stephen Adams <sra@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-02 19:23:18 +00:00
asiva 182a59cebb Skip all tests that use spawnUri when running in simulator mode as it makes no sense to run the CFE on the simulator. 
Change-Id: Ie3457e67fe4ddb3170bf4654effdc5b21dff2450
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107942
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-07-02 17:32:23 +00:00
asiva 585794ab75 Fix status file line. 
Change-Id: Idf62118cda425ea0e56439dd78515a1e9de4d2bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107940
Auto-Submit: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2019-07-02 15:49:15 +00:00
asiva 4a69ef4a50 Skip all spawnURI tests for the simulator architectures as these tests involve invoking the front end for compilation which would mean the front end has to run in simulated mode. 
Change-Id: Idce29ff924fb88c909e0faf2dc1107506659dc6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107832
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2019-07-02 15:06:37 +00:00
Stephen Adams 822de210b5 fix branch_canonicalization_test 
Change-Id: Icd26e9edf3dbf513c614743a97c696ed88df00db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107570
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-07-02 06:15:02 +00:00
Stephen Adams 90c88d984e Fix large integer literals in dart2js_extra/round_constant_folding_test 
Change-Id: Idf09515e7d31c1e778c8fa99c94d40e9939d286f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107831
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-02 00:14:40 +00:00
Stephen Adams 1db0b4436c [dart2js] new-rti: Implement type bounds check 
TBR=fishythefish@google.com

Change-Id: Id6978b8453de639fa403436487edb849e4074206
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107681
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-01 20:52:59 +00:00
Stephen Adams ca4b6e533a [dart2js] new-rti: Implement basic is-test 
Also add a few more type literal tests.

TBR=fishythefish@google.co,

Change-Id: Iab5ca4a5f8d224f67deaf1fe391e17ece46bde59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107600
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-01 19:12:20 +00:00
Lorenz Nickel 79e478e50e Fixed some links 
**I fixed some links and some other minor flaws.**

I also found the following outdated links, which I didn't fix:

- [This link](https://github.com/dart-lang/pool/tree/zone.strong) in [this file](https://github.com/dart-lang/sdk/blob/master/docs/newsletter/20170728.md) (didn't fix because don't know new location and this is some sort of archive so the link should probably stay the original)
- [This link](https://www.dartlang.org/tools/analyzer) in [this file](https://github.com/dart-lang/sdk/blob/master/pkg/analyzer_cli/lib/src/options.dart) (didn't fix since the link is still working, it just gets redirected and the link is part of the programm, I don't want to break anything by changing it, all other links are in comments)
- [This link](https://github.com/domokit/mojo/issues/728) in [this file](https://github.com/dart-lang/sdk/blob/master/build/config/compiler/BUILD.gn) (didn't fix since probably has no new location and is part of TODO, which I don't want to change)

While doing all this I also noticed that [these tests](https://github.com/dart-lang/sdk/tree/master/tests/compiler/dart2js_extra) contain a lot of other inconsistencies in their comments and the location of the import-statements (I only fixed one which was not link-related), could be target of another PR.

Closes #36927
https://github.com/dart-lang/sdk/pull/36927

GitOrigin-RevId: 71d05d0b52d8ec5b92d077a070e066d1fdd4bbfa
Change-Id: Ide4b2424fccad8ae2e06c788efd4443dc0de997b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102222
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2019-07-01 16:21:41 +00:00
Daco Harkes a515a0c256 Reland "[vm/ffi] SimDBC on Arm64 Android" 
This reverts commit 0abff7b2bb and fixes the assembly file.

Change-Id: Ibef58c932c843aebb4de227ac5fc7664d463173f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107746
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2019-07-01 13:55:02 +00:00
Stephen Adams 000cf0560c clean up type_literal_test 
TBR=leafp@google.com

Change-Id: Id8eebf4893103b187e981ccaf6c671ccdf659824
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107690
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-06-29 14:44:21 +00:00
Stephen Adams 0f20911022 Improve type_literal_test 
- Fix expectations for dart2js generic function types
- Split out Type canonicalization tests
- Do some partial checking for dart2js minification

Change-Id: Ifb6e38c1138311baf1a9852286e208c59aaa03fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107686
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-06-29 06:36:36 +00:00
Robert Nystrom 13b470ac46 Parse error expectations in tests. 
They don't do anything yet, but the syntax is supported and tested.

Change-Id: I67e3c72babd8e272b28b434dfb0cf6028f472676
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107568
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-06-29 00:54:11 +00:00