dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

21307 Commits

Author SHA1 Message Date
Alexander Aprelev dd59b193c7 Revert 52cace8160 as it breaks flutter tests on android nexus 5x. 
This reverts 'Reland "[vm/ffi] Support structs on 32bit architectures"' 52cace8160 reviewed on https://dart-review.googlesource.com/c/sdk/+/108818, reverts FfiStruct part of https://dart-review.googlesource.com/c/sdk/+/108724.

```
runtime/vm/compiler/ffi.cc:63:1: error: static_assert failed "FFI transformation alignment"
static_assert(alignof(double) == 4, "FFI transformation alignment");
^             ~~~~~~~~~~~~~~~~~~~~
runtime/vm/compiler/ffi.cc:64:1: error: static_assert failed "FFI transformation alignment"
static_assert(alignof(uint64_t) == 4, "FFI transformation alignment");
^             ~~~~~~~~~~~~~~~~~~
````

Change-Id: I0c3bf985f68b2184261e8999320f8ee89fe3f896
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110362
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-07-25 04:00:23 +00:00
Stephen Adams ac6a3d9369 Revert "[dart2js] new-rti: Add 'minified:' tag to minified names" 
This reverts commit e0ee7cbc7f.

Reason for revert: The new code in the tests does not compile yet with new rti.

Original change's description:
> [dart2js] new-rti: Add 'minified:' tag to minified names
> 
> Change-Id: I9ea58068bdc3bea74244c31d7c60a59e7ea08b9d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108208
> Reviewed-by: Mayank Patke <fishythefish@google.com>
> Commit-Queue: Stephen Adams <sra@google.com>

TBR=sra@google.com,fishythefish@google.com

Change-Id: I35c341a0c18932806ffe4ae4ada6029438a58573
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110421
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-25 01:11:22 +00:00
Ryan Macnak 9fe8865f4a [vm, bytecode] Implement ParameterMirror and enable mirror tests. 
In particular, mirrors_reader_test no longer crashes.

Change-Id: I602e7d85755dafd943fe84d20831f0f35484b387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108968
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-07-25 00:04:02 +00:00
Aart Bik 1ac0a36fcb [dart/vm] Fix division-by-zero bug in range analysis 
Rationale:
The attached test, a simplified version from a case found
by fuzzing, yielded the range [4,4] for the left hand side
of the division but [25,0] (sic!) for the right hand side.
This reverse range caused the logic in the TRUNC evaluation
to pass the >= 1 test but introduce the division by zero
in the compiler code. The true culprit, however, was
the reason for [25,0] which was due to a difference
in C++ and Dart shift right semantics. This CL fixes
the bug and adds some sanity assert to find more of
such cases.

https://github.com/dart-lang/sdk/issues/37622

Change-Id: I60e07428435d99589e1177c113ef5e24e1611d0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110420
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-07-25 00:00:39 +00:00
Leaf Petersen 9e4cf6af14 Add tests for static extension methods. 
Change-Id: I385db23248d266ae69882f7fb13f1a1e8d7ed5d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106908
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-07-24 21:55:02 +00:00
Stephen Adams e0ee7cbc7f [dart2js] new-rti: Add 'minified:' tag to minified names 
Change-Id: I9ea58068bdc3bea74244c31d7c60a59e7ea08b9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108208
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-24 19:25:03 +00:00
Johnni Winther 82f657d7cb [cfe] Support error testing in annotated tests 
Change-Id: I545ded4d82147f22efc80f4ed8ee833cd75a9be7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109963
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-24 07:10:23 +00:00
Konstantin Shcheglov 48662bdb94 Report not initialized potentially non-nullable instance fields. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Id762e0cf651b2f2d7199f3447b5bf305b1a584c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107567
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-07-23 23:17:32 +00:00
Nicholas Shahan e6db859100 [dartdevc] Cleanup unused portions of subtyping rules 
Add additional subtyping test cases.

Change-Id: I3aa65bb5c92cf26836f5f49143083b9634386594
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109544
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-07-23 20:04:42 +00:00
Alexander Aprelev f66964c66d [vm/concurrency] Ensure library tag handler is set up on the isolate group, shared by all isolates in the group. 
The library tag handler needs to be available during set up of child isolate, during kernel loading for the isolate(due to usage of native extensions).
Setting up library tag handler in initialize_isolate callback is too late for that.

Change-Id: Ie152d2c699ce3318e90325e693b6c66d30267d7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110160
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2019-07-23 20:03:42 +00:00
Stephen Adams 262e4c4b09 Remove canonicalization_hashing entries from language_2_dart2js.status 
We only add new entries for Skip and Slow tests.

TBR=rmacnak@google.com

Change-Id: I83fe176ee6ff0e9624cf1092aed9a45f41b970d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110124
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-23 18:23:26 +00:00
Vijay Menon 3605630e8a [dartdevc] don't clear generic type caches on a hot restart 
The combination of type expression hoisting, hot restart, and generic cache
reset triggers occasional breakage (see #37259).  Not clearing the generic
cache should be safe, but will some leak memory: unloaded types will
pollute the cache.  References to those unloaded types in user code,
however, should be cleared.


Bug: https://github.com/dart-lang/sdk/issues/37259
Change-Id: Ia15115a41556db7a19109f0178baa63ec0cfcb9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109100
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2019-07-23 13:54:31 +00:00
Stephen Adams 06b7329fc9 [dart2js, gardening]: Fix dart2js/inferrence/type_mask2_test 
Change-Id: I5b84c5832866931a9ffe6ece95ee621b4aca3593
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109981
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-23 09:41:18 +00:00
Ryan Macnak 60a952e261 [vm] Avoid superlinear time canonicalizing deep constants. 
Bug: https://github.com/dart-lang/sdk/issues/37523
Change-Id: Ia3c2514891e2e3f07d1b3266b019b142413918d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109318
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-07-22 22:20:33 +00:00
Stephen Adams 41263a4c1a [dart2js] Fix for 37502: double ~/ x returns int 
http://dartbug.com/37502 shows the type-propagation results of ~/ is double instead of int.

Bug: 37502
Change-Id: Iec7b8a876a20784c7d2858305eaa67e9d02a63dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109889
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2019-07-22 20:54:10 +00:00
Mayank Patke 76f82bd0ec [dart2js] Split up runtime_types. 
This is a first pass at breaking up runtime_types.dart.
runtime_types_resolution.dart contains the former parts of runtime_types
that runtime_types_new depends on (namely, RuntimeTypesNeed and
RuntimeTypesSubstitutions), as well as their transitive dependencies.
This leaves just the code responsible for encoding the old type
representation in runtime_types, mirroring what we have in
runtime_types_new. As a result, both runtime_types and runtime_types_new
have runtime_types_resolution as a common dependency, but
runtime_types_resolution does not depend on a particular encoding.

However, runtime_types_resolution is still over 2.5 KLOC and still
depends on the old TypeCheck representation.

Change-Id: I22d932d2695cb573c2a3b4dafe5132d4e424fa77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109557
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-22 20:00:47 +00:00
Johnni Winther 7075ae7026 [cfe+dart2js] Move features to CFE 
To share support for annotated tests based on Features.

Change-Id: Ic319442e2e016bf4d1584825ea019d13a74acedb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109560
Reviewed-by: Stephen Adams <sra@google.com>
 2019-07-22 16:00:28 +00:00
Stephen Adams 9cd47ac2e6 [dart2js] new-rti: Generate correct $signature functions for closures 
Change-Id: I0f75195be4a75b46793b1cd9ec49ecc6e783611d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109723
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-19 22:52:51 +00:00
Aart Bik ebc180be95 [dart/vm] Fix bug on missed exception in AOT 
Rationale:
The regression test in this CL should throw
with a NoSuchMethod on null. However, before
the fix, AOT did not throw at all.

https://github.com/dart-lang/sdk/issues/37408

Change-Id: I4037b163092caf78d313815624fd3b20c20f88ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109550
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-07-19 22:43:31 +00:00
Stephen Adams a089199b93 Fix for issue 37494 
A bad 'dummy interceptor' optimization was applied to a super-call to
a method that is used in an intercepted class. This lead to seeing '0'
instead of the List receiver. Fix is to base decision on the target
method when available.

Bug: 37494
Change-Id: I07e5555cbe0083d7dd2510dc5bb0cba99201cd0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109553
Reviewed-by: Mayank Patke <fishythefish@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-19 17:09:30 +00:00
Daco Harkes fbf13f561f [benchmarks/ffi] Add micro and macro benchmarks for dart:ffi 
Adds micro benchmarks to measure low level (1) C memory reads and writes from Dart and (2) calls from Dart into C. This CL also adds a macro benchmark to measure overall performance using BoringSSL to digest data. The shared libraries are precompiled for Linux and live in cipd packages. The benchmarks run on all hardware architectures (with the exception of Linux'es hardfp on Arm32: https://github.com/dart-lang/sdk/issues/36309).

Issue: https://github.com/dart-lang/sdk/issues/36247

Change-Id: I8dfb30cc66a26a2942bb09194c5eb0da0b6ca1b5
Cq-Include-Trybots: luci.dart.try:benchmark-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108724
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
 2019-07-19 14:59:57 +00:00
Stephen Adams d114c96920 [dart2js] new-rti: Use recipes in types table 
Change-Id: If4c1624ea7113e102d2a516496cd65a134b9b737
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109522
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-19 02:11:16 +00:00
Stephen Adams f77093145a [corelib] Test for overflow in int.modPow() 
Bug: 37469
Change-Id: If7a6cc1063ddfdab1c5a0261a7b0c5d168c081b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109316
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-17 13:49:05 +00:00
Johnni Winther a66a3e321e [cfe+dart2js] Handle duplicated references in constant nodes. 
Change-Id: If21810ea938cd697039e9549c7dbd6ac869eabc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109260
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-07-17 06:26:34 +00:00
Johnni Winther d68b482f26 [cfe] Handle constructor from external libraries 
Closes #37532

Change-Id: I8b07addeb1da6bc4fe165ff535944fab8c6698b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109261
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-07-17 06:26:34 +00:00
Siva Annamalai 27001fb289 Revert "[vm/compiler] Implement new inlining pragmas." 
This reverts commit 629f38cf87.

Reason for revert: This CL seems to depend on constant_update_2018 flag being turned on by default. The CL that turns on constant_update_2018 has been reverted, so this CL is also being reverted.

Original change's description:
> [vm/compiler] Implement new inlining pragmas.
> 
> This change introduces two new pragmas:
> 
> * `@pragma('vm:never-inline')`
> * `@pragma('vm:prefer-inline')`
> 
> These replaces the old way of specifying AlwaysInline or NeverInline
> annotations when the (now removed) --enable-inlining-annotations flag
> was used.
> 
> Bug: https://github.com/dart-lang/sdk/issues/36571
> Change-Id: I2495c72819d94e43cefc837d4eb454b7b3d4140c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99148
> Commit-Queue: Teagan Strickland <sstrickl@google.com>
> Reviewed-by: Samir Jindel <sjindel@google.com>

TBR=sjindel@google.com,sstrickl@google.com

Change-Id: Idc8e8344adb026a308af20c8b0d0224edb891d9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109320
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2019-07-16 22:33:00 +00:00
Mayank Patke 96fc1b4ade [dart2js] Support positional optional params in function RTI. 
Change-Id: Ieebe334706752b19fd65d0eb62460c98217ab887
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109201
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-07-16 21:06:52 +00:00
Johnni Winther 6d95cb72e2 [dart2js] Test type directives 
Change-Id: I4b0459bc097bb5618ab32f479a703ec35303436b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109080
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-07-16 14:32:37 +00:00
Johnni Winther b2ed4b3c7b [dart2js] More error tests on pragma annotations 
Change-Id: Ic8d27d795f5511ef46d3c7e53a179f766529d0b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108814
Reviewed-by: Stephen Adams <sra@google.com>
 2019-07-16 14:32:37 +00:00
Johnni Winther dfa12c7456 [cfe+dart2js] Support library and error ids in annotated tests 
Change-Id: Ife808a7d4aa1d4cf459ac3c04ee6ff02042442d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108810
Reviewed-by: Stephen Adams <sra@google.com>
 2019-07-16 14:32:37 +00:00
Teagan Strickland 629f38cf87 [vm/compiler] Implement new inlining pragmas. 
This change introduces two new pragmas:

* `@pragma('vm:never-inline')`
* `@pragma('vm:prefer-inline')`

These replaces the old way of specifying AlwaysInline or NeverInline
annotations when the (now removed) --enable-inlining-annotations flag
was used.

Bug: https://github.com/dart-lang/sdk/issues/36571
Change-Id: I2495c72819d94e43cefc837d4eb454b7b3d4140c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99148
Commit-Queue: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-07-16 09:41:12 +00:00
Stephen Adams fab9b9f71f [gardening] Move language_2/conditional_rewrite_test 
Change-Id: I878230e5ed311d5d51b15c48c9fb5dca447e0ef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108905
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-15 22:04:16 +00:00
Mayank Patke 555075ba54 [dart2js] Support functions in new RTI. 
This includes the RTI representation, string/canonical recipe
representations, recipe parsing, and subtyping. We do not yet support
optional parameters (named or positional), required named parameters, or
generic functions.

Change-Id: Ifb8d83f7842028fcd904c17d2e2774e42304d32c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108961
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-07-15 20:51:56 +00:00
Daco Harkes 52cace8160 Reland "[vm/ffi] Support structs on 32bit architectures" 
Fixed Flutter iOS build.

Fixes: https://github.com/dart-lang/sdk/issues/36334

Change-Id: Idee38671cf0f33797824b37f08a92f32f931d8e0
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try, app-kernel-linux-debug-x64-try, vm-kernel-linux-debug-simdbc64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-dartkb-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-ffi-android-product-arm-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108818
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2019-07-15 16:57:36 +00:00
Ben Konyi 70bafa8864 Revert "[vm/ffi] Support structs on 32bit architectures" 
This reverts commit 0c9abb8816.

Reasoning: breaking iOS build for Flutter engine, blocking SDK roll.
Change-Id: I8905f09114a192202e5d1144d189ba0ae0fd62eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108962
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-07-12 22:40:51 +00:00
Vijay Menon 85adf76abe [dartdevc] implement assertInterop 
Next step is the inject this in DDC generated code on Dart/JS boundaries.

Change-Id: If15ff1389b2ce5f6c264e3e31bddaade7f7687e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108943
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-07-12 19:36:39 +00:00
Nicholas Shahan e3663195c7 [dartdevc] Add more subtype tests 
Change-Id: I5314a5b80efbdc544d901184b2536d2f10427c89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108369
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-07-12 19:29:59 +00:00
Vyacheslav Egorov e82ca2f366 [fasta] Unconditionally enable asserts in const constructors 
Based on feedback from the language team (https://github.com/dart-lang/language/issues/447).

Removal of CompilerOptions.enableAsserts is pending cleanup in DDK.

Change-Id: Id515e91da3e31647941ce893b2cffc58894a1b1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108813
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-12 15:42:43 +00:00
Stephen Adams e4eea58ac9 [gardening] Update language_2/constructor12_test for strong checking 
Change-Id: I1f0f121af9d22ccb2345c8da9070d352ade742f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108907
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-12 14:46:13 +00:00
Lasse R.H. Nielsen e7fab5eacc Fix bugs in >>> test now that it has been implemented. 
Change-Id: Iafdf3e56a3e69b4d945799c541795e1fd6901178
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108806
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-07-12 12:57:14 +00:00
Johnni Winther e4689c9302 [dart2js] Use new pragma directive syntax. 
+ add annotation test.

Change-Id: Ic87e6b5f3f45a7e65de53fb6afacb04fd469e951
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108726
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-12 07:27:28 +00:00
Alexander Markov 96906936b4 [vm/bytecode] Fix writing and reading of nested function types in bytecode 
Fixes https://github.com/dart-lang/sdk/issues/37486

Change-Id: Id6b10288cf9afeddb8a9972eb1dd455184b15789
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108740
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-07-12 00:15:32 +00:00
Stephen Adams 7cadd70696 Fix language_2/ct_const_test 
Change-Id: Iebb3e40b8835ae5f24afe7ae31117ff24c18aa5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108370
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-11 20:51:04 +00:00
Mike Fairhurst 3c3dc09d47 Test that ! on void is a compile time error 
Change-Id: Ia2a43dca23df6d332bd5baa63af7cb68c94ac612
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108762
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-07-11 18:48:53 +00:00
Stephen Adams d1bd3a2f43 [gardening] Fix language_2/generic_instanceof2_test 
Change-Id: Ida4afe8488a6c58ebfedde901ae293465a320714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108741
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-11 18:40:48 +00:00
Mike Fairhurst e95b1f7bf0 Make UNNECESSARY_NULL_AWARE_CALL a warning 
Change-Id: I0cbe9522dcddb4c664ae5679e521191d0c91d777
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106385
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-07-11 17:59:58 +00:00
Stephen Adams 2c26ece3cf [gardening] Fix non-web-integer in corelib_2/num_parse_test 
Change-Id: Ie89d5065cc6a3c3a05f8bf52c57b8f082a830b2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108760
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-11 17:53:53 +00:00
Stephen Adams ed764e5688 [gardening] Delete legacy parser_quirks_test 
This is a test of keep-on-truckin' behaviour that is now a static
error.

Should we delete it?

Change-Id: Ia8702f46d8d343941ed002f42e0a217485e53fcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108761
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-11 17:45:48 +00:00
Daco Harkes 0c9abb8816 [vm/ffi] Support structs on 32bit architectures 
Fixes: https://github.com/dart-lang/sdk/issues/36334

Change-Id: Ie22e7fe87724f8d2497934cd681908c9015bd2f2
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try, app-kernel-linux-debug-x64-try, vm-kernel-linux-debug-simdbc64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-dartkb-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108103
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-07-11 16:50:38 +00:00
Nicholas Shahan 25bac04503 [tests] Delete temporary const tests 
These tests acted as a guard to make sure we didn't unintentionally enable control flow and spread
in const collections when we initially shipped the features. Now that we are getting close to
enabling them for const they no longer valid.

Added a few more compile-time errors to the const spread error suite.

Change-Id: I52e215d4c1c4394f1a1b868c05241277b0d58d2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108680
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-07-11 16:29:28 +00:00