dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

21307 Commits

Author SHA1 Message Date
Mayank Patke 78bf8f08b9 Fix language_2/deferred_load_library_wrong_args_test. 
Change-Id: I83f31b84a2128f01056bca21c2dce1b1dde57567
Bug: https://github.com/dart-lang/sdk/issues/38281
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116480
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-10 02:10:38 +00:00
Mayank Patke b4724c1d78 Fix language_2/regress_23408_test. 
Change-Id: I9ab03ffd07738d6c936052d104e8d68716835815
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116440
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-10 00:58:49 +00:00
Alexander Aprelev 95db62d6a2 [vm/io] Return data right away if it's ready. 
This fixes problem with directory watching on Windows where data might be accumulated before dart stream is setup.

Bug: https://github.com/dart-lang/sdk/issues/37909

Change-Id: I601842522e76e4a6a4e6a22d6b376a49af200e6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115801
Reviewed-by: Zichang Guo <zichangguo@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2019-09-09 23:16:52 +00:00
Mayank Patke 601d8934f4 Fix issue31596 tests 
Change-Id: I02d56402aa09c1c9563929ab3792743b8fe7e97d
Bug: https://github.com/dart-lang/sdk/issues/31596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116085
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
 2019-09-09 23:16:03 +00:00
Mayank Patke 4e7b77e428 Fix language_2/super_bound_closure_test 
Change-Id: Ib297bfb5350d97a30c3a2f737d9c2dad75ef88ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116087
Commit-Queue: Mayank Patke <fishythefish@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-09 19:54:41 +00:00
Mayank Patke a2c8b69af0 Status file cleanup 
Change-Id: If5fbfe605dd27c02f664c0017a84a4a7594bf4e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116181
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-09 19:54:31 +00:00
Mayank Patke 909e2515af Fix regress_29025_test 
This test doesn't do what it once did since callable classes are no
longer function subtypes. Still, we can preserve some of the behavior.

Change-Id: I92f503bfbbe81685cf79a3bb9b6d85b6859d3c52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116141
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-09 19:46:26 +00:00
Mayank Patke ecb9a113d1 Fix language_2/regress_22976_test 
Change-Id: I0ea4a1861d37e5eefa2e05b0aafcde95fe95f484
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115902
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
 2019-09-09 19:25:56 +00:00
Mayank Patke 4310d157a1 Fix language_2/type_promotion_more_specific_test/04 
Change-Id: Idb6dc5341e8b45f5dff22f6e6545ca154dcb05a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116180
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
 2019-09-09 18:59:26 +00:00
Mayank Patke 438c595950 Fix language_2/regress_30339_test 
Change-Id: Ic0aa807c53b0334096633b0c0952efb68d0231f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116086
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
 2019-09-09 18:57:36 +00:00
Mayank Patke 9497b7b0a4 Delete language_2/regress_29405_test 
Callable classes aren't functions anymore, so this test no longer makes sense.

Change-Id: I9c93273c378c707c5cd05d6619dd8114e283c3d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116143
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-09 18:34:21 +00:00
Paul Berry bc24702149 Add missing parens to static_extension_getter_setter_conflicts_test.dart 
Change-Id: I12642c789c082c1e083d821b9d01473ca70c1bcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116300
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-09-09 15:44:37 +00:00
Ryan Macnak 84db16381d [vm] Remove dead --load_deferred_eagerly and dependent code tracking for library prefixes. 
Since Dart 2, library prefixes are always loaded eagerly on the VM.

Also remove reload check for deferred prefixes. This check was added to avoid behavior of library prefixes giving spurious "not loaded" errors after a reload, but now this error can never occur. Resolves a difference in reload between AST and bytecode modes, since bytecode mode isn't surfacing the deferred property.

Change-Id: Ide5fb6cac2efc90ca1b108a35bc09d342cbd60de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116051
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-09-06 23:37:33 +00:00
Mayank Patke fd7676e0bc Fix language_2/config_import_corelib_test 
Change-Id: Idc45ec34d12957f2ea097e27ba606344aec32ee5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116057
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-06 23:20:16 +00:00
Mayank Patke 40454f0918 Fix language_2/f_bounded_quantification2_test 
Change-Id: Ibb182e2ea89f3dd4790be659a69d6c58e333efb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115779
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-06 21:35:36 +00:00
Mayank Patke 836f6de0f4 Fix language_2/f_bounded_quantification4_test 
This isn't quite what the test was doing before, but the test was completely broken before so /shrug.

Change-Id: Idc3b6e1eab3b0c444f7100f01eecc5f27991df9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115900
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-06 21:35:35 +00:00
Mayank Patke a689f8df06 corelib_2/unsigned_shift_test fixes 
Just doing some test cleanup on massively failing tests. This test still won't pass until we support `>>>` but we can fix some of the issues.

Change-Id: I1a111455c969f21644ab2713f81f4ee00e7383f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115881
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-06 19:49:57 +00:00
Mayank Patke add83ad185 Fix language_2/generic_no_such_method_dispatcher_test 
Change-Id: I5d048d47bb10e66caef483f47a9b8245fc45d3d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115901
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-06 18:15:49 +00:00
Mayank Patke f5b53276ce Fix language_2/compile_time_constant_static5_test 
Change-Id: Ice89ef6c38f93a94be41cece77804f6b04569534
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115778
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-06 18:15:19 +00:00
Konstantin Shcheglov 35f45f0ee4 Do null-aware shorting for IndexExpression. 
R=brianwilkerson@google.com

Change-Id: I72e6aabb4fd2f79201ee1146e6ea83aa54ceb7a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115763
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-05 23:52:39 +00:00
Leaf Petersen 90aca0b8d5 Add test for incomparable on type resolution and fix expectations. 
Change-Id: I8c1ead430a866461d802e86a36c892899645faf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115620
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-09-05 22:39:21 +00:00
Aart Bik d9a9346c3f [vm/compiler] Fix truncating logic 
Rationale:
The representation mask should not be used to
do the truncation, which is more subtle around
the sign bit. With regression test.

https://github.com/dart-lang/sdk/issues/38147

Change-Id: I9745f6d73f4761eb6210e0b60b2b0504994f5cbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115607
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-09-05 21:13:43 +00:00
Samir Jindel c219a76652 Reland "[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs)." 
The original change is in Patchset 1.
The dependency contains the fix for the non-bare-instructions bot.

Change-Id: Iab02ab0736a2ee9144b667d2777ca526341b2a36
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-android-release-arm-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-bare-linux-release-x64-try,vm-kernel-precomp-mac-debug-simarm_x64-try,vm-kernel-precomp-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115241
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-09-05 20:19:22 +00:00
Robert Nystrom 89ad636b58 Remove the old "preview Dart 2" flags from the test runner. 
Dart 2 shipped a year ago, so we're pretty well past a "preview". :)

Change-Id: I6c5d21ae4181e4228cc1fc49b6344cdb8fc43794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115544
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2019-09-05 16:59:43 +00:00
Zichang Guo 92ed74e5f1 Reland "[vm] support zoneID for http" 
This is a reland of c3db2e3ee0

Original change's description:
> [vm] support zoneID for http
> 
> Coming from https://dart-review.googlesource.com/c/sdk/+/103544.
> 
> Fixes: https://github.com/dart-lang/sdk/issues/37570
> Change-Id: I0f81cb5d8009dc929fca24e03a343a7b0c1597bc
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110121
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Commit-Queue: Zichang Guo <zichangguo@google.com>

Change-Id: I3692bf02fd29bc3bc8b9b54de1466075fecec1f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115605
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-09-05 14:54:48 +00:00
Johnni Winther 34004f7f6b [cfe] Support modular compilation of extensions 
Includes serialization/deserialization of Extension and
ExtensionMemberDescriptor.

Change-Id: I04df581355b0d6f9e6bfa638241c8b7f210d3ce5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115369
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-09-05 11:19:53 +00:00
Lasse R.H. Nielsen dfcc31baf3 Add test for getter/setter conflicts with extension members. 
Change-Id: I9332e29d021d126d6678f6866d484185e2f1da73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115211
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-09-05 09:15:43 +00:00
Konstantin Shcheglov 6eed35b60d Analyze null-aware index expression reads. 
R=brianwilkerson@google.com

Change-Id: Idcd787434eae070e87adf267a016bda2a4e5703e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-05 00:58:46 +00:00
Zichang Guo 05b7c55e8f Revert "[vm] support zoneID for http" 
This reverts commit c3db2e3ee0.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [vm] support zoneID for http
> 
> Coming from https://dart-review.googlesource.com/c/sdk/+/103544.
> 
> Fixes: https://github.com/dart-lang/sdk/issues/37570
> Change-Id: I0f81cb5d8009dc929fca24e03a343a7b0c1597bc
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110121
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Commit-Queue: Zichang Guo <zichangguo@google.com>

TBR=lrn@google.com,zra@google.com,asiva@google.com,zichangguo@google.com

Change-Id: I41e52b905b112a0e6f2a6c2c8c135a9ec6ef6869
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115604
Reviewed-by: Zichang Guo <zichangguo@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-09-04 22:17:48 +00:00
Zichang Guo c3db2e3ee0 [vm] support zoneID for http 
Coming from https://dart-review.googlesource.com/c/sdk/+/103544.

Fixes: https://github.com/dart-lang/sdk/issues/37570
Change-Id: I0f81cb5d8009dc929fca24e03a343a7b0c1597bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110121
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-09-04 15:42:01 +00:00
Johnni Winther 1946d9d7a0 [dart2js] Add tests for issue 37724 
Change-Id: I9df9daf9573906818564650495fa82e80200f607
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115024
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2019-09-04 07:20:50 +00:00
Aart Bik 622747502e [vm/interpreter] Enforce consistent interpreter/compiler unboxing view 
Rationale:
Both the interpreter and compiler had some logic on when fields
could be unboxed. Rather than duplicating this logic, this CL
uses the same methods to get a more consistent view of unboxing.
Note that this add a slight overhead to the interpreter, but
only a slight. We could avoid this by duplicating the logic
to enforce consistency, but this has the danger of getting
similar issues in the future.

https://github.com/dart-lang/sdk/issues/37821

Change-Id: Icf0c1ad518d75c63e9da72e1f75eaf1cf903587f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115301
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-09-04 00:52:27 +00:00
Samir Jindel 72e8bdc56b Revert "[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs)." 
This reverts commit ecbea5a58e.

Reason for revert: broken with bare instructions and ABI bot

Original change's description:
> [vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs).
> 
> To do this, we add writable data sections (currently uninitialzed) to ELF and Asm snapshots
> and allow Instructions to have patchable relocations against (the start of) these sections.
> 
> Issue https://github.com/dart-lang/sdk/issues/37295 (see also for design & discussion).
> 
> Change-Id: If20bfa55776f4044aaa6bb8ea2101d2ada41842c
> Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-android-release-arm-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110221
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,rmacnak@google.com,alexmarkov@google.com,sjindel@google.com

Change-Id: I9787da6d42575ca4f5ae0a698052a19ac4275afd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-product-x64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-android-release-arm-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115240
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-09-03 12:31:15 +00:00
Samir Jindel ecbea5a58e [vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs). 
To do this, we add writable data sections (currently uninitialzed) to ELF and Asm snapshots
and allow Instructions to have patchable relocations against (the start of) these sections.

Issue https://github.com/dart-lang/sdk/issues/37295 (see also for design & discussion).

Change-Id: If20bfa55776f4044aaa6bb8ea2101d2ada41842c
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-android-release-arm-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110221
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-09-03 12:02:02 +00:00
Jens Johansen 00d14e7dd1 [CFE] Always start constant evaluation error where we are asked to evaluate 
Fixes #38167

Change-Id: I57ded79835348a1e02b4949986a8b1668d3e425a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115206
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-09-03 06:16:37 +00:00
Karl Klose 29ca4e670a [infra] Remove non-essential test expectations with comments from analyzer status files 
Change-Id: I43a5c85fe414c4fc9ed70b926d245c291ef0d28c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114853
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-09-02 07:12:10 +00:00
Karl Klose ed55695f6b [infra] Remove non-essential test expectations with comments from kernel status files 
Change-Id: I7f49b31abdf4786365ac2a1e6cedc5ddbfae2ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114852
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-09-02 07:04:06 +00:00
Karl Klose e193f502f9 [infra] Remove non-essential test expectations with comments from devc status files 
Change-Id: I7fff65b92b1890ccce80f37afe30a58a8942e956
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114854
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-09-02 07:04:05 +00:00
Samir Jindel 0ff52a640c [vm/ffi] Don't run function_callbacks_test/{01,02,03} in ASAN. 
Issue https://github.com/dart-lang/sdk/issues/38121

Change-Id: Icc2ab6fa60e0227e5c38b25bc74c07472f35b732
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115022
Auto-Submit: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-08-30 13:08:51 +00:00
Leaf Petersen d548da74c0 Add tests for extension members shadowed in classes. 
Adding tests that unqualified identifiers referenced in classes are
looked up and resolved by basename when the same basename is declared
in the class lexical scope and in the external scope via an extension.

Change-Id: I487c082711350118bf1692771bea33b5621f1eca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114631
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-08-29 21:52:29 +00:00
Aart Bik d1c9a2b06f [vm/compiler] Improve DIV and MOD performance 
Rationale:
Mostly an AOT 64-bit improvement of DIV and MOV by constant
on X64_64. Also a few minor supporting optimizations
that were missed. With unit tests.

https://github.com/dart-lang/sdk/issues/37789

Change-Id: I2f12d6a24bbe983324521d7d4d778f20b34d18a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114901
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-08-29 20:32:10 +00:00
Mayank Patke 5148afa2fa [dart2js] Treat classes instantiated by a NativeBehavior as native. 
Change-Id: Ib1d19a6047492cd1a0e0d93e45107eb74f1b4306
Bug: https://github.com/dart-lang/sdk/issues/37576
Fixes: https://github.com/dart-lang/sdk/issues/37576
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114466
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-08-29 00:53:55 +00:00
Samir Jindel 1b288607f1 [vm] Make fragmentation_typed_data_test less flaky on Android. 
Issue https://github.com/dart-lang/sdk/issues/37772

Change-Id: If6858bafdc3983fa679a9bb4990790d3602cfe6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114862
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-08-28 17:05:12 +00:00
Karl Klose 4b19400ba7 [infra] Remove non-essential test expectations from devc status files 
Change-Id: If1d4550aab4465fbf2491a4411148d94f6a47273
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113987
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-08-28 10:10:52 +00:00
Alexander Markov 1017a562d7 [vm/bytecode] Fix crash while querying parameter descriptors for static implicit closure 
Fixes https://github.com/dart-lang/sdk/issues/38035

Change-Id: Ib060a0b43ff0ca85d984642e9faca8fd966a1e62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114634
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-08-28 02:26:33 +00:00
Aske Simon Christensen 21cf0f5f90 [cfe] Clean out all uses of expired flags. 
Change-Id: Ib9096f1a8628d78444bc0847b453dd4032864e09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114073
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-27 09:24:23 +00:00
Aart Bik cebb64f249 [vm/compiler] Avoid deopt for non-clamping typed data 
Rationale:
The recent introduction of non-SMI deopt to fix the
clamping bug is a bit too restrictive for the other,
truncating operations. In particular, we observed
a unnecessary regression in one of our performance
benchmarks.

https://github.com/dart-lang/sdk/issues/37868
https://github.com/dart-lang/sdk/issues/37895

Change-Id: Iabf59db5c50b775a717c6e961efb3a5f4b6a964e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114447
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-08-26 19:04:32 +00:00
Leaf Petersen 9a817c722b Add tests for extension method setter/getter basename shadowing. 
Test that setters and getters shadow names external to the extension
based on their basename (so that a setter shadows an external getter
and vice versa).

Change-Id: Id5bfceb552ab3d84ef90fc85f8eb80f0eab08451
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112925
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-08-26 17:59:13 +00:00
Martin Kustermann 48f8454960 [vm] Force raw variables created during scope building to be on the stack 
Fixes https://github.com/dart-lang/sdk/issues/37984

Change-Id: I9aa283becbb836d4a0480f954aaa6d387bbc1fdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114511
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-08-26 13:58:35 +00:00
Karl Klose 1f17242a4f [infra] Remove non-essential test expectations from dart2js status files 
Change-Id: Ie6ead34c5628cd63f6eeb363585932c4f15f33a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114062
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-08-26 11:55:25 +00:00