dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2317 Commits

Author SHA1 Message Date
Mayank Patke a2c8b69af0 Status file cleanup 
Change-Id: If5fbfe605dd27c02f664c0017a84a4a7594bf4e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116181
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-09 19:54:31 +00:00
Mayank Patke 909e2515af Fix regress_29025_test 
This test doesn't do what it once did since callable classes are no
longer function subtypes. Still, we can preserve some of the behavior.

Change-Id: I92f503bfbbe81685cf79a3bb9b6d85b6859d3c52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116141
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-09 19:46:26 +00:00
Mayank Patke ecb9a113d1 Fix language_2/regress_22976_test 
Change-Id: I0ea4a1861d37e5eefa2e05b0aafcde95fe95f484
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115902
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
 2019-09-09 19:25:56 +00:00
Mayank Patke 4310d157a1 Fix language_2/type_promotion_more_specific_test/04 
Change-Id: Idb6dc5341e8b45f5dff22f6e6545ca154dcb05a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116180
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
 2019-09-09 18:59:26 +00:00
Mayank Patke 438c595950 Fix language_2/regress_30339_test 
Change-Id: Ic0aa807c53b0334096633b0c0952efb68d0231f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116086
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
 2019-09-09 18:57:36 +00:00
Mayank Patke 9497b7b0a4 Delete language_2/regress_29405_test 
Callable classes aren't functions anymore, so this test no longer makes sense.

Change-Id: I9c93273c378c707c5cd05d6619dd8114e283c3d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116143
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-09 18:34:21 +00:00
Paul Berry bc24702149 Add missing parens to static_extension_getter_setter_conflicts_test.dart 
Change-Id: I12642c789c082c1e083d821b9d01473ca70c1bcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116300
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-09-09 15:44:37 +00:00
Ryan Macnak 84db16381d [vm] Remove dead --load_deferred_eagerly and dependent code tracking for library prefixes. 
Since Dart 2, library prefixes are always loaded eagerly on the VM.

Also remove reload check for deferred prefixes. This check was added to avoid behavior of library prefixes giving spurious "not loaded" errors after a reload, but now this error can never occur. Resolves a difference in reload between AST and bytecode modes, since bytecode mode isn't surfacing the deferred property.

Change-Id: Ide5fb6cac2efc90ca1b108a35bc09d342cbd60de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116051
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-09-06 23:37:33 +00:00
Mayank Patke fd7676e0bc Fix language_2/config_import_corelib_test 
Change-Id: Idc45ec34d12957f2ea097e27ba606344aec32ee5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116057
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-06 23:20:16 +00:00
Mayank Patke 40454f0918 Fix language_2/f_bounded_quantification2_test 
Change-Id: Ibb182e2ea89f3dd4790be659a69d6c58e333efb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115779
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-06 21:35:36 +00:00
Mayank Patke 836f6de0f4 Fix language_2/f_bounded_quantification4_test 
This isn't quite what the test was doing before, but the test was completely broken before so /shrug.

Change-Id: Idc3b6e1eab3b0c444f7100f01eecc5f27991df9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115900
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-06 21:35:35 +00:00
Mayank Patke add83ad185 Fix language_2/generic_no_such_method_dispatcher_test 
Change-Id: I5d048d47bb10e66caef483f47a9b8245fc45d3d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115901
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-06 18:15:49 +00:00
Mayank Patke f5b53276ce Fix language_2/compile_time_constant_static5_test 
Change-Id: Ice89ef6c38f93a94be41cece77804f6b04569534
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115778
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-06 18:15:19 +00:00
Konstantin Shcheglov 35f45f0ee4 Do null-aware shorting for IndexExpression. 
R=brianwilkerson@google.com

Change-Id: I72e6aabb4fd2f79201ee1146e6ea83aa54ceb7a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115763
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-05 23:52:39 +00:00
Leaf Petersen 90aca0b8d5 Add test for incomparable on type resolution and fix expectations. 
Change-Id: I8c1ead430a866461d802e86a36c892899645faf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115620
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-09-05 22:39:21 +00:00
Aart Bik d9a9346c3f [vm/compiler] Fix truncating logic 
Rationale:
The representation mask should not be used to
do the truncation, which is more subtle around
the sign bit. With regression test.

https://github.com/dart-lang/sdk/issues/38147

Change-Id: I9745f6d73f4761eb6210e0b60b2b0504994f5cbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115607
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-09-05 21:13:43 +00:00
Robert Nystrom 89ad636b58 Remove the old "preview Dart 2" flags from the test runner. 
Dart 2 shipped a year ago, so we're pretty well past a "preview". :)

Change-Id: I6c5d21ae4181e4228cc1fc49b6344cdb8fc43794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115544
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2019-09-05 16:59:43 +00:00
Lasse R.H. Nielsen dfcc31baf3 Add test for getter/setter conflicts with extension members. 
Change-Id: I9332e29d021d126d6678f6866d484185e2f1da73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115211
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-09-05 09:15:43 +00:00
Konstantin Shcheglov 6eed35b60d Analyze null-aware index expression reads. 
R=brianwilkerson@google.com

Change-Id: Idcd787434eae070e87adf267a016bda2a4e5703e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-05 00:58:46 +00:00
Aart Bik 622747502e [vm/interpreter] Enforce consistent interpreter/compiler unboxing view 
Rationale:
Both the interpreter and compiler had some logic on when fields
could be unboxed. Rather than duplicating this logic, this CL
uses the same methods to get a more consistent view of unboxing.
Note that this add a slight overhead to the interpreter, but
only a slight. We could avoid this by duplicating the logic
to enforce consistency, but this has the danger of getting
similar issues in the future.

https://github.com/dart-lang/sdk/issues/37821

Change-Id: Icf0c1ad518d75c63e9da72e1f75eaf1cf903587f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115301
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-09-04 00:52:27 +00:00
Karl Klose 29ca4e670a [infra] Remove non-essential test expectations with comments from analyzer status files 
Change-Id: I43a5c85fe414c4fc9ed70b926d245c291ef0d28c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114853
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-09-02 07:12:10 +00:00
Karl Klose ed55695f6b [infra] Remove non-essential test expectations with comments from kernel status files 
Change-Id: I7f49b31abdf4786365ac2a1e6cedc5ddbfae2ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114852
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-09-02 07:04:06 +00:00
Karl Klose e193f502f9 [infra] Remove non-essential test expectations with comments from devc status files 
Change-Id: I7fff65b92b1890ccce80f37afe30a58a8942e956
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114854
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-09-02 07:04:05 +00:00
Leaf Petersen d548da74c0 Add tests for extension members shadowed in classes. 
Adding tests that unqualified identifiers referenced in classes are
looked up and resolved by basename when the same basename is declared
in the class lexical scope and in the external scope via an extension.

Change-Id: I487c082711350118bf1692771bea33b5621f1eca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114631
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-08-29 21:52:29 +00:00
Aart Bik d1c9a2b06f [vm/compiler] Improve DIV and MOD performance 
Rationale:
Mostly an AOT 64-bit improvement of DIV and MOV by constant
on X64_64. Also a few minor supporting optimizations
that were missed. With unit tests.

https://github.com/dart-lang/sdk/issues/37789

Change-Id: I2f12d6a24bbe983324521d7d4d778f20b34d18a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114901
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-08-29 20:32:10 +00:00
Karl Klose 4b19400ba7 [infra] Remove non-essential test expectations from devc status files 
Change-Id: If1d4550aab4465fbf2491a4411148d94f6a47273
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113987
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-08-28 10:10:52 +00:00
Aart Bik cebb64f249 [vm/compiler] Avoid deopt for non-clamping typed data 
Rationale:
The recent introduction of non-SMI deopt to fix the
clamping bug is a bit too restrictive for the other,
truncating operations. In particular, we observed
a unnecessary regression in one of our performance
benchmarks.

https://github.com/dart-lang/sdk/issues/37868
https://github.com/dart-lang/sdk/issues/37895

Change-Id: Iabf59db5c50b775a717c6e961efb3a5f4b6a964e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114447
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-08-26 19:04:32 +00:00
Leaf Petersen 9a817c722b Add tests for extension method setter/getter basename shadowing. 
Test that setters and getters shadow names external to the extension
based on their basename (so that a setter shadows an external getter
and vice versa).

Change-Id: Id5bfceb552ab3d84ef90fc85f8eb80f0eab08451
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112925
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-08-26 17:59:13 +00:00
Martin Kustermann 48f8454960 [vm] Force raw variables created during scope building to be on the stack 
Fixes https://github.com/dart-lang/sdk/issues/37984

Change-Id: I9aa283becbb836d4a0480f954aaa6d387bbc1fdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114511
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-08-26 13:58:35 +00:00
Karl Klose 1f17242a4f [infra] Remove non-essential test expectations from dart2js status files 
Change-Id: Ie6ead34c5628cd63f6eeb363585932c4f15f33a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114062
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-08-26 11:55:25 +00:00
Brian Wilkerson 5935b916e3 Rename several error codes and improve some messages 
Change-Id: I6e629719dee14c2af7c1358145fb25b21f5d5157
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114160
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-22 20:08:53 +00:00
Aske Simon Christensen 88c0c11612 Remove constant-update-2018 flag from tests. 
Change-Id: I85d3d0180bb7f5973ad2da946a3519c553fc7f92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113991
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-08-22 11:00:54 +00:00
Karl Klose 5428119bee [infra] Remove non-essential test expectations from analyzer status files 
Change-Id: I63fdbea8f7f800a362ee5a5ad2b708bb30e4ebf8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114060
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-08-22 10:36:29 +00:00
Karl Klose b625152523 [infra] Remove non-essential test expectations from kernel status files 
Change-Id: Id246d9abb338873ef5082c3c70f45f5650ad1dcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113981
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-08-21 10:37:45 +00:00
Karl Klose 095d1c2835 [infra] Clean up general status files 
Change-Id: I421fca89e748474a585f052532b86ef3ddbed4ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113681
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-08-21 09:18:34 +00:00
William Hesse 2706114f4d Revert "[infra] Remove non-essential test expectations from kernel status files" 
This reverts commit c010458732.

Reason for revert: We believed that the Crash marker had no effect in the -kernel status files, but some of these crashes were vm crashes, so they were suppressing upload of core dumps.  These uploads are failing on Windows builders.

Original change's description:
> [infra] Remove non-essential test expectations from kernel status files
> 
> Change-Id: I959b7847e93c221d77c94bd25f95e913a25e91cd
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113685
> Reviewed-by: Jens Johansen <jensj@google.com>
> Commit-Queue: Karl Klose <karlklose@google.com>

TBR=karlklose@google.com,jensj@google.com

Change-Id: I57978d9253a5889c58444fce3ce6c30b79ab4040
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113691
Reviewed-by: William Hesse <whesse@google.com>
 2019-08-19 14:29:45 +00:00
Karl Klose c010458732 [infra] Remove non-essential test expectations from kernel status files 
Change-Id: I959b7847e93c221d77c94bd25f95e913a25e91cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113685
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-08-19 12:01:01 +00:00
Aske Simon Christensen e611357309 [CFE] Error on bitwise or shift operation on a double constant. 
Fixes https://github.com/dart-lang/sdk/issues/36823

Change-Id: I9aeb34b9f80261889434f85bf39af3d78a38202e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112391
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-08-16 11:11:27 +00:00
Aart Bik 1523fbd96e [vm/compiler] Fixed bug with clamping on 32-bit arch 
Rationale:
Feel the power of value-guided fuzzing that, in combination
with new types, founds this issue in the graph intrinsifier.
The deopt on the speculative code for Smi was missing.

https://github.com/dart-lang/sdk/issues/37868

Change-Id: I9f310f62eb6cf1cdb3e39685caed5b7792024565
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113203
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-08-15 21:05:02 +00:00
Brian Wilkerson 100d500b45 Update test expectations to match analyzer behavior 
Change-Id: Ifd0528af3099086aee517813e64656dc1eaa2bdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113205
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-15 18:20:21 +00:00
Leaf Petersen 617dd903e2 Update static error expectations for 
static_extension_bounds_error_test.dart .

Change-Id: Id674261e7619c3ed6fd088158209b7aa34d36aa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113001
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
 2019-08-14 23:42:03 +00:00
Vijay Menon a981bfe47b [dartdevc] fix virtual method computation due to nsm 
Fixes https://github.com/dart-lang/sdk/issues/37855

Change-Id: I468d66fb8e88fa92a92eb99716a1a2d2d00f54ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113124
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2019-08-14 22:07:41 +00:00
Leaf Petersen 81e98dd47b Update comment on assignability 
Change-Id: I2ff2cf3a34e2eb545ed90dd725ecd13b7f1a55b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-14 21:21:47 +00:00
Erik Ernst a58052974e Adjusted Dart.g to contain the grammar updates of language repo PR 293 
This CL makes several adjustments to the spec_parser grammar Dart.g,
such that the spec_parser can parse the proposed NNBD constructs,
cf. language PR #293.

Change-Id: Ieec00259d73b6037d6a87d5c97cfac40186baef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101500
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2019-08-14 08:17:54 +00:00
Leaf Petersen 76c99bcd01 Add tests for internal name conflicts in extension methods 
Change-Id: I7c2bed173f4d945ab83ab9157fcf650ddd4990ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112645
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-08-14 02:24:44 +00:00
Aart Bik b0968395f1 [vm/compiler] Minor heuristic change to reduce code size 
Rationale:
Inlining constant constructors/mixin is practically always
profitable. So the heuristics have been changed to at least
consider these even at higher depth (note that they are of
course still subject to actual heuristics while inlining).

This brings back flutter gallery size to where it was
before mixins were introduced.

head:

VMIsolate(CodeSize): 4737
Isolate(CodeSize): 2005123                     101%
ReadOnlyData(CodeSize): 2212408                103%
Instructions(CodeSize): 7006928                100%
Total(CodeSize): 11229196                      101%

improved heuristic:

VMIsolate(CodeSize): 4737
Isolate(CodeSize): 1985691
ReadOnlyData(CodeSize): 2152880
Instructions(CodeSize): 6987616
Total(CodeSize): 11130924

https://github.com/dart-lang/sdk/issues/37126

Change-Id: I28de0fa6c92a785bbc47e9fa09ed55ae68593c0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112758
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-08-12 23:17:43 +00:00
Leaf Petersen b21a5f1adf Fix bugs in static_extension_syntax_test.dart 
Fix #37765

Change-Id: I4af67aae1b6e5fbb28371762261d20fccc90d8b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112751
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-12 19:38:39 +00:00
Brian Wilkerson 9eb2e8d111 Stop reporting duplicate diagnostics for other ambiguous extensions 
Change-Id: Ia81c43f0ccd41aa09697b6f629fd1d5a3acd3923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112643
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-12 18:04:11 +00:00
Konstantin Shcheglov 9713ce16b9 Report EXTENSION_CONFLICTING_STATIC_AND_INSTANCE and DUPLICATE_DEFINITION for extensions. 
R=brianwilkerson@google.com

Change-Id: I237ee3edc6a2196693638c12c59d1530a1f15152
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112605
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-09 23:09:25 +00:00
Mayank Patke af5a466e3b [dart2js] (Old RTI) Check function subtypes after checking for FutureOr. 
Change-Id: I7d2feab60295304377e48fddce901aea1c79ce19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112481
Reviewed-by: Stephen Adams <sra@google.com>
 2019-08-09 02:41:30 +00:00